[INFO] crate colored_json 1.0.0 is already in cache
[INFO] extracting crate colored_json 1.0.0 into work/ex/clippy-test-run/sources/stable/reg/colored_json/1.0.0
[INFO] extracting crate colored_json 1.0.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/colored_json/1.0.0
[INFO] validating manifest of colored_json-1.0.0 on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of colored_json-1.0.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing colored_json-1.0.0
[INFO] finished frobbing colored_json-1.0.0
[INFO] frobbed toml for colored_json-1.0.0 written to work/ex/clippy-test-run/sources/stable/reg/colored_json/1.0.0/Cargo.toml
[INFO] started frobbing colored_json-1.0.0
[INFO] finished frobbing colored_json-1.0.0
[INFO] frobbed toml for colored_json-1.0.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/colored_json/1.0.0/Cargo.toml
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting colored_json-1.0.0 against stable for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-7/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/colored_json/1.0.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] 8f8568d1d8920746678e7e63e226892aac149027152c4315fcfea17b903c0b70
[INFO] running `"docker" "start" "-a" "8f8568d1d8920746678e7e63e226892aac149027152c4315fcfea17b903c0b70"`
[INFO] [stderr]     Checking colored_json v1.0.0 (/opt/crater/workdir)
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/lib.rs:238:13
[INFO] [stderr]     |
[INFO] [stderr] 238 |             styler: styler,
[INFO] [stderr]     |             ^^^^^^^^^^^^^^ help: replace it with: `styler`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::redundant_field_names)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/lib.rs:238:13
[INFO] [stderr]     |
[INFO] [stderr] 238 |             styler: styler,
[INFO] [stderr]     |             ^^^^^^^^^^^^^^ help: replace it with: `styler`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::redundant_field_names)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/lib.rs:228:9
[INFO] [stderr]     |
[INFO] [stderr] 228 | /         return ColoredFormatter {
[INFO] [stderr] 229 | |             formatter,
[INFO] [stderr] 230 | |             styler: Styler::default(),
[INFO] [stderr] 231 | |             in_object_key: false,
[INFO] [stderr] 232 | |         };
[INFO] [stderr]     | |__________^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::needless_return)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] help: remove `return` as shown
[INFO] [stderr]     |
[INFO] [stderr] 228 |         ColoredFormatter {
[INFO] [stderr] 229 |             formatter,
[INFO] [stderr] 230 |             styler: Styler::default(),
[INFO] [stderr] 231 |             in_object_key: false,
[INFO] [stderr] 232 |         }
[INFO] [stderr]     |
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/lib.rs:236:9
[INFO] [stderr]     |
[INFO] [stderr] 236 | /         return ColoredFormatter {
[INFO] [stderr] 237 | |             formatter,
[INFO] [stderr] 238 | |             styler: styler,
[INFO] [stderr] 239 | |             in_object_key: false,
[INFO] [stderr] 240 | |         };
[INFO] [stderr]     | |__________^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] help: remove `return` as shown
[INFO] [stderr]     |
[INFO] [stderr] 236 |         ColoredFormatter {
[INFO] [stderr] 237 |             formatter,
[INFO] [stderr] 238 |             styler: styler,
[INFO] [stderr] 239 |             in_object_key: false,
[INFO] [stderr] 240 |         }
[INFO] [stderr]     |
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/lib.rs:252:9
[INFO] [stderr]     |
[INFO] [stderr] 252 |         return Ok(String::from_utf8_lossy(&writer).to_string());
[INFO] [stderr]     |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(String::from_utf8_lossy(&writer).to_string())`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/lib.rs:268:17
[INFO] [stderr]     |
[INFO] [stderr] 268 |                 return value.serialize(&mut serializer);
[INFO] [stderr]     |                 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `value.serialize(&mut serializer)`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/lib.rs:272:17
[INFO] [stderr]     |
[INFO] [stderr] 272 |                 return value.serialize(&mut serializer);
[INFO] [stderr]     |                 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `value.serialize(&mut serializer)`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/lib.rs:675:5
[INFO] [stderr]     |
[INFO] [stderr] 675 |     return Ok(String::from_utf8_lossy(&writer).to_string());
[INFO] [stderr]     |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(String::from_utf8_lossy(&writer).to_string())`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/test.rs:24:5
[INFO] [stderr]    |
[INFO] [stderr] 24 |     return Ok(());
[INFO] [stderr]    |     ^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(())`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::needless_return)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/test.rs:174:5
[INFO] [stderr]     |
[INFO] [stderr] 174 |     return Ok(());
[INFO] [stderr]     |     ^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(())`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/test.rs:215:5
[INFO] [stderr]     |
[INFO] [stderr] 215 |     return Ok(());
[INFO] [stderr]     |     ^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(())`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: long literal lacking separators
[INFO] [stderr]    --> src/test.rs:199:22
[INFO] [stderr]     |
[INFO] [stderr] 199 |           "integer": 4398798674962568u64,
[INFO] [stderr]     |                      ^^^^^^^^^^^^^^^^^^^ help: consider: `4_398_798_674_962_568u64`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::unreadable_literal)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal
[INFO] [stderr] 
[INFO] [stderr] warning: long literal lacking separators
[INFO] [stderr]    --> src/test.rs:200:20
[INFO] [stderr]     |
[INFO] [stderr] 200 |           "float": 3.1415926,
[INFO] [stderr]     |                    ^^^^^^^^^ help: consider: `3.141_592_6`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/test.rs:259:5
[INFO] [stderr]     |
[INFO] [stderr] 259 |     return Ok(());
[INFO] [stderr]     |     ^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(())`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: long literal lacking separators
[INFO] [stderr]    --> src/test.rs:241:22
[INFO] [stderr]     |
[INFO] [stderr] 241 |           "integer": 4398798674962568u64,
[INFO] [stderr]     |                      ^^^^^^^^^^^^^^^^^^^ help: consider: `4_398_798_674_962_568u64`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal
[INFO] [stderr] 
[INFO] [stderr] warning: long literal lacking separators
[INFO] [stderr]    --> src/test.rs:242:20
[INFO] [stderr]     |
[INFO] [stderr] 242 |           "float": 3.1415926,
[INFO] [stderr]     |                    ^^^^^^^^^ help: consider: `3.141_592_6`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/test.rs:296:5
[INFO] [stderr]     |
[INFO] [stderr] 296 |     return Ok(());
[INFO] [stderr]     |     ^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(())`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/lib.rs:228:9
[INFO] [stderr]     |
[INFO] [stderr] 228 | /         return ColoredFormatter {
[INFO] [stderr] 229 | |             formatter,
[INFO] [stderr] 230 | |             styler: Styler::default(),
[INFO] [stderr] 231 | |             in_object_key: false,
[INFO] [stderr] 232 | |         };
[INFO] [stderr]     | |__________^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] help: remove `return` as shown
[INFO] [stderr]     |
[INFO] [stderr] 228 |         ColoredFormatter {
[INFO] [stderr] 229 |             formatter,
[INFO] [stderr] 230 |             styler: Styler::default(),
[INFO] [stderr] 231 |             in_object_key: false,
[INFO] [stderr] 232 |         }
[INFO] [stderr]     |
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/lib.rs:236:9
[INFO] [stderr]     |
[INFO] [stderr] 236 | /         return ColoredFormatter {
[INFO] [stderr] 237 | |             formatter,
[INFO] [stderr] 238 | |             styler: styler,
[INFO] [stderr] 239 | |             in_object_key: false,
[INFO] [stderr] 240 | |         };
[INFO] [stderr]     | |__________^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] help: remove `return` as shown
[INFO] [stderr]     |
[INFO] [stderr] 236 |         ColoredFormatter {
[INFO] [stderr] 237 |             formatter,
[INFO] [stderr] 238 |             styler: styler,
[INFO] [stderr] 239 |             in_object_key: false,
[INFO] [stderr] 240 |         }
[INFO] [stderr]     |
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/lib.rs:252:9
[INFO] [stderr]     |
[INFO] [stderr] 252 |         return Ok(String::from_utf8_lossy(&writer).to_string());
[INFO] [stderr]     |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(String::from_utf8_lossy(&writer).to_string())`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/lib.rs:268:17
[INFO] [stderr]     |
[INFO] [stderr] 268 |                 return value.serialize(&mut serializer);
[INFO] [stderr]     |                 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `value.serialize(&mut serializer)`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/lib.rs:272:17
[INFO] [stderr]     |
[INFO] [stderr] 272 |                 return value.serialize(&mut serializer);
[INFO] [stderr]     |                 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `value.serialize(&mut serializer)`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/lib.rs:675:5
[INFO] [stderr]     |
[INFO] [stderr] 675 |     return Ok(String::from_utf8_lossy(&writer).to_string());
[INFO] [stderr]     |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(String::from_utf8_lossy(&writer).to_string())`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: methods called `to_*` usually take self by reference; consider choosing a less ambiguous name
[INFO] [stderr]    --> src/lib.rs:243:33
[INFO] [stderr]     |
[INFO] [stderr] 243 |     pub fn to_colored_json_auto(self, value: &Value) -> serde_json::Result<String> {
[INFO] [stderr]     |                                 ^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::wrong_self_convention)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention
[INFO] [stderr] 
[INFO] [stderr] warning: methods called `to_*` usually take self by reference; consider choosing a less ambiguous name
[INFO] [stderr]    --> src/lib.rs:247:28
[INFO] [stderr]     |
[INFO] [stderr] 247 |     pub fn to_colored_json(self, value: &Value, mode: ColorMode) -> serde_json::Result<String> {
[INFO] [stderr]     |                            ^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention
[INFO] [stderr] 
[INFO] [stderr] warning: you seem to be trying to match on a boolean expression
[INFO] [stderr]    --> src/lib.rs:264:9
[INFO] [stderr]     |
[INFO] [stderr] 264 | /         match mode.use_color() {
[INFO] [stderr] 265 | |             true => {
[INFO] [stderr] 266 | |                 let mut serializer = serde_json::Serializer::with_formatter(writer, self);
[INFO] [stderr] 267 | |
[INFO] [stderr] ...   |
[INFO] [stderr] 273 | |             }
[INFO] [stderr] 274 | |         }
[INFO] [stderr]     | |_________^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::match_bool)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool
[INFO] [stderr] help: consider using an if/else expression
[INFO] [stderr]     |
[INFO] [stderr] 264 |         if mode.use_color() {
[INFO] [stderr] 265 |     let mut serializer = serde_json::Serializer::with_formatter(writer, self);
[INFO] [stderr] 266 | 
[INFO] [stderr] 267 |     return value.serialize(&mut serializer);
[INFO] [stderr] 268 | } else {
[INFO] [stderr] 269 |     let mut serializer = serde_json::Serializer::with_formatter(writer, self.formatter);
[INFO] [stderr]   ...
[INFO] [stderr] 
[INFO] [stderr] warning: passing a unit value to a function
[INFO] [stderr]    --> src/lib.rs:287:8
[INFO] [stderr]     |
[INFO] [stderr] 287 |     Ok(writer.write_all(style.paint(s).to_string().as_bytes())?)
[INFO] [stderr]     |        ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::unit_arg)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unit_arg
[INFO] [stderr] help: if you intended to pass a unit value, use a unit literal instead
[INFO] [stderr]     |
[INFO] [stderr] 287 |     Ok(())
[INFO] [stderr]     |        ^^
[INFO] [stderr] 
[INFO] [stderr] warning: you seem to be trying to match on a boolean expression
[INFO] [stderr]    --> src/lib.rs:417:25
[INFO] [stderr]     |
[INFO] [stderr] 417 |               let style = match self.in_object_key {
[INFO] [stderr]     |  _________________________^
[INFO] [stderr] 418 | |                 true => self.styler.key,
[INFO] [stderr] 419 | |                 false => self.styler.string_value,
[INFO] [stderr] 420 | |             };
[INFO] [stderr]     | |_____________^ help: consider using an if/else expression: `if self.in_object_key { self.styler.key } else { self.styler.string_value }`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool
[INFO] [stderr] 
[INFO] [stderr] warning: you seem to be trying to match on a boolean expression
[INFO] [stderr]    --> src/lib.rs:432:25
[INFO] [stderr]     |
[INFO] [stderr] 432 |               let style = match self.in_object_key {
[INFO] [stderr]     |  _________________________^
[INFO] [stderr] 433 | |                 true => self.styler.key,
[INFO] [stderr] 434 | |                 false => self.styler.string_value,
[INFO] [stderr] 435 | |             };
[INFO] [stderr]     | |_____________^ help: consider using an if/else expression: `if self.in_object_key { self.styler.key } else { self.styler.string_value }`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool
[INFO] [stderr] 
[INFO] [stderr] warning: you seem to be trying to match on a boolean expression
[INFO] [stderr]    --> src/lib.rs:446:21
[INFO] [stderr]     |
[INFO] [stderr] 446 |           let style = match self.in_object_key {
[INFO] [stderr]     |  _____________________^
[INFO] [stderr] 447 | |             true => self.styler.key,
[INFO] [stderr] 448 | |             false => self.styler.string_value,
[INFO] [stderr] 449 | |         };
[INFO] [stderr]     | |_________^ help: consider using an if/else expression: `if self.in_object_key { self.styler.key } else { self.styler.string_value }`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool
[INFO] [stderr] 
[INFO] [stderr] warning: you seem to be trying to match on a boolean expression
[INFO] [stderr]    --> src/lib.rs:700:5
[INFO] [stderr]     |
[INFO] [stderr] 700 | /     match mode.use_color() {
[INFO] [stderr] 701 | |         true => {
[INFO] [stderr] 702 | |             let formatter = ColoredFormatter::new(PrettyFormatter::new());
[INFO] [stderr] 703 | |             let mut serializer = serde_json::Serializer::with_formatter(writer, formatter);
[INFO] [stderr] ...   |
[INFO] [stderr] 710 | |         }
[INFO] [stderr] 711 | |     }
[INFO] [stderr]     | |_____^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool
[INFO] [stderr] help: consider using an if/else expression
[INFO] [stderr]     |
[INFO] [stderr] 700 |     if mode.use_color() {
[INFO] [stderr] 701 |     let formatter = ColoredFormatter::new(PrettyFormatter::new());
[INFO] [stderr] 702 |     let mut serializer = serde_json::Serializer::with_formatter(writer, formatter);
[INFO] [stderr] 703 |     value.serialize(&mut serializer)
[INFO] [stderr] 704 | } else {
[INFO] [stderr] 705 |     let formatter = PrettyFormatter::new();
[INFO] [stderr]   ...
[INFO] [stderr] 
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]    --> src/lib.rs:754:23
[INFO] [stderr]     |
[INFO] [stderr] 754 |     fn is_tty(output: &Output) -> bool {
[INFO] [stderr]     |                       ^^^^^^^ help: consider passing by value instead: `Output`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]    --> src/lib.rs:762:36
[INFO] [stderr]     |
[INFO] [stderr] 762 |     pub fn should_colorize(output: &Output) -> bool {
[INFO] [stderr]     |                                    ^^^^^^^ help: consider passing by value instead: `Output`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr] warning: you seem to be trying to match on a boolean expression
[INFO] [stderr]    --> src/lib.rs:782:9
[INFO] [stderr]     |
[INFO] [stderr] 782 | /         match self.use_color() {
[INFO] [stderr] 783 | |             true => ColorMode::On,
[INFO] [stderr] 784 | |             false => ColorMode::Off,
[INFO] [stderr] 785 | |         }
[INFO] [stderr]     | |_________^ help: consider using an if/else expression: `if self.use_color() { ColorMode::On } else { ColorMode::Off }`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool
[INFO] [stderr] 
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]    --> src/lib.rs:811:22
[INFO] [stderr]     |
[INFO] [stderr] 811 |     pub fn use_color(&self) -> bool {
[INFO] [stderr]     |                      ^^^^^ help: consider passing by value instead: `self`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr] error: approximate value of `f{32, 64}::consts::PI` found. Consider using it directly
[INFO] [stderr]    --> src/test.rs:200:20
[INFO] [stderr]     |
[INFO] [stderr] 200 |           "float": 3.1415926,
[INFO] [stderr]     |                    ^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[deny(clippy::approx_constant)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#approx_constant
[INFO] [stderr] 
[INFO] [stderr] error: approximate value of `f{32, 64}::consts::PI` found. Consider using it directly
[INFO] [stderr]    --> src/test.rs:242:20
[INFO] [stderr]     |
[INFO] [stderr] 242 |           "float": 3.1415926,
[INFO] [stderr]     |                    ^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#approx_constant
[INFO] [stderr] 
[INFO] [stderr] warning: methods called `to_*` usually take self by reference; consider choosing a less ambiguous name
[INFO] [stderr]    --> src/lib.rs:243:33
[INFO] [stderr]     |
[INFO] [stderr] 243 |     pub fn to_colored_json_auto(self, value: &Value) -> serde_json::Result<String> {
[INFO] [stderr]     |                                 ^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::wrong_self_convention)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention
[INFO] [stderr] 
[INFO] [stderr] warning: methods called `to_*` usually take self by reference; consider choosing a less ambiguous name
[INFO] [stderr]    --> src/lib.rs:247:28
[INFO] [stderr]     |
[INFO] [stderr] 247 |     pub fn to_colored_json(self, value: &Value, mode: ColorMode) -> serde_json::Result<String> {
[INFO] [stderr]     |                            ^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention
[INFO] [stderr] 
[INFO] [stderr] warning: you seem to be trying to match on a boolean expression
[INFO] [stderr]    --> src/lib.rs:264:9
[INFO] [stderr]     |
[INFO] [stderr] 264 | /         match mode.use_color() {
[INFO] [stderr] 265 | |             true => {
[INFO] [stderr] 266 | |                 let mut serializer = serde_json::Serializer::with_formatter(writer, self);
[INFO] [stderr] 267 | |
[INFO] [stderr] ...   |
[INFO] [stderr] 273 | |             }
[INFO] [stderr] 274 | |         }
[INFO] [stderr]     | |_________^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::match_bool)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool
[INFO] [stderr] help: consider using an if/else expression
[INFO] [stderr]     |
[INFO] [stderr] 264 |         if mode.use_color() {
[INFO] [stderr] 265 |     let mut serializer = serde_json::Serializer::with_formatter(writer, self);
[INFO] [stderr] 266 | 
[INFO] [stderr] 267 |     return value.serialize(&mut serializer);
[INFO] [stderr] 268 | } else {
[INFO] [stderr] 269 |     let mut serializer = serde_json::Serializer::with_formatter(writer, self.formatter);
[INFO] [stderr]   ...
[INFO] [stderr] 
[INFO] [stderr] warning: passing a unit value to a function
[INFO] [stderr]    --> src/lib.rs:287:8
[INFO] [stderr]     |
[INFO] [stderr] 287 |     Ok(writer.write_all(style.paint(s).to_string().as_bytes())?)
[INFO] [stderr]     |        ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::unit_arg)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unit_arg
[INFO] [stderr] help: if you intended to pass a unit value, use a unit literal instead
[INFO] [stderr]     |
[INFO] [stderr] 287 |     Ok(())
[INFO] [stderr]     |        ^^
[INFO] [stderr] 
[INFO] [stderr] warning: you seem to be trying to match on a boolean expression
[INFO] [stderr]    --> src/lib.rs:417:25
[INFO] [stderr]     |
[INFO] [stderr] 417 |               let style = match self.in_object_key {
[INFO] [stderr]     |  _________________________^
[INFO] [stderr] 418 | |                 true => self.styler.key,
[INFO] [stderr] 419 | |                 false => self.styler.string_value,
[INFO] [stderr] 420 | |             };
[INFO] [stderr]     | |_____________^ help: consider using an if/else expression: `if self.in_object_key { self.styler.key } else { self.styler.string_value }`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool
[INFO] [stderr] 
[INFO] [stderr] warning: you seem to be trying to match on a boolean expression
[INFO] [stderr]    --> src/lib.rs:432:25
[INFO] [stderr]     |
[INFO] [stderr] 432 |               let style = match self.in_object_key {
[INFO] [stderr]     |  _________________________^
[INFO] [stderr] 433 | |                 true => self.styler.key,
[INFO] [stderr] 434 | |                 false => self.styler.string_value,
[INFO] [stderr] 435 | |             };
[INFO] [stderr]     | |_____________^ help: consider using an if/else expression: `if self.in_object_key { self.styler.key } else { self.styler.string_value }`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool
[INFO] [stderr] 
[INFO] [stderr] warning: you seem to be trying to match on a boolean expression
[INFO] [stderr]    --> src/lib.rs:446:21
[INFO] [stderr]     |
[INFO] [stderr] 446 |           let style = match self.in_object_key {
[INFO] [stderr]     |  _____________________^
[INFO] [stderr] 447 | |             true => self.styler.key,
[INFO] [stderr] 448 | |             false => self.styler.string_value,
[INFO] [stderr] 449 | |         };
[INFO] [stderr]     | |_________^ help: consider using an if/else expression: `if self.in_object_key { self.styler.key } else { self.styler.string_value }`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool
[INFO] [stderr] 
[INFO] [stderr] warning: you seem to be trying to match on a boolean expression
[INFO] [stderr]    --> src/lib.rs:700:5
[INFO] [stderr]     |
[INFO] [stderr] 700 | /     match mode.use_color() {
[INFO] [stderr] 701 | |         true => {
[INFO] [stderr] 702 | |             let formatter = ColoredFormatter::new(PrettyFormatter::new());
[INFO] [stderr] 703 | |             let mut serializer = serde_json::Serializer::with_formatter(writer, formatter);
[INFO] [stderr] ...   |
[INFO] [stderr] 710 | |         }
[INFO] [stderr] 711 | |     }
[INFO] [stderr]     | |_____^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool
[INFO] [stderr] help: consider using an if/else expression
[INFO] [stderr]     |
[INFO] [stderr] 700 |     if mode.use_color() {
[INFO] [stderr] 701 |     let formatter = ColoredFormatter::new(PrettyFormatter::new());
[INFO] [stderr] 702 |     let mut serializer = serde_json::Serializer::with_formatter(writer, formatter);
[INFO] [stderr] 703 |     value.serialize(&mut serializer)
[INFO] [stderr] 704 | } else {
[INFO] [stderr] 705 |     let formatter = PrettyFormatter::new();
[INFO] [stderr]   ...
[INFO] [stderr] 
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]    --> src/lib.rs:754:23
[INFO] [stderr]     |
[INFO] [stderr] 754 |     fn is_tty(output: &Output) -> bool {
[INFO] [stderr]     |                       ^^^^^^^ help: consider passing by value instead: `Output`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]    --> src/lib.rs:762:36
[INFO] [stderr]     |
[INFO] [stderr] 762 |     pub fn should_colorize(output: &Output) -> bool {
[INFO] [stderr]     |                                    ^^^^^^^ help: consider passing by value instead: `Output`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr] warning: you seem to be trying to match on a boolean expression
[INFO] [stderr]    --> src/lib.rs:782:9
[INFO] [stderr]     |
[INFO] [stderr] 782 | /         match self.use_color() {
[INFO] [stderr] 783 | |             true => ColorMode::On,
[INFO] [stderr] 784 | |             false => ColorMode::Off,
[INFO] [stderr] 785 | |         }
[INFO] [stderr]     | |_________^ help: consider using an if/else expression: `if self.use_color() { ColorMode::On } else { ColorMode::Off }`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool
[INFO] [stderr] 
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]    --> src/lib.rs:811:22
[INFO] [stderr]     |
[INFO] [stderr] 811 |     pub fn use_color(&self) -> bool {
[INFO] [stderr]     |                      ^^^^^ help: consider passing by value instead: `self`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr] error: aborting due to 2 previous errors
[INFO] [stderr] 
[INFO] [stderr] error: Could not compile `colored_json`.
[INFO] [stderr] 
[INFO] [stderr] To learn more, run the command again with --verbose.
[INFO] running `"docker" "inspect" "8f8568d1d8920746678e7e63e226892aac149027152c4315fcfea17b903c0b70"`
[INFO] running `"docker" "rm" "-f" "8f8568d1d8920746678e7e63e226892aac149027152c4315fcfea17b903c0b70"`
[INFO] [stdout] 8f8568d1d8920746678e7e63e226892aac149027152c4315fcfea17b903c0b70