[INFO] crate color-thief 0.1.0 is already in cache [INFO] extracting crate color-thief 0.1.0 into work/ex/clippy-test-run/sources/stable/reg/color-thief/0.1.0 [INFO] extracting crate color-thief 0.1.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/color-thief/0.1.0 [INFO] validating manifest of color-thief-0.1.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of color-thief-0.1.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing color-thief-0.1.0 [INFO] finished frobbing color-thief-0.1.0 [INFO] frobbed toml for color-thief-0.1.0 written to work/ex/clippy-test-run/sources/stable/reg/color-thief/0.1.0/Cargo.toml [INFO] started frobbing color-thief-0.1.0 [INFO] finished frobbing color-thief-0.1.0 [INFO] frobbed toml for color-thief-0.1.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/color-thief/0.1.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting color-thief-0.1.0 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-4/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/color-thief/0.1.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 42d8fae45e680ff4e1fb49fff4593863b70e00bedb8a9d28c5027ff16b93b034 [INFO] running `"docker" "start" "-a" "42d8fae45e680ff4e1fb49fff4593863b70e00bedb8a9d28c5027ff16b93b034"` [INFO] [stderr] Checking color-thief v0.1.0 (/opt/crater/workdir) [INFO] [stderr] Checking png v0.8.0 [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:116:13 [INFO] [stderr] | [INFO] [stderr] 116 | r_min: r_min, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `r_min` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:117:13 [INFO] [stderr] | [INFO] [stderr] 117 | r_max: r_max, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `r_max` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:118:13 [INFO] [stderr] | [INFO] [stderr] 118 | g_min: g_min, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `g_min` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:119:13 [INFO] [stderr] | [INFO] [stderr] 119 | g_max: g_max, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `g_max` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:120:13 [INFO] [stderr] | [INFO] [stderr] 120 | b_min: b_min, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `b_min` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:121:13 [INFO] [stderr] | [INFO] [stderr] 121 | b_max: b_max, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `b_max` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: 5th binding whose name is just one char [INFO] [stderr] --> src/lib.rs:237:23 [INFO] [stderr] | [INFO] [stderr] 237 | let (r, g, b, a) = color_parts(pixels, color_format, pos); [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::many_single_char_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:138:12 [INFO] [stderr] | [INFO] [stderr] 138 | (self.r_max as i32 - self.r_min as i32 + 1) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `i32::from(self.r_max)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:138:32 [INFO] [stderr] | [INFO] [stderr] 138 | (self.r_max as i32 - self.r_min as i32 + 1) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `i32::from(self.r_min)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:139:12 [INFO] [stderr] | [INFO] [stderr] 139 | * (self.g_max as i32 - self.g_min as i32 + 1) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `i32::from(self.g_max)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:139:32 [INFO] [stderr] | [INFO] [stderr] 139 | * (self.g_max as i32 - self.g_min as i32 + 1) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `i32::from(self.g_min)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:140:12 [INFO] [stderr] | [INFO] [stderr] 140 | * (self.b_max as i32 - self.b_min as i32 + 1) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `i32::from(self.b_max)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:140:32 [INFO] [stderr] | [INFO] [stderr] 140 | * (self.b_max as i32 - self.b_min as i32 + 1) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `i32::from(self.b_min)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/lib.rs:146:18 [INFO] [stderr] | [INFO] [stderr] 146 | for i in self.r_min..(self.r_max + 1) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `self.r_min..=self.r_max` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::range_plus_one)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/lib.rs:147:22 [INFO] [stderr] | [INFO] [stderr] 147 | for j in self.g_min..(self.g_max + 1) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `self.g_min..=self.g_max` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/lib.rs:148:26 [INFO] [stderr] | [INFO] [stderr] 148 | for k in self.b_min..(self.b_max + 1) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `self.b_min..=self.b_max` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/lib.rs:165:18 [INFO] [stderr] | [INFO] [stderr] 165 | for i in self.r_min..(self.r_max + 1) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `self.r_min..=self.r_max` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/lib.rs:166:22 [INFO] [stderr] | [INFO] [stderr] 166 | for j in self.g_min..(self.g_max + 1) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `self.g_min..=self.g_max` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/lib.rs:167:26 [INFO] [stderr] | [INFO] [stderr] 167 | for k in self.b_min..(self.b_max + 1) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `self.b_min..=self.b_max` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:169:32 [INFO] [stderr] | [INFO] [stderr] 169 | let hval = histogram[index] as f64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(histogram[index])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to f64 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:171:39 [INFO] [stderr] | [INFO] [stderr] 171 | r_sum += (hval * (i as f64 + 0.5) * MULTIPLIER_64) as i32; [INFO] [stderr] | ^^^^^^^^ help: try: `f64::from(i)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to f64 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:172:39 [INFO] [stderr] | [INFO] [stderr] 172 | g_sum += (hval * (j as f64 + 0.5) * MULTIPLIER_64) as i32; [INFO] [stderr] | ^^^^^^^^ help: try: `f64::from(j)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to f64 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:173:39 [INFO] [stderr] | [INFO] [stderr] 173 | b_sum += (hval * (k as f64 + 0.5) * MULTIPLIER_64) as i32; [INFO] [stderr] | ^^^^^^^^ help: try: `f64::from(k)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:184:35 [INFO] [stderr] | [INFO] [stderr] 184 | let r = MULTIPLIER * (self.r_min as i32 + self.r_max as i32 + 1) / 2; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `i32::from(self.r_min)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:184:55 [INFO] [stderr] | [INFO] [stderr] 184 | let r = MULTIPLIER * (self.r_min as i32 + self.r_max as i32 + 1) / 2; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `i32::from(self.r_max)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:185:35 [INFO] [stderr] | [INFO] [stderr] 185 | let g = MULTIPLIER * (self.g_min as i32 + self.g_max as i32 + 1) / 2; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `i32::from(self.g_min)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:185:55 [INFO] [stderr] | [INFO] [stderr] 185 | let g = MULTIPLIER * (self.g_min as i32 + self.g_max as i32 + 1) / 2; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `i32::from(self.g_max)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:186:35 [INFO] [stderr] | [INFO] [stderr] 186 | let b = MULTIPLIER * (self.b_min as i32 + self.b_max as i32 + 1) / 2; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `i32::from(self.b_min)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:186:55 [INFO] [stderr] | [INFO] [stderr] 186 | let b = MULTIPLIER * (self.b_min as i32 + self.b_max as i32 + 1) / 2; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `i32::from(self.b_max)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `pos` [INFO] [stderr] --> src/lib.rs:277:21 [INFO] [stderr] | [INFO] [stderr] 277 | (pixels[pos + 0], [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_op)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `pos` [INFO] [stderr] --> src/lib.rs:283:21 [INFO] [stderr] | [INFO] [stderr] 283 | (pixels[pos + 0], [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `pos` [INFO] [stderr] --> src/lib.rs:292:21 [INFO] [stderr] | [INFO] [stderr] 292 | pixels[pos + 0]) [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `pos` [INFO] [stderr] --> src/lib.rs:297:21 [INFO] [stderr] | [INFO] [stderr] 297 | pixels[pos + 0], [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `pos` [INFO] [stderr] --> src/lib.rs:303:21 [INFO] [stderr] | [INFO] [stderr] 303 | pixels[pos + 0], [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/lib.rs:329:22 [INFO] [stderr] | [INFO] [stderr] 329 | for i in vbox.r_min..(vbox.r_max + 1) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `vbox.r_min..=vbox.r_max` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/lib.rs:331:26 [INFO] [stderr] | [INFO] [stderr] 331 | for j in vbox.g_min..(vbox.g_max + 1) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `vbox.g_min..=vbox.g_max` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/lib.rs:332:30 [INFO] [stderr] | [INFO] [stderr] 332 | for k in vbox.b_min..(vbox.b_max + 1) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `vbox.b_min..=vbox.b_max` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/lib.rs:342:22 [INFO] [stderr] | [INFO] [stderr] 342 | for i in vbox.g_min..(vbox.g_max + 1) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `vbox.g_min..=vbox.g_max` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/lib.rs:344:26 [INFO] [stderr] | [INFO] [stderr] 344 | for j in vbox.r_min..(vbox.r_max + 1) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `vbox.r_min..=vbox.r_max` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/lib.rs:345:30 [INFO] [stderr] | [INFO] [stderr] 345 | for k in vbox.b_min..(vbox.b_max + 1) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `vbox.b_min..=vbox.b_max` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/lib.rs:355:22 [INFO] [stderr] | [INFO] [stderr] 355 | for i in vbox.b_min..(vbox.b_max + 1) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `vbox.b_min..=vbox.b_max` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/lib.rs:357:26 [INFO] [stderr] | [INFO] [stderr] 357 | for j in vbox.r_min..(vbox.r_max + 1) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `vbox.r_min..=vbox.r_max` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/lib.rs:358:30 [INFO] [stderr] | [INFO] [stderr] 358 | for k in vbox.g_min..(vbox.g_max + 1) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `vbox.g_min..=vbox.g_max` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:386:33 [INFO] [stderr] | [INFO] [stderr] 386 | ColorChannel::Red => (vbox.r_min as i32, vbox.r_max as i32), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `i32::from(vbox.r_min)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:386:52 [INFO] [stderr] | [INFO] [stderr] 386 | ColorChannel::Red => (vbox.r_min as i32, vbox.r_max as i32), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `i32::from(vbox.r_max)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:387:33 [INFO] [stderr] | [INFO] [stderr] 387 | ColorChannel::Green => (vbox.g_min as i32, vbox.g_max as i32), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `i32::from(vbox.g_min)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:387:52 [INFO] [stderr] | [INFO] [stderr] 387 | ColorChannel::Green => (vbox.g_min as i32, vbox.g_max as i32), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `i32::from(vbox.g_max)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:388:33 [INFO] [stderr] | [INFO] [stderr] 388 | ColorChannel::Blue => (vbox.b_min as i32, vbox.b_max as i32), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `i32::from(vbox.b_min)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:388:52 [INFO] [stderr] | [INFO] [stderr] 388 | ColorChannel::Blue => (vbox.b_min as i32, vbox.b_max as i32), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `i32::from(vbox.b_max)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:407:33 [INFO] [stderr] | [INFO] [stderr] 407 | cmp::max(vbox_min, ((i - 1) as f64 - left as f64 / 2.0) as i32) [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try: `f64::from(i - 1)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:407:50 [INFO] [stderr] | [INFO] [stderr] 407 | cmp::max(vbox_min, ((i - 1) as f64 - left as f64 / 2.0) as i32) [INFO] [stderr] | ^^^^^^^^^^^ help: try: `f64::from(left)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to f64 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:458:44 [INFO] [stderr] | [INFO] [stderr] 458 | let target = (FRACTION_BY_POPULATION * max_colors as f64).ceil() as u8; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `f64::from(max_colors)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to i64 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:524:25 [INFO] [stderr] | [INFO] [stderr] 524 | let a_product = a.count as i64 * a.volume as i64; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try: `i64::from(a.count)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to i64 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:524:42 [INFO] [stderr] | [INFO] [stderr] 524 | let a_product = a.count as i64 * a.volume as i64; [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `i64::from(a.volume)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to i64 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:525:25 [INFO] [stderr] | [INFO] [stderr] 525 | let b_product = b.count as i64 * b.volume as i64; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try: `i64::from(b.count)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to i64 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:525:42 [INFO] [stderr] | [INFO] [stderr] 525 | let b_product = b.count as i64 * b.volume as i64; [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `i64::from(b.volume)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:532:10 [INFO] [stderr] | [INFO] [stderr] 532 | ( ((red as i32) << (2 * SIGNAL_BITS)) [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `i32::from(red)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:533:10 [INFO] [stderr] | [INFO] [stderr] 533 | + ((green as i32) << SIGNAL_BITS) [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try: `i32::from(green)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:534:11 [INFO] [stderr] | [INFO] [stderr] 534 | + blue as i32 [INFO] [stderr] | ^^^^^^^^^^^ help: try: `i32::from(blue)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] Checking image v0.14.0 [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:116:13 [INFO] [stderr] | [INFO] [stderr] 116 | r_min: r_min, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `r_min` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:117:13 [INFO] [stderr] | [INFO] [stderr] 117 | r_max: r_max, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `r_max` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:118:13 [INFO] [stderr] | [INFO] [stderr] 118 | g_min: g_min, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `g_min` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:119:13 [INFO] [stderr] | [INFO] [stderr] 119 | g_max: g_max, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `g_max` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:120:13 [INFO] [stderr] | [INFO] [stderr] 120 | b_min: b_min, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `b_min` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:121:13 [INFO] [stderr] | [INFO] [stderr] 121 | b_max: b_max, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `b_max` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: 5th binding whose name is just one char [INFO] [stderr] --> src/lib.rs:237:23 [INFO] [stderr] | [INFO] [stderr] 237 | let (r, g, b, a) = color_parts(pixels, color_format, pos); [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::many_single_char_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:138:12 [INFO] [stderr] | [INFO] [stderr] 138 | (self.r_max as i32 - self.r_min as i32 + 1) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `i32::from(self.r_max)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:138:32 [INFO] [stderr] | [INFO] [stderr] 138 | (self.r_max as i32 - self.r_min as i32 + 1) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `i32::from(self.r_min)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:139:12 [INFO] [stderr] | [INFO] [stderr] 139 | * (self.g_max as i32 - self.g_min as i32 + 1) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `i32::from(self.g_max)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:139:32 [INFO] [stderr] | [INFO] [stderr] 139 | * (self.g_max as i32 - self.g_min as i32 + 1) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `i32::from(self.g_min)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:140:12 [INFO] [stderr] | [INFO] [stderr] 140 | * (self.b_max as i32 - self.b_min as i32 + 1) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `i32::from(self.b_max)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:140:32 [INFO] [stderr] | [INFO] [stderr] 140 | * (self.b_max as i32 - self.b_min as i32 + 1) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `i32::from(self.b_min)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/lib.rs:146:18 [INFO] [stderr] | [INFO] [stderr] 146 | for i in self.r_min..(self.r_max + 1) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `self.r_min..=self.r_max` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::range_plus_one)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/lib.rs:147:22 [INFO] [stderr] | [INFO] [stderr] 147 | for j in self.g_min..(self.g_max + 1) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `self.g_min..=self.g_max` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/lib.rs:148:26 [INFO] [stderr] | [INFO] [stderr] 148 | for k in self.b_min..(self.b_max + 1) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `self.b_min..=self.b_max` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/lib.rs:165:18 [INFO] [stderr] | [INFO] [stderr] 165 | for i in self.r_min..(self.r_max + 1) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `self.r_min..=self.r_max` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/lib.rs:166:22 [INFO] [stderr] | [INFO] [stderr] 166 | for j in self.g_min..(self.g_max + 1) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `self.g_min..=self.g_max` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/lib.rs:167:26 [INFO] [stderr] | [INFO] [stderr] 167 | for k in self.b_min..(self.b_max + 1) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `self.b_min..=self.b_max` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:169:32 [INFO] [stderr] | [INFO] [stderr] 169 | let hval = histogram[index] as f64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(histogram[index])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to f64 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:171:39 [INFO] [stderr] | [INFO] [stderr] 171 | r_sum += (hval * (i as f64 + 0.5) * MULTIPLIER_64) as i32; [INFO] [stderr] | ^^^^^^^^ help: try: `f64::from(i)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to f64 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:172:39 [INFO] [stderr] | [INFO] [stderr] 172 | g_sum += (hval * (j as f64 + 0.5) * MULTIPLIER_64) as i32; [INFO] [stderr] | ^^^^^^^^ help: try: `f64::from(j)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to f64 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:173:39 [INFO] [stderr] | [INFO] [stderr] 173 | b_sum += (hval * (k as f64 + 0.5) * MULTIPLIER_64) as i32; [INFO] [stderr] | ^^^^^^^^ help: try: `f64::from(k)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:184:35 [INFO] [stderr] | [INFO] [stderr] 184 | let r = MULTIPLIER * (self.r_min as i32 + self.r_max as i32 + 1) / 2; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `i32::from(self.r_min)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:184:55 [INFO] [stderr] | [INFO] [stderr] 184 | let r = MULTIPLIER * (self.r_min as i32 + self.r_max as i32 + 1) / 2; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `i32::from(self.r_max)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:185:35 [INFO] [stderr] | [INFO] [stderr] 185 | let g = MULTIPLIER * (self.g_min as i32 + self.g_max as i32 + 1) / 2; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `i32::from(self.g_min)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:185:55 [INFO] [stderr] | [INFO] [stderr] 185 | let g = MULTIPLIER * (self.g_min as i32 + self.g_max as i32 + 1) / 2; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `i32::from(self.g_max)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:186:35 [INFO] [stderr] | [INFO] [stderr] 186 | let b = MULTIPLIER * (self.b_min as i32 + self.b_max as i32 + 1) / 2; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `i32::from(self.b_min)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:186:55 [INFO] [stderr] | [INFO] [stderr] 186 | let b = MULTIPLIER * (self.b_min as i32 + self.b_max as i32 + 1) / 2; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `i32::from(self.b_max)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `pos` [INFO] [stderr] --> src/lib.rs:277:21 [INFO] [stderr] | [INFO] [stderr] 277 | (pixels[pos + 0], [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_op)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `pos` [INFO] [stderr] --> src/lib.rs:283:21 [INFO] [stderr] | [INFO] [stderr] 283 | (pixels[pos + 0], [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `pos` [INFO] [stderr] --> src/lib.rs:292:21 [INFO] [stderr] | [INFO] [stderr] 292 | pixels[pos + 0]) [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `pos` [INFO] [stderr] --> src/lib.rs:297:21 [INFO] [stderr] | [INFO] [stderr] 297 | pixels[pos + 0], [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `pos` [INFO] [stderr] --> src/lib.rs:303:21 [INFO] [stderr] | [INFO] [stderr] 303 | pixels[pos + 0], [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/lib.rs:329:22 [INFO] [stderr] | [INFO] [stderr] 329 | for i in vbox.r_min..(vbox.r_max + 1) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `vbox.r_min..=vbox.r_max` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/lib.rs:331:26 [INFO] [stderr] | [INFO] [stderr] 331 | for j in vbox.g_min..(vbox.g_max + 1) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `vbox.g_min..=vbox.g_max` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/lib.rs:332:30 [INFO] [stderr] | [INFO] [stderr] 332 | for k in vbox.b_min..(vbox.b_max + 1) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `vbox.b_min..=vbox.b_max` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/lib.rs:342:22 [INFO] [stderr] | [INFO] [stderr] 342 | for i in vbox.g_min..(vbox.g_max + 1) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `vbox.g_min..=vbox.g_max` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/lib.rs:344:26 [INFO] [stderr] | [INFO] [stderr] 344 | for j in vbox.r_min..(vbox.r_max + 1) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `vbox.r_min..=vbox.r_max` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/lib.rs:345:30 [INFO] [stderr] | [INFO] [stderr] 345 | for k in vbox.b_min..(vbox.b_max + 1) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `vbox.b_min..=vbox.b_max` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/lib.rs:355:22 [INFO] [stderr] | [INFO] [stderr] 355 | for i in vbox.b_min..(vbox.b_max + 1) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `vbox.b_min..=vbox.b_max` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/lib.rs:357:26 [INFO] [stderr] | [INFO] [stderr] 357 | for j in vbox.r_min..(vbox.r_max + 1) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `vbox.r_min..=vbox.r_max` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/lib.rs:358:30 [INFO] [stderr] | [INFO] [stderr] 358 | for k in vbox.g_min..(vbox.g_max + 1) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `vbox.g_min..=vbox.g_max` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:386:33 [INFO] [stderr] | [INFO] [stderr] 386 | ColorChannel::Red => (vbox.r_min as i32, vbox.r_max as i32), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `i32::from(vbox.r_min)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:386:52 [INFO] [stderr] | [INFO] [stderr] 386 | ColorChannel::Red => (vbox.r_min as i32, vbox.r_max as i32), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `i32::from(vbox.r_max)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:387:33 [INFO] [stderr] | [INFO] [stderr] 387 | ColorChannel::Green => (vbox.g_min as i32, vbox.g_max as i32), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `i32::from(vbox.g_min)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:387:52 [INFO] [stderr] | [INFO] [stderr] 387 | ColorChannel::Green => (vbox.g_min as i32, vbox.g_max as i32), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `i32::from(vbox.g_max)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:388:33 [INFO] [stderr] | [INFO] [stderr] 388 | ColorChannel::Blue => (vbox.b_min as i32, vbox.b_max as i32), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `i32::from(vbox.b_min)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:388:52 [INFO] [stderr] | [INFO] [stderr] 388 | ColorChannel::Blue => (vbox.b_min as i32, vbox.b_max as i32), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `i32::from(vbox.b_max)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:407:33 [INFO] [stderr] | [INFO] [stderr] 407 | cmp::max(vbox_min, ((i - 1) as f64 - left as f64 / 2.0) as i32) [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try: `f64::from(i - 1)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:407:50 [INFO] [stderr] | [INFO] [stderr] 407 | cmp::max(vbox_min, ((i - 1) as f64 - left as f64 / 2.0) as i32) [INFO] [stderr] | ^^^^^^^^^^^ help: try: `f64::from(left)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to f64 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:458:44 [INFO] [stderr] | [INFO] [stderr] 458 | let target = (FRACTION_BY_POPULATION * max_colors as f64).ceil() as u8; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `f64::from(max_colors)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to i64 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:524:25 [INFO] [stderr] | [INFO] [stderr] 524 | let a_product = a.count as i64 * a.volume as i64; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try: `i64::from(a.count)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to i64 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:524:42 [INFO] [stderr] | [INFO] [stderr] 524 | let a_product = a.count as i64 * a.volume as i64; [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `i64::from(a.volume)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to i64 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:525:25 [INFO] [stderr] | [INFO] [stderr] 525 | let b_product = b.count as i64 * b.volume as i64; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try: `i64::from(b.count)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to i64 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:525:42 [INFO] [stderr] | [INFO] [stderr] 525 | let b_product = b.count as i64 * b.volume as i64; [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `i64::from(b.volume)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:532:10 [INFO] [stderr] | [INFO] [stderr] 532 | ( ((red as i32) << (2 * SIGNAL_BITS)) [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `i32::from(red)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:533:10 [INFO] [stderr] | [INFO] [stderr] 533 | + ((green as i32) << SIGNAL_BITS) [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try: `i32::from(green)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:534:11 [INFO] [stderr] | [INFO] [stderr] 534 | + blue as i32 [INFO] [stderr] | ^^^^^^^^^^^ help: try: `i32::from(blue)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 9.09s [INFO] running `"docker" "inspect" "42d8fae45e680ff4e1fb49fff4593863b70e00bedb8a9d28c5027ff16b93b034"` [INFO] running `"docker" "rm" "-f" "42d8fae45e680ff4e1fb49fff4593863b70e00bedb8a9d28c5027ff16b93b034"` [INFO] [stdout] 42d8fae45e680ff4e1fb49fff4593863b70e00bedb8a9d28c5027ff16b93b034