[INFO] crate collisions 0.1.3 is already in cache [INFO] extracting crate collisions 0.1.3 into work/ex/clippy-test-run/sources/stable/reg/collisions/0.1.3 [INFO] extracting crate collisions 0.1.3 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/collisions/0.1.3 [INFO] validating manifest of collisions-0.1.3 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of collisions-0.1.3 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing collisions-0.1.3 [INFO] finished frobbing collisions-0.1.3 [INFO] frobbed toml for collisions-0.1.3 written to work/ex/clippy-test-run/sources/stable/reg/collisions/0.1.3/Cargo.toml [INFO] started frobbing collisions-0.1.3 [INFO] finished frobbing collisions-0.1.3 [INFO] frobbed toml for collisions-0.1.3 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/collisions/0.1.3/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting collisions-0.1.3 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-2/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/collisions/0.1.3:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 24eb96f83b73b85ae90af72fdb6fcee6638d23e28de182c26590e8390c7b53bf [INFO] running `"docker" "start" "-a" "24eb96f83b73b85ae90af72fdb6fcee6638d23e28de182c26590e8390c7b53bf"` [INFO] [stderr] Checking nalgebra v0.8.2 [INFO] [stderr] Checking collisions v0.1.3 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/quadtree.rs:84:4 [INFO] [stderr] | [INFO] [stderr] 84 | quads: quads, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `quads` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: 5th binding whose name is just one char [INFO] [stderr] --> src/quadtree.rs:180:14 [INFO] [stderr] | [INFO] [stderr] 180 | (d, f, s) => [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::many_single_char_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 5th binding whose name is just one char [INFO] [stderr] --> src/quadtree.rs:204:14 [INFO] [stderr] | [INFO] [stderr] 204 | (d, f, s) => [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/collidable.rs:99:13 [INFO] [stderr] | [INFO] [stderr] 99 | nvert: nvert, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `nvert` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/collidable.rs:100:13 [INFO] [stderr] | [INFO] [stderr] 100 | vertx: vertx, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `vertx` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/collidable.rs:101:13 [INFO] [stderr] | [INFO] [stderr] 101 | verty: verty, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `verty` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/collidable.rs:102:13 [INFO] [stderr] | [INFO] [stderr] 102 | normx: normx, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `normx` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/collidable.rs:103:13 [INFO] [stderr] | [INFO] [stderr] 103 | normy: normy, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `normy` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/collidable.rs:121:4 [INFO] [stderr] | [INFO] [stderr] 121 | nvert: nvert, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `nvert` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/collidable.rs:122:4 [INFO] [stderr] | [INFO] [stderr] 122 | vertx: vertx, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `vertx` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/collidable.rs:123:4 [INFO] [stderr] | [INFO] [stderr] 123 | verty: verty, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `verty` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/collidable.rs:124:4 [INFO] [stderr] | [INFO] [stderr] 124 | normx: normx, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `normx` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/collidable.rs:125:4 [INFO] [stderr] | [INFO] [stderr] 125 | normy: normy, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `normy` [INFO] [stderr] | [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/quadtree.rs:84:4 [INFO] [stderr] | [INFO] [stderr] 84 | quads: quads, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `quads` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: 5th binding whose name is just one char [INFO] [stderr] --> src/collidable.rs:129:53 [INFO] [stderr] | [INFO] [stderr] 129 | pub fn new_square(t: u8, i: usize, x: f32, y: f32, w: f32, h: f32) -> Collidable [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 5th binding whose name is just one char [INFO] [stderr] --> src/quadtree.rs:180:14 [INFO] [stderr] | [INFO] [stderr] 180 | (d, f, s) => [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::many_single_char_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 6th binding whose name is just one char [INFO] [stderr] --> src/collidable.rs:129:61 [INFO] [stderr] | [INFO] [stderr] 129 | pub fn new_square(t: u8, i: usize, x: f32, y: f32, w: f32, h: f32) -> Collidable [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 5th binding whose name is just one char [INFO] [stderr] --> src/quadtree.rs:204:14 [INFO] [stderr] | [INFO] [stderr] 204 | (d, f, s) => [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/collidable.rs:154:4 [INFO] [stderr] | [INFO] [stderr] 154 | nvert: nvert, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `nvert` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/collidable.rs:155:4 [INFO] [stderr] | [INFO] [stderr] 155 | vertx: vertx, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `vertx` [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/collidable.rs:99:13 [INFO] [stderr] | [INFO] [stderr] 99 | nvert: nvert, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `nvert` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/collidable.rs:100:13 [INFO] [stderr] | [INFO] [stderr] 100 | vertx: vertx, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `vertx` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/collidable.rs:156:4 [INFO] [stderr] | [INFO] [stderr] 156 | verty: verty, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `verty` [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/collidable.rs:101:13 [INFO] [stderr] | [INFO] [stderr] 101 | verty: verty, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `verty` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] | [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] --> src/collidable.rs:102:13 [INFO] [stderr] | [INFO] [stderr] 102 | normx: normx, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `normx` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/collidable.rs:103:13 [INFO] [stderr] | [INFO] [stderr] 103 | normy: normy, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `normy` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/collidable.rs:157:4 [INFO] [stderr] | [INFO] [stderr] 157 | normx: normx, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `normx` [INFO] [stderr] | [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/collidable.rs:121:4 [INFO] [stderr] | [INFO] [stderr] 121 | nvert: nvert, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `nvert` [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] | [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] --> src/collidable.rs:158:4 [INFO] [stderr] | [INFO] [stderr] 158 | normy: normy, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `normy` [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/collidable.rs:122:4 [INFO] [stderr] | [INFO] [stderr] 122 | vertx: vertx, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `vertx` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/collidable.rs:123:4 [INFO] [stderr] | [INFO] [stderr] 123 | verty: verty, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `verty` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/collidable.rs:124:4 [INFO] [stderr] | [INFO] [stderr] 124 | normx: normx, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `normx` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/collidable.rs:125:4 [INFO] [stderr] | [INFO] [stderr] 125 | normy: normy, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `normy` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: 5th binding whose name is just one char [INFO] [stderr] --> src/collidable.rs:129:53 [INFO] [stderr] | [INFO] [stderr] 129 | pub fn new_square(t: u8, i: usize, x: f32, y: f32, w: f32, h: f32) -> Collidable [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 6th binding whose name is just one char [INFO] [stderr] --> src/collidable.rs:129:61 [INFO] [stderr] | [INFO] [stderr] 129 | pub fn new_square(t: u8, i: usize, x: f32, y: f32, w: f32, h: f32) -> Collidable [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/collidable.rs:154:4 [INFO] [stderr] | [INFO] [stderr] 154 | nvert: nvert, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `nvert` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/collidable.rs:155:4 [INFO] [stderr] | [INFO] [stderr] 155 | vertx: vertx, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `vertx` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/collidable.rs:156:4 [INFO] [stderr] | [INFO] [stderr] 156 | verty: verty, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `verty` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/collidable.rs:157:4 [INFO] [stderr] | [INFO] [stderr] 157 | normx: normx, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `normx` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/collidable.rs:158:4 [INFO] [stderr] | [INFO] [stderr] 158 | normy: normy, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `normy` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/util.rs:23:5 [INFO] [stderr] | [INFO] [stderr] 23 | return c; [INFO] [stderr] | ^^^^^^^^^ help: remove `return` as shown: `c` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/util.rs:36:5 [INFO] [stderr] | [INFO] [stderr] 36 | return c; [INFO] [stderr] | ^^^^^^^^^ help: remove `return` as shown: `c` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/util.rs:23:5 [INFO] [stderr] | [INFO] [stderr] 23 | return c; [INFO] [stderr] | ^^^^^^^^^ help: remove `return` as shown: `c` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/util.rs:36:5 [INFO] [stderr] | [INFO] [stderr] 36 | return c; [INFO] [stderr] | ^^^^^^^^^ help: remove `return` as shown: `c` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: the loop variable `j` is only used to index `quad_items`. [INFO] [stderr] --> src/quadtree.rs:129:14 [INFO] [stderr] | [INFO] [stderr] 129 | for j in 0..quad_items.len() [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_range_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 129 | for in &quad_items [INFO] [stderr] | ^^^^^^ ^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: this function has too many arguments (8/7) [INFO] [stderr] --> src/collidable.rs:58:5 [INFO] [stderr] | [INFO] [stderr] 58 | / pub fn new_arc(t: u8, id: usize, cx: f32, cy: f32, r: f32, dirx: f32, diry: f32, rad: f32) -> Collidable [INFO] [stderr] 59 | | { [INFO] [stderr] 60 | | let centre = Vector2::new(cx, cy); [INFO] [stderr] 61 | | [INFO] [stderr] ... | [INFO] [stderr] 104 | | } [INFO] [stderr] 105 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::too_many_arguments)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stderr] [INFO] [stderr] warning: this function has too many arguments (8/7) [INFO] [stderr] --> src/util.rs:195:1 [INFO] [stderr] | [INFO] [stderr] 195 | / pub fn penetration(nverta: usize, vertxa: &[f32], vertya: &[f32], normxa: &[f32], normya: &[f32], nvertb: usize, vertxb: &[f32], vertyb: &[f32]) -> (Distance, FaceIndex, SupportPoint) [INFO] [stderr] 196 | | { [INFO] [stderr] 197 | | let mut best_dist = f32::MIN; [INFO] [stderr] 198 | | let mut best_face = 0; [INFO] [stderr] ... | [INFO] [stderr] 213 | | (best_dist, best_face, best_supp) [INFO] [stderr] 214 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stderr] [INFO] [stderr] warning: the loop variable `j` is only used to index `quad_items`. [INFO] [stderr] --> src/quadtree.rs:129:14 [INFO] [stderr] | [INFO] [stderr] 129 | for j in 0..quad_items.len() [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_range_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 129 | for in &quad_items [INFO] [stderr] | ^^^^^^ ^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: this function has too many arguments (8/7) [INFO] [stderr] --> src/collidable.rs:58:5 [INFO] [stderr] | [INFO] [stderr] 58 | / pub fn new_arc(t: u8, id: usize, cx: f32, cy: f32, r: f32, dirx: f32, diry: f32, rad: f32) -> Collidable [INFO] [stderr] 59 | | { [INFO] [stderr] 60 | | let centre = Vector2::new(cx, cy); [INFO] [stderr] 61 | | [INFO] [stderr] ... | [INFO] [stderr] 104 | | } [INFO] [stderr] 105 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::too_many_arguments)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stderr] [INFO] [stderr] warning: this function has too many arguments (8/7) [INFO] [stderr] --> src/util.rs:195:1 [INFO] [stderr] | [INFO] [stderr] 195 | / pub fn penetration(nverta: usize, vertxa: &[f32], vertya: &[f32], normxa: &[f32], normya: &[f32], nvertb: usize, vertxb: &[f32], vertyb: &[f32]) -> (Distance, FaceIndex, SupportPoint) [INFO] [stderr] 196 | | { [INFO] [stderr] 197 | | let mut best_dist = f32::MIN; [INFO] [stderr] 198 | | let mut best_face = 0; [INFO] [stderr] ... | [INFO] [stderr] 213 | | (best_dist, best_face, best_supp) [INFO] [stderr] 214 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 12.96s [INFO] running `"docker" "inspect" "24eb96f83b73b85ae90af72fdb6fcee6638d23e28de182c26590e8390c7b53bf"` [INFO] running `"docker" "rm" "-f" "24eb96f83b73b85ae90af72fdb6fcee6638d23e28de182c26590e8390c7b53bf"` [INFO] [stdout] 24eb96f83b73b85ae90af72fdb6fcee6638d23e28de182c26590e8390c7b53bf