[INFO] crate collision 0.18.0 is already in cache [INFO] extracting crate collision 0.18.0 into work/ex/clippy-test-run/sources/stable/reg/collision/0.18.0 [INFO] extracting crate collision 0.18.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/collision/0.18.0 [INFO] validating manifest of collision-0.18.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of collision-0.18.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing collision-0.18.0 [INFO] finished frobbing collision-0.18.0 [INFO] frobbed toml for collision-0.18.0 written to work/ex/clippy-test-run/sources/stable/reg/collision/0.18.0/Cargo.toml [INFO] started frobbing collision-0.18.0 [INFO] finished frobbing collision-0.18.0 [INFO] frobbed toml for collision-0.18.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/collision/0.18.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting collision-0.18.0 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-5/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/collision/0.18.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] c211f16d75d313c3978a5a3da26fded95728d505513104a8a4a8f59d8750081c [INFO] running `"docker" "start" "-a" "c211f16d75d313c3978a5a3da26fded95728d505513104a8a4a8f59d8750081c"` [INFO] [stderr] Checking cgmath v0.14.1 [INFO] [stderr] Checking cgmath v0.16.1 [INFO] [stderr] Checking genmesh v0.5.0 [INFO] [stderr] Checking collision v0.18.0 (/opt/crater/workdir) [INFO] [stderr] warning: 5th binding whose name is just one char [INFO] [stderr] --> src/primitive/util.rs:68:9 [INFO] [stderr] | [INFO] [stderr] 68 | let v = (d11 * d20 - d01 * d21) * inv_denom; [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::many_single_char_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 6th binding whose name is just one char [INFO] [stderr] --> src/primitive/util.rs:69:9 [INFO] [stderr] | [INFO] [stderr] 69 | let w = (d00 * d21 - d01 * d20) * inv_denom; [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 7th binding whose name is just one char [INFO] [stderr] --> src/primitive/util.rs:70:9 [INFO] [stderr] | [INFO] [stderr] 70 | let u = V::Scalar::one() - v - w; [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 5th binding whose name is just one char [INFO] [stderr] --> src/primitive/util.rs:91:9 [INFO] [stderr] | [INFO] [stderr] 91 | let v = (d11 * d20 - d01 * d21) * inv_denom; [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 6th binding whose name is just one char [INFO] [stderr] --> src/primitive/util.rs:92:9 [INFO] [stderr] | [INFO] [stderr] 92 | let w = (d00 * d21 - d01 * d20) * inv_denom; [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 7th binding whose name is just one char [INFO] [stderr] --> src/primitive/util.rs:93:9 [INFO] [stderr] | [INFO] [stderr] 93 | let u = P::Scalar::one() - v - w; [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 5th binding whose name is just one char [INFO] [stderr] --> src/algorithm/minkowski/epa/epa2d.rs:146:17 [INFO] [stderr] | [INFO] [stderr] 146 | let n = triple_product(&e, &oa, &e).normalize(); [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 6th binding whose name is just one char [INFO] [stderr] --> src/algorithm/minkowski/epa/epa2d.rs:147:17 [INFO] [stderr] | [INFO] [stderr] 147 | let d = n.dot(a); [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 5th binding whose name is just one char [INFO] [stderr] --> src/algorithm/minkowski/gjk/simplex/simplex3d.rs:33:17 [INFO] [stderr] | [INFO] [stderr] 33 | let d = simplex[0].v; [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 5th binding whose name is just one char [INFO] [stderr] --> src/algorithm/minkowski/gjk/simplex/simplex3d.rs:148:21 [INFO] [stderr] | [INFO] [stderr] 148 | let (u, v, w) = barycentric_vector(point.to_vec(), *a, *b, *c); [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 6th binding whose name is just one char [INFO] [stderr] --> src/algorithm/minkowski/gjk/simplex/simplex3d.rs:148:24 [INFO] [stderr] | [INFO] [stderr] 148 | let (u, v, w) = barycentric_vector(point.to_vec(), *a, *b, *c); [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/plane.rs:50:13 [INFO] [stderr] | [INFO] [stderr] 50 | d: d, [INFO] [stderr] | ^^^^ help: replace it with: `d` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: 5th binding whose name is just one char [INFO] [stderr] --> src/plane.rs:85:17 [INFO] [stderr] | [INFO] [stderr] 85 | let d = -a.dot(n); [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/plane.rs:94:17 [INFO] [stderr] | [INFO] [stderr] 94 | Plane { n: n, d: p.dot(n) } [INFO] [stderr] | ^^^^ help: replace it with: `n` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: 5th binding whose name is just one char [INFO] [stderr] --> src/line.rs:100:13 [INFO] [stderr] | [INFO] [stderr] 100 | let t = qmp.perp_dot(s) / cross_1; [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 6th binding whose name is just one char [INFO] [stderr] --> src/line.rs:101:13 [INFO] [stderr] | [INFO] [stderr] 101 | let u = cross_2 / cross_1; [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 5th binding whose name is just one char [INFO] [stderr] --> src/primitive/util.rs:68:9 [INFO] [stderr] | [INFO] [stderr] 68 | let v = (d11 * d20 - d01 * d21) * inv_denom; [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::many_single_char_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 6th binding whose name is just one char [INFO] [stderr] --> src/primitive/util.rs:69:9 [INFO] [stderr] | [INFO] [stderr] 69 | let w = (d00 * d21 - d01 * d20) * inv_denom; [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 7th binding whose name is just one char [INFO] [stderr] --> src/primitive/util.rs:70:9 [INFO] [stderr] | [INFO] [stderr] 70 | let u = V::Scalar::one() - v - w; [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 5th binding whose name is just one char [INFO] [stderr] --> src/primitive/util.rs:91:9 [INFO] [stderr] | [INFO] [stderr] 91 | let v = (d11 * d20 - d01 * d21) * inv_denom; [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 6th binding whose name is just one char [INFO] [stderr] --> src/primitive/util.rs:92:9 [INFO] [stderr] | [INFO] [stderr] 92 | let w = (d00 * d21 - d01 * d20) * inv_denom; [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 7th binding whose name is just one char [INFO] [stderr] --> src/primitive/util.rs:93:9 [INFO] [stderr] | [INFO] [stderr] 93 | let u = P::Scalar::one() - v - w; [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 5th binding whose name is just one char [INFO] [stderr] --> src/algorithm/minkowski/epa/epa2d.rs:146:17 [INFO] [stderr] | [INFO] [stderr] 146 | let n = triple_product(&e, &oa, &e).normalize(); [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 6th binding whose name is just one char [INFO] [stderr] --> src/algorithm/minkowski/epa/epa2d.rs:147:17 [INFO] [stderr] | [INFO] [stderr] 147 | let d = n.dot(a); [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 5th binding whose name is just one char [INFO] [stderr] --> src/algorithm/minkowski/gjk/simplex/simplex3d.rs:33:17 [INFO] [stderr] | [INFO] [stderr] 33 | let d = simplex[0].v; [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 5th binding whose name is just one char [INFO] [stderr] --> src/algorithm/minkowski/gjk/simplex/simplex3d.rs:148:21 [INFO] [stderr] | [INFO] [stderr] 148 | let (u, v, w) = barycentric_vector(point.to_vec(), *a, *b, *c); [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 6th binding whose name is just one char [INFO] [stderr] --> src/algorithm/minkowski/gjk/simplex/simplex3d.rs:148:24 [INFO] [stderr] | [INFO] [stderr] 148 | let (u, v, w) = barycentric_vector(point.to_vec(), *a, *b, *c); [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/plane.rs:50:13 [INFO] [stderr] | [INFO] [stderr] 50 | d: d, [INFO] [stderr] | ^^^^ help: replace it with: `d` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: 5th binding whose name is just one char [INFO] [stderr] --> src/plane.rs:85:17 [INFO] [stderr] | [INFO] [stderr] 85 | let d = -a.dot(n); [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/plane.rs:94:17 [INFO] [stderr] | [INFO] [stderr] 94 | Plane { n: n, d: p.dot(n) } [INFO] [stderr] | ^^^^ help: replace it with: `n` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: 5th binding whose name is just one char [INFO] [stderr] --> src/line.rs:100:13 [INFO] [stderr] | [INFO] [stderr] 100 | let t = qmp.perp_dot(s) / cross_1; [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 6th binding whose name is just one char [INFO] [stderr] --> src/line.rs:101:13 [INFO] [stderr] | [INFO] [stderr] 101 | let u = cross_2 / cross_1; [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/algorithm/minkowski/gjk/mod.rs:21:37 [INFO] [stderr] | [INFO] [stderr] 21 | const GJK_DISTANCE_TOLERANCE: f32 = 0.000001; [INFO] [stderr] | ^^^^^^^^ help: consider: `0.000_001` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/algorithm/minkowski/gjk/mod.rs:22:39 [INFO] [stderr] | [INFO] [stderr] 22 | const GJK_CONTINUOUS_TOLERANCE: f32 = 0.000001; [INFO] [stderr] | ^^^^^^^^ help: consider: `0.000_001` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/primitive/circle.rs:108:29 [INFO] [stderr] | [INFO] [stderr] 108 | test_circle(1., 1., 7.0710677, 7.0710677, 0.); [INFO] [stderr] | ^^^^^^^^^ help: consider: `7.071_067_7` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/primitive/circle.rs:108:40 [INFO] [stderr] | [INFO] [stderr] 108 | test_circle(1., 1., 7.0710677, 7.0710677, 0.); [INFO] [stderr] | ^^^^^^^^^ help: consider: `7.071_067_7` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/primitive/capsule.rs:232:37 [INFO] [stderr] | [INFO] [stderr] 232 | assert_ulps_eq!(Point3::new(0.44721365, -2.8944273, 0.), point); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0.447_213_65` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/primitive/capsule.rs:232:50 [INFO] [stderr] | [INFO] [stderr] 232 | assert_ulps_eq!(Point3::new(0.44721365, -2.8944273, 0.), point); [INFO] [stderr] | ^^^^^^^^^ help: consider: `2.894_427_3` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/primitive/capsule.rs:329:17 [INFO] [stderr] | [INFO] [stderr] 329 | 0.10102588514869944, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: consider: `0.101_025_885_148_699_44` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/primitive/capsule.rs:330:17 [INFO] [stderr] | [INFO] [stderr] 330 | 2.989741148513006, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: consider: `2.989_741_148_513_006` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/primitive/capsule.rs:331:17 [INFO] [stderr] | [INFO] [stderr] 331 | 0.10102588514869944 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: consider: `0.101_025_885_148_699_44` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/primitive/cuboid.rs:271:25 [INFO] [stderr] | [INFO] [stderr] 271 | assert_ulps_eq!(5.233758, p.x); [INFO] [stderr] | ^^^^^^^^ help: consider: `5.233_758` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/primitive/particle.rs:206:26 [INFO] [stderr] | [INFO] [stderr] 206 | Point2::new(-2.8284271247461903, -2.8284271247461903), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider: `2.828_427_124_746_190_3` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/primitive/particle.rs:206:47 [INFO] [stderr] | [INFO] [stderr] 206 | Point2::new(-2.8284271247461903, -2.8284271247461903), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider: `2.828_427_124_746_190_3` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/primitive/particle.rs:225:26 [INFO] [stderr] | [INFO] [stderr] 225 | Point2::new(-2.8284271247461903, -2.8284271247461903), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider: `2.828_427_124_746_190_3` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/primitive/particle.rs:225:47 [INFO] [stderr] | [INFO] [stderr] 225 | Point2::new(-2.8284271247461903, -2.8284271247461903), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider: `2.828_427_124_746_190_3` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/primitive/polygon.rs:409:25 [INFO] [stderr] | [INFO] [stderr] 409 | assert_ulps_eq!(0.38913357, p.x); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0.389_133_57` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/primitive/polyhedron.rs:690:25 [INFO] [stderr] | [INFO] [stderr] 690 | assert_ulps_eq!(0.25000018, p.x); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0.250_000_18` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/primitive/polyhedron.rs:691:25 [INFO] [stderr] | [INFO] [stderr] 691 | assert_ulps_eq!(0.4999997, p.y); [INFO] [stderr] | ^^^^^^^^^ help: consider: `0.499_999_7` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/primitive/polyhedron.rs:692:25 [INFO] [stderr] | [INFO] [stderr] 692 | assert_ulps_eq!(0.25000018, p.z); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0.250_000_18` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/primitive/polyhedron.rs:712:25 [INFO] [stderr] | [INFO] [stderr] 712 | assert_ulps_eq!(0.25000018, p.x); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0.250_000_18` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/primitive/polyhedron.rs:713:25 [INFO] [stderr] | [INFO] [stderr] 713 | assert_ulps_eq!(0.4999997, p.y); [INFO] [stderr] | ^^^^^^^^^ help: consider: `0.499_999_7` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/primitive/polyhedron.rs:714:25 [INFO] [stderr] | [INFO] [stderr] 714 | assert_ulps_eq!(0.25000018, p.z); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0.250_000_18` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/primitive/polyhedron.rs:720:25 [INFO] [stderr] | [INFO] [stderr] 720 | assert_ulps_eq!(0.25000018, p.x); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0.250_000_18` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/primitive/polyhedron.rs:721:25 [INFO] [stderr] | [INFO] [stderr] 721 | assert_ulps_eq!(1.4999997, p.y); [INFO] [stderr] | ^^^^^^^^^ help: consider: `1.499_999_7` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/primitive/polyhedron.rs:722:25 [INFO] [stderr] | [INFO] [stderr] 722 | assert_ulps_eq!(0.25000018, p.z); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0.250_000_18` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/primitive/polyhedron.rs:726:25 [INFO] [stderr] | [INFO] [stderr] 726 | assert_ulps_eq!(0.4677162, p.y); [INFO] [stderr] | ^^^^^^^^^ help: consider: `0.467_716_2` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/primitive/rectangle.rs:240:25 [INFO] [stderr] | [INFO] [stderr] 240 | assert_ulps_eq!(5.233758, p.x); [INFO] [stderr] | ^^^^^^^^ help: consider: `5.233_758` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/primitive/sphere.rs:120:13 [INFO] [stderr] | [INFO] [stderr] 120 | 5.773502691896258, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: consider: `5.773_502_691_896_258` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/primitive/sphere.rs:121:13 [INFO] [stderr] | [INFO] [stderr] 121 | 5.773502691896258, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: consider: `5.773_502_691_896_258` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/primitive/sphere.rs:122:13 [INFO] [stderr] | [INFO] [stderr] 122 | 5.773502691896258, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: consider: `5.773_502_691_896_258` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/primitive/sphere.rs:134:13 [INFO] [stderr] | [INFO] [stderr] 134 | 0.0000009536743, [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: consider: `0.000_000_953_674_3` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/algorithm/minkowski/epa/epa2d.rs:186:25 [INFO] [stderr] | [INFO] [stderr] 186 | assert_ulps_eq!(2.5607374, edge.distance); [INFO] [stderr] | ^^^^^^^^^ help: consider: `2.560_737_4` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/algorithm/minkowski/epa/epa2d.rs:187:26 [INFO] [stderr] | [INFO] [stderr] 187 | assert_ulps_eq!(-0.6401844, edge.normal.x); [INFO] [stderr] | ^^^^^^^^^ help: consider: `0.640_184_4` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/algorithm/minkowski/epa/epa2d.rs:188:26 [INFO] [stderr] | [INFO] [stderr] 188 | assert_ulps_eq!(-0.7682213, edge.normal.y); [INFO] [stderr] | ^^^^^^^^^ help: consider: `0.768_221_3` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/algorithm/minkowski/epa/epa3d.rs:259:14 [INFO] [stderr] | [INFO] [stderr] 259 | -0.8728715, [INFO] [stderr] | ^^^^^^^^^ help: consider: `0.872_871_5` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/algorithm/minkowski/epa/epa3d.rs:260:13 [INFO] [stderr] | [INFO] [stderr] 260 | 0.43643576, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0.436_435_76` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/algorithm/minkowski/epa/epa3d.rs:261:13 [INFO] [stderr] | [INFO] [stderr] 261 | 0.21821788, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0.218_217_88` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/algorithm/minkowski/epa/epa3d.rs:262:13 [INFO] [stderr] | [INFO] [stderr] 262 | 1.0910894, [INFO] [stderr] | ^^^^^^^^^ help: consider: `1.091_089_4` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/algorithm/minkowski/epa/epa3d.rs:264:46 [INFO] [stderr] | [INFO] [stderr] 264 | assert_face(&faces[1], 3, 1, 0, 0., -0.89442724, 0.44721362, 2.236068); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0.894_427_24` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/algorithm/minkowski/epa/epa3d.rs:264:58 [INFO] [stderr] | [INFO] [stderr] 264 | assert_face(&faces[1], 3, 1, 0, 0., -0.89442724, 0.44721362, 2.236068); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0.447_213_62` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/algorithm/minkowski/epa/epa3d.rs:264:70 [INFO] [stderr] | [INFO] [stderr] 264 | assert_face(&faces[1], 3, 1, 0, 0., -0.89442724, 0.44721362, 2.236068); [INFO] [stderr] | ^^^^^^^^ help: consider: `2.236_068` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/algorithm/minkowski/epa/epa3d.rs:270:13 [INFO] [stderr] | [INFO] [stderr] 270 | 0.8728715, [INFO] [stderr] | ^^^^^^^^^ help: consider: `0.872_871_5` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/algorithm/minkowski/epa/epa3d.rs:271:13 [INFO] [stderr] | [INFO] [stderr] 271 | 0.43643576, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0.436_435_76` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/algorithm/minkowski/epa/epa3d.rs:272:13 [INFO] [stderr] | [INFO] [stderr] 272 | 0.21821788, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0.218_217_88` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/algorithm/minkowski/epa/epa3d.rs:273:13 [INFO] [stderr] | [INFO] [stderr] 273 | 1.0910894, [INFO] [stderr] | ^^^^^^^^^ help: consider: `1.091_089_4` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: unused import: `smallvec::SmallVec` [INFO] [stderr] --> src/algorithm/minkowski/gjk/simplex/simplex2d.rs:100:9 [INFO] [stderr] | [INFO] [stderr] 100 | use smallvec::SmallVec; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused import: `smallvec::SmallVec` [INFO] [stderr] --> src/algorithm/minkowski/gjk/simplex/simplex3d.rs:228:9 [INFO] [stderr] | [INFO] [stderr] 228 | use smallvec::SmallVec; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/algorithm/minkowski/gjk/mod.rs:21:37 [INFO] [stderr] | [INFO] [stderr] 21 | const GJK_DISTANCE_TOLERANCE: f32 = 0.000001; [INFO] [stderr] | ^^^^^^^^ help: consider: `0.000_001` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/algorithm/minkowski/gjk/mod.rs:22:39 [INFO] [stderr] | [INFO] [stderr] 22 | const GJK_CONTINUOUS_TOLERANCE: f32 = 0.000001; [INFO] [stderr] | ^^^^^^^^ help: consider: `0.000_001` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/algorithm/minkowski/gjk/mod.rs:769:25 [INFO] [stderr] | [INFO] [stderr] 769 | assert_ulps_eq!(0.1666667, contact.time_of_impact); [INFO] [stderr] | ^^^^^^^^^ help: consider: `0.166_666_7` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/algorithm/minkowski/gjk/mod.rs:798:25 [INFO] [stderr] | [INFO] [stderr] 798 | assert_ulps_eq!(0.1666667, contact.time_of_impact); [INFO] [stderr] | ^^^^^^^^^ help: consider: `0.166_666_7` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `primitive::particle::Particle
`
[INFO] [stderr] --> src/primitive/particle.rs:27:5
[INFO] [stderr] |
[INFO] [stderr] 27 | / pub fn new() -> Self {
[INFO] [stderr] 28 | | Self {
[INFO] [stderr] 29 | | m: marker::PhantomData,
[INFO] [stderr] 30 | | }
[INFO] [stderr] 31 | | }
[INFO] [stderr] | |_____^
[INFO] [stderr] |
[INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default
[INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive
[INFO] [stderr] help: try this
[INFO] [stderr] |
[INFO] [stderr] 21 | #[derive(Default)]
[INFO] [stderr] |
[INFO] [stderr]
[INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression
[INFO] [stderr] --> src/primitive/polygon.rs:144:9
[INFO] [stderr] |
[INFO] [stderr] 144 | / let mut previous_dot = left_dot;
[INFO] [stderr] 145 | | if left_dot > max_dot && left_dot > right_dot {
[INFO] [stderr] 146 | | add = -1;
[INFO] [stderr] 147 | | previous_dot = right_dot;
[INFO] [stderr] 148 | | }
[INFO] [stderr] | |_________^ help: it is more idiomatic to write: `let `
[INFO] [stderr] --> src/algorithm/minkowski/mod.rs:30:5
[INFO] [stderr] |
[INFO] [stderr] 30 | / pub fn new() -> Self {
[INFO] [stderr] 31 | | Self {
[INFO] [stderr] 32 | | v: P::Diff::zero(),
[INFO] [stderr] 33 | | sup_a: P::origin(),
[INFO] [stderr] 34 | | sup_b: P::origin(),
[INFO] [stderr] 35 | | }
[INFO] [stderr] 36 | | }
[INFO] [stderr] | |_____^
[INFO] [stderr] |
[INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default
[INFO] [stderr] help: try this
[INFO] [stderr] |
[INFO] [stderr] 25 | impl Default for algorithm::minkowski::SupportPoint {
[INFO] [stderr] 26 | fn default() -> Self {
[INFO] [stderr] 27 | Self::new()
[INFO] [stderr] 28 | }
[INFO] [stderr] 29 | }
[INFO] [stderr] |
[INFO] [stderr]
[INFO] [stderr] warning: the loop variable `right_index` is used to index `shapes`
[INFO] [stderr] --> src/algorithm/broad_phase/brute_force.rs:32:32
[INFO] [stderr] |
[INFO] [stderr] 32 | for right_index in (left_index + 1)..shapes.len() {
[INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] |
[INFO] [stderr] = note: #[warn(clippy::needless_range_loop)] on by default
[INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop
[INFO] [stderr] help: consider using an iterator
[INFO] [stderr] |
[INFO] [stderr] 32 | for (right_index, `
[INFO] [stderr] --> src/primitive/particle.rs:27:5
[INFO] [stderr] |
[INFO] [stderr] 27 | / pub fn new() -> Self {
[INFO] [stderr] 28 | | Self {
[INFO] [stderr] 29 | | m: marker::PhantomData,
[INFO] [stderr] 30 | | }
[INFO] [stderr] 31 | | }
[INFO] [stderr] | |_____^
[INFO] [stderr] |
[INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default
[INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive
[INFO] [stderr] help: try this
[INFO] [stderr] |
[INFO] [stderr] 21 | #[derive(Default)]
[INFO] [stderr] |
[INFO] [stderr]
[INFO] [stderr] warning: float has excessive precision
[INFO] [stderr] --> src/primitive/particle.rs:225:26
[INFO] [stderr] |
[INFO] [stderr] 225 | Point2::new(-2.8284271247461903, -2.8284271247461903),
[INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider changing the type or truncating it to: `2.828_427`
[INFO] [stderr] |
[INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#excessive_precision
[INFO] [stderr]
[INFO] [stderr] warning: float has excessive precision
[INFO] [stderr] --> src/primitive/particle.rs:225:47
[INFO] [stderr] |
[INFO] [stderr] 225 | Point2::new(-2.8284271247461903, -2.8284271247461903),
[INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider changing the type or truncating it to: `2.828_427`
[INFO] [stderr] |
[INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#excessive_precision
[INFO] [stderr]
[INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression
[INFO] [stderr] --> src/primitive/polygon.rs:144:9
[INFO] [stderr] |
[INFO] [stderr] 144 | / let mut previous_dot = left_dot;
[INFO] [stderr] 145 | | if left_dot > max_dot && left_dot > right_dot {
[INFO] [stderr] 146 | | add = -1;
[INFO] [stderr] 147 | | previous_dot = right_dot;
[INFO] [stderr] 148 | | }
[INFO] [stderr] | |_________^ help: it is more idiomatic to write: `let `
[INFO] [stderr] --> src/algorithm/minkowski/mod.rs:30:5
[INFO] [stderr] |
[INFO] [stderr] 30 | / pub fn new() -> Self {
[INFO] [stderr] 31 | | Self {
[INFO] [stderr] 32 | | v: P::Diff::zero(),
[INFO] [stderr] 33 | | sup_a: P::origin(),
[INFO] [stderr] 34 | | sup_b: P::origin(),
[INFO] [stderr] 35 | | }
[INFO] [stderr] 36 | | }
[INFO] [stderr] | |_____^
[INFO] [stderr] |
[INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default
[INFO] [stderr] help: try this
[INFO] [stderr] |
[INFO] [stderr] 25 | impl Default for algorithm::minkowski::SupportPoint {
[INFO] [stderr] 26 | fn default() -> Self {
[INFO] [stderr] 27 | Self::new()
[INFO] [stderr] 28 | }
[INFO] [stderr] 29 | }
[INFO] [stderr] |
[INFO] [stderr]
[INFO] [stderr] warning: the loop variable `right_index` is used to index `shapes`
[INFO] [stderr] --> src/algorithm/broad_phase/brute_force.rs:32:32
[INFO] [stderr] |
[INFO] [stderr] 32 | for right_index in (left_index + 1)..shapes.len() {
[INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] |
[INFO] [stderr] = note: #[warn(clippy::needless_range_loop)] on by default
[INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop
[INFO] [stderr] help: consider using an iterator
[INFO] [stderr] |
[INFO] [stderr] 32 | for (right_index, (
[INFO] [stderr] 180 | | abc: &Vector3,
[INFO] [stderr] 181 | | ab: &Vector3,
[INFO] [stderr] 182 | | ac: &Vector3,
[INFO] [stderr] ... |
[INFO] [stderr] 220 | | }
[INFO] [stderr] 221 | | }
[INFO] [stderr] | |_^
[INFO] [stderr] |
[INFO] [stderr] = note: #[warn(clippy::too_many_arguments)] on by default
[INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments
[INFO] [stderr]
[INFO] [stderr] error: this `if` has identical blocks
[INFO] [stderr] --> src/algorithm/minkowski/gjk/simplex/simplex3d.rs:212:40
[INFO] [stderr] |
[INFO] [stderr] 212 | } else if abc.dot(*ao) > S::zero() {
[INFO] [stderr] | ________________________________________^
[INFO] [stderr] 213 | | // [c, b, a]
[INFO] [stderr] 214 | | *v = *abc;
[INFO] [stderr] 215 | | // origin below triangle, rewind simplex and set v = surface normal towards origin
[INFO] [stderr] 216 | | } else {
[INFO] [stderr] | |_____^
[INFO] [stderr] |
[INFO] [stderr] = note: #[deny(clippy::if_same_then_else)] on by default
[INFO] [stderr] note: same as this
[INFO] [stderr] --> src/algorithm/minkowski/gjk/simplex/simplex3d.rs:210:14
[INFO] [stderr] |
[INFO] [stderr] 210 | if above {
[INFO] [stderr] | ______________^
[INFO] [stderr] 211 | | *v = *abc;
[INFO] [stderr] 212 | | } else if abc.dot(*ao) > S::zero() {
[INFO] [stderr] | |_____^
[INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#if_same_then_else
[INFO] [stderr]
[INFO] [stderr] warning: you should consider adding a `Default` implementation for `algorithm::minkowski::gjk::GJK(
[INFO] [stderr] 180 | | abc: &Vector3,
[INFO] [stderr] 181 | | ab: &Vector3,
[INFO] [stderr] 182 | | ac: &Vector3,
[INFO] [stderr] ... |
[INFO] [stderr] 220 | | }
[INFO] [stderr] 221 | | }
[INFO] [stderr] | |_^
[INFO] [stderr] |
[INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments
[INFO] [stderr]
[INFO] [stderr] error: this `if` has identical blocks
[INFO] [stderr] --> src/algorithm/minkowski/gjk/simplex/simplex3d.rs:212:40
[INFO] [stderr] |
[INFO] [stderr] 212 | } else if abc.dot(*ao) > S::zero() {
[INFO] [stderr] | ________________________________________^
[INFO] [stderr] 213 | | // [c, b, a]
[INFO] [stderr] 214 | | *v = *abc;
[INFO] [stderr] 215 | | // origin below triangle, rewind simplex and set v = surface normal towards origin
[INFO] [stderr] 216 | | } else {
[INFO] [stderr] | |_____^
[INFO] [stderr] |
[INFO] [stderr] = note: #[deny(clippy::if_same_then_else)] on by default
[INFO] [stderr] note: same as this
[INFO] [stderr] --> src/algorithm/minkowski/gjk/simplex/simplex3d.rs:210:14
[INFO] [stderr] |
[INFO] [stderr] 210 | if above {
[INFO] [stderr] | ______________^
[INFO] [stderr] 211 | | *v = *abc;
[INFO] [stderr] 212 | | } else if abc.dot(*ao) > S::zero() {
[INFO] [stderr] | |_____^
[INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#if_same_then_else
[INFO] [stderr]
[INFO] [stderr] warning: you should consider adding a `Default` implementation for `algorithm::minkowski::gjk::GJK