[INFO] crate codeviz_js 0.2.2 is already in cache
[INFO] extracting crate codeviz_js 0.2.2 into work/ex/clippy-test-run/sources/stable/reg/codeviz_js/0.2.2
[INFO] extracting crate codeviz_js 0.2.2 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/codeviz_js/0.2.2
[INFO] validating manifest of codeviz_js-0.2.2 on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of codeviz_js-0.2.2 on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing codeviz_js-0.2.2
[INFO] finished frobbing codeviz_js-0.2.2
[INFO] frobbed toml for codeviz_js-0.2.2 written to work/ex/clippy-test-run/sources/stable/reg/codeviz_js/0.2.2/Cargo.toml
[INFO] started frobbing codeviz_js-0.2.2
[INFO] finished frobbing codeviz_js-0.2.2
[INFO] frobbed toml for codeviz_js-0.2.2 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/codeviz_js/0.2.2/Cargo.toml
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting codeviz_js-0.2.2 against stable for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-7/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/codeviz_js/0.2.2:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] 4f53b010721ca934432f359b2a85ee676f418d4366622c08752b20ce1d48e9c3
[INFO] running `"docker" "start" "-a" "4f53b010721ca934432f359b2a85ee676f418d4366622c08752b20ce1d48e9c3"`
[INFO] [stderr]     Checking codeviz_common v0.2.2
[INFO] [stderr]     Checking codeviz_js v0.2.2 (/opt/crater/workdir)
[INFO] [stderr] warning: you should consider adding a `Default` implementation for `constructor_spec::ConstructorSpec`
[INFO] [stderr]   --> src/constructor_spec.rs:10:5
[INFO] [stderr]    |
[INFO] [stderr] 10 | /     pub fn new() -> ConstructorSpec {
[INFO] [stderr] 11 | |         ConstructorSpec {
[INFO] [stderr] 12 | |             arguments: Vec::new(),
[INFO] [stderr] 13 | |             elements: Elements::new(),
[INFO] [stderr] 14 | |         }
[INFO] [stderr] 15 | |     }
[INFO] [stderr]    | |_____^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::new_without_default)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default
[INFO] [stderr] help: try this
[INFO] [stderr]    |
[INFO] [stderr] 9  | impl Default for constructor_spec::ConstructorSpec {
[INFO] [stderr] 10 |     fn default() -> Self {
[INFO] [stderr] 11 |         Self::new()
[INFO] [stderr] 12 |     }
[INFO] [stderr] 13 | }
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: you should consider adding a `Default` implementation for `file_spec::FileSpec`
[INFO] [stderr]   --> src/file_spec.rs:13:5
[INFO] [stderr]    |
[INFO] [stderr] 13 | /     pub fn new() -> FileSpec {
[INFO] [stderr] 14 | |         FileSpec { elements: Elements::new() }
[INFO] [stderr] 15 | |     }
[INFO] [stderr]    | |_____^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default
[INFO] [stderr] help: try this
[INFO] [stderr]    |
[INFO] [stderr] 12 | impl Default for file_spec::FileSpec {
[INFO] [stderr] 13 |     fn default() -> Self {
[INFO] [stderr] 14 |         Self::new()
[INFO] [stderr] 15 |     }
[INFO] [stderr] 16 | }
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: single-character string constant used as pattern
[INFO] [stderr]   --> src/file_spec.rs:25:43
[INFO] [stderr]    |
[INFO] [stderr] 25 |         let parts: Vec<&str> = path.split(".").collect();
[INFO] [stderr]    |                                           ^^^ help: try using a char instead: `'.'`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::single_char_pattern)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: this let-binding has unit value. Consider omitting `let mut extra =`
[INFO] [stderr]    --> src/file_spec.rs:101:9
[INFO] [stderr]     |
[INFO] [stderr] 101 |         let mut extra = ();
[INFO] [stderr]     |         ^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::let_unit_value)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]  --> src/imports.rs:6:42
[INFO] [stderr]   |
[INFO] [stderr] 6 |     fn import_all<T>(&mut self, sources: &Vec<T>)
[INFO] [stderr]   |                                          ^^^^^^^ help: change this to: `&[T]`
[INFO] [stderr]   |
[INFO] [stderr]   = note: #[warn(clippy::ptr_arg)] on by default
[INFO] [stderr]   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let`
[INFO] [stderr]   --> src/imports.rs:28:9
[INFO] [stderr]    |
[INFO] [stderr] 28 | /         match *self {
[INFO] [stderr] 29 | |             Name::Imported(ref imported) => receiver.receive(imported),
[INFO] [stderr] 30 | |             _ => {}
[INFO] [stderr] 31 | |         };
[INFO] [stderr]    | |_________^ help: try this: `if let Name::Imported(ref imported) = *self { receiver.receive(imported) }`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::single_match)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match
[INFO] [stderr] 
[INFO] [stderr] warning: you should consider adding a `Default` implementation for `constructor_spec::ConstructorSpec`
[INFO] [stderr]   --> src/constructor_spec.rs:10:5
[INFO] [stderr]    |
[INFO] [stderr] 10 | /     pub fn new() -> ConstructorSpec {
[INFO] [stderr] 11 | |         ConstructorSpec {
[INFO] [stderr] 12 | |             arguments: Vec::new(),
[INFO] [stderr] 13 | |             elements: Elements::new(),
[INFO] [stderr] 14 | |         }
[INFO] [stderr] 15 | |     }
[INFO] [stderr]    | |_____^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::new_without_default)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default
[INFO] [stderr] help: try this
[INFO] [stderr]    |
[INFO] [stderr] 9  | impl Default for constructor_spec::ConstructorSpec {
[INFO] [stderr] 10 |     fn default() -> Self {
[INFO] [stderr] 11 |         Self::new()
[INFO] [stderr] 12 |     }
[INFO] [stderr] 13 | }
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: you should consider adding a `Default` implementation for `file_spec::FileSpec`
[INFO] [stderr]   --> src/file_spec.rs:13:5
[INFO] [stderr]    |
[INFO] [stderr] 13 | /     pub fn new() -> FileSpec {
[INFO] [stderr] 14 | |         FileSpec { elements: Elements::new() }
[INFO] [stderr] 15 | |     }
[INFO] [stderr]    | |_____^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default
[INFO] [stderr] help: try this
[INFO] [stderr]    |
[INFO] [stderr] 12 | impl Default for file_spec::FileSpec {
[INFO] [stderr] 13 |     fn default() -> Self {
[INFO] [stderr] 14 |         Self::new()
[INFO] [stderr] 15 |     }
[INFO] [stderr] 16 | }
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: single-character string constant used as pattern
[INFO] [stderr]   --> src/file_spec.rs:25:43
[INFO] [stderr]    |
[INFO] [stderr] 25 |         let parts: Vec<&str> = path.split(".").collect();
[INFO] [stderr]    |                                           ^^^ help: try using a char instead: `'.'`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::single_char_pattern)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: this let-binding has unit value. Consider omitting `let mut extra =`
[INFO] [stderr]    --> src/file_spec.rs:101:9
[INFO] [stderr]     |
[INFO] [stderr] 101 |         let mut extra = ();
[INFO] [stderr]     |         ^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::let_unit_value)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]  --> src/imports.rs:6:42
[INFO] [stderr]   |
[INFO] [stderr] 6 |     fn import_all<T>(&mut self, sources: &Vec<T>)
[INFO] [stderr]   |                                          ^^^^^^^ help: change this to: `&[T]`
[INFO] [stderr]   |
[INFO] [stderr]   = note: #[warn(clippy::ptr_arg)] on by default
[INFO] [stderr]   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let`
[INFO] [stderr]   --> src/imports.rs:28:9
[INFO] [stderr]    |
[INFO] [stderr] 28 | /         match *self {
[INFO] [stderr] 29 | |             Name::Imported(ref imported) => receiver.receive(imported),
[INFO] [stderr] 30 | |             _ => {}
[INFO] [stderr] 31 | |         };
[INFO] [stderr]    | |_________^ help: try this: `if let Name::Imported(ref imported) = *self { receiver.receive(imported) }`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::single_match)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match
[INFO] [stderr] 
[INFO] [stderr]     Finished dev [unoptimized + debuginfo] target(s) in 2.84s
[INFO] running `"docker" "inspect" "4f53b010721ca934432f359b2a85ee676f418d4366622c08752b20ce1d48e9c3"`
[INFO] running `"docker" "rm" "-f" "4f53b010721ca934432f359b2a85ee676f418d4366622c08752b20ce1d48e9c3"`
[INFO] [stdout] 4f53b010721ca934432f359b2a85ee676f418d4366622c08752b20ce1d48e9c3