[INFO] crate codeviz_java 0.2.2 is already in cache [INFO] extracting crate codeviz_java 0.2.2 into work/ex/clippy-test-run/sources/stable/reg/codeviz_java/0.2.2 [INFO] extracting crate codeviz_java 0.2.2 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/codeviz_java/0.2.2 [INFO] validating manifest of codeviz_java-0.2.2 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of codeviz_java-0.2.2 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing codeviz_java-0.2.2 [INFO] finished frobbing codeviz_java-0.2.2 [INFO] frobbed toml for codeviz_java-0.2.2 written to work/ex/clippy-test-run/sources/stable/reg/codeviz_java/0.2.2/Cargo.toml [INFO] started frobbing codeviz_java-0.2.2 [INFO] finished frobbing codeviz_java-0.2.2 [INFO] frobbed toml for codeviz_java-0.2.2 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/codeviz_java/0.2.2/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting codeviz_java-0.2.2 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-6/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/codeviz_java/0.2.2:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 5b694beb8e7445059b1f8cd16a80595573484f453a87c768b98aa932ec35bf76 [INFO] running `"docker" "start" "-a" "5b694beb8e7445059b1f8cd16a80595573484f453a87c768b98aa932ec35bf76"` [INFO] [stderr] Checking codeviz_java v0.2.2 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/_type.rs:17:13 [INFO] [stderr] | [INFO] [stderr] 17 | arguments: arguments, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `arguments` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/argument_spec.rs:17:13 [INFO] [stderr] | [INFO] [stderr] 17 | modifiers: modifiers, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `modifiers` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/class_spec.rs:18:13 [INFO] [stderr] | [INFO] [stderr] 18 | modifiers: modifiers, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `modifiers` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/constructor_spec.rs:15:13 [INFO] [stderr] | [INFO] [stderr] 15 | modifiers: modifiers, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `modifiers` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/enum_spec.rs:18:13 [INFO] [stderr] | [INFO] [stderr] 18 | modifiers: modifiers, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `modifiers` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/extra.rs:15:17 [INFO] [stderr] | [INFO] [stderr] 15 | Extra { locals: locals } [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `locals` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/field_spec.rs:18:13 [INFO] [stderr] | [INFO] [stderr] 18 | modifiers: modifiers, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `modifiers` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/interface_spec.rs:15:13 [INFO] [stderr] | [INFO] [stderr] 15 | modifiers: modifiers, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `modifiers` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/method_spec.rs:17:13 [INFO] [stderr] | [INFO] [stderr] 17 | modifiers: modifiers, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `modifiers` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/_type.rs:17:13 [INFO] [stderr] | [INFO] [stderr] 17 | arguments: arguments, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `arguments` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/argument_spec.rs:17:13 [INFO] [stderr] | [INFO] [stderr] 17 | modifiers: modifiers, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `modifiers` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/class_spec.rs:18:13 [INFO] [stderr] | [INFO] [stderr] 18 | modifiers: modifiers, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `modifiers` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/constructor_spec.rs:15:13 [INFO] [stderr] | [INFO] [stderr] 15 | modifiers: modifiers, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `modifiers` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/enum_spec.rs:18:13 [INFO] [stderr] | [INFO] [stderr] 18 | modifiers: modifiers, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `modifiers` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/extra.rs:15:17 [INFO] [stderr] | [INFO] [stderr] 15 | Extra { locals: locals } [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `locals` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/field_spec.rs:18:13 [INFO] [stderr] | [INFO] [stderr] 18 | modifiers: modifiers, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `modifiers` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/interface_spec.rs:15:13 [INFO] [stderr] | [INFO] [stderr] 15 | modifiers: modifiers, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `modifiers` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/method_spec.rs:17:13 [INFO] [stderr] | [INFO] [stderr] 17 | modifiers: modifiers, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `modifiers` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] error: this comparison involving the minimum or maximum element for this type contains a case that is always true or always false [INFO] [stderr] --> src/_type.rs:95:12 [INFO] [stderr] | [INFO] [stderr] 95 | if level <= 0 { [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::absurd_extreme_comparisons)] on by default [INFO] [stderr] = help: because 0 is the minimum value for this type, the case where the two sides are not equal never occurs, consider using level == 0 instead [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#absurd_extreme_comparisons [INFO] [stderr] [INFO] [stderr] warning: this loop could be written as a `for` loop [INFO] [stderr] --> src/common.rs:14:32 [INFO] [stderr] | [INFO] [stderr] 14 | while let Some(next) = it.next() { [INFO] [stderr] | ^^^^^^^^^ help: try: `for next in it { .. }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::while_let_on_iterator)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#while_let_on_iterator [INFO] [stderr] [INFO] [stderr] warning: this loop could be written as a `for` loop [INFO] [stderr] --> src/common.rs:39:28 [INFO] [stderr] | [INFO] [stderr] 39 | while let Some(next) = it.next() { [INFO] [stderr] | ^^^^^^^^^ help: try: `for next in it { .. }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#while_let_on_iterator [INFO] [stderr] [INFO] [stderr] warning: methods called `as_*` usually take self by reference or self by mutable reference; consider choosing a less ambiguous name [INFO] [stderr] --> src/constructor_spec.rs:51:23 [INFO] [stderr] | [INFO] [stderr] 51 | pub fn as_element(self, enclosing: &str) -> Element { [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::wrong_self_convention)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_some()` [INFO] [stderr] --> src/file_spec.rs:56:24 [INFO] [stderr] | [INFO] [stderr] 56 | if let Some(_) = locals.get(&t.name) { [INFO] [stderr] | _________________- ^^^^^^^ [INFO] [stderr] 57 | | continue; [INFO] [stderr] 58 | | } [INFO] [stderr] | |_________________- help: try this: `if locals.get(&t.name).is_some()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_pattern_matching)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/imports.rs:6:42 [INFO] [stderr] | [INFO] [stderr] 6 | fn import_all(&mut self, sources: &Vec) [INFO] [stderr] | ^^^^^^^ help: change this to: `&[T]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/imports.rs:93:9 [INFO] [stderr] | [INFO] [stderr] 93 | / match *self { [INFO] [stderr] 94 | | Type::Class(ref class) => class.imports(receiver), [INFO] [stderr] 95 | | _ => {} [INFO] [stderr] 96 | | }; [INFO] [stderr] | |_________^ help: try this: `if let Type::Class(ref class) = *self { class.imports(receiver) }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `modifier::Modifiers` [INFO] [stderr] --> src/modifier.rs:21:5 [INFO] [stderr] | [INFO] [stderr] 21 | / pub fn new() -> Modifiers { [INFO] [stderr] 22 | | Modifiers { modifiers: BTreeSet::new() } [INFO] [stderr] 23 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 16 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: Could not compile `codeviz_java`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] error: this comparison involving the minimum or maximum element for this type contains a case that is always true or always false [INFO] [stderr] --> src/_type.rs:95:12 [INFO] [stderr] | [INFO] [stderr] 95 | if level <= 0 { [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::absurd_extreme_comparisons)] on by default [INFO] [stderr] = help: because 0 is the minimum value for this type, the case where the two sides are not equal never occurs, consider using level == 0 instead [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#absurd_extreme_comparisons [INFO] [stderr] [INFO] [stderr] warning: this loop could be written as a `for` loop [INFO] [stderr] --> src/common.rs:14:32 [INFO] [stderr] | [INFO] [stderr] 14 | while let Some(next) = it.next() { [INFO] [stderr] | ^^^^^^^^^ help: try: `for next in it { .. }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::while_let_on_iterator)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#while_let_on_iterator [INFO] [stderr] [INFO] [stderr] warning: this loop could be written as a `for` loop [INFO] [stderr] --> src/common.rs:39:28 [INFO] [stderr] | [INFO] [stderr] 39 | while let Some(next) = it.next() { [INFO] [stderr] | ^^^^^^^^^ help: try: `for next in it { .. }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#while_let_on_iterator [INFO] [stderr] [INFO] [stderr] warning: methods called `as_*` usually take self by reference or self by mutable reference; consider choosing a less ambiguous name [INFO] [stderr] --> src/constructor_spec.rs:51:23 [INFO] [stderr] | [INFO] [stderr] 51 | pub fn as_element(self, enclosing: &str) -> Element { [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::wrong_self_convention)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_some()` [INFO] [stderr] --> src/file_spec.rs:56:24 [INFO] [stderr] | [INFO] [stderr] 56 | if let Some(_) = locals.get(&t.name) { [INFO] [stderr] | _________________- ^^^^^^^ [INFO] [stderr] 57 | | continue; [INFO] [stderr] 58 | | } [INFO] [stderr] | |_________________- help: try this: `if locals.get(&t.name).is_some()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_pattern_matching)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/imports.rs:6:42 [INFO] [stderr] | [INFO] [stderr] 6 | fn import_all(&mut self, sources: &Vec) [INFO] [stderr] | ^^^^^^^ help: change this to: `&[T]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/imports.rs:93:9 [INFO] [stderr] | [INFO] [stderr] 93 | / match *self { [INFO] [stderr] 94 | | Type::Class(ref class) => class.imports(receiver), [INFO] [stderr] 95 | | _ => {} [INFO] [stderr] 96 | | }; [INFO] [stderr] | |_________^ help: try this: `if let Type::Class(ref class) = *self { class.imports(receiver) }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `modifier::Modifiers` [INFO] [stderr] --> src/modifier.rs:21:5 [INFO] [stderr] | [INFO] [stderr] 21 | / pub fn new() -> Modifiers { [INFO] [stderr] 22 | | Modifiers { modifiers: BTreeSet::new() } [INFO] [stderr] 23 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 16 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: Could not compile `codeviz_java`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "5b694beb8e7445059b1f8cd16a80595573484f453a87c768b98aa932ec35bf76"` [INFO] running `"docker" "rm" "-f" "5b694beb8e7445059b1f8cd16a80595573484f453a87c768b98aa932ec35bf76"` [INFO] [stdout] 5b694beb8e7445059b1f8cd16a80595573484f453a87c768b98aa932ec35bf76