[INFO] crate codeviz_common 0.2.2 is already in cache [INFO] extracting crate codeviz_common 0.2.2 into work/ex/clippy-test-run/sources/stable/reg/codeviz_common/0.2.2 [INFO] extracting crate codeviz_common 0.2.2 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/codeviz_common/0.2.2 [INFO] validating manifest of codeviz_common-0.2.2 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of codeviz_common-0.2.2 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing codeviz_common-0.2.2 [INFO] finished frobbing codeviz_common-0.2.2 [INFO] frobbed toml for codeviz_common-0.2.2 written to work/ex/clippy-test-run/sources/stable/reg/codeviz_common/0.2.2/Cargo.toml [INFO] started frobbing codeviz_common-0.2.2 [INFO] finished frobbing codeviz_common-0.2.2 [INFO] frobbed toml for codeviz_common-0.2.2 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/codeviz_common/0.2.2/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting codeviz_common-0.2.2 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-3/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/codeviz_common/0.2.2:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] af4314afc1477b7f22bf8bf940b6a115efbcf165850ebbf52f2efd3e01ff0698 [INFO] running `"docker" "start" "-a" "af4314afc1477b7f22bf8bf940b6a115efbcf165850ebbf52f2efd3e01ff0698"` [INFO] [stderr] Checking codeviz_common v0.2.2 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/element_formatter.rs:24:13 [INFO] [stderr] | [INFO] [stderr] 24 | write: write, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `write` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/statement.rs:46:21 [INFO] [stderr] | [INFO] [stderr] 46 | Statement { parts: parts } [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `parts` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/element_formatter.rs:24:13 [INFO] [stderr] | [INFO] [stderr] 24 | write: write, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `write` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/statement.rs:46:21 [INFO] [stderr] | [INFO] [stderr] 46 | Statement { parts: parts } [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `parts` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `elements::Elements` [INFO] [stderr] --> src/elements.rs:15:5 [INFO] [stderr] | [INFO] [stderr] 15 | / pub fn new() -> Elements { [INFO] [stderr] 16 | | Elements { elements: Vec::new() } [INFO] [stderr] 17 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 4 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this loop could be written as a `for` loop [INFO] [stderr] --> src/elements.rs:55:32 [INFO] [stderr] | [INFO] [stderr] 55 | while let Some(part) = it.next() { [INFO] [stderr] | ^^^^^^^^^ help: try: `for part in it { .. }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::while_let_on_iterator)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#while_let_on_iterator [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `statement::Statement` [INFO] [stderr] --> src/statement.rs:16:5 [INFO] [stderr] | [INFO] [stderr] 16 | / pub fn new() -> Statement { [INFO] [stderr] 17 | | Statement { parts: Vec::new() } [INFO] [stderr] 18 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 5 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this loop could be written as a `for` loop [INFO] [stderr] --> src/statement.rs:41:32 [INFO] [stderr] | [INFO] [stderr] 41 | while let Some(part) = it.next() { [INFO] [stderr] | ^^^^^^^^^ help: try: `for part in it { .. }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#while_let_on_iterator [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `elements::Elements` [INFO] [stderr] --> src/elements.rs:15:5 [INFO] [stderr] | [INFO] [stderr] 15 | / pub fn new() -> Elements { [INFO] [stderr] 16 | | Elements { elements: Vec::new() } [INFO] [stderr] 17 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 4 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this loop could be written as a `for` loop [INFO] [stderr] --> src/elements.rs:55:32 [INFO] [stderr] | [INFO] [stderr] 55 | while let Some(part) = it.next() { [INFO] [stderr] | ^^^^^^^^^ help: try: `for part in it { .. }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::while_let_on_iterator)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#while_let_on_iterator [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `statement::Statement` [INFO] [stderr] --> src/statement.rs:16:5 [INFO] [stderr] | [INFO] [stderr] 16 | / pub fn new() -> Statement { [INFO] [stderr] 17 | | Statement { parts: Vec::new() } [INFO] [stderr] 18 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 5 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this loop could be written as a `for` loop [INFO] [stderr] --> src/statement.rs:41:32 [INFO] [stderr] | [INFO] [stderr] 41 | while let Some(part) = it.next() { [INFO] [stderr] | ^^^^^^^^^ help: try: `for part in it { .. }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#while_let_on_iterator [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 1.48s [INFO] running `"docker" "inspect" "af4314afc1477b7f22bf8bf940b6a115efbcf165850ebbf52f2efd3e01ff0698"` [INFO] running `"docker" "rm" "-f" "af4314afc1477b7f22bf8bf940b6a115efbcf165850ebbf52f2efd3e01ff0698"` [INFO] [stdout] af4314afc1477b7f22bf8bf940b6a115efbcf165850ebbf52f2efd3e01ff0698