[INFO] crate codepage-437 0.1.0 is already in cache [INFO] extracting crate codepage-437 0.1.0 into work/ex/clippy-test-run/sources/stable/reg/codepage-437/0.1.0 [INFO] extracting crate codepage-437 0.1.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/codepage-437/0.1.0 [INFO] validating manifest of codepage-437-0.1.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of codepage-437-0.1.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing codepage-437-0.1.0 [INFO] finished frobbing codepage-437-0.1.0 [INFO] frobbed toml for codepage-437-0.1.0 written to work/ex/clippy-test-run/sources/stable/reg/codepage-437/0.1.0/Cargo.toml [INFO] started frobbing codepage-437-0.1.0 [INFO] finished frobbing codepage-437-0.1.0 [INFO] frobbed toml for codepage-437-0.1.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/codepage-437/0.1.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting codepage-437-0.1.0 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-5/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/codepage-437/0.1.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] d95704f18569af2a8a3db2b0e23c795a1f11791c840a98a0ae25f4b3d0d154b8 [INFO] running `"docker" "start" "-a" "d95704f18569af2a8a3db2b0e23c795a1f11791c840a98a0ae25f4b3d0d154b8"` [INFO] [stderr] Compiling memchr v2.1.3 [INFO] [stderr] Compiling csv-core v0.1.5 [INFO] [stderr] Compiling csv v1.0.5 [INFO] [stderr] Compiling codepage-437 v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: this boolean expression can be simplified [INFO] [stderr] --> src/dialect.rs:26:9 [INFO] [stderr] | [INFO] [stderr] 26 | (self.overlap_unicode)(unicode) && !self.remaps.iter().rev().find(|&&(_, _, to)| to == unicode).is_some() [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `(self.overlap_unicode)(unicode) && self.remaps.iter().rev().find(|&&(_, _, to)| to == unicode).is_none()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::nonminimal_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stderr] [INFO] [stderr] warning: called `is_some()` after searching an `Iterator` with find. This is more succinctly expressed by calling `any()`. [INFO] [stderr] --> src/dialect.rs:26:45 [INFO] [stderr] | [INFO] [stderr] 26 | (self.overlap_unicode)(unicode) && !self.remaps.iter().rev().find(|&&(_, _, to)| to == unicode).is_some() [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::search_is_some)] on by default [INFO] [stderr] = note: replace `find(|&&(_, _, to)| to == unicode).is_some()` with `any(|&&(_, _, to)| to == unicode)` [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#search_is_some [INFO] [stderr] [INFO] [stderr] warning: this boolean expression can be simplified [INFO] [stderr] --> src/dialect.rs:32:9 [INFO] [stderr] | [INFO] [stderr] 32 | (self.overlap_cp437)(cp437) && !self.remaps.iter().rev().find(|&&(whom, _, _)| whom == cp437).is_some() [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `(self.overlap_cp437)(cp437) && self.remaps.iter().rev().find(|&&(whom, _, _)| whom == cp437).is_none()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stderr] [INFO] [stderr] warning: called `is_some()` after searching an `Iterator` with find. This is more succinctly expressed by calling `any()`. [INFO] [stderr] --> src/dialect.rs:32:41 [INFO] [stderr] | [INFO] [stderr] 32 | (self.overlap_cp437)(cp437) && !self.remaps.iter().rev().find(|&&(whom, _, _)| whom == cp437).is_some() [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: replace `find(|&&(whom, _, _)| whom == cp437).is_some()` with `any(|&&(whom, _, _)| whom == cp437)` [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#search_is_some [INFO] [stderr] [INFO] [stderr] warning: this boolean expression can be simplified [INFO] [stderr] --> src/dialect.rs:26:9 [INFO] [stderr] | [INFO] [stderr] 26 | (self.overlap_unicode)(unicode) && !self.remaps.iter().rev().find(|&&(_, _, to)| to == unicode).is_some() [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `(self.overlap_unicode)(unicode) && self.remaps.iter().rev().find(|&&(_, _, to)| to == unicode).is_none()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::nonminimal_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stderr] [INFO] [stderr] warning: called `is_some()` after searching an `Iterator` with find. This is more succinctly expressed by calling `any()`. [INFO] [stderr] --> src/dialect.rs:26:45 [INFO] [stderr] | [INFO] [stderr] 26 | (self.overlap_unicode)(unicode) && !self.remaps.iter().rev().find(|&&(_, _, to)| to == unicode).is_some() [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::search_is_some)] on by default [INFO] [stderr] = note: replace `find(|&&(_, _, to)| to == unicode).is_some()` with `any(|&&(_, _, to)| to == unicode)` [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#search_is_some [INFO] [stderr] [INFO] [stderr] warning: this boolean expression can be simplified [INFO] [stderr] --> src/dialect.rs:32:9 [INFO] [stderr] | [INFO] [stderr] 32 | (self.overlap_cp437)(cp437) && !self.remaps.iter().rev().find(|&&(whom, _, _)| whom == cp437).is_some() [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `(self.overlap_cp437)(cp437) && self.remaps.iter().rev().find(|&&(whom, _, _)| whom == cp437).is_none()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stderr] [INFO] [stderr] warning: called `is_some()` after searching an `Iterator` with find. This is more succinctly expressed by calling `any()`. [INFO] [stderr] --> src/dialect.rs:32:41 [INFO] [stderr] | [INFO] [stderr] 32 | (self.overlap_cp437)(cp437) && !self.remaps.iter().rev().find(|&&(whom, _, _)| whom == cp437).is_some() [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: replace `find(|&&(whom, _, _)| whom == cp437).is_some()` with `any(|&&(whom, _, _)| whom == cp437)` [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#search_is_some [INFO] [stderr] [INFO] [stderr] warning: module has the same name as its containing module [INFO] [stderr] --> tests/cp437_wingdings/encode/mod.rs:3:1 [INFO] [stderr] | [INFO] [stderr] 3 | mod encode; [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::module_inception)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#module_inception [INFO] [stderr] [INFO] [stderr] warning: module has the same name as its containing module [INFO] [stderr] --> tests/cp437_control/encode/mod.rs:3:1 [INFO] [stderr] | [INFO] [stderr] 3 | mod encode; [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#module_inception [INFO] [stderr] [INFO] [stderr] error: this .into_iter() call is equivalent to .iter() and will not move the array [INFO] [stderr] --> tests/cp437_wingdings/encode/to_cp437/borrowing.rs:12:34 [INFO] [stderr] | [INFO] [stderr] 12 | assert!(is_borrowed(&[c].into_iter().collect::().to_cp437(&CP437_WINGDINGS).unwrap())); [INFO] [stderr] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::into_iter_on_array)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_array [INFO] [stderr] [INFO] [stderr] error: this .into_iter() call is equivalent to .iter() and will not move the array [INFO] [stderr] --> tests/cp437_wingdings/encode/to_cp437/borrowing.rs:23:35 [INFO] [stderr] | [INFO] [stderr] 23 | assert!(!is_borrowed(&[c].into_iter().collect::().to_cp437(&CP437_WINGDINGS).unwrap())); [INFO] [stderr] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_array [INFO] [stderr] [INFO] [stderr] error: this .into_iter() call is equivalent to .iter() and will not move the array [INFO] [stderr] --> tests/cp437_wingdings/encode/to_cp437/borrowing.rs:42:47 [INFO] [stderr] | [INFO] [stderr] 42 | assert!(!is_borrowed(&[c, new_beyond].into_iter().collect::().to_cp437(&CP437_WINGDINGS).unwrap())); [INFO] [stderr] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_array [INFO] [stderr] [INFO] [stderr] warning: using a reference to `Cow` is not recommended. [INFO] [stderr] --> tests/cp437_wingdings/mod.rs:13:42 [INFO] [stderr] | [INFO] [stderr] 13 | fn is_borrowed(who: &Cow) -> bool { [INFO] [stderr] | ^^^^^^^ help: change this to: `&T` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> tests/cp437_wingdings/mod.rs:14:5 [INFO] [stderr] | [INFO] [stderr] 14 | / match who { [INFO] [stderr] 15 | | &Cow::Borrowed(_) => true, [INFO] [stderr] 16 | | &Cow::Owned(_) => false, [INFO] [stderr] 17 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 14 | match *who { [INFO] [stderr] 15 | Cow::Borrowed(_) => true, [INFO] [stderr] 16 | Cow::Owned(_) => false, [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] error: this .into_iter() call is equivalent to .iter() and will not move the array [INFO] [stderr] --> tests/cp437_control/encode/to_cp437/borrowing.rs:12:34 [INFO] [stderr] | [INFO] [stderr] 12 | assert!(is_borrowed(&[c].into_iter().collect::().to_cp437(&CP437_CONTROL).unwrap())); [INFO] [stderr] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_array [INFO] [stderr] [INFO] [stderr] error: this .into_iter() call is equivalent to .iter() and will not move the array [INFO] [stderr] --> tests/cp437_control/encode/to_cp437/borrowing.rs:23:35 [INFO] [stderr] | [INFO] [stderr] 23 | assert!(!is_borrowed(&[c].into_iter().collect::().to_cp437(&CP437_CONTROL).unwrap())); [INFO] [stderr] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_array [INFO] [stderr] [INFO] [stderr] error: this .into_iter() call is equivalent to .iter() and will not move the array [INFO] [stderr] --> tests/cp437_control/encode/to_cp437/borrowing.rs:42:47 [INFO] [stderr] | [INFO] [stderr] 42 | assert!(!is_borrowed(&[c, new_beyond].into_iter().collect::().to_cp437(&CP437_CONTROL).unwrap())); [INFO] [stderr] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_array [INFO] [stderr] [INFO] [stderr] warning: using a reference to `Cow` is not recommended. [INFO] [stderr] --> tests/cp437_control/mod.rs:13:42 [INFO] [stderr] | [INFO] [stderr] 13 | fn is_borrowed(who: &Cow) -> bool { [INFO] [stderr] | ^^^^^^^ help: change this to: `&T` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> tests/cp437_control/mod.rs:14:5 [INFO] [stderr] | [INFO] [stderr] 14 | / match who { [INFO] [stderr] 15 | | &Cow::Borrowed(_) => true, [INFO] [stderr] 16 | | &Cow::Owned(_) => false, [INFO] [stderr] 17 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 14 | match *who { [INFO] [stderr] 15 | Cow::Borrowed(_) => true, [INFO] [stderr] 16 | Cow::Owned(_) => false, [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] error: aborting due to 6 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `codepage-437`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "d95704f18569af2a8a3db2b0e23c795a1f11791c840a98a0ae25f4b3d0d154b8"` [INFO] running `"docker" "rm" "-f" "d95704f18569af2a8a3db2b0e23c795a1f11791c840a98a0ae25f4b3d0d154b8"` [INFO] [stdout] d95704f18569af2a8a3db2b0e23c795a1f11791c840a98a0ae25f4b3d0d154b8