[INFO] crate codeowners 0.1.3 is already in cache [INFO] extracting crate codeowners 0.1.3 into work/ex/clippy-test-run/sources/stable/reg/codeowners/0.1.3 [INFO] extracting crate codeowners 0.1.3 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/codeowners/0.1.3 [INFO] validating manifest of codeowners-0.1.3 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of codeowners-0.1.3 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing codeowners-0.1.3 [INFO] finished frobbing codeowners-0.1.3 [INFO] frobbed toml for codeowners-0.1.3 written to work/ex/clippy-test-run/sources/stable/reg/codeowners/0.1.3/Cargo.toml [INFO] started frobbing codeowners-0.1.3 [INFO] finished frobbing codeowners-0.1.3 [INFO] frobbed toml for codeowners-0.1.3 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/codeowners/0.1.3/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting codeowners-0.1.3 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-6/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/codeowners/0.1.3:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 823a2d15c857273c3d0722403e9bfe89f1c3babced35e8ef77197325689fc2a7 [INFO] running `"docker" "start" "-a" "823a2d15c857273c3d0722403e9bfe89f1c3babced35e8ef77197325689fc2a7"` [INFO] [stderr] Checking codeowners v0.1.3 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:226:14 [INFO] [stderr] | [INFO] [stderr] 226 | Owners { paths: paths } [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `paths` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:226:14 [INFO] [stderr] | [INFO] [stderr] 226 | Owners { paths: paths } [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `paths` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/lib.rs:77:21 [INFO] [stderr] | [INFO] [stderr] 77 | let inner = match self { [INFO] [stderr] | _____________________^ [INFO] [stderr] 78 | | &Owner::Username(ref u) => u, [INFO] [stderr] 79 | | &Owner::Team(ref t) => t, [INFO] [stderr] 80 | | &Owner::Email(ref e) => e, [INFO] [stderr] 81 | | }; [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 77 | let inner = match *self { [INFO] [stderr] 78 | Owner::Username(ref u) => u, [INFO] [stderr] 79 | Owner::Team(ref t) => t, [INFO] [stderr] 80 | Owner::Email(ref e) => e, [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/lib.rs:125:74 [INFO] [stderr] | [INFO] [stderr] 125 | require_literal_separator: pattern.as_str().contains("/"), [INFO] [stderr] | ^^^ help: try using a char instead: `'/'` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: this call to `as_ref` does nothing [INFO] [stderr] --> src/lib.rs:141:54 [INFO] [stderr] | [INFO] [stderr] 141 | if pattern.matches_path_with(parent.as_ref(), &opts) { [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try this: `parent` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_asref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_asref [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/lib.rs:232:40 [INFO] [stderr] | [INFO] [stderr] 232 | let prefixed = if path.starts_with("*") || path.starts_with("/") { [INFO] [stderr] | ^^^ help: try using a char instead: `'*'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/lib.rs:232:65 [INFO] [stderr] | [INFO] [stderr] 232 | let prefixed = if path.starts_with("*") || path.starts_with("/") { [INFO] [stderr] | ^^^ help: try using a char instead: `'/'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/lib.rs:239:53 [INFO] [stderr] | [INFO] [stderr] 239 | let mut normalized = prefixed.trim_left_matches("/").to_string(); [INFO] [stderr] | ^^^ help: try using a char instead: `'/'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/lib.rs:241:29 [INFO] [stderr] | [INFO] [stderr] 241 | if normalized.ends_with("/") { [INFO] [stderr] | ^^^ help: try using a char instead: `'/'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/lib.rs:77:21 [INFO] [stderr] | [INFO] [stderr] 77 | let inner = match self { [INFO] [stderr] | _____________________^ [INFO] [stderr] 78 | | &Owner::Username(ref u) => u, [INFO] [stderr] 79 | | &Owner::Team(ref t) => t, [INFO] [stderr] 80 | | &Owner::Email(ref e) => e, [INFO] [stderr] 81 | | }; [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 77 | let inner = match *self { [INFO] [stderr] 78 | Owner::Username(ref u) => u, [INFO] [stderr] 79 | Owner::Team(ref t) => t, [INFO] [stderr] 80 | Owner::Email(ref e) => e, [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/lib.rs:125:74 [INFO] [stderr] | [INFO] [stderr] 125 | require_literal_separator: pattern.as_str().contains("/"), [INFO] [stderr] | ^^^ help: try using a char instead: `'/'` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: this call to `as_ref` does nothing [INFO] [stderr] --> src/lib.rs:141:54 [INFO] [stderr] | [INFO] [stderr] 141 | if pattern.matches_path_with(parent.as_ref(), &opts) { [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try this: `parent` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_asref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_asref [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/lib.rs:232:40 [INFO] [stderr] | [INFO] [stderr] 232 | let prefixed = if path.starts_with("*") || path.starts_with("/") { [INFO] [stderr] | ^^^ help: try using a char instead: `'*'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/lib.rs:232:65 [INFO] [stderr] | [INFO] [stderr] 232 | let prefixed = if path.starts_with("*") || path.starts_with("/") { [INFO] [stderr] | ^^^ help: try using a char instead: `'/'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/lib.rs:239:53 [INFO] [stderr] | [INFO] [stderr] 239 | let mut normalized = prefixed.trim_left_matches("/").to_string(); [INFO] [stderr] | ^^^ help: try using a char instead: `'/'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/lib.rs:241:29 [INFO] [stderr] | [INFO] [stderr] 241 | if normalized.ends_with("/") { [INFO] [stderr] | ^^^ help: try using a char instead: `'/'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/lib.rs:455:34 [INFO] [stderr] | [INFO] [stderr] 455 | let owners = from_reader("foo/bar @doug".as_bytes()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"foo/bar @doug"` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::string_lit_as_bytes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 2.38s [INFO] running `"docker" "inspect" "823a2d15c857273c3d0722403e9bfe89f1c3babced35e8ef77197325689fc2a7"` [INFO] running `"docker" "rm" "-f" "823a2d15c857273c3d0722403e9bfe89f1c3babced35e8ef77197325689fc2a7"` [INFO] [stdout] 823a2d15c857273c3d0722403e9bfe89f1c3babced35e8ef77197325689fc2a7