[INFO] crate codemap-diagnostic 0.1.0 is already in cache [INFO] extracting crate codemap-diagnostic 0.1.0 into work/ex/clippy-test-run/sources/stable/reg/codemap-diagnostic/0.1.0 [INFO] extracting crate codemap-diagnostic 0.1.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/codemap-diagnostic/0.1.0 [INFO] validating manifest of codemap-diagnostic-0.1.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of codemap-diagnostic-0.1.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing codemap-diagnostic-0.1.0 [INFO] finished frobbing codemap-diagnostic-0.1.0 [INFO] frobbed toml for codemap-diagnostic-0.1.0 written to work/ex/clippy-test-run/sources/stable/reg/codemap-diagnostic/0.1.0/Cargo.toml [INFO] started frobbing codemap-diagnostic-0.1.0 [INFO] finished frobbing codemap-diagnostic-0.1.0 [INFO] frobbed toml for codemap-diagnostic-0.1.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/codemap-diagnostic/0.1.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting codemap-diagnostic-0.1.0 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-0/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/codemap-diagnostic/0.1.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 3f5c676a3d4601daacabe93f1595e5b3ef67ae7d299388f1f2e75983244be54b [INFO] running `"docker" "start" "-a" "3f5c676a3d4601daacabe93f1595e5b3ef67ae7d299388f1f2e75983244be54b"` [INFO] [stderr] Checking codemap-diagnostic v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/emitter.rs:65:17 [INFO] [stderr] | [INFO] [stderr] 65 | dst: dst, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `dst` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/emitter.rs:102:25 [INFO] [stderr] | [INFO] [stderr] 102 | line_index: line_index, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `line_index` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/emitter.rs:111:17 [INFO] [stderr] | [INFO] [stderr] 111 | file: file, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `file` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead [INFO] [stderr] --> src/emitter.rs:885:15 [INFO] [stderr] | [INFO] [stderr] 885 | match write!(&mut self.dst, "\n") { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::write_with_newline)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline [INFO] [stderr] [INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead [INFO] [stderr] --> src/emitter.rs:972:9 [INFO] [stderr] | [INFO] [stderr] 972 | write!(dst, "\n")?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/emitter.rs:65:17 [INFO] [stderr] | [INFO] [stderr] 65 | dst: dst, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `dst` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/emitter.rs:102:25 [INFO] [stderr] | [INFO] [stderr] 102 | line_index: line_index, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `line_index` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/emitter.rs:111:17 [INFO] [stderr] | [INFO] [stderr] 111 | file: file, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `file` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead [INFO] [stderr] --> src/emitter.rs:885:15 [INFO] [stderr] | [INFO] [stderr] 885 | match write!(&mut self.dst, "\n") { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::write_with_newline)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline [INFO] [stderr] [INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead [INFO] [stderr] --> src/emitter.rs:972:9 [INFO] [stderr] | [INFO] [stderr] 972 | write!(dst, "\n")?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/snippet.rs:160:13 [INFO] [stderr] | [INFO] [stderr] 160 | label.len() > 0 [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!label.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/emitter.rs:38:18 [INFO] [stderr] | [INFO] [stderr] 38 | fn use_color(&self) -> bool { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this lifetime isn't used in the function definition [INFO] [stderr] --> src/emitter.rs:85:35 [INFO] [stderr] | [INFO] [stderr] 85 | fn add_annotation_to_file<'a>(file_vec: &mut Vec, [INFO] [stderr] | ^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::extra_unused_lifetimes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#extra_unused_lifetimes [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/emitter.rs:175:21 [INFO] [stderr] | [INFO] [stderr] 175 | let ref mut a = item.1; [INFO] [stderr] | ----^^^^^^^^^---------- help: try: `let a = &mut item.1;` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::toplevel_ref_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: the function has a cyclomatic complexity of 33 [INFO] [stderr] --> src/emitter.rs:211:6 [INFO] [stderr] | [INFO] [stderr] 211 | / fn render_source_line(&self, [INFO] [stderr] 212 | | buffer: &mut StyledBuffer, [INFO] [stderr] 213 | | file: &File, [INFO] [stderr] 214 | | line: &Line, [INFO] [stderr] ... | [INFO] [stderr] 598 | | }).collect::>() [INFO] [stderr] 599 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cyclomatic_complexity)] on by default [INFO] [stderr] = help: you could split it up into multiple smaller functions [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cyclomatic_complexity [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/emitter.rs:412:43 [INFO] [stderr] | [INFO] [stderr] 412 | if line.annotations.is_empty() || line.annotations.iter() [INFO] [stderr] | ___________________________________________^ [INFO] [stderr] 413 | | .filter(|a| !a.is_line()).collect::>().len() == 0 [INFO] [stderr] | |____________________________________________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] help: using `is_empty` is clearer and more explicit [INFO] [stderr] | [INFO] [stderr] 412 | if line.annotations.is_empty() || line.annotations.iter() [INFO] [stderr] 413 | .filter(|a| !a.is_line()).collect::>().is_empty() [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: avoid using `collect()` when not needed [INFO] [stderr] --> src/emitter.rs:413:38 [INFO] [stderr] | [INFO] [stderr] 413 | .filter(|a| !a.is_line()).collect::>().len() == 0 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace with: `.count()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_collect)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_collect [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/emitter.rs:429:20 [INFO] [stderr] | [INFO] [stderr] 429 | for pos in 0..line_len + 1 { [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: use: `0..=line_len` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::range_plus_one)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/emitter.rs:490:26 [INFO] [stderr] | [INFO] [stderr] 490 | for p in line_offset + 1..line_offset + pos + 1 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `line_offset + 1..=line_offset + pos` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/emitter.rs:507:30 [INFO] [stderr] | [INFO] [stderr] 507 | for p in line_offset..line_offset + pos + 1 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `line_offset..=line_offset + pos` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/emitter.rs:615:27 [INFO] [stderr] | [INFO] [stderr] 615 | msg: &Vec<(String, Style)>, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: change this to: `&[(String, Style)]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/emitter.rs:689:34 [INFO] [stderr] | [INFO] [stderr] 689 | msg: &Vec<(String, Style)>, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: change this to: `&[(String, Style)]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/emitter.rs:691:36 [INFO] [stderr] | [INFO] [stderr] 691 | level: &Level, [INFO] [stderr] | ^^^^^^ help: consider passing by value instead: `Level` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/emitter.rs:697:28 [INFO] [stderr] | [INFO] [stderr] 697 | if is_secondary && spans.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `spans.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/emitter.rs:707:63 [INFO] [stderr] | [INFO] [stderr] 707 | buffer.append(0, &level.to_string(), Style::Level(level.clone())); [INFO] [stderr] | ^^^^^^^^^^^^^ help: try dereferencing it: `*level` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/emitter.rs:709:52 [INFO] [stderr] | [INFO] [stderr] 709 | buffer.append(0, "[", Style::Level(level.clone())); [INFO] [stderr] | ^^^^^^^^^^^^^ help: try dereferencing it: `*level` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/emitter.rs:710:54 [INFO] [stderr] | [INFO] [stderr] 710 | buffer.append(0, &code, Style::Level(level.clone())); [INFO] [stderr] | ^^^^^^^^^^^^^ help: try dereferencing it: `*level` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/emitter.rs:711:52 [INFO] [stderr] | [INFO] [stderr] 711 | buffer.append(0, "]", Style::Level(level.clone())); [INFO] [stderr] | ^^^^^^^^^^^^^ help: try dereferencing it: `*level` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/emitter.rs:888:17 [INFO] [stderr] | [INFO] [stderr] 888 | / match self.dst.flush() { [INFO] [stderr] 889 | | Err(e) => panic!("failed to emit error: {}", e), [INFO] [stderr] 890 | | _ => (), [INFO] [stderr] 891 | | } [INFO] [stderr] | |_________________^ help: try this: `if let Err(e) = self.dst.flush() { panic!("failed to emit error: {}", e) }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/emitter.rs:947:41 [INFO] [stderr] | [INFO] [stderr] 947 | fn emit_to_destination(rendered_buffer: &Vec>, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `&[Vec]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/emitter.rs:948:29 [INFO] [stderr] | [INFO] [stderr] 948 | lvl: &Level, [INFO] [stderr] | ^^^^^^ help: consider passing by value instead: `Level` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/snippet.rs:160:13 [INFO] [stderr] | [INFO] [stderr] 160 | label.len() > 0 [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!label.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/emitter.rs:38:18 [INFO] [stderr] | [INFO] [stderr] 38 | fn use_color(&self) -> bool { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this lifetime isn't used in the function definition [INFO] [stderr] --> src/emitter.rs:85:35 [INFO] [stderr] | [INFO] [stderr] 85 | fn add_annotation_to_file<'a>(file_vec: &mut Vec, [INFO] [stderr] | ^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::extra_unused_lifetimes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#extra_unused_lifetimes [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/emitter.rs:175:21 [INFO] [stderr] | [INFO] [stderr] 175 | let ref mut a = item.1; [INFO] [stderr] | ----^^^^^^^^^---------- help: try: `let a = &mut item.1;` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::toplevel_ref_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: the function has a cyclomatic complexity of 33 [INFO] [stderr] --> src/emitter.rs:211:6 [INFO] [stderr] | [INFO] [stderr] 211 | / fn render_source_line(&self, [INFO] [stderr] 212 | | buffer: &mut StyledBuffer, [INFO] [stderr] 213 | | file: &File, [INFO] [stderr] 214 | | line: &Line, [INFO] [stderr] ... | [INFO] [stderr] 598 | | }).collect::>() [INFO] [stderr] 599 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cyclomatic_complexity)] on by default [INFO] [stderr] = help: you could split it up into multiple smaller functions [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cyclomatic_complexity [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/emitter.rs:412:43 [INFO] [stderr] | [INFO] [stderr] 412 | if line.annotations.is_empty() || line.annotations.iter() [INFO] [stderr] | ___________________________________________^ [INFO] [stderr] 413 | | .filter(|a| !a.is_line()).collect::>().len() == 0 [INFO] [stderr] | |____________________________________________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] help: using `is_empty` is clearer and more explicit [INFO] [stderr] | [INFO] [stderr] 412 | if line.annotations.is_empty() || line.annotations.iter() [INFO] [stderr] 413 | .filter(|a| !a.is_line()).collect::>().is_empty() [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: avoid using `collect()` when not needed [INFO] [stderr] --> src/emitter.rs:413:38 [INFO] [stderr] | [INFO] [stderr] 413 | .filter(|a| !a.is_line()).collect::>().len() == 0 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace with: `.count()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_collect)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_collect [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/emitter.rs:429:20 [INFO] [stderr] | [INFO] [stderr] 429 | for pos in 0..line_len + 1 { [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: use: `0..=line_len` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::range_plus_one)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/emitter.rs:490:26 [INFO] [stderr] | [INFO] [stderr] 490 | for p in line_offset + 1..line_offset + pos + 1 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `line_offset + 1..=line_offset + pos` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/emitter.rs:507:30 [INFO] [stderr] | [INFO] [stderr] 507 | for p in line_offset..line_offset + pos + 1 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `line_offset..=line_offset + pos` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/emitter.rs:615:27 [INFO] [stderr] | [INFO] [stderr] 615 | msg: &Vec<(String, Style)>, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: change this to: `&[(String, Style)]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/emitter.rs:689:34 [INFO] [stderr] | [INFO] [stderr] 689 | msg: &Vec<(String, Style)>, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: change this to: `&[(String, Style)]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/emitter.rs:691:36 [INFO] [stderr] | [INFO] [stderr] 691 | level: &Level, [INFO] [stderr] | ^^^^^^ help: consider passing by value instead: `Level` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/emitter.rs:697:28 [INFO] [stderr] | [INFO] [stderr] 697 | if is_secondary && spans.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `spans.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/emitter.rs:707:63 [INFO] [stderr] | [INFO] [stderr] 707 | buffer.append(0, &level.to_string(), Style::Level(level.clone())); [INFO] [stderr] | ^^^^^^^^^^^^^ help: try dereferencing it: `*level` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/emitter.rs:709:52 [INFO] [stderr] | [INFO] [stderr] 709 | buffer.append(0, "[", Style::Level(level.clone())); [INFO] [stderr] | ^^^^^^^^^^^^^ help: try dereferencing it: `*level` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/emitter.rs:710:54 [INFO] [stderr] | [INFO] [stderr] 710 | buffer.append(0, &code, Style::Level(level.clone())); [INFO] [stderr] | ^^^^^^^^^^^^^ help: try dereferencing it: `*level` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/emitter.rs:711:52 [INFO] [stderr] | [INFO] [stderr] 711 | buffer.append(0, "]", Style::Level(level.clone())); [INFO] [stderr] | ^^^^^^^^^^^^^ help: try dereferencing it: `*level` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/emitter.rs:888:17 [INFO] [stderr] | [INFO] [stderr] 888 | / match self.dst.flush() { [INFO] [stderr] 889 | | Err(e) => panic!("failed to emit error: {}", e), [INFO] [stderr] 890 | | _ => (), [INFO] [stderr] 891 | | } [INFO] [stderr] | |_________________^ help: try this: `if let Err(e) = self.dst.flush() { panic!("failed to emit error: {}", e) }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/emitter.rs:947:41 [INFO] [stderr] | [INFO] [stderr] 947 | fn emit_to_destination(rendered_buffer: &Vec>, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `&[Vec]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/emitter.rs:948:29 [INFO] [stderr] | [INFO] [stderr] 948 | lvl: &Level, [INFO] [stderr] | ^^^^^^ help: consider passing by value instead: `Level` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 3.20s [INFO] running `"docker" "inspect" "3f5c676a3d4601daacabe93f1595e5b3ef67ae7d299388f1f2e75983244be54b"` [INFO] running `"docker" "rm" "-f" "3f5c676a3d4601daacabe93f1595e5b3ef67ae7d299388f1f2e75983244be54b"` [INFO] [stdout] 3f5c676a3d4601daacabe93f1595e5b3ef67ae7d299388f1f2e75983244be54b