[INFO] crate cobalt-bin 0.14.0 is already in cache [INFO] extracting crate cobalt-bin 0.14.0 into work/ex/clippy-test-run/sources/stable/reg/cobalt-bin/0.14.0 [INFO] extracting crate cobalt-bin 0.14.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/cobalt-bin/0.14.0 [INFO] validating manifest of cobalt-bin-0.14.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of cobalt-bin-0.14.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing cobalt-bin-0.14.0 [INFO] finished frobbing cobalt-bin-0.14.0 [INFO] frobbed toml for cobalt-bin-0.14.0 written to work/ex/clippy-test-run/sources/stable/reg/cobalt-bin/0.14.0/Cargo.toml [INFO] started frobbing cobalt-bin-0.14.0 [INFO] finished frobbing cobalt-bin-0.14.0 [INFO] frobbed toml for cobalt-bin-0.14.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/cobalt-bin/0.14.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting cobalt-bin-0.14.0 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-4/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/cobalt-bin/0.14.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 19a755f7a4b4e9003ab2aa1e5c9d5077bd334c1fc361a8333fb79908bf2f8ce4 [INFO] running `"docker" "start" "-a" "19a755f7a4b4e9003ab2aa1e5c9d5077bd334c1fc361a8333fb79908bf2f8ce4"` [INFO] [stderr] Compiling sass-sys v0.4.7 [INFO] [stderr] Checking float-cmp v0.4.0 [INFO] [stderr] Checking ghp v0.1.2 [INFO] [stderr] Checking serde v1.0.85 [INFO] [stderr] Checking quick-xml v0.13.2 [INFO] [stderr] Checking globwalk v0.5.0 [INFO] [stderr] Checking predicates v1.0.0 [INFO] [stderr] Checking rss v1.6.1 [INFO] [stderr] Checking assert_fs v0.10.1 [INFO] [stderr] Checking liquid-value v0.17.1 [INFO] [stderr] Checking bincode v1.0.1 [INFO] [stderr] Checking plist v0.2.4 [INFO] [stderr] Checking serde_json v1.0.37 [INFO] [stderr] Checking serde_yaml v0.8.8 [INFO] [stderr] Checking toml v0.4.10 [INFO] [stderr] Checking liquid-interpreter v0.17.1 [INFO] [stderr] Checking syntect v2.1.0 [INFO] [stderr] Checking escargot v0.3.1 [INFO] [stderr] Checking jsonfeed v0.2.0 [INFO] [stderr] Checking liquid-compiler v0.17.1 [INFO] [stderr] Checking assert_cmd v0.10.2 [INFO] [stderr] Checking liquid v0.17.1 [INFO] [stderr] Checking sass-rs v0.2.1 [INFO] [stderr] Checking cobalt-bin v0.14.0 (/opt/crater/workdir) [INFO] [stderr] warning: this .into_iter() call is equivalent to .iter() and will not move the slice [INFO] [stderr] --> src/pagination.rs:65:37 [INFO] [stderr] | [INFO] [stderr] 65 | self.pages = Some(all_pages.into_iter().map(|p| (*p).clone()).collect()); [INFO] [stderr] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::into_iter_on_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `60` [INFO] [stderr] --> src/cobalt_model/datetime.rs:237:41 [INFO] [stderr] | [INFO] [stderr] 237 | .and_then(|d| d.with_offset(1 * 60 * 60)) [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_op)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `60` [INFO] [stderr] --> src/cobalt_model/datetime.rs:249:41 [INFO] [stderr] | [INFO] [stderr] 249 | .and_then(|d| d.with_offset(1 * 60 * 60)) [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `60` [INFO] [stderr] --> src/cobalt_model/datetime.rs:261:41 [INFO] [stderr] | [INFO] [stderr] 261 | .and_then(|d| d.with_offset(1 * 60 * 60)) [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: this .into_iter() call is equivalent to .iter() and will not move the slice [INFO] [stderr] --> src/pagination.rs:65:37 [INFO] [stderr] | [INFO] [stderr] 65 | self.pages = Some(all_pages.into_iter().map(|p| (*p).clone()).collect()); [INFO] [stderr] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::into_iter_on_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref [INFO] [stderr] [INFO] [stderr] warning: use of `expect` followed by a function call [INFO] [stderr] --> tests/mod.rs:67:31 [INFO] [stderr] | [INFO] [stderr] 67 | File::open(&src_file).expect(&format!( [INFO] [stderr] | _______________________________^ [INFO] [stderr] 68 | | "File {:?} does not exist in reference ({:?}).", [INFO] [stderr] 69 | | entry.path(), [INFO] [stderr] 70 | | src_file [INFO] [stderr] 71 | | )); [INFO] [stderr] | |__________^ help: try this: `unwrap_or_else(|_| panic!("File {:?} does not exist in reference ({:?}).", entry.path()))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::expect_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 2m 37s [INFO] running `"docker" "inspect" "19a755f7a4b4e9003ab2aa1e5c9d5077bd334c1fc361a8333fb79908bf2f8ce4"` [INFO] running `"docker" "rm" "-f" "19a755f7a4b4e9003ab2aa1e5c9d5077bd334c1fc361a8333fb79908bf2f8ce4"` [INFO] [stdout] 19a755f7a4b4e9003ab2aa1e5c9d5077bd334c1fc361a8333fb79908bf2f8ce4