[INFO] crate coarsetime 0.1.9 is already in cache [INFO] extracting crate coarsetime 0.1.9 into work/ex/clippy-test-run/sources/stable/reg/coarsetime/0.1.9 [INFO] extracting crate coarsetime 0.1.9 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/coarsetime/0.1.9 [INFO] validating manifest of coarsetime-0.1.9 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of coarsetime-0.1.9 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing coarsetime-0.1.9 [INFO] finished frobbing coarsetime-0.1.9 [INFO] frobbed toml for coarsetime-0.1.9 written to work/ex/clippy-test-run/sources/stable/reg/coarsetime/0.1.9/Cargo.toml [INFO] started frobbing coarsetime-0.1.9 [INFO] finished frobbing coarsetime-0.1.9 [INFO] frobbed toml for coarsetime-0.1.9 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/coarsetime/0.1.9/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting coarsetime-0.1.9 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-2/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/coarsetime/0.1.9:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 4c794efc5bb2e0d36fc88a801a5c34bdbdab2874ab45190e1fd7d357f698842c [INFO] running `"docker" "start" "-a" "4c794efc5bb2e0d36fc88a801a5c34bdbdab2874ab45190e1fd7d357f698842c"` [INFO] [stderr] Checking coarsetime v0.1.9 (/opt/crater/workdir) [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/duration.rs:32:20 [INFO] [stderr] | [INFO] [stderr] 32 | pub fn as_secs(&self) -> u64 { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/duration.rs:38:25 [INFO] [stderr] | [INFO] [stderr] 38 | pub fn subsec_nanos(&self) -> u32 { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/duration.rs:39:11 [INFO] [stderr] | [INFO] [stderr] 39 | ((self.0 as u32 as u64 * 125_000_000) >> 29) as u32 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(self.0 as u32)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/duration.rs:44:19 [INFO] [stderr] | [INFO] [stderr] 44 | pub fn as_u64(&self) -> u64 { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/duration.rs:56:19 [INFO] [stderr] | [INFO] [stderr] 56 | pub fn as_f64(&self) -> f64 { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/duration.rs:107:27 [INFO] [stderr] | [INFO] [stderr] 107 | Duration(self.0 * rhs as u64) [INFO] [stderr] | ^^^^^^^^^^ help: try: `u64::from(rhs)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/duration.rs:123:27 [INFO] [stderr] | [INFO] [stderr] 123 | Duration(self.0 / rhs as u64) [INFO] [stderr] | ^^^^^^^^^^ help: try: `u64::from(rhs)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/helpers.rs:19:24 [INFO] [stderr] | [INFO] [stderr] 19 | (tp_sec << 32) | ((tp_nsec as u64 * 9_223_372_037) >> 31) [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try: `u64::from(tp_nsec)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/helpers.rs:24:24 [INFO] [stderr] | [INFO] [stderr] 24 | (tv_sec << 32) | ((tv_usec as u64 * 9_223_372_036_855) >> 31) [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try: `u64::from(tv_usec)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/instant.rs:95:27 [INFO] [stderr] | [INFO] [stderr] 95 | pub fn duration_since(&self, earlier: Instant) -> Duration { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/instant.rs:102:33 [INFO] [stderr] | [INFO] [stderr] 102 | pub fn elapsed_since_recent(&self) -> Duration { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/instant.rs:110:20 [INFO] [stderr] | [INFO] [stderr] 110 | pub fn elapsed(&self) -> Duration { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/instant.rs:116:19 [INFO] [stderr] | [INFO] [stderr] 116 | pub fn as_u64(&self) -> u64 { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/duration.rs:32:20 [INFO] [stderr] | [INFO] [stderr] 32 | pub fn as_secs(&self) -> u64 { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/duration.rs:38:25 [INFO] [stderr] | [INFO] [stderr] 38 | pub fn subsec_nanos(&self) -> u32 { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/duration.rs:39:11 [INFO] [stderr] | [INFO] [stderr] 39 | ((self.0 as u32 as u64 * 125_000_000) >> 29) as u32 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(self.0 as u32)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/duration.rs:44:19 [INFO] [stderr] | [INFO] [stderr] 44 | pub fn as_u64(&self) -> u64 { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/duration.rs:56:19 [INFO] [stderr] | [INFO] [stderr] 56 | pub fn as_f64(&self) -> f64 { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/duration.rs:107:27 [INFO] [stderr] | [INFO] [stderr] 107 | Duration(self.0 * rhs as u64) [INFO] [stderr] | ^^^^^^^^^^ help: try: `u64::from(rhs)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/duration.rs:123:27 [INFO] [stderr] | [INFO] [stderr] 123 | Duration(self.0 / rhs as u64) [INFO] [stderr] | ^^^^^^^^^^ help: try: `u64::from(rhs)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/helpers.rs:19:24 [INFO] [stderr] | [INFO] [stderr] 19 | (tp_sec << 32) | ((tp_nsec as u64 * 9_223_372_037) >> 31) [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try: `u64::from(tp_nsec)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/helpers.rs:24:24 [INFO] [stderr] | [INFO] [stderr] 24 | (tv_sec << 32) | ((tv_usec as u64 * 9_223_372_036_855) >> 31) [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try: `u64::from(tv_usec)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/instant.rs:95:27 [INFO] [stderr] | [INFO] [stderr] 95 | pub fn duration_since(&self, earlier: Instant) -> Duration { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/instant.rs:102:33 [INFO] [stderr] | [INFO] [stderr] 102 | pub fn elapsed_since_recent(&self) -> Duration { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/instant.rs:110:20 [INFO] [stderr] | [INFO] [stderr] 110 | pub fn elapsed(&self) -> Duration { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/instant.rs:116:19 [INFO] [stderr] | [INFO] [stderr] 116 | pub fn as_u64(&self) -> u64 { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 1.32s [INFO] running `"docker" "inspect" "4c794efc5bb2e0d36fc88a801a5c34bdbdab2874ab45190e1fd7d357f698842c"` [INFO] running `"docker" "rm" "-f" "4c794efc5bb2e0d36fc88a801a5c34bdbdab2874ab45190e1fd7d357f698842c"` [INFO] [stdout] 4c794efc5bb2e0d36fc88a801a5c34bdbdab2874ab45190e1fd7d357f698842c