[INFO] crate coap 0.7.1 is already in cache [INFO] extracting crate coap 0.7.1 into work/ex/clippy-test-run/sources/stable/reg/coap/0.7.1 [INFO] extracting crate coap 0.7.1 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/coap/0.7.1 [INFO] validating manifest of coap-0.7.1 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of coap-0.7.1 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing coap-0.7.1 [INFO] finished frobbing coap-0.7.1 [INFO] frobbed toml for coap-0.7.1 written to work/ex/clippy-test-run/sources/stable/reg/coap/0.7.1/Cargo.toml [INFO] started frobbing coap-0.7.1 [INFO] finished frobbing coap-0.7.1 [INFO] frobbed toml for coap-0.7.1 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/coap/0.7.1/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting coap-0.7.1 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-5/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/coap/0.7.1:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 00b8b8ce0b90c965f1aa1b4bb65996f7c823c82cb184706dd710e1305442463b [INFO] running `"docker" "start" "-a" "00b8b8ce0b90c965f1aa1b4bb65996f7c823c82cb184706dd710e1305442463b"` [INFO] [stderr] Checking bincode v0.3.0 [INFO] [stderr] Checking coap v0.7.1 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/message/packet.rs:282:21 [INFO] [stderr] | [INFO] [stderr] 282 | header: header, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `header` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/message/packet.rs:283:21 [INFO] [stderr] | [INFO] [stderr] 283 | token: token, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `token` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/message/packet.rs:284:21 [INFO] [stderr] | [INFO] [stderr] 284 | options: options, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `options` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/message/packet.rs:285:21 [INFO] [stderr] | [INFO] [stderr] 285 | payload: payload, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `payload` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/server.rs:83:13 [INFO] [stderr] | [INFO] [stderr] 83 | socket: socket, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `socket` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/server.rs:84:13 [INFO] [stderr] | [INFO] [stderr] 84 | tx_sender: tx_sender, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `tx_sender` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/server.rs:85:13 [INFO] [stderr] | [INFO] [stderr] 85 | rx_recv: rx_recv, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `rx_recv` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/server.rs:87:13 [INFO] [stderr] | [INFO] [stderr] 87 | coap_handler: coap_handler, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `coap_handler` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/observer.rs:57:13 [INFO] [stderr] | [INFO] [stderr] 57 | tx_sender: tx_sender, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `tx_sender` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/observer.rs:58:13 [INFO] [stderr] | [INFO] [stderr] 58 | response_notify: response_notify, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `response_notify` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/message/packet.rs:282:21 [INFO] [stderr] | [INFO] [stderr] 282 | header: header, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `header` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/message/packet.rs:283:21 [INFO] [stderr] | [INFO] [stderr] 283 | token: token, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `token` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/message/packet.rs:284:21 [INFO] [stderr] | [INFO] [stderr] 284 | options: options, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `options` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/message/packet.rs:285:21 [INFO] [stderr] | [INFO] [stderr] 285 | payload: payload, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `payload` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/server.rs:83:13 [INFO] [stderr] | [INFO] [stderr] 83 | socket: socket, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `socket` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/server.rs:84:13 [INFO] [stderr] | [INFO] [stderr] 84 | tx_sender: tx_sender, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `tx_sender` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/server.rs:85:13 [INFO] [stderr] | [INFO] [stderr] 85 | rx_recv: rx_recv, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `rx_recv` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/server.rs:87:13 [INFO] [stderr] | [INFO] [stderr] 87 | coap_handler: coap_handler, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `coap_handler` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/observer.rs:57:13 [INFO] [stderr] | [INFO] [stderr] 57 | tx_sender: tx_sender, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `tx_sender` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/observer.rs:58:13 [INFO] [stderr] | [INFO] [stderr] 58 | response_notify: response_notify, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `response_notify` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/message/header.rs:85:9 [INFO] [stderr] | [INFO] [stderr] 85 | return Header::from_raw(&HeaderRaw::default()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Header::from_raw(&HeaderRaw::default())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/message/header.rs:89:9 [INFO] [stderr] | [INFO] [stderr] 89 | / return Header { [INFO] [stderr] 90 | | ver_type_tkl: raw.ver_type_tkl, [INFO] [stderr] 91 | | code: code_to_class(&raw.code), [INFO] [stderr] 92 | | message_id: raw.message_id, [INFO] [stderr] 93 | | }; [INFO] [stderr] | |__________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 89 | Header { [INFO] [stderr] 90 | ver_type_tkl: raw.ver_type_tkl, [INFO] [stderr] 91 | code: code_to_class(&raw.code), [INFO] [stderr] 92 | message_id: raw.message_id, [INFO] [stderr] 93 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/message/header.rs:97:9 [INFO] [stderr] | [INFO] [stderr] 97 | / return HeaderRaw { [INFO] [stderr] 98 | | ver_type_tkl: self.ver_type_tkl, [INFO] [stderr] 99 | | code: class_to_code(&self.code), [INFO] [stderr] 100 | | message_id: self.message_id, [INFO] [stderr] 101 | | }; [INFO] [stderr] | |__________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 97 | HeaderRaw { [INFO] [stderr] 98 | ver_type_tkl: self.ver_type_tkl, [INFO] [stderr] 99 | code: class_to_code(&self.code), [INFO] [stderr] 100 | message_id: self.message_id, [INFO] [stderr] 101 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/message/header.rs:112:9 [INFO] [stderr] | [INFO] [stderr] 112 | return self.ver_type_tkl >> 6; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.ver_type_tkl >> 6` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/message/header.rs:151:9 [INFO] [stderr] | [INFO] [stderr] 151 | return 0x0F & self.ver_type_tkl; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `0x0F & self.ver_type_tkl` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/message/header.rs:177:9 [INFO] [stderr] | [INFO] [stderr] 177 | return self.message_id; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.message_id` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/message/header.rs:182:5 [INFO] [stderr] | [INFO] [stderr] 182 | / return match *class { [INFO] [stderr] 183 | | MessageClass::Empty => 0x00, [INFO] [stderr] 184 | | [INFO] [stderr] 185 | | MessageClass::Request(RequestType::Get) => 0x01, [INFO] [stderr] ... | [INFO] [stderr] 214 | | _ => 0xFF, [INFO] [stderr] 215 | | } as u8; [INFO] [stderr] | |____________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 182 | match *class { [INFO] [stderr] 183 | MessageClass::Empty => 0x00, [INFO] [stderr] 184 | [INFO] [stderr] 185 | MessageClass::Request(RequestType::Get) => 0x01, [INFO] [stderr] 186 | MessageClass::Request(RequestType::Post) => 0x02, [INFO] [stderr] 187 | MessageClass::Request(RequestType::Put) => 0x03, [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/message/header.rs:263:5 [INFO] [stderr] | [INFO] [stderr] 263 | return code_to_str(&class_to_code(class)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `code_to_str(&class_to_code(class))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/message/packet.rs:95:9 [INFO] [stderr] | [INFO] [stderr] 95 | return &self.token; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `&self.token` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/message/mod.rs:21:9 [INFO] [stderr] | [INFO] [stderr] 21 | return self.get_message().get_token(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.get_message().get_token()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/message/mod.rs:33:9 [INFO] [stderr] | [INFO] [stderr] 33 | return self.get_message().get_option(tp); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.get_message().get_option(tp)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/message/mod.rs:42:9 [INFO] [stderr] | [INFO] [stderr] 42 | return self.get_message().get_observe(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.get_message().get_observe()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/message/mod.rs:46:9 [INFO] [stderr] | [INFO] [stderr] 46 | return self.get_message().header.get_message_id(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.get_message().header.get_message_id()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/message/mod.rs:55:9 [INFO] [stderr] | [INFO] [stderr] 55 | return self.get_message().header.get_version(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.get_message().header.get_version()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/message/mod.rs:61:9 [INFO] [stderr] | [INFO] [stderr] 61 | return self.get_message().header.get_type(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.get_message().header.get_type()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/message/mod.rs:64:9 [INFO] [stderr] | [INFO] [stderr] 64 | return self.get_message().header.get_code(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.get_message().header.get_code()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/client.rs:159:9 [INFO] [stderr] | [INFO] [stderr] 159 | return Ok(()); [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/client.rs:203:21 [INFO] [stderr] | [INFO] [stderr] 203 | return Ok(receive_packet); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(receive_packet)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/client.rs:205:21 [INFO] [stderr] | [INFO] [stderr] 205 | return Err(Error::new(ErrorKind::Other, "receive invalid data")); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Err(Error::new(ErrorKind::Other, "receive invalid data"))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/client.rs:278:9 [INFO] [stderr] | [INFO] [stderr] 278 | return Ok((host.to_string(), port, path)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok((host.to_string(), port, path))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/client.rs:283:9 [INFO] [stderr] | [INFO] [stderr] 283 | return *message_id; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `*message_id` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/server.rs:59:9 [INFO] [stderr] | [INFO] [stderr] 59 | return self(request); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self(request)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/server.rs:163:25 [INFO] [stderr] | [INFO] [stderr] 163 | return Some(CoAPRequest::from_packet(packet, &src)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Some(CoAPRequest::from_packet(packet, &src))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/server.rs:167:25 [INFO] [stderr] | [INFO] [stderr] 167 | return None; [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `None` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/server.rs:183:33 [INFO] [stderr] | [INFO] [stderr] 183 | Ok(None) => return Err(ResponseError::SocketUnwritable), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Err(ResponseError::SocketUnwritable)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/server.rs:187:25 [INFO] [stderr] | [INFO] [stderr] 187 | return Err(ResponseError::SocketError); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Err(ResponseError::SocketError)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/server.rs:193:17 [INFO] [stderr] | [INFO] [stderr] 193 | return Err(ResponseError::PacketInvalid); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Err(ResponseError::PacketInvalid)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/observer.rs:73:21 [INFO] [stderr] | [INFO] [stderr] 73 | return false; [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove `return` as shown: `false` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/observer.rs:77:21 [INFO] [stderr] | [INFO] [stderr] 77 | return true; [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `true` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/observer.rs:79:22 [INFO] [stderr] | [INFO] [stderr] 79 | _ => return true, [INFO] [stderr] | ^^^^^^^^^^^ help: remove `return` as shown: `true` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/observer.rs:83:17 [INFO] [stderr] | [INFO] [stderr] 83 | return true; [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `true` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/observer.rs:85:18 [INFO] [stderr] | [INFO] [stderr] 85 | _ => return true, [INFO] [stderr] | ^^^^^^^^^^^ help: remove `return` as shown: `true` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/observer.rs:247:9 [INFO] [stderr] | [INFO] [stderr] 247 | return true; [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `true` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/observer.rs:256:17 [INFO] [stderr] | [INFO] [stderr] 256 | return r; [INFO] [stderr] | ^^^^^^^^^ help: remove `return` as shown: `r` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/observer.rs:259:17 [INFO] [stderr] | [INFO] [stderr] 259 | / return v.insert(ResourceItem { [INFO] [stderr] 260 | | payload: payload.clone(), [INFO] [stderr] 261 | | register_resources: HashSet::new(), [INFO] [stderr] 262 | | sequence: 0, [INFO] [stderr] 263 | | }); [INFO] [stderr] | |___________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 259 | v.insert(ResourceItem { [INFO] [stderr] 260 | payload: payload.clone(), [INFO] [stderr] 261 | register_resources: HashSet::new(), [INFO] [stderr] 262 | sequence: 0, [INFO] [stderr] 263 | }) [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/observer.rs:315:9 [INFO] [stderr] | [INFO] [stderr] 315 | return try_again; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `try_again` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/observer.rs:376:9 [INFO] [stderr] | [INFO] [stderr] 376 | return self.current_message_id; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.current_message_id` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: you should consider adding a `Default` implementation for `message::header::Header` [INFO] [stderr] --> src/message/header.rs:84:5 [INFO] [stderr] | [INFO] [stderr] 84 | / pub fn new() -> Header { [INFO] [stderr] 85 | | return Header::from_raw(&HeaderRaw::default()); [INFO] [stderr] 86 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 83 | impl Default for message::header::Header { [INFO] [stderr] 84 | fn default() -> Self { [INFO] [stderr] 85 | Self::new() [INFO] [stderr] 86 | } [INFO] [stderr] 87 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: the function has a cyclomatic complexity of 27 [INFO] [stderr] --> src/message/header.rs:181:1 [INFO] [stderr] | [INFO] [stderr] 181 | / pub fn class_to_code(class: &MessageClass) -> u8 { [INFO] [stderr] 182 | | return match *class { [INFO] [stderr] 183 | | MessageClass::Empty => 0x00, [INFO] [stderr] 184 | | [INFO] [stderr] ... | [INFO] [stderr] 215 | | } as u8; [INFO] [stderr] 216 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cyclomatic_complexity)] on by default [INFO] [stderr] = help: you could split it up into multiple smaller functions [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cyclomatic_complexity [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/message/header.rs:218:28 [INFO] [stderr] | [INFO] [stderr] 218 | pub fn code_to_class(code: &u8) -> MessageClass { [INFO] [stderr] | ^^^ help: consider passing by value instead: `u8` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/message/header.rs:255:26 [INFO] [stderr] | [INFO] [stderr] 255 | pub fn code_to_str(code: &u8) -> String { [INFO] [stderr] | ^^^ help: consider passing by value instead: `u8` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: you should consider adding a `Default` implementation for `message::request::CoAPRequest` [INFO] [stderr] --> src/message/request.rs:18:5 [INFO] [stderr] | [INFO] [stderr] 18 | / pub fn new() -> CoAPRequest { [INFO] [stderr] 19 | | CoAPRequest { [INFO] [stderr] 20 | | response: None, [INFO] [stderr] 21 | | message: Packet::new(), [INFO] [stderr] 22 | | source: None, [INFO] [stderr] 23 | | } [INFO] [stderr] 24 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 17 | impl Default for message::request::CoAPRequest { [INFO] [stderr] 18 | fn default() -> Self { [INFO] [stderr] 19 | Self::new() [INFO] [stderr] 20 | } [INFO] [stderr] 21 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/message/request.rs:30:26 [INFO] [stderr] | [INFO] [stderr] 30 | source: Some(source.clone()), [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try dereferencing it: `*source` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/message/request.rs:51:31 [INFO] [stderr] | [INFO] [stderr] 51 | let segs = path.split("/"); [INFO] [stderr] | ^^^ help: try using a char instead: `'/'` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/message/request.rs:53:16 [INFO] [stderr] | [INFO] [stderr] 53 | if s.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `s.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/message/header.rs:85:9 [INFO] [stderr] | [INFO] [stderr] 85 | return Header::from_raw(&HeaderRaw::default()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Header::from_raw(&HeaderRaw::default())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/message/header.rs:89:9 [INFO] [stderr] | [INFO] [stderr] 89 | / return Header { [INFO] [stderr] 90 | | ver_type_tkl: raw.ver_type_tkl, [INFO] [stderr] 91 | | code: code_to_class(&raw.code), [INFO] [stderr] 92 | | message_id: raw.message_id, [INFO] [stderr] 93 | | }; [INFO] [stderr] | |__________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 89 | Header { [INFO] [stderr] 90 | ver_type_tkl: raw.ver_type_tkl, [INFO] [stderr] 91 | code: code_to_class(&raw.code), [INFO] [stderr] 92 | message_id: raw.message_id, [INFO] [stderr] 93 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/message/header.rs:97:9 [INFO] [stderr] | [INFO] [stderr] 97 | / return HeaderRaw { [INFO] [stderr] 98 | | ver_type_tkl: self.ver_type_tkl, [INFO] [stderr] 99 | | code: class_to_code(&self.code), [INFO] [stderr] 100 | | message_id: self.message_id, [INFO] [stderr] 101 | | }; [INFO] [stderr] | |__________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 97 | HeaderRaw { [INFO] [stderr] 98 | ver_type_tkl: self.ver_type_tkl, [INFO] [stderr] 99 | code: class_to_code(&self.code), [INFO] [stderr] 100 | message_id: self.message_id, [INFO] [stderr] 101 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/message/header.rs:112:9 [INFO] [stderr] | [INFO] [stderr] 112 | return self.ver_type_tkl >> 6; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.ver_type_tkl >> 6` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/message/header.rs:151:9 [INFO] [stderr] | [INFO] [stderr] 151 | return 0x0F & self.ver_type_tkl; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `0x0F & self.ver_type_tkl` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/message/header.rs:177:9 [INFO] [stderr] | [INFO] [stderr] 177 | return self.message_id; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.message_id` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/message/header.rs:182:5 [INFO] [stderr] | [INFO] [stderr] 182 | / return match *class { [INFO] [stderr] 183 | | MessageClass::Empty => 0x00, [INFO] [stderr] 184 | | [INFO] [stderr] 185 | | MessageClass::Request(RequestType::Get) => 0x01, [INFO] [stderr] ... | [INFO] [stderr] 214 | | _ => 0xFF, [INFO] [stderr] 215 | | } as u8; [INFO] [stderr] | |____________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 182 | match *class { [INFO] [stderr] 183 | MessageClass::Empty => 0x00, [INFO] [stderr] 184 | [INFO] [stderr] 185 | MessageClass::Request(RequestType::Get) => 0x01, [INFO] [stderr] 186 | MessageClass::Request(RequestType::Post) => 0x02, [INFO] [stderr] 187 | MessageClass::Request(RequestType::Put) => 0x03, [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/message/header.rs:263:5 [INFO] [stderr] | [INFO] [stderr] 263 | return code_to_str(&class_to_code(class)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `code_to_str(&class_to_code(class))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: you should consider adding a `Default` implementation for `message::packet::Packet` [INFO] [stderr] --> src/message/packet.rs:80:5 [INFO] [stderr] | [INFO] [stderr] 80 | / pub fn new() -> Packet { [INFO] [stderr] 81 | | Packet { [INFO] [stderr] 82 | | header: header::Header::new(), [INFO] [stderr] 83 | | token: Vec::new(), [INFO] [stderr] ... | [INFO] [stderr] 86 | | } [INFO] [stderr] 87 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 79 | impl Default for message::packet::Packet { [INFO] [stderr] 80 | fn default() -> Self { [INFO] [stderr] 81 | Self::new() [INFO] [stderr] 82 | } [INFO] [stderr] 83 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/message/packet.rs:95:9 [INFO] [stderr] | [INFO] [stderr] 95 | return &self.token; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `&self.token` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/message/packet.rs:118:9 [INFO] [stderr] | [INFO] [stderr] 118 | / match self.options.get_mut(&num) { [INFO] [stderr] 119 | | Some(list) => { [INFO] [stderr] 120 | | list.push_back(value); [INFO] [stderr] 121 | | return; [INFO] [stderr] 122 | | } [INFO] [stderr] 123 | | None => (), [INFO] [stderr] 124 | | }; [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 118 | if let Some(list) = self.options.get_mut(&num) { [INFO] [stderr] 119 | list.push_back(value); [INFO] [stderr] 120 | return; [INFO] [stderr] 121 | }; [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/message/packet.rs:146:27 [INFO] [stderr] | [INFO] [stderr] 146 | let msb = vector[0] as u16; [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: try: `u16::from(vector[0])` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/message/packet.rs:147:27 [INFO] [stderr] | [INFO] [stderr] 147 | let lsb = vector[1] as u16; [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: try: `u16::from(vector[1])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/message/mod.rs:21:9 [INFO] [stderr] | [INFO] [stderr] 21 | return self.get_message().get_token(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.get_message().get_token()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/message/mod.rs:33:9 [INFO] [stderr] | [INFO] [stderr] 33 | return self.get_message().get_option(tp); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.get_message().get_option(tp)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/message/mod.rs:42:9 [INFO] [stderr] | [INFO] [stderr] 42 | return self.get_message().get_observe(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.get_message().get_observe()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/message/mod.rs:46:9 [INFO] [stderr] | [INFO] [stderr] 46 | return self.get_message().header.get_message_id(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.get_message().header.get_message_id()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/message/mod.rs:55:9 [INFO] [stderr] | [INFO] [stderr] 55 | return self.get_message().header.get_version(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.get_message().header.get_version()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/message/mod.rs:61:9 [INFO] [stderr] | [INFO] [stderr] 61 | return self.get_message().header.get_type(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.get_message().header.get_type()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/message/mod.rs:64:9 [INFO] [stderr] | [INFO] [stderr] 64 | return self.get_message().header.get_code(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.get_message().header.get_code()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/client.rs:159:9 [INFO] [stderr] | [INFO] [stderr] 159 | return Ok(()); [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression [INFO] [stderr] --> src/message/packet.rs:275:17 [INFO] [stderr] | [INFO] [stderr] 275 | / let mut payload = Vec::new(); [INFO] [stderr] 276 | | if idx < buf.len() { [INFO] [stderr] 277 | | payload = buf[(idx + 1)..buf.len()].to_vec(); [INFO] [stderr] 278 | | } [INFO] [stderr] | |_________________^ help: it is more idiomatic to write: `let payload = if idx < buf.len() { buf[(idx + 1)..buf.len()].to_vec() } else { Vec::new() };` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_let_if_seq)] on by default [INFO] [stderr] = note: you might not need `mut` at all [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/client.rs:203:21 [INFO] [stderr] | [INFO] [stderr] 203 | return Ok(receive_packet); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(receive_packet)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/client.rs:205:21 [INFO] [stderr] | [INFO] [stderr] 205 | return Err(Error::new(ErrorKind::Other, "receive invalid data")); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Err(Error::new(ErrorKind::Other, "receive invalid data"))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/client.rs:278:9 [INFO] [stderr] | [INFO] [stderr] 278 | return Ok((host.to_string(), port, path)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok((host.to_string(), port, path))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/client.rs:283:9 [INFO] [stderr] | [INFO] [stderr] 283 | return *message_id; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `*message_id` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/message/packet.rs:11:9 [INFO] [stderr] | [INFO] [stderr] 11 | (0 .. $end - $start + 1).rev().fold(0, |acc, i| acc | $src[$start+i] as $t << i * 8) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `(0..=$end)` [INFO] [stderr] ... [INFO] [stderr] 220 | delta = (u16::from_be(u8_to_unsigned_be!(buf, idx, idx + 1, u16)) + [INFO] [stderr] | ------------------------------------------ in this macro invocation [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::range_plus_one)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/message/packet.rs:11:63 [INFO] [stderr] | [INFO] [stderr] 11 | (0 .. $end - $start + 1).rev().fold(0, |acc, i| acc | $src[$start+i] as $t << i * 8) [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try: `u16::from($src[$start+i])` [INFO] [stderr] ... [INFO] [stderr] 220 | delta = (u16::from_be(u8_to_unsigned_be!(buf, idx, idx + 1, u16)) + [INFO] [stderr] | ------------------------------------------ in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/message/packet.rs:11:9 [INFO] [stderr] | [INFO] [stderr] 11 | (0 .. $end - $start + 1).rev().fold(0, |acc, i| acc | $src[$start+i] as $t << i * 8) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `(0..=$end)` [INFO] [stderr] ... [INFO] [stderr] 245 | length = (u16::from_be(u8_to_unsigned_be!(buf, idx, idx + 1, u16)) + [INFO] [stderr] | ------------------------------------------ in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/message/packet.rs:11:63 [INFO] [stderr] | [INFO] [stderr] 11 | (0 .. $end - $start + 1).rev().fold(0, |acc, i| acc | $src[$start+i] as $t << i * 8) [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try: `u16::from($src[$start+i])` [INFO] [stderr] ... [INFO] [stderr] 245 | length = (u16::from_be(u8_to_unsigned_be!(buf, idx, idx + 1, u16)) + [INFO] [stderr] | ------------------------------------------ in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/server.rs:59:9 [INFO] [stderr] | [INFO] [stderr] 59 | return self(request); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self(request)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/server.rs:163:25 [INFO] [stderr] | [INFO] [stderr] 163 | return Some(CoAPRequest::from_packet(packet, &src)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Some(CoAPRequest::from_packet(packet, &src))` [INFO] [stderr] warning: usage of `contains_key` followed by `insert` on a `BTreeMap` [INFO] [stderr] --> src/message/packet.rs:263:21 [INFO] [stderr] | [INFO] [stderr] 263 | / if options.contains_key(&options_number) { [INFO] [stderr] 264 | | let mut options_list = options.get_mut(&options_number).unwrap(); [INFO] [stderr] 265 | | options_list.push_back(options_value); [INFO] [stderr] 266 | | } else { [INFO] [stderr] ... | [INFO] [stderr] 269 | | options.insert(options_number, list); [INFO] [stderr] 270 | | } [INFO] [stderr] | |_____________________^ help: consider using: `options.entry(options_number)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::map_entry)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_entry [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/server.rs:167:25 [INFO] [stderr] | [INFO] [stderr] 167 | return None; [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `None` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/server.rs:183:33 [INFO] [stderr] | [INFO] [stderr] 183 | Ok(None) => return Err(ResponseError::SocketUnwritable), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Err(ResponseError::SocketUnwritable)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/server.rs:187:25 [INFO] [stderr] | [INFO] [stderr] 187 | return Err(ResponseError::SocketError); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Err(ResponseError::SocketError)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/server.rs:193:17 [INFO] [stderr] | [INFO] [stderr] 193 | return Err(ResponseError::PacketInvalid); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Err(ResponseError::PacketInvalid)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/observer.rs:73:21 [INFO] [stderr] | [INFO] [stderr] 73 | return false; [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove `return` as shown: `false` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/observer.rs:77:21 [INFO] [stderr] | [INFO] [stderr] 77 | return true; [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `true` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/observer.rs:79:22 [INFO] [stderr] | [INFO] [stderr] 79 | _ => return true, [INFO] [stderr] | ^^^^^^^^^^^ help: remove `return` as shown: `true` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/observer.rs:83:17 [INFO] [stderr] | [INFO] [stderr] 83 | return true; [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `true` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/observer.rs:85:18 [INFO] [stderr] | [INFO] [stderr] 85 | _ => return true, [INFO] [stderr] | ^^^^^^^^^^^ help: remove `return` as shown: `true` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/observer.rs:247:9 [INFO] [stderr] | [INFO] [stderr] 247 | return true; [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `true` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/observer.rs:256:17 [INFO] [stderr] | [INFO] [stderr] 256 | return r; [INFO] [stderr] | ^^^^^^^^^ help: remove `return` as shown: `r` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/observer.rs:259:17 [INFO] [stderr] | [INFO] [stderr] 259 | / return v.insert(ResourceItem { [INFO] [stderr] 260 | | payload: payload.clone(), [INFO] [stderr] 261 | | register_resources: HashSet::new(), [INFO] [stderr] 262 | | sequence: 0, [INFO] [stderr] 263 | | }); [INFO] [stderr] | |___________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 259 | v.insert(ResourceItem { [INFO] [stderr] 260 | payload: payload.clone(), [INFO] [stderr] 261 | register_resources: HashSet::new(), [INFO] [stderr] 262 | sequence: 0, [INFO] [stderr] 263 | }) [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/observer.rs:315:9 [INFO] [stderr] | [INFO] [stderr] 315 | return try_again; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `try_again` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: use of `offset` with a `usize` casted to an `isize` [INFO] [stderr] --> src/message/packet.rs:341:31 [INFO] [stderr] | [INFO] [stderr] 341 | options_bytes.as_mut_ptr().offset(buf_len as isize), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `options_bytes.as_mut_ptr().add(buf_len)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_offset_with_cast)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_offset_with_cast [INFO] [stderr] [INFO] [stderr] warning: use of `offset` with a `usize` casted to an `isize` [INFO] [stderr] --> src/message/packet.rs:344:31 [INFO] [stderr] | [INFO] [stderr] 344 | options_bytes.as_mut_ptr().offset((buf_len + header.len()) as isize), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `options_bytes.as_mut_ptr().add((buf_len + header.len()))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_offset_with_cast [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/observer.rs:376:9 [INFO] [stderr] | [INFO] [stderr] 376 | return self.current_message_id; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.current_message_id` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/message/packet.rs:352:63 [INFO] [stderr] | [INFO] [stderr] 352 | if self.header.code != header::MessageClass::Empty && self.payload.len() != 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!self.payload.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: use of `offset` with a `usize` casted to an `isize` [INFO] [stderr] --> src/message/packet.rs:373:31 [INFO] [stderr] | [INFO] [stderr] 373 | buf.as_mut_ptr().offset(buf_len as isize), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `buf.as_mut_ptr().add(buf_len)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_offset_with_cast [INFO] [stderr] [INFO] [stderr] warning: use of `offset` with a `usize` casted to an `isize` [INFO] [stderr] --> src/message/packet.rs:376:31 [INFO] [stderr] | [INFO] [stderr] 376 | buf.as_mut_ptr().offset((buf_len + self.token.len()) as isize), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `buf.as_mut_ptr().add((buf_len + self.token.len()))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_offset_with_cast [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/message/packet.rs:381:71 [INFO] [stderr] | [INFO] [stderr] 381 | if self.header.code != header::MessageClass::Empty && self.payload.len() != 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!self.payload.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: use of `offset` with a `usize` casted to an `isize` [INFO] [stderr] --> src/message/packet.rs:388:35 [INFO] [stderr] | [INFO] [stderr] 388 | buf.as_mut_ptr().offset(buf.len() as isize), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `buf.as_mut_ptr().add(buf.len())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_offset_with_cast [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/client.rs:109:25 [INFO] [stderr] | [INFO] [stderr] 109 | let peer_addr = self.peer_addr.clone(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `self.peer_addr` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/client.rs:164:9 [INFO] [stderr] | [INFO] [stderr] 164 | / match self.observe_sender.take() { [INFO] [stderr] 165 | | Some(ref sender) => { [INFO] [stderr] 166 | | sender.send(ObserveMessage::Terminate).unwrap(); [INFO] [stderr] 167 | | [INFO] [stderr] ... | [INFO] [stderr] 170 | | _ => {} [INFO] [stderr] 171 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 164 | if let Some(ref sender) = self.observe_sender.take() { [INFO] [stderr] 165 | sender.send(ObserveMessage::Terminate).unwrap(); [INFO] [stderr] 166 | [INFO] [stderr] 167 | self.observe_thread.take().map(|g| g.join().unwrap()); [INFO] [stderr] 168 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: called `map(f)` on an Option value where `f` is a unit closure [INFO] [stderr] --> src/client.rs:168:17 [INFO] [stderr] | [INFO] [stderr] 168 | self.observe_thread.take().map(|g| g.join().unwrap()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^- [INFO] [stderr] | | [INFO] [stderr] | help: try this: `if let Some(g) = self.observe_thread.take() { g.join().unwrap() }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::option_map_unit_fn)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_map_unit_fn [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/server.rs:93:9 [INFO] [stderr] | [INFO] [stderr] 93 | / match self.requset_recv() { [INFO] [stderr] 94 | | Some(rqst) => { [INFO] [stderr] 95 | | let filtered = !self.observer.request_handler(&rqst); [INFO] [stderr] 96 | | if filtered { [INFO] [stderr] ... | [INFO] [stderr] 127 | | None => {} [INFO] [stderr] 128 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 93 | if let Some(rqst) = self.requset_recv() { [INFO] [stderr] 94 | let filtered = !self.observer.request_handler(&rqst); [INFO] [stderr] 95 | if filtered { [INFO] [stderr] 96 | return; [INFO] [stderr] 97 | } [INFO] [stderr] 98 | [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/server.rs:206:13 [INFO] [stderr] | [INFO] [stderr] 206 | / match self.response_handler() { [INFO] [stderr] 207 | | true => { [INFO] [stderr] 208 | | event_loop.reregister(&self.socket, Token(0), EventSet::readable(), PollOpt::level()).unwrap(); [INFO] [stderr] 209 | | } [INFO] [stderr] ... | [INFO] [stderr] 212 | | } [INFO] [stderr] 213 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] help: consider using an if/else expression [INFO] [stderr] | [INFO] [stderr] 206 | if self.response_handler() { [INFO] [stderr] 207 | event_loop.reregister(&self.socket, Token(0), EventSet::readable(), PollOpt::level()).unwrap(); [INFO] [stderr] 208 | } else { [INFO] [stderr] 209 | event_loop.reregister(&self.socket, Token(0), EventSet::writable(), PollOpt::edge()).unwrap(); [INFO] [stderr] 210 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_some()` [INFO] [stderr] --> src/server.rs:276:16 [INFO] [stderr] | [INFO] [stderr] 276 | if let Some(_) = self.event_sender { [INFO] [stderr] | _________- ^^^^^^^ [INFO] [stderr] 277 | | error!("Handler already running!"); [INFO] [stderr] 278 | | return Err(CoAPServerError::AnotherHandlerIsRunning); [INFO] [stderr] 279 | | } [INFO] [stderr] | |_________- help: try this: `if self.event_sender.is_some()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_pattern_matching)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/server.rs:329:9 [INFO] [stderr] | [INFO] [stderr] 329 | / match event_sender { [INFO] [stderr] 330 | | Some(ref sender) => { [INFO] [stderr] 331 | | sender.send(EventLoopNotify::Shutdown).unwrap(); [INFO] [stderr] 332 | | self.event_thread.take().map(|g| g.join().unwrap()); [INFO] [stderr] 333 | | } [INFO] [stderr] 334 | | _ => {} [INFO] [stderr] 335 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 329 | if let Some(ref sender) = event_sender { [INFO] [stderr] 330 | sender.send(EventLoopNotify::Shutdown).unwrap(); [INFO] [stderr] 331 | self.event_thread.take().map(|g| g.join().unwrap()); [INFO] [stderr] 332 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: called `map(f)` on an Option value where `f` is a unit closure [INFO] [stderr] --> src/server.rs:332:17 [INFO] [stderr] | [INFO] [stderr] 332 | self.event_thread.take().map(|g| g.join().unwrap()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^- [INFO] [stderr] | | [INFO] [stderr] | help: try this: `if let Some(g) = self.event_thread.take() { g.join().unwrap() }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_map_unit_fn [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/observer.rs:123:24 [INFO] [stderr] | [INFO] [stderr] 123 | let resource = self.resources.get(&resource_path).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&self.resources[&resource_path]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::get_unwrap)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/observer.rs:144:13 [INFO] [stderr] | [INFO] [stderr] 144 | let ref resource_payload = request.message.payload; [INFO] [stderr] | ----^^^^^^^^^^^^^^^^^^^^--------------------------- help: try: `let resource_payload = &request.message.payload;` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::toplevel_ref_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: You are using an explicit closure for cloning elements [INFO] [stderr] --> src/observer.rs:151:38 [INFO] [stderr] | [INFO] [stderr] 151 | register_resource_keys = resource [INFO] [stderr] | ______________________________________^ [INFO] [stderr] 152 | | .register_resources [INFO] [stderr] 153 | | .iter() [INFO] [stderr] 154 | | .map(|k| k.clone()) [INFO] [stderr] | |___________________________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::map_clone)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stderr] help: Consider calling the dedicated `cloned` method [INFO] [stderr] | [INFO] [stderr] 151 | register_resource_keys = resource [INFO] [stderr] 152 | .register_resources [INFO] [stderr] 153 | .iter().cloned() [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/observer.rs:169:72 [INFO] [stderr] | [INFO] [stderr] 169 | fn record_register_resource(&mut self, address: &SocketAddr, path: &String, token: &Vec) { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/observer.rs:169:88 [INFO] [stderr] | [INFO] [stderr] 169 | fn record_register_resource(&mut self, address: &SocketAddr, path: &String, token: &Vec) { [INFO] [stderr] | ^^^^^^^^ help: change this to: `&[u8]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/observer.rs:206:15 [INFO] [stderr] | [INFO] [stderr] 206 | path: &String, [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/observer.rs:207:16 [INFO] [stderr] | [INFO] [stderr] 207 | token: &Vec, [INFO] [stderr] | ^^^^^^^^ help: change this to: `&[u8]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/observer.rs:238:35 [INFO] [stderr] | [INFO] [stderr] 238 | remove_register = register.register_resources.len() == 0; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `register.register_resources.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/observer.rs:250:41 [INFO] [stderr] | [INFO] [stderr] 250 | fn record_resource(&mut self, path: &String, payload: &Vec) -> &ResourceItem { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/observer.rs:250:59 [INFO] [stderr] | [INFO] [stderr] 250 | fn record_resource(&mut self, path: &String, payload: &Vec) -> &ResourceItem { [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] help: change this to [INFO] [stderr] | [INFO] [stderr] 250 | fn record_resource(&mut self, path: &String, payload: &[u8]) -> &ResourceItem { [INFO] [stderr] | ^^^^^ [INFO] [stderr] help: change `payload.clone()` to [INFO] [stderr] | [INFO] [stderr] 255 | r.payload = payload.to_owned(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/observer.rs:268:71 [INFO] [stderr] | [INFO] [stderr] 268 | fn record_unacknowledge_message(&mut self, register_resource_key: &String) { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/observer.rs:288:68 [INFO] [stderr] | [INFO] [stderr] 288 | fn try_unacknowledge_message(&mut self, register_resource_key: &String) -> bool { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/observer.rs:292:13 [INFO] [stderr] | [INFO] [stderr] 292 | let ref message_id = register_resource.unacknowledge_message.unwrap(); [INFO] [stderr] | ----^^^^^^^^^^^^^^---------------------------------------------------- help: try: `let message_id = ®ister_resource.unacknowledge_message.unwrap();` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/observer.rs:318:73 [INFO] [stderr] | [INFO] [stderr] 318 | fn remove_unacknowledge_message(&mut self, message_id: &u16, token: &Vec) { [INFO] [stderr] | ^^^^^^^^ help: change this to: `&[u8]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/observer.rs:318:60 [INFO] [stderr] | [INFO] [stderr] 318 | fn remove_unacknowledge_message(&mut self, message_id: &u16, token: &Vec) { [INFO] [stderr] | ^^^^ help: consider passing by value instead: `u16` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/observer.rs:333:75 [INFO] [stderr] | [INFO] [stderr] 333 | fn notify_register_with_newest_resource(&self, register_resource_key: &String) { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/observer.rs:338:13 [INFO] [stderr] | [INFO] [stderr] 338 | let ref mut message = Packet::new(); [INFO] [stderr] | ----^^^^^^^^^^^^^^^----------------- help: try: `let message = &mut Packet::new();` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/observer.rs:344:37 [INFO] [stderr] | [INFO] [stderr] 344 | let register_resource = self.register_resources.get(register_resource_key).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&self.register_resources[register_resource_key]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/observer.rs:345:28 [INFO] [stderr] | [INFO] [stderr] 345 | let resource = self.resources.get(®ister_resource.resource).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&self.resources[®ister_resource.resource]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/observer.rs:383:61 [INFO] [stderr] | [INFO] [stderr] 383 | fn format_register_resource(address: &SocketAddr, path: &String) -> String { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: you should consider adding a `Default` implementation for `message::header::Header` [INFO] [stderr] --> src/message/header.rs:84:5 [INFO] [stderr] | [INFO] [stderr] 84 | / pub fn new() -> Header { [INFO] [stderr] 85 | | return Header::from_raw(&HeaderRaw::default()); [INFO] [stderr] 86 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 83 | impl Default for message::header::Header { [INFO] [stderr] 84 | fn default() -> Self { [INFO] [stderr] 85 | Self::new() [INFO] [stderr] 86 | } [INFO] [stderr] 87 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: the function has a cyclomatic complexity of 27 [INFO] [stderr] --> src/message/header.rs:181:1 [INFO] [stderr] | [INFO] [stderr] 181 | / pub fn class_to_code(class: &MessageClass) -> u8 { [INFO] [stderr] 182 | | return match *class { [INFO] [stderr] 183 | | MessageClass::Empty => 0x00, [INFO] [stderr] 184 | | [INFO] [stderr] ... | [INFO] [stderr] 215 | | } as u8; [INFO] [stderr] 216 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cyclomatic_complexity)] on by default [INFO] [stderr] = help: you could split it up into multiple smaller functions [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cyclomatic_complexity [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/message/header.rs:218:28 [INFO] [stderr] | [INFO] [stderr] 218 | pub fn code_to_class(code: &u8) -> MessageClass { [INFO] [stderr] | ^^^ help: consider passing by value instead: `u8` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/message/header.rs:255:26 [INFO] [stderr] | [INFO] [stderr] 255 | pub fn code_to_str(code: &u8) -> String { [INFO] [stderr] | ^^^ help: consider passing by value instead: `u8` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: you should consider adding a `Default` implementation for `message::request::CoAPRequest` [INFO] [stderr] --> src/message/request.rs:18:5 [INFO] [stderr] | [INFO] [stderr] 18 | / pub fn new() -> CoAPRequest { [INFO] [stderr] 19 | | CoAPRequest { [INFO] [stderr] 20 | | response: None, [INFO] [stderr] 21 | | message: Packet::new(), [INFO] [stderr] 22 | | source: None, [INFO] [stderr] 23 | | } [INFO] [stderr] 24 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 17 | impl Default for message::request::CoAPRequest { [INFO] [stderr] 18 | fn default() -> Self { [INFO] [stderr] 19 | Self::new() [INFO] [stderr] 20 | } [INFO] [stderr] 21 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/message/request.rs:30:26 [INFO] [stderr] | [INFO] [stderr] 30 | source: Some(source.clone()), [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try dereferencing it: `*source` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/message/request.rs:51:31 [INFO] [stderr] | [INFO] [stderr] 51 | let segs = path.split("/"); [INFO] [stderr] | ^^^ help: try using a char instead: `'/'` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/message/request.rs:53:16 [INFO] [stderr] | [INFO] [stderr] 53 | if s.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `s.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: you should consider adding a `Default` implementation for `message::packet::Packet` [INFO] [stderr] --> src/message/packet.rs:80:5 [INFO] [stderr] | [INFO] [stderr] 80 | / pub fn new() -> Packet { [INFO] [stderr] 81 | | Packet { [INFO] [stderr] 82 | | header: header::Header::new(), [INFO] [stderr] 83 | | token: Vec::new(), [INFO] [stderr] ... | [INFO] [stderr] 86 | | } [INFO] [stderr] 87 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 79 | impl Default for message::packet::Packet { [INFO] [stderr] 80 | fn default() -> Self { [INFO] [stderr] 81 | Self::new() [INFO] [stderr] 82 | } [INFO] [stderr] 83 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/message/packet.rs:118:9 [INFO] [stderr] | [INFO] [stderr] 118 | / match self.options.get_mut(&num) { [INFO] [stderr] 119 | | Some(list) => { [INFO] [stderr] 120 | | list.push_back(value); [INFO] [stderr] 121 | | return; [INFO] [stderr] 122 | | } [INFO] [stderr] 123 | | None => (), [INFO] [stderr] 124 | | }; [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 118 | if let Some(list) = self.options.get_mut(&num) { [INFO] [stderr] 119 | list.push_back(value); [INFO] [stderr] 120 | return; [INFO] [stderr] 121 | }; [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/message/packet.rs:146:27 [INFO] [stderr] | [INFO] [stderr] 146 | let msb = vector[0] as u16; [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: try: `u16::from(vector[0])` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/message/packet.rs:147:27 [INFO] [stderr] | [INFO] [stderr] 147 | let lsb = vector[1] as u16; [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: try: `u16::from(vector[1])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression [INFO] [stderr] --> src/message/packet.rs:275:17 [INFO] [stderr] | [INFO] [stderr] 275 | / let mut payload = Vec::new(); [INFO] [stderr] 276 | | if idx < buf.len() { [INFO] [stderr] 277 | | payload = buf[(idx + 1)..buf.len()].to_vec(); [INFO] [stderr] 278 | | } [INFO] [stderr] | |_________________^ help: it is more idiomatic to write: `let payload = if idx < buf.len() { buf[(idx + 1)..buf.len()].to_vec() } else { Vec::new() };` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_let_if_seq)] on by default [INFO] [stderr] = note: you might not need `mut` at all [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/message/packet.rs:11:9 [INFO] [stderr] | [INFO] [stderr] 11 | (0 .. $end - $start + 1).rev().fold(0, |acc, i| acc | $src[$start+i] as $t << i * 8) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `(0..=$end)` [INFO] [stderr] ... [INFO] [stderr] 220 | delta = (u16::from_be(u8_to_unsigned_be!(buf, idx, idx + 1, u16)) + [INFO] [stderr] | ------------------------------------------ in this macro invocation [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::range_plus_one)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/message/packet.rs:11:63 [INFO] [stderr] | [INFO] [stderr] 11 | (0 .. $end - $start + 1).rev().fold(0, |acc, i| acc | $src[$start+i] as $t << i * 8) [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try: `u16::from($src[$start+i])` [INFO] [stderr] ... [INFO] [stderr] 220 | delta = (u16::from_be(u8_to_unsigned_be!(buf, idx, idx + 1, u16)) + [INFO] [stderr] | ------------------------------------------ in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/message/packet.rs:11:9 [INFO] [stderr] | [INFO] [stderr] 11 | (0 .. $end - $start + 1).rev().fold(0, |acc, i| acc | $src[$start+i] as $t << i * 8) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `(0..=$end)` [INFO] [stderr] ... [INFO] [stderr] 245 | length = (u16::from_be(u8_to_unsigned_be!(buf, idx, idx + 1, u16)) + [INFO] [stderr] | ------------------------------------------ in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/message/packet.rs:11:63 [INFO] [stderr] | [INFO] [stderr] 11 | (0 .. $end - $start + 1).rev().fold(0, |acc, i| acc | $src[$start+i] as $t << i * 8) [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try: `u16::from($src[$start+i])` [INFO] [stderr] ... [INFO] [stderr] 245 | length = (u16::from_be(u8_to_unsigned_be!(buf, idx, idx + 1, u16)) + [INFO] [stderr] | ------------------------------------------ in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: usage of `contains_key` followed by `insert` on a `BTreeMap` [INFO] [stderr] --> src/message/packet.rs:263:21 [INFO] [stderr] | [INFO] [stderr] 263 | / if options.contains_key(&options_number) { [INFO] [stderr] 264 | | let mut options_list = options.get_mut(&options_number).unwrap(); [INFO] [stderr] 265 | | options_list.push_back(options_value); [INFO] [stderr] 266 | | } else { [INFO] [stderr] ... | [INFO] [stderr] 269 | | options.insert(options_number, list); [INFO] [stderr] 270 | | } [INFO] [stderr] | |_____________________^ help: consider using: `options.entry(options_number)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::map_entry)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_entry [INFO] [stderr] [INFO] [stderr] warning: use of `offset` with a `usize` casted to an `isize` [INFO] [stderr] --> src/message/packet.rs:341:31 [INFO] [stderr] | [INFO] [stderr] 341 | options_bytes.as_mut_ptr().offset(buf_len as isize), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `options_bytes.as_mut_ptr().add(buf_len)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_offset_with_cast)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_offset_with_cast [INFO] [stderr] [INFO] [stderr] warning: use of `offset` with a `usize` casted to an `isize` [INFO] [stderr] --> src/message/packet.rs:344:31 [INFO] [stderr] | [INFO] [stderr] 344 | options_bytes.as_mut_ptr().offset((buf_len + header.len()) as isize), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `options_bytes.as_mut_ptr().add((buf_len + header.len()))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_offset_with_cast [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/message/packet.rs:352:63 [INFO] [stderr] | [INFO] [stderr] 352 | if self.header.code != header::MessageClass::Empty && self.payload.len() != 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!self.payload.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: use of `offset` with a `usize` casted to an `isize` [INFO] [stderr] --> src/message/packet.rs:373:31 [INFO] [stderr] | [INFO] [stderr] 373 | buf.as_mut_ptr().offset(buf_len as isize), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `buf.as_mut_ptr().add(buf_len)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_offset_with_cast [INFO] [stderr] [INFO] [stderr] warning: use of `offset` with a `usize` casted to an `isize` [INFO] [stderr] --> src/message/packet.rs:376:31 [INFO] [stderr] | [INFO] [stderr] 376 | buf.as_mut_ptr().offset((buf_len + self.token.len()) as isize), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `buf.as_mut_ptr().add((buf_len + self.token.len()))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_offset_with_cast [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/message/packet.rs:381:71 [INFO] [stderr] | [INFO] [stderr] 381 | if self.header.code != header::MessageClass::Empty && self.payload.len() != 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!self.payload.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: use of `offset` with a `usize` casted to an `isize` [INFO] [stderr] --> src/message/packet.rs:388:35 [INFO] [stderr] | [INFO] [stderr] 388 | buf.as_mut_ptr().offset(buf.len() as isize), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `buf.as_mut_ptr().add(buf.len())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_offset_with_cast [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/message/packet.rs:449:37 [INFO] [stderr] | [INFO] [stderr] 449 | expected_uri_path.push_back("Hi".as_bytes().to_vec()); [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"Hi"` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::string_lit_as_bytes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/message/packet.rs:450:37 [INFO] [stderr] | [INFO] [stderr] 450 | expected_uri_path.push_back("Test".as_bytes().to_vec()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"Test"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/message/packet.rs:457:38 [INFO] [stderr] | [INFO] [stderr] 457 | expected_uri_query.push_back("a=1".as_bytes().to_vec()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"a=1"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/message/packet.rs:476:36 [INFO] [stderr] | [INFO] [stderr] 476 | assert_eq!(packet.payload, "Hello".as_bytes().to_vec()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"Hello"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/message/packet.rs:503:26 [INFO] [stderr] | [INFO] [stderr] 503 | packet.payload = "Hello".as_bytes().to_vec(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"Hello"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/client.rs:109:25 [INFO] [stderr] | [INFO] [stderr] 109 | let peer_addr = self.peer_addr.clone(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `self.peer_addr` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/client.rs:164:9 [INFO] [stderr] | [INFO] [stderr] 164 | / match self.observe_sender.take() { [INFO] [stderr] 165 | | Some(ref sender) => { [INFO] [stderr] 166 | | sender.send(ObserveMessage::Terminate).unwrap(); [INFO] [stderr] 167 | | [INFO] [stderr] ... | [INFO] [stderr] 170 | | _ => {} [INFO] [stderr] 171 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 164 | if let Some(ref sender) = self.observe_sender.take() { [INFO] [stderr] 165 | sender.send(ObserveMessage::Terminate).unwrap(); [INFO] [stderr] 166 | [INFO] [stderr] 167 | self.observe_thread.take().map(|g| g.join().unwrap()); [INFO] [stderr] 168 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: called `map(f)` on an Option value where `f` is a unit closure [INFO] [stderr] --> src/client.rs:168:17 [INFO] [stderr] | [INFO] [stderr] 168 | self.observe_thread.take().map(|g| g.join().unwrap()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^- [INFO] [stderr] | | [INFO] [stderr] | help: try this: `if let Some(g) = self.observe_thread.take() { g.join().unwrap() }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::option_map_unit_fn)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_map_unit_fn [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/server.rs:93:9 [INFO] [stderr] | [INFO] [stderr] 93 | / match self.requset_recv() { [INFO] [stderr] 94 | | Some(rqst) => { [INFO] [stderr] 95 | | let filtered = !self.observer.request_handler(&rqst); [INFO] [stderr] 96 | | if filtered { [INFO] [stderr] ... | [INFO] [stderr] 127 | | None => {} [INFO] [stderr] 128 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 93 | if let Some(rqst) = self.requset_recv() { [INFO] [stderr] 94 | let filtered = !self.observer.request_handler(&rqst); [INFO] [stderr] 95 | if filtered { [INFO] [stderr] 96 | return; [INFO] [stderr] 97 | } [INFO] [stderr] 98 | [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/server.rs:206:13 [INFO] [stderr] | [INFO] [stderr] 206 | / match self.response_handler() { [INFO] [stderr] 207 | | true => { [INFO] [stderr] 208 | | event_loop.reregister(&self.socket, Token(0), EventSet::readable(), PollOpt::level()).unwrap(); [INFO] [stderr] 209 | | } [INFO] [stderr] ... | [INFO] [stderr] 212 | | } [INFO] [stderr] 213 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] help: consider using an if/else expression [INFO] [stderr] | [INFO] [stderr] 206 | if self.response_handler() { [INFO] [stderr] 207 | event_loop.reregister(&self.socket, Token(0), EventSet::readable(), PollOpt::level()).unwrap(); [INFO] [stderr] 208 | } else { [INFO] [stderr] 209 | event_loop.reregister(&self.socket, Token(0), EventSet::writable(), PollOpt::edge()).unwrap(); [INFO] [stderr] 210 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_some()` [INFO] [stderr] --> src/server.rs:276:16 [INFO] [stderr] | [INFO] [stderr] 276 | if let Some(_) = self.event_sender { [INFO] [stderr] | _________- ^^^^^^^ [INFO] [stderr] 277 | | error!("Handler already running!"); [INFO] [stderr] 278 | | return Err(CoAPServerError::AnotherHandlerIsRunning); [INFO] [stderr] 279 | | } [INFO] [stderr] | |_________- help: try this: `if self.event_sender.is_some()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_pattern_matching)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/server.rs:329:9 [INFO] [stderr] | [INFO] [stderr] 329 | / match event_sender { [INFO] [stderr] 330 | | Some(ref sender) => { [INFO] [stderr] 331 | | sender.send(EventLoopNotify::Shutdown).unwrap(); [INFO] [stderr] 332 | | self.event_thread.take().map(|g| g.join().unwrap()); [INFO] [stderr] 333 | | } [INFO] [stderr] 334 | | _ => {} [INFO] [stderr] 335 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 329 | if let Some(ref sender) = event_sender { [INFO] [stderr] 330 | sender.send(EventLoopNotify::Shutdown).unwrap(); [INFO] [stderr] 331 | self.event_thread.take().map(|g| g.join().unwrap()); [INFO] [stderr] 332 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: called `map(f)` on an Option value where `f` is a unit closure [INFO] [stderr] --> src/server.rs:332:17 [INFO] [stderr] | [INFO] [stderr] 332 | self.event_thread.take().map(|g| g.join().unwrap()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^- [INFO] [stderr] | | [INFO] [stderr] | help: try this: `if let Some(g) = self.event_thread.take() { g.join().unwrap() }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_map_unit_fn [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/observer.rs:123:24 [INFO] [stderr] | [INFO] [stderr] 123 | let resource = self.resources.get(&resource_path).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&self.resources[&resource_path]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::get_unwrap)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/observer.rs:144:13 [INFO] [stderr] | [INFO] [stderr] 144 | let ref resource_payload = request.message.payload; [INFO] [stderr] | ----^^^^^^^^^^^^^^^^^^^^--------------------------- help: try: `let resource_payload = &request.message.payload;` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::toplevel_ref_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: You are using an explicit closure for cloning elements [INFO] [stderr] --> src/observer.rs:151:38 [INFO] [stderr] | [INFO] [stderr] 151 | register_resource_keys = resource [INFO] [stderr] | ______________________________________^ [INFO] [stderr] 152 | | .register_resources [INFO] [stderr] 153 | | .iter() [INFO] [stderr] 154 | | .map(|k| k.clone()) [INFO] [stderr] | |___________________________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::map_clone)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stderr] help: Consider calling the dedicated `cloned` method [INFO] [stderr] | [INFO] [stderr] 151 | register_resource_keys = resource [INFO] [stderr] 152 | .register_resources [INFO] [stderr] 153 | .iter().cloned() [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/observer.rs:169:72 [INFO] [stderr] | [INFO] [stderr] 169 | fn record_register_resource(&mut self, address: &SocketAddr, path: &String, token: &Vec) { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/observer.rs:169:88 [INFO] [stderr] | [INFO] [stderr] 169 | fn record_register_resource(&mut self, address: &SocketAddr, path: &String, token: &Vec) { [INFO] [stderr] | ^^^^^^^^ help: change this to: `&[u8]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/observer.rs:206:15 [INFO] [stderr] | [INFO] [stderr] 206 | path: &String, [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/observer.rs:207:16 [INFO] [stderr] | [INFO] [stderr] 207 | token: &Vec, [INFO] [stderr] | ^^^^^^^^ help: change this to: `&[u8]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/observer.rs:238:35 [INFO] [stderr] | [INFO] [stderr] 238 | remove_register = register.register_resources.len() == 0; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `register.register_resources.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/observer.rs:250:41 [INFO] [stderr] | [INFO] [stderr] 250 | fn record_resource(&mut self, path: &String, payload: &Vec) -> &ResourceItem { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/observer.rs:250:59 [INFO] [stderr] | [INFO] [stderr] 250 | fn record_resource(&mut self, path: &String, payload: &Vec) -> &ResourceItem { [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] help: change this to [INFO] [stderr] | [INFO] [stderr] 250 | fn record_resource(&mut self, path: &String, payload: &[u8]) -> &ResourceItem { [INFO] [stderr] | ^^^^^ [INFO] [stderr] help: change `payload.clone()` to [INFO] [stderr] | [INFO] [stderr] 255 | r.payload = payload.to_owned(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/observer.rs:268:71 [INFO] [stderr] | [INFO] [stderr] 268 | fn record_unacknowledge_message(&mut self, register_resource_key: &String) { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/observer.rs:288:68 [INFO] [stderr] | [INFO] [stderr] 288 | fn try_unacknowledge_message(&mut self, register_resource_key: &String) -> bool { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/observer.rs:292:13 [INFO] [stderr] | [INFO] [stderr] 292 | let ref message_id = register_resource.unacknowledge_message.unwrap(); [INFO] [stderr] | ----^^^^^^^^^^^^^^---------------------------------------------------- help: try: `let message_id = ®ister_resource.unacknowledge_message.unwrap();` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/observer.rs:318:73 [INFO] [stderr] | [INFO] [stderr] 318 | fn remove_unacknowledge_message(&mut self, message_id: &u16, token: &Vec) { [INFO] [stderr] | ^^^^^^^^ help: change this to: `&[u8]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/observer.rs:318:60 [INFO] [stderr] | [INFO] [stderr] 318 | fn remove_unacknowledge_message(&mut self, message_id: &u16, token: &Vec) { [INFO] [stderr] | ^^^^ help: consider passing by value instead: `u16` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/observer.rs:333:75 [INFO] [stderr] | [INFO] [stderr] 333 | fn notify_register_with_newest_resource(&self, register_resource_key: &String) { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/observer.rs:338:13 [INFO] [stderr] | [INFO] [stderr] 338 | let ref mut message = Packet::new(); [INFO] [stderr] | ----^^^^^^^^^^^^^^^----------------- help: try: `let message = &mut Packet::new();` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/observer.rs:344:37 [INFO] [stderr] | [INFO] [stderr] 344 | let register_resource = self.register_resources.get(register_resource_key).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&self.register_resources[register_resource_key]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/observer.rs:345:28 [INFO] [stderr] | [INFO] [stderr] 345 | let resource = self.resources.get(®ister_resource.resource).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&self.resources[®ister_resource.resource]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/observer.rs:383:61 [INFO] [stderr] | [INFO] [stderr] 383 | fn format_register_resource(address: &SocketAddr, path: &String) -> String { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/observer.rs:402:9 [INFO] [stderr] | [INFO] [stderr] 402 | / match req.get_method() { [INFO] [stderr] 403 | | &Method::Get => { [INFO] [stderr] 404 | | let observe_option = req.get_observe().unwrap(); [INFO] [stderr] 405 | | assert_eq!(observe_option[0], ObserveOption::Deregister as u8); [INFO] [stderr] ... | [INFO] [stderr] 408 | | _ => panic!("unexpected request"), [INFO] [stderr] 409 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 402 | match *req.get_method() { [INFO] [stderr] 403 | Method::Get => { [INFO] [stderr] 404 | let observe_option = req.get_observe().unwrap(); [INFO] [stderr] 405 | assert_eq!(observe_option[0], ObserveOption::Deregister as u8); [INFO] [stderr] 406 | } [INFO] [stderr] 407 | Method::Put => {} [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/observer.rs:447:13 [INFO] [stderr] | [INFO] [stderr] 447 | / match rx.try_recv() { [INFO] [stderr] 448 | | Ok(n) => receive_step = n, [INFO] [stderr] 449 | | _ => (), [INFO] [stderr] 450 | | } [INFO] [stderr] | |_____________^ help: try this: `if let Ok(n) = rx.try_recv() { receive_step = n }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] error[E0554]: #![feature] may not be used on the stable release channel [INFO] [stderr] --> benches/client.rs:1:1 [INFO] [stderr] | [INFO] [stderr] 1 | #![feature(test)] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] For more information about this error, try `rustc --explain E0554`. [INFO] [stderr] error: Could not compile `coap`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> examples/client_and_server.rs:9:5 [INFO] [stderr] | [INFO] [stderr] 9 | / return match request.response { [INFO] [stderr] 10 | | Some(mut response) => { [INFO] [stderr] 11 | | response.set_payload(uri_path.as_bytes().to_vec()); [INFO] [stderr] 12 | | Some(response) [INFO] [stderr] 13 | | } [INFO] [stderr] 14 | | _ => None, [INFO] [stderr] 15 | | }; [INFO] [stderr] | |______^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 9 | match request.response { [INFO] [stderr] 10 | Some(mut response) => { [INFO] [stderr] 11 | response.set_payload(uri_path.as_bytes().to_vec()); [INFO] [stderr] 12 | Some(response) [INFO] [stderr] 13 | } [INFO] [stderr] 14 | _ => None, [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> examples/server.rs:14:2 [INFO] [stderr] | [INFO] [stderr] 14 | return match request.response { [INFO] [stderr] | _____^ [INFO] [stderr] 15 | | Some(mut message) => { [INFO] [stderr] 16 | | message.set_payload(b"OK".to_vec()); [INFO] [stderr] 17 | | Some(message) [INFO] [stderr] 18 | | }, [INFO] [stderr] 19 | | _ => None [INFO] [stderr] 20 | | }; [INFO] [stderr] | |______^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 14 | match request.response { [INFO] [stderr] 15 | Some(mut message) => { [INFO] [stderr] 16 | message.set_payload(b"OK".to_vec()); [INFO] [stderr] 17 | Some(message) [INFO] [stderr] 18 | }, [INFO] [stderr] 19 | _ => None [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> examples/server.rs:7:2 [INFO] [stderr] | [INFO] [stderr] 7 | match request.get_method() { [INFO] [stderr] | _____^ [INFO] [stderr] 8 | | &Method::Get => println!("request by get {}", request.get_path()), [INFO] [stderr] 9 | | &Method::Post => println!("request by post {}", String::from_utf8(request.message.payload).unwrap()), [INFO] [stderr] 10 | | &Method::Put => println!("request by put {}", String::from_utf8(request.message.payload).unwrap()), [INFO] [stderr] 11 | | _ => println!("request by other method"), [INFO] [stderr] 12 | | }; [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 7 | match *request.get_method() { [INFO] [stderr] 8 | Method::Get => println!("request by get {}", request.get_path()), [INFO] [stderr] 9 | Method::Post => println!("request by post {}", String::from_utf8(request.message.payload).unwrap()), [INFO] [stderr] 10 | Method::Put => println!("request by put {}", String::from_utf8(request.message.payload).unwrap()), [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] error: build failed [INFO] running `"docker" "inspect" "00b8b8ce0b90c965f1aa1b4bb65996f7c823c82cb184706dd710e1305442463b"` [INFO] running `"docker" "rm" "-f" "00b8b8ce0b90c965f1aa1b4bb65996f7c823c82cb184706dd710e1305442463b"` [INFO] [stdout] 00b8b8ce0b90c965f1aa1b4bb65996f7c823c82cb184706dd710e1305442463b