[INFO] crate coalescing_buffer 0.0.3 is already in cache [INFO] extracting crate coalescing_buffer 0.0.3 into work/ex/clippy-test-run/sources/stable/reg/coalescing_buffer/0.0.3 [INFO] extracting crate coalescing_buffer 0.0.3 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/coalescing_buffer/0.0.3 [INFO] validating manifest of coalescing_buffer-0.0.3 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of coalescing_buffer-0.0.3 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing coalescing_buffer-0.0.3 [INFO] finished frobbing coalescing_buffer-0.0.3 [INFO] frobbed toml for coalescing_buffer-0.0.3 written to work/ex/clippy-test-run/sources/stable/reg/coalescing_buffer/0.0.3/Cargo.toml [INFO] started frobbing coalescing_buffer-0.0.3 [INFO] finished frobbing coalescing_buffer-0.0.3 [INFO] frobbed toml for coalescing_buffer-0.0.3 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/coalescing_buffer/0.0.3/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting coalescing_buffer-0.0.3 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-7/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/coalescing_buffer/0.0.3:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 6818fa09a13896dcf2955611b203d8fef6165e0ad22ef4357a22f37337e9340a [INFO] running `"docker" "start" "-a" "6818fa09a13896dcf2955611b203d8fef6165e0ad22ef4357a22f37337e9340a"` [INFO] [stderr] Checking coalescing_buffer v0.0.3 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/ring/spsc_coalescing_ring_buffer.rs:86:13 [INFO] [stderr] | [INFO] [stderr] 86 | keys: keys, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `keys` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/ring/spsc_coalescing_ring_buffer.rs:87:13 [INFO] [stderr] | [INFO] [stderr] 87 | values: values, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `values` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/ring/spsc_coalescing_ring_buffer.rs:352:17 [INFO] [stderr] | [INFO] [stderr] 352 | instrument_id: instrument_id, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `instrument_id` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/ring/spsc_coalescing_ring_buffer.rs:86:13 [INFO] [stderr] | [INFO] [stderr] 86 | keys: keys, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `keys` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/ring/spsc_coalescing_ring_buffer.rs:87:13 [INFO] [stderr] | [INFO] [stderr] 87 | values: values, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `values` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/ring/spsc_coalescing_ring_buffer.rs:352:17 [INFO] [stderr] | [INFO] [stderr] 352 | instrument_id: instrument_id, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `instrument_id` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/ring/spsc_coalescing_ring_buffer.rs:58:5 [INFO] [stderr] | [INFO] [stderr] 58 | return v; [INFO] [stderr] | ^^^^^^^^^ help: remove `return` as shown: `v` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/ring/spsc_coalescing_ring_buffer.rs:106:9 [INFO] [stderr] | [INFO] [stderr] 106 | return self.capacity; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.capacity` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/ring/spsc_coalescing_ring_buffer.rs:110:9 [INFO] [stderr] | [INFO] [stderr] 110 | return self.rejection_count.load(Ordering::SeqCst); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.rejection_count.load(Ordering::SeqCst)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/ring/spsc_coalescing_ring_buffer.rs:114:9 [INFO] [stderr] | [INFO] [stderr] 114 | return self.next_write.load(Ordering::SeqCst); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.next_write.load(Ordering::SeqCst)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/ring/spsc_coalescing_ring_buffer.rs:118:9 [INFO] [stderr] | [INFO] [stderr] 118 | return self.first_write.load(Ordering::SeqCst); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.first_write.load(Ordering::SeqCst)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/ring/spsc_coalescing_ring_buffer.rs:122:9 [INFO] [stderr] | [INFO] [stderr] 122 | return self.first_write.load(Ordering::SeqCst) == self.next_write.load(Ordering::SeqCst); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.first_write.load(Ordering::SeqCst) == self.next_write.load(Ordering::SeqCst)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/ring/spsc_coalescing_ring_buffer.rs:126:9 [INFO] [stderr] | [INFO] [stderr] 126 | return self.size() == self.capacity; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.size() == self.capacity` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/ring/spsc_coalescing_ring_buffer.rs:148:9 [INFO] [stderr] | [INFO] [stderr] 148 | return self.add(key_type, val_ptr); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.add(key_type, val_ptr)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/ring/spsc_coalescing_ring_buffer.rs:152:9 [INFO] [stderr] | [INFO] [stderr] 152 | return self.add(KeyHolder::NonCollapsible, Box::into_raw(Box::new(value))); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.add(KeyHolder::NonCollapsible, Box::into_raw(Box::new(value)))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/ring/spsc_coalescing_ring_buffer.rs:162:9 [INFO] [stderr] | [INFO] [stderr] 162 | return true; [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `true` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/ring/spsc_coalescing_ring_buffer.rs:193:9 [INFO] [stderr] | [INFO] [stderr] 193 | return self.fill(total_to_poll); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.fill(total_to_poll)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/ring/spsc_coalescing_ring_buffer.rs:201:9 [INFO] [stderr] | [INFO] [stderr] 201 | return self.fill(claim_up_to); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.fill(claim_up_to)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/ring/spsc_coalescing_ring_buffer.rs:221:9 [INFO] [stderr] | [INFO] [stderr] 221 | return bucket; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `bucket` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/ring/spsc_coalescing_ring_buffer.rs:225:9 [INFO] [stderr] | [INFO] [stderr] 225 | return value & self.mask; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `value & self.mask` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/ring/spsc_coalescing_ring_buffer.rs:260:9 [INFO] [stderr] | [INFO] [stderr] 260 | return self.buffer.poll_all(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.buffer.poll_all()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/ring/spsc_coalescing_ring_buffer.rs:264:9 [INFO] [stderr] | [INFO] [stderr] 264 | return self.buffer.poll(max_items); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.buffer.poll(max_items)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/ring/spsc_coalescing_ring_buffer.rs:289:9 [INFO] [stderr] | [INFO] [stderr] 289 | return self.buffer.offer(key, value); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.buffer.offer(key, value)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/ring/spsc_coalescing_ring_buffer.rs:293:9 [INFO] [stderr] | [INFO] [stderr] 293 | return self.buffer.offer_value_only(value); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.buffer.offer_value_only(value)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/ring/spsc_coalescing_ring_buffer.rs:58:5 [INFO] [stderr] | [INFO] [stderr] 58 | return v; [INFO] [stderr] | ^^^^^^^^^ help: remove `return` as shown: `v` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/ring/spsc_coalescing_ring_buffer.rs:106:9 [INFO] [stderr] | [INFO] [stderr] 106 | return self.capacity; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.capacity` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/ring/spsc_coalescing_ring_buffer.rs:110:9 [INFO] [stderr] | [INFO] [stderr] 110 | return self.rejection_count.load(Ordering::SeqCst); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.rejection_count.load(Ordering::SeqCst)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/ring/spsc_coalescing_ring_buffer.rs:114:9 [INFO] [stderr] | [INFO] [stderr] 114 | return self.next_write.load(Ordering::SeqCst); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.next_write.load(Ordering::SeqCst)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/ring/spsc_coalescing_ring_buffer.rs:118:9 [INFO] [stderr] | [INFO] [stderr] 118 | return self.first_write.load(Ordering::SeqCst); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.first_write.load(Ordering::SeqCst)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/ring/spsc_coalescing_ring_buffer.rs:122:9 [INFO] [stderr] | [INFO] [stderr] 122 | return self.first_write.load(Ordering::SeqCst) == self.next_write.load(Ordering::SeqCst); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.first_write.load(Ordering::SeqCst) == self.next_write.load(Ordering::SeqCst)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/ring/spsc_coalescing_ring_buffer.rs:126:9 [INFO] [stderr] | [INFO] [stderr] 126 | return self.size() == self.capacity; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.size() == self.capacity` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/ring/spsc_coalescing_ring_buffer.rs:148:9 [INFO] [stderr] | [INFO] [stderr] 148 | return self.add(key_type, val_ptr); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.add(key_type, val_ptr)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/ring/spsc_coalescing_ring_buffer.rs:152:9 [INFO] [stderr] | [INFO] [stderr] 152 | return self.add(KeyHolder::NonCollapsible, Box::into_raw(Box::new(value))); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.add(KeyHolder::NonCollapsible, Box::into_raw(Box::new(value)))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/ring/spsc_coalescing_ring_buffer.rs:162:9 [INFO] [stderr] | [INFO] [stderr] 162 | return true; [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `true` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/ring/spsc_coalescing_ring_buffer.rs:193:9 [INFO] [stderr] | [INFO] [stderr] 193 | return self.fill(total_to_poll); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.fill(total_to_poll)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/ring/spsc_coalescing_ring_buffer.rs:201:9 [INFO] [stderr] | [INFO] [stderr] 201 | return self.fill(claim_up_to); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.fill(claim_up_to)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/ring/spsc_coalescing_ring_buffer.rs:221:9 [INFO] [stderr] | [INFO] [stderr] 221 | return bucket; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `bucket` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/ring/spsc_coalescing_ring_buffer.rs:225:9 [INFO] [stderr] | [INFO] [stderr] 225 | return value & self.mask; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `value & self.mask` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/ring/spsc_coalescing_ring_buffer.rs:260:9 [INFO] [stderr] | [INFO] [stderr] 260 | return self.buffer.poll_all(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.buffer.poll_all()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/ring/spsc_coalescing_ring_buffer.rs:264:9 [INFO] [stderr] | [INFO] [stderr] 264 | return self.buffer.poll(max_items); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.buffer.poll(max_items)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/ring/spsc_coalescing_ring_buffer.rs:289:9 [INFO] [stderr] | [INFO] [stderr] 289 | return self.buffer.offer(key, value); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.buffer.offer(key, value)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/ring/spsc_coalescing_ring_buffer.rs:293:9 [INFO] [stderr] | [INFO] [stderr] 293 | return self.buffer.offer_value_only(value); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.buffer.offer_value_only(value)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/ring/spsc_coalescing_ring_buffer.rs:577:9 [INFO] [stderr] | [INFO] [stderr] 577 | return ret; [INFO] [stderr] | ^^^^^^^^^^^ help: remove `return` as shown: `ret` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/ring/spsc_coalescing_ring_buffer.rs:51:5 [INFO] [stderr] | [INFO] [stderr] 51 | v = v - 1; [INFO] [stderr] | ^^^^^^^^^ help: replace it with: `v -= 1` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::assign_op_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/ring/spsc_coalescing_ring_buffer.rs:57:5 [INFO] [stderr] | [INFO] [stderr] 57 | v = v + 1; [INFO] [stderr] | ^^^^^^^^^ help: replace it with: `v += 1` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/ring/spsc_coalescing_ring_buffer.rs:51:5 [INFO] [stderr] | [INFO] [stderr] 51 | v = v - 1; [INFO] [stderr] | ^^^^^^^^^ help: replace it with: `v -= 1` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::assign_op_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/ring/spsc_coalescing_ring_buffer.rs:57:5 [INFO] [stderr] | [INFO] [stderr] 57 | v = v + 1; [INFO] [stderr] | ^^^^^^^^^ help: replace it with: `v += 1` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a Vec. Using `[]` is more clear and more concise [INFO] [stderr] --> src/ring/spsc_coalescing_ring_buffer.rs:498:34 [INFO] [stderr] | [INFO] [stderr] 498 | assert_eq!(&BP_SNAPSHOT, snapshots.get(0).unwrap()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&snapshots[0]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::get_unwrap)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a Vec. Using `[]` is more clear and more concise [INFO] [stderr] --> src/ring/spsc_coalescing_ring_buffer.rs:499:37 [INFO] [stderr] | [INFO] [stderr] 499 | assert_eq!(&VOD_SNAPSHOT_1, snapshots.get(1).unwrap()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&snapshots[1]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a Vec. Using `[]` is more clear and more concise [INFO] [stderr] --> src/ring/spsc_coalescing_ring_buffer.rs:503:37 [INFO] [stderr] | [INFO] [stderr] 503 | assert_eq!(&VOD_SNAPSHOT_2, snapshots.get(0).unwrap()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&snapshots[0]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a Vec. Using `[]` is more clear and more concise [INFO] [stderr] --> src/ring/spsc_coalescing_ring_buffer.rs:519:34 [INFO] [stderr] | [INFO] [stderr] 519 | assert_eq!(&BP_SNAPSHOT, snapshots.get(0).unwrap()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&snapshots[0]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a Vec. Using `[]` is more clear and more concise [INFO] [stderr] --> src/ring/spsc_coalescing_ring_buffer.rs:520:37 [INFO] [stderr] | [INFO] [stderr] 520 | assert_eq!(&VOD_SNAPSHOT_2, snapshots.get(1).unwrap()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&snapshots[1]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/main.rs:20:21 [INFO] [stderr] | [INFO] [stderr] 20 | for i in 0..10000000 { [INFO] [stderr] | ^^^^^^^^ help: consider: `10_000_000` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/main.rs:27:21 [INFO] [stderr] | [INFO] [stderr] 27 | for i in 0..10000000 { [INFO] [stderr] | ^^^^^^^^ help: consider: `10_000_000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/main.rs:20:21 [INFO] [stderr] | [INFO] [stderr] 20 | for i in 0..10000000 { [INFO] [stderr] | ^^^^^^^^ help: consider: `10_000_000` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/main.rs:27:21 [INFO] [stderr] | [INFO] [stderr] 27 | for i in 0..10000000 { [INFO] [stderr] | ^^^^^^^^ help: consider: `10_000_000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 2.28s [INFO] running `"docker" "inspect" "6818fa09a13896dcf2955611b203d8fef6165e0ad22ef4357a22f37337e9340a"` [INFO] running `"docker" "rm" "-f" "6818fa09a13896dcf2955611b203d8fef6165e0ad22ef4357a22f37337e9340a"` [INFO] [stdout] 6818fa09a13896dcf2955611b203d8fef6165e0ad22ef4357a22f37337e9340a