[INFO] crate cntr-nix 0.11.3-pre1 is already in cache [INFO] extracting crate cntr-nix 0.11.3-pre1 into work/ex/clippy-test-run/sources/stable/reg/cntr-nix/0.11.3-pre1 [INFO] extracting crate cntr-nix 0.11.3-pre1 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/cntr-nix/0.11.3-pre1 [INFO] validating manifest of cntr-nix-0.11.3-pre1 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of cntr-nix-0.11.3-pre1 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing cntr-nix-0.11.3-pre1 [INFO] removed 0 missing tests [INFO] finished frobbing cntr-nix-0.11.3-pre1 [INFO] frobbed toml for cntr-nix-0.11.3-pre1 written to work/ex/clippy-test-run/sources/stable/reg/cntr-nix/0.11.3-pre1/Cargo.toml [INFO] started frobbing cntr-nix-0.11.3-pre1 [INFO] removed 0 missing tests [INFO] finished frobbing cntr-nix-0.11.3-pre1 [INFO] frobbed toml for cntr-nix-0.11.3-pre1 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/cntr-nix/0.11.3-pre1/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting cntr-nix-0.11.3-pre1 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-7/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/cntr-nix/0.11.3-pre1:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 545af3b1965842f6905273c76aefb41f5945f17ad166555436c40e105675ef55 [INFO] running `"docker" "start" "-a" "545af3b1965842f6905273c76aefb41f5945f17ad166555436c40e105675ef55"` [INFO] [stderr] Compiling cntr-nix v0.11.3-pre1 (/opt/crater/workdir) [INFO] [stderr] error: redundant field names in struct initialization [INFO] [stderr] --> src/ifaddrs.rs:55:13 [INFO] [stderr] | [INFO] [stderr] 55 | address: address, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `address` [INFO] [stderr] | [INFO] [stderr] note: lint level defined here [INFO] [stderr] --> src/lib.rs:11:24 [INFO] [stderr] | [INFO] [stderr] 11 | #![cfg_attr(test, deny(warnings))] [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] = note: #[deny(clippy::redundant_field_names)] implied by #[deny(warnings)] [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] error: redundant field names in struct initialization [INFO] [stderr] --> src/ifaddrs.rs:56:13 [INFO] [stderr] | [INFO] [stderr] 56 | netmask: netmask, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `netmask` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] error: redundant field names in struct initialization [INFO] [stderr] --> src/poll.rs:33:17 [INFO] [stderr] | [INFO] [stderr] 33 | fd: fd, [INFO] [stderr] | ^^^^^^ help: replace it with: `fd` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] error: redundant field names in struct initialization [INFO] [stderr] --> src/pty.rs:272:9 [INFO] [stderr] | [INFO] [stderr] 272 | master: master, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `master` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] error: redundant field names in struct initialization [INFO] [stderr] --> src/pty.rs:273:9 [INFO] [stderr] | [INFO] [stderr] 273 | slave: slave, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `slave` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] error: redundant field names in struct initialization [INFO] [stderr] --> src/sys/signal.rs:273:18 [INFO] [stderr] | [INFO] [stderr] 273 | SigSet { sigset: sigset } [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `sigset` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] error: redundant field names in struct initialization [INFO] [stderr] --> src/sys/signal.rs:280:18 [INFO] [stderr] | [INFO] [stderr] 280 | SigSet { sigset: sigset } [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `sigset` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] error: 5th binding whose name is just one char [INFO] [stderr] --> src/sys/socket/addr.rs:412:51 [INFO] [stderr] | [INFO] [stderr] 412 | pub fn new_v6(a: u16, b: u16, c: u16, d: u16, e: u16, f: u16, g: u16, h: u16) -> IpAddr { [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] note: lint level defined here [INFO] [stderr] --> src/lib.rs:11:24 [INFO] [stderr] | [INFO] [stderr] 11 | #![cfg_attr(test, deny(warnings))] [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] = note: #[deny(clippy::many_single_char_names)] implied by #[deny(warnings)] [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] error: 6th binding whose name is just one char [INFO] [stderr] --> src/sys/socket/addr.rs:412:59 [INFO] [stderr] | [INFO] [stderr] 412 | pub fn new_v6(a: u16, b: u16, c: u16, d: u16, e: u16, f: u16, g: u16, h: u16) -> IpAddr { [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] error: 7th binding whose name is just one char [INFO] [stderr] --> src/sys/socket/addr.rs:412:67 [INFO] [stderr] | [INFO] [stderr] 412 | pub fn new_v6(a: u16, b: u16, c: u16, d: u16, e: u16, f: u16, g: u16, h: u16) -> IpAddr { [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] error: 8th binding whose name is just one char [INFO] [stderr] --> src/sys/socket/addr.rs:412:75 [INFO] [stderr] | [INFO] [stderr] 412 | pub fn new_v6(a: u16, b: u16, c: u16, d: u16, e: u16, f: u16, g: u16, h: u16) -> IpAddr { [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] error: 5th binding whose name is just one char [INFO] [stderr] --> src/sys/socket/addr.rs:546:48 [INFO] [stderr] | [INFO] [stderr] 546 | pub fn new(a: u16, b: u16, c: u16, d: u16, e: u16, f: u16, g: u16, h: u16) -> Ipv6Addr { [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] error: 6th binding whose name is just one char [INFO] [stderr] --> src/sys/socket/addr.rs:546:56 [INFO] [stderr] | [INFO] [stderr] 546 | pub fn new(a: u16, b: u16, c: u16, d: u16, e: u16, f: u16, g: u16, h: u16) -> Ipv6Addr { [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] error: 7th binding whose name is just one char [INFO] [stderr] --> src/sys/socket/addr.rs:546:64 [INFO] [stderr] | [INFO] [stderr] 546 | pub fn new(a: u16, b: u16, c: u16, d: u16, e: u16, f: u16, g: u16, h: u16) -> Ipv6Addr { [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] error: 8th binding whose name is just one char [INFO] [stderr] --> src/sys/socket/addr.rs:546:72 [INFO] [stderr] | [INFO] [stderr] 546 | pub fn new(a: u16, b: u16, c: u16, d: u16, e: u16, f: u16, g: u16, h: u16) -> Ipv6Addr { [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] error: redundant field names in struct initialization [INFO] [stderr] --> src/sys/socket/addr.rs:1077:54 [INFO] [stderr] | [INFO] [stderr] 1077 | let mut info = ctl_ioc_info { ctl_id: 0, ctl_name: ctl_name }; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `ctl_name` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] error: 5th binding whose name is just one char [INFO] [stderr] --> src/sys/socket/addr.rs:1159:17 [INFO] [stderr] | [INFO] [stderr] 1159 | let e = self.0.sll_addr[4] as u8; [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] error: 6th binding whose name is just one char [INFO] [stderr] --> src/sys/socket/addr.rs:1160:17 [INFO] [stderr] | [INFO] [stderr] 1160 | let f = self.0.sll_addr[5] as u8; [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] error: 5th binding whose name is just one char [INFO] [stderr] --> src/sys/socket/addr.rs:1281:17 [INFO] [stderr] | [INFO] [stderr] 1281 | let e = data[nlen + 4] as u8; [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] error: 6th binding whose name is just one char [INFO] [stderr] --> src/sys/socket/addr.rs:1282:17 [INFO] [stderr] | [INFO] [stderr] 1282 | let f = data[nlen + 5] as u8; [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] error: redundant field names in struct initialization [INFO] [stderr] --> src/sys/socket/sockopt.rs:326:21 [INFO] [stderr] | [INFO] [stderr] 326 | SetStruct { ptr: ptr } [INFO] [stderr] | ^^^^^^^^ help: replace it with: `ptr` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] error: redundant field names in struct initialization [INFO] [stderr] --> src/ucontext.rs:22:47 [INFO] [stderr] | [INFO] [stderr] 22 | Errno::result(res).map(|_| UContext { context: context }) [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `context` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/ifaddrs.rs:55:13 [INFO] [stderr] | [INFO] [stderr] 55 | address: address, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `address` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/ifaddrs.rs:56:13 [INFO] [stderr] | [INFO] [stderr] 56 | netmask: netmask, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `netmask` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/poll.rs:33:17 [INFO] [stderr] | [INFO] [stderr] 33 | fd: fd, [INFO] [stderr] | ^^^^^^ help: replace it with: `fd` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/pty.rs:272:9 [INFO] [stderr] | [INFO] [stderr] 272 | master: master, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `master` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/pty.rs:273:9 [INFO] [stderr] | [INFO] [stderr] 273 | slave: slave, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `slave` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/sys/signal.rs:273:18 [INFO] [stderr] | [INFO] [stderr] 273 | SigSet { sigset: sigset } [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `sigset` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/sys/signal.rs:280:18 [INFO] [stderr] | [INFO] [stderr] 280 | SigSet { sigset: sigset } [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `sigset` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: 5th binding whose name is just one char [INFO] [stderr] --> src/sys/socket/addr.rs:412:51 [INFO] [stderr] | [INFO] [stderr] 412 | pub fn new_v6(a: u16, b: u16, c: u16, d: u16, e: u16, f: u16, g: u16, h: u16) -> IpAddr { [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::many_single_char_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 6th binding whose name is just one char [INFO] [stderr] --> src/sys/socket/addr.rs:412:59 [INFO] [stderr] | [INFO] [stderr] 412 | pub fn new_v6(a: u16, b: u16, c: u16, d: u16, e: u16, f: u16, g: u16, h: u16) -> IpAddr { [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 7th binding whose name is just one char [INFO] [stderr] --> src/sys/socket/addr.rs:412:67 [INFO] [stderr] | [INFO] [stderr] 412 | pub fn new_v6(a: u16, b: u16, c: u16, d: u16, e: u16, f: u16, g: u16, h: u16) -> IpAddr { [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 8th binding whose name is just one char [INFO] [stderr] --> src/sys/socket/addr.rs:412:75 [INFO] [stderr] | [INFO] [stderr] 412 | pub fn new_v6(a: u16, b: u16, c: u16, d: u16, e: u16, f: u16, g: u16, h: u16) -> IpAddr { [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 5th binding whose name is just one char [INFO] [stderr] --> src/sys/socket/addr.rs:546:48 [INFO] [stderr] | [INFO] [stderr] 546 | pub fn new(a: u16, b: u16, c: u16, d: u16, e: u16, f: u16, g: u16, h: u16) -> Ipv6Addr { [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 6th binding whose name is just one char [INFO] [stderr] --> src/sys/socket/addr.rs:546:56 [INFO] [stderr] | [INFO] [stderr] 546 | pub fn new(a: u16, b: u16, c: u16, d: u16, e: u16, f: u16, g: u16, h: u16) -> Ipv6Addr { [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 7th binding whose name is just one char [INFO] [stderr] --> src/sys/socket/addr.rs:546:64 [INFO] [stderr] | [INFO] [stderr] 546 | pub fn new(a: u16, b: u16, c: u16, d: u16, e: u16, f: u16, g: u16, h: u16) -> Ipv6Addr { [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 8th binding whose name is just one char [INFO] [stderr] --> src/sys/socket/addr.rs:546:72 [INFO] [stderr] | [INFO] [stderr] 546 | pub fn new(a: u16, b: u16, c: u16, d: u16, e: u16, f: u16, g: u16, h: u16) -> Ipv6Addr { [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/sys/socket/addr.rs:1077:54 [INFO] [stderr] | [INFO] [stderr] 1077 | let mut info = ctl_ioc_info { ctl_id: 0, ctl_name: ctl_name }; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `ctl_name` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: 5th binding whose name is just one char [INFO] [stderr] --> src/sys/socket/addr.rs:1159:17 [INFO] [stderr] | [INFO] [stderr] 1159 | let e = self.0.sll_addr[4] as u8; [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 6th binding whose name is just one char [INFO] [stderr] --> src/sys/socket/addr.rs:1160:17 [INFO] [stderr] | [INFO] [stderr] 1160 | let f = self.0.sll_addr[5] as u8; [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 5th binding whose name is just one char [INFO] [stderr] --> src/sys/socket/addr.rs:1281:17 [INFO] [stderr] | [INFO] [stderr] 1281 | let e = data[nlen + 4] as u8; [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 6th binding whose name is just one char [INFO] [stderr] --> src/sys/socket/addr.rs:1282:17 [INFO] [stderr] | [INFO] [stderr] 1282 | let f = data[nlen + 5] as u8; [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/sys/socket/sockopt.rs:326:21 [INFO] [stderr] | [INFO] [stderr] 326 | SetStruct { ptr: ptr } [INFO] [stderr] | ^^^^^^^^ help: replace it with: `ptr` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/ucontext.rs:22:47 [INFO] [stderr] | [INFO] [stderr] 22 | Errno::result(res).map(|_| UContext { context: context }) [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `context` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: unneeded unit return type [INFO] [stderr] --> src/errno.rs:49:19 [INFO] [stderr] | [INFO] [stderr] 49 | unsafe fn clear() -> () { [INFO] [stderr] | ^^^^^ help: remove the `-> ()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unused_unit)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: unneeded unit return type [INFO] [stderr] --> src/errno.rs:73:27 [INFO] [stderr] | [INFO] [stderr] 73 | pub unsafe fn clear() -> () { [INFO] [stderr] | ^^^^^ help: remove the `-> ()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: unneeded unit expression [INFO] [stderr] --> src/sys/aio.rs:1222:21 [INFO] [stderr] | [INFO] [stderr] 1222 | () [INFO] [stderr] | ^^ help: remove the final `()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] error: unneeded unit return type [INFO] [stderr] --> src/errno.rs:49:19 [INFO] [stderr] | [INFO] [stderr] 49 | unsafe fn clear() -> () { [INFO] [stderr] | ^^^^^ help: remove the `-> ()` [INFO] [stderr] | [INFO] [stderr] note: lint level defined here [INFO] [stderr] --> src/lib.rs:11:24 [INFO] [stderr] | [INFO] [stderr] 11 | #![cfg_attr(test, deny(warnings))] [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] = note: #[deny(clippy::unused_unit)] implied by #[deny(warnings)] [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] error: unneeded unit return type [INFO] [stderr] --> src/errno.rs:73:27 [INFO] [stderr] | [INFO] [stderr] 73 | pub unsafe fn clear() -> () { [INFO] [stderr] | ^^^^^ help: remove the `-> ()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] error: unneeded unit expression [INFO] [stderr] --> src/sys/aio.rs:1222:21 [INFO] [stderr] | [INFO] [stderr] 1222 | () [INFO] [stderr] | ^^ help: remove the final `()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] error: aborting due to 25 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `cntr-nix`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/dirent.rs:86:13 [INFO] [stderr] | [INFO] [stderr] 86 | Err(Error::last().into()) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: consider removing `.into()`: `Error::last()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_conversion)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/dirent.rs:100:13 [INFO] [stderr] | [INFO] [stderr] 100 | Err(Error::last().into()) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: consider removing `.into()`: `Error::last()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/dirent.rs:109:1 [INFO] [stderr] | [INFO] [stderr] 109 | / pub fn readdir<'a>(dir: &'a mut DirectoryStream) -> Result> { [INFO] [stderr] 110 | | let dirent = unsafe { [INFO] [stderr] 111 | | Errno::clear(); [INFO] [stderr] 112 | | readdir64(dir.0) [INFO] [stderr] ... | [INFO] [stderr] 121 | | } [INFO] [stderr] 122 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_lifetimes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/dirent.rs:117:22 [INFO] [stderr] | [INFO] [stderr] 117 | _ => Err(Error::last().into()), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: consider removing `.into()`: `Error::last()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/dirent.rs:128:1 [INFO] [stderr] | [INFO] [stderr] 128 | / pub fn seekdir<'a>(dir: &'a mut DirectoryStream, loc: c_long) { [INFO] [stderr] 129 | | unsafe { libc::seekdir(dir.0, loc) }; [INFO] [stderr] 130 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/dirent.rs:134:1 [INFO] [stderr] | [INFO] [stderr] 134 | / pub fn telldir<'a>(dir: &'a mut DirectoryStream) -> c_long { [INFO] [stderr] 135 | | unsafe { libc::telldir(dir.0) } [INFO] [stderr] 136 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/dirent.rs:138:1 [INFO] [stderr] | [INFO] [stderr] 138 | / pub fn dirfd<'a>(dir: &'a mut DirectoryStream) -> Result { [INFO] [stderr] 139 | | let res = unsafe { libc::dirfd(dir.0) }; [INFO] [stderr] 140 | | Errno::result(res) [INFO] [stderr] 141 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: casting i32 to i64 may become silently lossy if types change [INFO] [stderr] --> src/mqueue.rs:156:31 [INFO] [stderr] | [INFO] [stderr] 156 | let newattr = MqAttr::new(MQ_OFlag::O_NONBLOCK.bits() as c_long, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `i64::from(MQ_OFlag::O_NONBLOCK.bits())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/poll.rs:41:20 [INFO] [stderr] | [INFO] [stderr] 41 | pub fn revents(&self) -> Option { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: you should consider adding a `Default` implementation for `sched::CpuSet` [INFO] [stderr] --> src/sched.rs:49:5 [INFO] [stderr] | [INFO] [stderr] 49 | / pub fn new() -> CpuSet { [INFO] [stderr] 50 | | CpuSet { cpu_set: unsafe { mem::zeroed() } } [INFO] [stderr] 51 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 48 | impl Default for sched::CpuSet { [INFO] [stderr] 49 | fn default() -> Self { [INFO] [stderr] 50 | Self::new() [INFO] [stderr] 51 | } [INFO] [stderr] 52 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: passing a unit value to a function [INFO] [stderr] --> src/sched.rs:65:16 [INFO] [stderr] | [INFO] [stderr] 65 | Ok(unsafe { libc::CPU_SET(field, &mut self.cpu_set) }) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unit_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unit_arg [INFO] [stderr] help: if you intended to pass a unit value, use a unit literal instead [INFO] [stderr] | [INFO] [stderr] 65 | Ok(()) [INFO] [stderr] | ^^ [INFO] [stderr] [INFO] [stderr] warning: passing a unit value to a function [INFO] [stderr] --> src/sched.rs:73:16 [INFO] [stderr] | [INFO] [stderr] 73 | Ok(unsafe { libc::CPU_CLR(field, &mut self.cpu_set) }) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unit_arg [INFO] [stderr] help: if you intended to pass a unit value, use a unit literal instead [INFO] [stderr] | [INFO] [stderr] 73 | Ok(()) [INFO] [stderr] | ^^ [INFO] [stderr] [INFO] [stderr] warning: use of `offset` with a `usize` casted to an `isize` [INFO] [stderr] --> src/sched.rs:100:19 [INFO] [stderr] | [INFO] [stderr] 100 | let ptr = stack.as_mut_ptr().offset(stack.len() as isize); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `stack.as_mut_ptr().add(stack.len())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_offset_with_cast)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_offset_with_cast [INFO] [stderr] [INFO] [stderr] warning: Negation by multiplying with -1 [INFO] [stderr] --> src/sched.rs:101:38 [INFO] [stderr] | [INFO] [stderr] 101 | let ptr_aligned = ptr.offset((ptr as usize % 16) as isize * -1); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::neg_multiply)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#neg_multiply [INFO] [stderr] [INFO] [stderr] warning: you should consider adding a `Default` implementation for `sys::select::FdSet` [INFO] [stderr] --> src/sys/select.rs:19:5 [INFO] [stderr] | [INFO] [stderr] 19 | / pub fn new() -> FdSet { [INFO] [stderr] 20 | | let mut fdset = unsafe { mem::uninitialized() }; [INFO] [stderr] 21 | | unsafe { libc::FD_ZERO(&mut fdset) }; [INFO] [stderr] 22 | | FdSet(fdset) [INFO] [stderr] 23 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 18 | impl Default for sys::select::FdSet { [INFO] [stderr] 19 | fn default() -> Self { [INFO] [stderr] 20 | Self::new() [INFO] [stderr] 21 | } [INFO] [stderr] 22 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: struct update has no effect, all the fields in the struct have already been specified [INFO] [stderr] --> src/sys/socket/addr.rs:267:24 [INFO] [stderr] | [INFO] [stderr] 267 | .. unsafe { mem::zeroed() } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_update)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_update [INFO] [stderr] [INFO] [stderr] warning: this function has too many arguments (8/7) [INFO] [stderr] --> src/sys/socket/addr.rs:412:5 [INFO] [stderr] | [INFO] [stderr] 412 | / pub fn new_v6(a: u16, b: u16, c: u16, d: u16, e: u16, f: u16, g: u16, h: u16) -> IpAddr { [INFO] [stderr] 413 | | IpAddr::V6(Ipv6Addr::new(a, b, c, d, e, f, g, h)) [INFO] [stderr] 414 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::too_many_arguments)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/sys/socket/addr.rs:458:20 [INFO] [stderr] | [INFO] [stderr] 458 | let ip = (((a as u32) << 24) | [INFO] [stderr] | ^^^^^^^^^^ help: try: `u32::from(a)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/sys/socket/addr.rs:459:20 [INFO] [stderr] | [INFO] [stderr] 459 | ((b as u32) << 16) | [INFO] [stderr] | ^^^^^^^^^^ help: try: `u32::from(b)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/sys/socket/addr.rs:460:20 [INFO] [stderr] | [INFO] [stderr] 460 | ((c as u32) << 8) | [INFO] [stderr] | ^^^^^^^^^^ help: try: `u32::from(c)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `(d as u32)` [INFO] [stderr] --> src/sys/socket/addr.rs:461:19 [INFO] [stderr] | [INFO] [stderr] 461 | ((d as u32) << 0)).to_be(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_op)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/sys/socket/addr.rs:461:20 [INFO] [stderr] | [INFO] [stderr] 461 | ((d as u32) << 0)).to_be(); [INFO] [stderr] | ^^^^^^^^^^ help: try: `u32::from(d)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/sys/socket/addr.rs:466:26 [INFO] [stderr] | [INFO] [stderr] 466 | pub fn from_std(std: &net::Ipv4Addr) -> Ipv4Addr { [INFO] [stderr] | ^^^^^^^^^^^^^^ help: consider passing by value instead: `net::Ipv4Addr` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/sys/socket/addr.rs:475:19 [INFO] [stderr] | [INFO] [stderr] 475 | pub fn octets(&self) -> [u8; 4] { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/sys/socket/addr.rs:480:19 [INFO] [stderr] | [INFO] [stderr] 480 | pub fn to_std(&self) -> net::Ipv4Addr { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this function has too many arguments (8/7) [INFO] [stderr] --> src/sys/socket/addr.rs:546:5 [INFO] [stderr] | [INFO] [stderr] 546 | / pub fn new(a: u16, b: u16, c: u16, d: u16, e: u16, f: u16, g: u16, h: u16) -> Ipv6Addr { [INFO] [stderr] 547 | | let mut in6_addr_var: libc::in6_addr = unsafe{mem::uninitialized()}; [INFO] [stderr] 548 | | in6_addr_var.s6_addr = to_u8_array!(a,b,c,d,e,f,g,h); [INFO] [stderr] 549 | | Ipv6Addr(in6_addr_var) [INFO] [stderr] 550 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/sys/socket/addr.rs:541:14 [INFO] [stderr] | [INFO] [stderr] 541 | [$( (($slf.0.s6_addr[$first] as u16) << 8) + $slf.0.s6_addr[$second] as u16,)*] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from($slf.0.s6_addr[$first])` [INFO] [stderr] ... [INFO] [stderr] 559 | to_u16_array!(self, 0,1,2,3,4,5,6,7,8,9,10,11,12,13,14,15) [INFO] [stderr] | ---------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/sys/socket/addr.rs:541:54 [INFO] [stderr] | [INFO] [stderr] 541 | [$( (($slf.0.s6_addr[$first] as u16) << 8) + $slf.0.s6_addr[$second] as u16,)*] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from($slf.0.s6_addr[$second])` [INFO] [stderr] ... [INFO] [stderr] 559 | to_u16_array!(self, 0,1,2,3,4,5,6,7,8,9,10,11,12,13,14,15) [INFO] [stderr] | ---------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to i32 may become silently lossy if types change [INFO] [stderr] --> src/sys/socket/addr.rs:805:43 [INFO] [stderr] | [INFO] [stderr] 805 | match AddressFamily::from_i32((*addr).sa_family as i32) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `i32::from((*addr).sa_family)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] error: casting from `*const libc::sockaddr` to a more-strictly-aligned pointer (`*const libc::sockaddr_in`) [INFO] [stderr] --> src/sys/socket/addr.rs:808:35 [INFO] [stderr] | [INFO] [stderr] 808 | InetAddr::V4(*(addr as *const libc::sockaddr_in)))), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::cast_ptr_alignment)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_ptr_alignment [INFO] [stderr] [INFO] [stderr] error: casting from `*const libc::sockaddr` to a more-strictly-aligned pointer (`*const libc::sockaddr_in6`) [INFO] [stderr] --> src/sys/socket/addr.rs:810:35 [INFO] [stderr] | [INFO] [stderr] 810 | InetAddr::V6(*(addr as *const libc::sockaddr_in6)))), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_ptr_alignment [INFO] [stderr] [INFO] [stderr] error: casting from `*const libc::sockaddr` to a more-strictly-aligned pointer (`*const libc::sockaddr_nl`) [INFO] [stderr] --> src/sys/socket/addr.rs:813:34 [INFO] [stderr] | [INFO] [stderr] 813 | NetlinkAddr(*(addr as *const libc::sockaddr_nl)))), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_ptr_alignment [INFO] [stderr] [INFO] [stderr] error: casting from `*const libc::sockaddr` to a more-strictly-aligned pointer (`*const libc::sockaddr_ll`) [INFO] [stderr] --> src/sys/socket/addr.rs:819:31 [INFO] [stderr] | [INFO] [stderr] 819 | LinkAddr(*(addr as *const libc::sockaddr_ll)))), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_ptr_alignment [INFO] [stderr] [INFO] [stderr] warning: transmute from a reference to a reference [INFO] [stderr] --> src/sys/socket/addr.rs:850:56 [INFO] [stderr] | [INFO] [stderr] 850 | SockAddr::Inet(InetAddr::V4(ref addr)) => (mem::transmute(addr), mem::size_of::() as libc::socklen_t), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try: `&*(addr as *const libc::sockaddr_in as *const libc::sockaddr)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::transmute_ptr_to_ptr)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#transmute_ptr_to_ptr [INFO] [stderr] [INFO] [stderr] warning: transmute from a reference to a reference [INFO] [stderr] --> src/sys/socket/addr.rs:851:56 [INFO] [stderr] | [INFO] [stderr] 851 | SockAddr::Inet(InetAddr::V6(ref addr)) => (mem::transmute(addr), mem::size_of::() as libc::socklen_t), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try: `&*(addr as *const libc::sockaddr_in6 as *const libc::sockaddr)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#transmute_ptr_to_ptr [INFO] [stderr] [INFO] [stderr] warning: transmute from a reference to a reference [INFO] [stderr] --> src/sys/socket/addr.rs:852:57 [INFO] [stderr] | [INFO] [stderr] 852 | SockAddr::Unix(UnixAddr(ref addr, len)) => (mem::transmute(addr), (len + offset_of!(libc::sockaddr_un, sun_path)) as libc::socklen_t), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try: `&*(addr as *const libc::sockaddr_un as *const libc::sockaddr)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#transmute_ptr_to_ptr [INFO] [stderr] [INFO] [stderr] warning: `0 as *const _` detected. Consider using `ptr::null()` [INFO] [stderr] --> src/macros.rs:262:12 [INFO] [stderr] | [INFO] [stderr] 262 | &(*(0 as *const $ty)).$field as *const _ as usize [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] ::: src/sys/socket/addr.rs:852:86 [INFO] [stderr] | [INFO] [stderr] 852 | SockAddr::Unix(UnixAddr(ref addr, len)) => (mem::transmute(addr), (len + offset_of!(libc::sockaddr_un, sun_path)) as libc::socklen_t), [INFO] [stderr] | --------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::zero_ptr)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#zero_ptr [INFO] [stderr] [INFO] [stderr] warning: transmute from a reference to a reference [INFO] [stderr] --> src/sys/socket/addr.rs:854:56 [INFO] [stderr] | [INFO] [stderr] 854 | SockAddr::Netlink(NetlinkAddr(ref sa)) => (mem::transmute(sa), mem::size_of::() as libc::socklen_t), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try: `&*(sa as *const libc::sockaddr_nl as *const libc::sockaddr)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#transmute_ptr_to_ptr [INFO] [stderr] [INFO] [stderr] warning: transmute from a reference to a reference [INFO] [stderr] --> src/sys/socket/addr.rs:858:58 [INFO] [stderr] | [INFO] [stderr] 858 | SockAddr::Link(LinkAddr(ref ether_addr)) => (mem::transmute(ether_addr), mem::size_of::() as libc::socklen_t), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `&*(ether_addr as *const libc::sockaddr_ll as *const libc::sockaddr)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#transmute_ptr_to_ptr [INFO] [stderr] [INFO] [stderr] warning: casting u16 to i32 may become silently lossy if types change [INFO] [stderr] --> src/sys/socket/addr.rs:1124:24 [INFO] [stderr] | [INFO] [stderr] 1124 | assert_eq!(self.0.sll_family as i32, libc::AF_PACKET); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `i32::from(self.0.sll_family)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] error: casting from `*const u8` to a more-strictly-aligned pointer (`*const libc::cmsghdr`) [INFO] [stderr] --> src/sys/socket/mod.rs:369:44 [INFO] [stderr] | [INFO] [stderr] 369 | let cmsg: &'a cmsghdr = unsafe { &*(self.buf.as_ptr() as *const cmsghdr) }; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_ptr_alignment [INFO] [stderr] [INFO] [stderr] error: casting from `*const u8` to a more-strictly-aligned pointer (`*const i32`) [INFO] [stderr] --> src/sys/socket/mod.rs:398:43 [INFO] [stderr] | [INFO] [stderr] 398 | slice::from_raw_parts(cmsg_data.as_ptr() as *const _, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_ptr_alignment [INFO] [stderr] [INFO] [stderr] error: casting from `*const u8` to a more-strictly-aligned pointer (`*const sys::time::TimeVal`) [INFO] [stderr] --> src/sys/socket/mod.rs:403:23 [INFO] [stderr] | [INFO] [stderr] 403 | &*(cmsg_data.as_ptr() as *const _))) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_ptr_alignment [INFO] [stderr] [INFO] [stderr] warning: struct update has no effect, all the fields in the struct have already been specified [INFO] [stderr] --> src/sys/socket/mod.rs:550:23 [INFO] [stderr] | [INFO] [stderr] 550 | ..mem::uninitialized() [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_update [INFO] [stderr] [INFO] [stderr] warning: struct update has no effect, all the fields in the struct have already been specified [INFO] [stderr] --> src/sys/socket/mod.rs:568:23 [INFO] [stderr] | [INFO] [stderr] 568 | ..mem::uninitialized() [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_update [INFO] [stderr] [INFO] [stderr] error: unsafe vector initialization [INFO] [stderr] --> src/sys/socket/mod.rs:612:9 [INFO] [stderr] | [INFO] [stderr] 611 | let mut vec = Vec::::with_capacity(capacity); [INFO] [stderr] | ---------------------------------- help: consider replace allocation with: `vec![0; capacity]` [INFO] [stderr] 612 | vec.set_len(capacity); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::unsafe_vector_initialization)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unsafe_vector_initialization [INFO] [stderr] [INFO] [stderr] warning: transmute from a reference to a pointer [INFO] [stderr] --> src/sys/socket/mod.rs:832:13 [INFO] [stderr] | [INFO] [stderr] 832 | mem::transmute(&addr), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try: `&addr as *const libc::sockaddr_storage as *mut libc::sockaddr` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_transmute)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_transmute [INFO] [stderr] [INFO] [stderr] warning: transmute from a reference to a pointer [INFO] [stderr] --> src/sys/socket/mod.rs:925:41 [INFO] [stderr] | [INFO] [stderr] 925 | let ret = libc::getpeername(fd, mem::transmute(&addr), &mut len); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try: `&addr as *const libc::sockaddr_storage as *mut libc::sockaddr` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_transmute [INFO] [stderr] [INFO] [stderr] warning: transmute from a reference to a pointer [INFO] [stderr] --> src/sys/socket/mod.rs:941:41 [INFO] [stderr] | [INFO] [stderr] 941 | let ret = libc::getsockname(fd, mem::transmute(&addr), &mut len); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try: `&addr as *const libc::sockaddr_storage as *mut libc::sockaddr` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_transmute [INFO] [stderr] [INFO] [stderr] warning: casting u16 to i32 may become silently lossy if types change [INFO] [stderr] --> src/sys/socket/mod.rs:963:11 [INFO] [stderr] | [INFO] [stderr] 963 | match addr.ss_family as c_int { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try: `i32::from(addr.ss_family)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: `0 as *const _` detected. Consider using `ptr::null()` [INFO] [stderr] --> src/macros.rs:262:12 [INFO] [stderr] | [INFO] [stderr] 262 | &(*(0 as *const $ty)).$field as *const _ as usize [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] ::: src/sys/socket/mod.rs:975:33 [INFO] [stderr] | [INFO] [stderr] 975 | let pathlen = len - offset_of!(sockaddr_un, sun_path); [INFO] [stderr] | --------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#zero_ptr [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/sys/stat.rs:68:44 [INFO] [stderr] | [INFO] [stderr] 68 | pub fn mknodat(dirfd: &RawFd, path: &P, kind: SFlag, perm: Mode, dev: dev_t) -> Result<()> { [INFO] [stderr] | ^^^^^^ help: consider passing by value instead: `RawFd` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/sys/stat.rs:232:13 [INFO] [stderr] | [INFO] [stderr] 232 | / match time { [INFO] [stderr] 233 | | &UtimeSpec::Now => libc::timespec { [INFO] [stderr] 234 | | tv_sec: 0, [INFO] [stderr] 235 | | tv_nsec: libc::UTIME_NOW, [INFO] [stderr] ... | [INFO] [stderr] 241 | | &UtimeSpec::Time(spec) => *spec.as_ref() [INFO] [stderr] 242 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 232 | match *time { [INFO] [stderr] 233 | UtimeSpec::Now => libc::timespec { [INFO] [stderr] 234 | tv_sec: 0, [INFO] [stderr] 235 | tv_nsec: libc::UTIME_NOW, [INFO] [stderr] 236 | }, [INFO] [stderr] 237 | UtimeSpec::Omit => libc::timespec { [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/sys/sysinfo.rs:20:38 [INFO] [stderr] | [INFO] [stderr] 20 | self.0.loads[0] as f64 / (1 << SI_LOAD_SHIFT) as f64, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(1 << SI_LOAD_SHIFT)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/sys/sysinfo.rs:21:38 [INFO] [stderr] | [INFO] [stderr] 21 | self.0.loads[1] as f64 / (1 << SI_LOAD_SHIFT) as f64, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(1 << SI_LOAD_SHIFT)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/sys/sysinfo.rs:22:38 [INFO] [stderr] | [INFO] [stderr] 22 | self.0.loads[2] as f64 / (1 << SI_LOAD_SHIFT) as f64, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(1 << SI_LOAD_SHIFT)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/sys/sysinfo.rs:62:24 [INFO] [stderr] | [INFO] [stderr] 62 | units as u64 * self.0.mem_unit as u64 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(self.0.mem_unit)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to i64 may become silently lossy if types change [INFO] [stderr] --> src/sys/time.rs:211:55 [INFO] [stderr] | [INFO] [stderr] 211 | let usec = self.num_nanoseconds().checked_mul(rhs as i64) [INFO] [stderr] | ^^^^^^^^^^ help: try: `i64::from(rhs)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to i64 may become silently lossy if types change [INFO] [stderr] --> src/sys/time.rs:222:45 [INFO] [stderr] | [INFO] [stderr] 222 | let usec = self.num_nanoseconds() / rhs as i64; [INFO] [stderr] | ^^^^^^^^^^ help: try: `i64::from(rhs)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to i64 may become silently lossy if types change [INFO] [stderr] --> src/sys/time.rs:425:56 [INFO] [stderr] | [INFO] [stderr] 425 | let usec = self.num_microseconds().checked_mul(rhs as i64) [INFO] [stderr] | ^^^^^^^^^^ help: try: `i64::from(rhs)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to i64 may become silently lossy if types change [INFO] [stderr] --> src/sys/time.rs:436:46 [INFO] [stderr] | [INFO] [stderr] 436 | let usec = self.num_microseconds() / rhs as i64; [INFO] [stderr] | ^^^^^^^^^^ help: try: `i64::from(rhs)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/sys/wait.rs:224:24 [INFO] [stderr] | [INFO] [stderr] 224 | pid.into().unwrap_or(Pid::from_raw(-1)).into(), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| Pid::from_raw(-1))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: transmute from a reference to a reference [INFO] [stderr] --> src/ucontext.rs:34:18 [INFO] [stderr] | [INFO] [stderr] 34 | unsafe { mem::transmute(&mut self.context.uc_sigmask) } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `&mut *(&mut self.context.uc_sigmask as *mut libc::sigset_t as *mut sys::signal::SigSet)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#transmute_ptr_to_ptr [INFO] [stderr] [INFO] [stderr] warning: transmute from a reference to a reference [INFO] [stderr] --> src/ucontext.rs:38:18 [INFO] [stderr] | [INFO] [stderr] 38 | unsafe { mem::transmute(&self.context.uc_sigmask) } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `&*(&self.context.uc_sigmask as *const libc::sigset_t as *const sys::signal::SigSet)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#transmute_ptr_to_ptr [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/unistd.rs:54:20 [INFO] [stderr] | [INFO] [stderr] 54 | pub fn is_root(&self) -> bool { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/unistd.rs:162:21 [INFO] [stderr] | [INFO] [stderr] 162 | pub fn is_child(&self) -> bool { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/unistd.rs:171:22 [INFO] [stderr] | [INFO] [stderr] 171 | pub fn is_parent(&self) -> bool { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/unistd.rs:574:25 [INFO] [stderr] | [INFO] [stderr] 574 | val.map(Into::into).unwrap_or((0 as uid_t).wrapping_sub(1)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| (0 as uid_t).wrapping_sub(1))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/unistd.rs:578:25 [INFO] [stderr] | [INFO] [stderr] 578 | val.map(Into::into).unwrap_or((0 as gid_t).wrapping_sub(1)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| (0 as gid_t).wrapping_sub(1))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: trait `NixPath` has a `len` method but no (possibly inherited) `is_empty` method [INFO] [stderr] --> src/lib.rs:157:1 [INFO] [stderr] | [INFO] [stderr] 157 | / pub trait NixPath { [INFO] [stderr] 158 | | fn len(&self) -> usize; [INFO] [stderr] 159 | | [INFO] [stderr] 160 | | fn with_nix_path(&self, f: F) -> Result [INFO] [stderr] 161 | | where F: FnOnce(&CStr) -> T; [INFO] [stderr] 162 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_without_is_empty)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_without_is_empty [INFO] [stderr] [INFO] [stderr] error: aborting due to 8 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `cntr-nix`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "545af3b1965842f6905273c76aefb41f5945f17ad166555436c40e105675ef55"` [INFO] running `"docker" "rm" "-f" "545af3b1965842f6905273c76aefb41f5945f17ad166555436c40e105675ef55"` [INFO] [stdout] 545af3b1965842f6905273c76aefb41f5945f17ad166555436c40e105675ef55