[INFO] crate cntr 1.1.2 is already in cache [INFO] extracting crate cntr 1.1.2 into work/ex/clippy-test-run/sources/stable/reg/cntr/1.1.2 [INFO] extracting crate cntr 1.1.2 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/cntr/1.1.2 [INFO] validating manifest of cntr-1.1.2 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of cntr-1.1.2 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing cntr-1.1.2 [INFO] finished frobbing cntr-1.1.2 [INFO] frobbed toml for cntr-1.1.2 written to work/ex/clippy-test-run/sources/stable/reg/cntr/1.1.2/Cargo.toml [INFO] started frobbing cntr-1.1.2 [INFO] finished frobbing cntr-1.1.2 [INFO] frobbed toml for cntr-1.1.2 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/cntr/1.1.2/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting cntr-1.1.2 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-0/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/cntr/1.1.2:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 9147b4a007571d8cb4da29655f1ad79ba917cc92f411999f924634d7fcf874fb [INFO] running `"docker" "start" "-a" "9147b4a007571d8cb4da29655f1ad79ba917cc92f411999f924634d7fcf874fb"` [INFO] [stderr] Compiling cntr-fuse v0.3.6 [INFO] [stderr] Checking concurrent-hashmap v0.2.2 [INFO] [stderr] Checking cntr-nix v0.10.0-pre1 [INFO] [stderr] Checking parking_lot_core v0.2.14 [INFO] [stderr] Checking parking_lot v0.5.5 [INFO] [stderr] Checking cntr v1.1.2 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/cmd.rs:77:13 [INFO] [stderr] | [INFO] [stderr] 77 | arguments: arguments, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `arguments` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/cmd.rs:77:13 [INFO] [stderr] | [INFO] [stderr] 77 | arguments: arguments, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `arguments` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: called `map(f)` on an Option value where `f` is a unit function [INFO] [stderr] --> src/pty.rs:222:5 [INFO] [stderr] | [INFO] [stderr] 222 | raw_tty.map(drop); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^- [INFO] [stderr] | | [INFO] [stderr] | help: try this: `if let Some(_raw_tty) = raw_tty { drop(...) }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::option_map_unit_fn)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_map_unit_fn [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/lsm.rs:156:25 [INFO] [stderr] | [INFO] [stderr] 156 | Ok(Some(String::from(context))) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: consider removing `String::from()`: `context` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_conversion)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/fs.rs:303:23 [INFO] [stderr] | [INFO] [stderr] 303 | let context = if let &Some(ref context) = selinux_context { [INFO] [stderr] | _______________________^ [INFO] [stderr] 304 | | format!("context=\"{}\"", context) [INFO] [stderr] 305 | | } else { [INFO] [stderr] 306 | | "".to_owned() [INFO] [stderr] 307 | | }; [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 303 | let context = if let Some(ref context) = *selinux_context { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ ^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: this function has too many arguments (9/7) [INFO] [stderr] --> src/fs.rs:327:5 [INFO] [stderr] | [INFO] [stderr] 327 | / fn setattr_inner( [INFO] [stderr] 328 | | &mut self, [INFO] [stderr] 329 | | ino: u64, [INFO] [stderr] 330 | | fd: &Fd, [INFO] [stderr] ... | [INFO] [stderr] 364 | | Ok(()) [INFO] [stderr] 365 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::too_many_arguments)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/fs.rs:452:33 [INFO] [stderr] | [INFO] [stderr] 452 | fn inode<'a>(&'a self, ino: &u64) -> nix::Result> { [INFO] [stderr] | ^^^^ help: consider passing by value instead: `u64` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: called `map(f)` on an Option value where `f` is a unit function [INFO] [stderr] --> src/pty.rs:222:5 [INFO] [stderr] | [INFO] [stderr] 222 | raw_tty.map(drop); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^- [INFO] [stderr] | | [INFO] [stderr] | help: try this: `if let Some(_raw_tty) = raw_tty { drop(...) }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::option_map_unit_fn)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_map_unit_fn [INFO] [stderr] [INFO] [stderr] warning: the function has a cyclomatic complexity of 27 [INFO] [stderr] --> src/attach/child.rs:33:1 [INFO] [stderr] | [INFO] [stderr] 33 | / pub fn run(options: &ChildOptions) -> Result { [INFO] [stderr] 34 | | let target_caps = tryfmt!( [INFO] [stderr] 35 | | capabilities::get(options.container_pid), [INFO] [stderr] 36 | | "failed to get capabilities of target process" [INFO] [stderr] ... | [INFO] [stderr] 180 | | process::exit(1); [INFO] [stderr] 181 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cyclomatic_complexity)] on by default [INFO] [stderr] = help: you could split it up into multiple smaller functions [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cyclomatic_complexity [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to both the expression and the patterns [INFO] [stderr] --> src/attach/child.rs:46:23 [INFO] [stderr] | [INFO] [stderr] 46 | let mount_label = if let &Some(ref p) = &lsm_profile { [INFO] [stderr] | _______________________^ [INFO] [stderr] 47 | | tryfmt!( [INFO] [stderr] 48 | | p.mount_label(options.container_pid), [INFO] [stderr] 49 | | "failed to read mount options" [INFO] [stderr] ... | [INFO] [stderr] 52 | | None [INFO] [stderr] 53 | | }; [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 46 | let mount_label = if let Some(ref p) = lsm_profile { [INFO] [stderr] | ^^^^^^^^^^^ ^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/lsm.rs:156:25 [INFO] [stderr] | [INFO] [stderr] 156 | Ok(Some(String::from(context))) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: consider removing `String::from()`: `context` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_conversion)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/fs.rs:303:23 [INFO] [stderr] | [INFO] [stderr] 303 | let context = if let &Some(ref context) = selinux_context { [INFO] [stderr] | _______________________^ [INFO] [stderr] 304 | | format!("context=\"{}\"", context) [INFO] [stderr] 305 | | } else { [INFO] [stderr] 306 | | "".to_owned() [INFO] [stderr] 307 | | }; [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 303 | let context = if let Some(ref context) = *selinux_context { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ ^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: this function has too many arguments (9/7) [INFO] [stderr] --> src/fs.rs:327:5 [INFO] [stderr] | [INFO] [stderr] 327 | / fn setattr_inner( [INFO] [stderr] 328 | | &mut self, [INFO] [stderr] 329 | | ino: u64, [INFO] [stderr] 330 | | fd: &Fd, [INFO] [stderr] ... | [INFO] [stderr] 364 | | Ok(()) [INFO] [stderr] 365 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::too_many_arguments)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/fs.rs:452:33 [INFO] [stderr] | [INFO] [stderr] 452 | fn inode<'a>(&'a self, ino: &u64) -> nix::Result> { [INFO] [stderr] | ^^^^ help: consider passing by value instead: `u64` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: the function has a cyclomatic complexity of 27 [INFO] [stderr] --> src/attach/child.rs:33:1 [INFO] [stderr] | [INFO] [stderr] 33 | / pub fn run(options: &ChildOptions) -> Result { [INFO] [stderr] 34 | | let target_caps = tryfmt!( [INFO] [stderr] 35 | | capabilities::get(options.container_pid), [INFO] [stderr] 36 | | "failed to get capabilities of target process" [INFO] [stderr] ... | [INFO] [stderr] 180 | | process::exit(1); [INFO] [stderr] 181 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cyclomatic_complexity)] on by default [INFO] [stderr] = help: you could split it up into multiple smaller functions [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cyclomatic_complexity [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to both the expression and the patterns [INFO] [stderr] --> src/attach/child.rs:46:23 [INFO] [stderr] | [INFO] [stderr] 46 | let mount_label = if let &Some(ref p) = &lsm_profile { [INFO] [stderr] | _______________________^ [INFO] [stderr] 47 | | tryfmt!( [INFO] [stderr] 48 | | p.mount_label(options.container_pid), [INFO] [stderr] 49 | | "failed to read mount options" [INFO] [stderr] ... | [INFO] [stderr] 52 | | None [INFO] [stderr] 53 | | }; [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 46 | let mount_label = if let Some(ref p) = lsm_profile { [INFO] [stderr] | ^^^^^^^^^^^ ^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 20.35s [INFO] running `"docker" "inspect" "9147b4a007571d8cb4da29655f1ad79ba917cc92f411999f924634d7fcf874fb"` [INFO] running `"docker" "rm" "-f" "9147b4a007571d8cb4da29655f1ad79ba917cc92f411999f924634d7fcf874fb"` [INFO] [stdout] 9147b4a007571d8cb4da29655f1ad79ba917cc92f411999f924634d7fcf874fb