[INFO] crate cmake 0.1.35 is already in cache
[INFO] extracting crate cmake 0.1.35 into work/ex/clippy-test-run/sources/stable/reg/cmake/0.1.35
[INFO] extracting crate cmake 0.1.35 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/cmake/0.1.35
[INFO] validating manifest of cmake-0.1.35 on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of cmake-0.1.35 on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing cmake-0.1.35
[INFO] finished frobbing cmake-0.1.35
[INFO] frobbed toml for cmake-0.1.35 written to work/ex/clippy-test-run/sources/stable/reg/cmake/0.1.35/Cargo.toml
[INFO] started frobbing cmake-0.1.35
[INFO] finished frobbing cmake-0.1.35
[INFO] frobbed toml for cmake-0.1.35 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/cmake/0.1.35/Cargo.toml
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting cmake-0.1.35 against stable for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-1/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/cmake/0.1.35:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] 7598d71d13fe092416a58d6f5921445d768a82f546967962cb99dd5c1c007f8a
[INFO] running `"docker" "start" "-a" "7598d71d13fe092416a58d6f5921445d768a82f546967962cb99dd5c1c007f8a"`
[INFO] [stderr]     Checking cmake v0.1.35 (/opt/crater/workdir)
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/lib.rs:674:9
[INFO] [stderr]     |
[INFO] [stderr] 674 |         return dst
[INFO] [stderr]     |         ^^^^^^^^^^ help: remove `return` as shown: `dst`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::needless_return)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: this if statement can be collapsed
[INFO] [stderr]    --> src/lib.rs:408:16
[INFO] [stderr]     |
[INFO] [stderr] 408 |           } else if target.contains("solaris") {
[INFO] [stderr]     |  ________________^
[INFO] [stderr] 409 | |             if !self.defined("CMAKE_SYSTEM_NAME") {
[INFO] [stderr] 410 | |                 cmd.arg("-DCMAKE_SYSTEM_NAME=SunOS");
[INFO] [stderr] 411 | |             }
[INFO] [stderr] 412 | |         }
[INFO] [stderr]     | |_________^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::collapsible_if)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if
[INFO] [stderr] help: try
[INFO] [stderr]     |
[INFO] [stderr] 408 |         } else if target.contains("solaris") && !self.defined("CMAKE_SYSTEM_NAME") {
[INFO] [stderr] 409 |     cmd.arg("-DCMAKE_SYSTEM_NAME=SunOS");
[INFO] [stderr] 410 | }
[INFO] [stderr]     |
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/lib.rs:674:9
[INFO] [stderr]     |
[INFO] [stderr] 674 |         return dst
[INFO] [stderr]     |         ^^^^^^^^^^ help: remove `return` as shown: `dst`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::needless_return)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: this if statement can be collapsed
[INFO] [stderr]    --> src/lib.rs:408:16
[INFO] [stderr]     |
[INFO] [stderr] 408 |           } else if target.contains("solaris") {
[INFO] [stderr]     |  ________________^
[INFO] [stderr] 409 | |             if !self.defined("CMAKE_SYSTEM_NAME") {
[INFO] [stderr] 410 | |                 cmd.arg("-DCMAKE_SYSTEM_NAME=SunOS");
[INFO] [stderr] 411 | |             }
[INFO] [stderr] 412 | |         }
[INFO] [stderr]     | |_________^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::collapsible_if)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if
[INFO] [stderr] help: try
[INFO] [stderr]     |
[INFO] [stderr] 408 |         } else if target.contains("solaris") && !self.defined("CMAKE_SYSTEM_NAME") {
[INFO] [stderr] 409 |     cmd.arg("-DCMAKE_SYSTEM_NAME=SunOS");
[INFO] [stderr] 410 | }
[INFO] [stderr]     |
[INFO] [stderr] 
[INFO] [stderr] warning: the function has a cyclomatic complexity of 41
[INFO] [stderr]    --> src/lib.rs:278:5
[INFO] [stderr]     |
[INFO] [stderr] 278 | /     pub fn build(&mut self) -> PathBuf {
[INFO] [stderr] 279 | |         let target = match self.target.clone() {
[INFO] [stderr] 280 | |             Some(t) => t,
[INFO] [stderr] 281 | |             None => {
[INFO] [stderr] ...   |
[INFO] [stderr] 674 | |         return dst
[INFO] [stderr] 675 | |     }
[INFO] [stderr]     | |_____^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::cyclomatic_complexity)] on by default
[INFO] [stderr]     = help: you could split it up into multiple smaller functions
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cyclomatic_complexity
[INFO] [stderr] 
[INFO] [stderr] warning: manual implementation of an assign operation
[INFO] [stderr]    --> src/lib.rs:284:21
[INFO] [stderr]     |
[INFO] [stderr] 284 |                     t = t + "11"
[INFO] [stderr]     |                     ^^^^^^^^^^^^ help: replace it with: `t += "11"`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::assign_op_pattern)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: use of `unwrap_or` followed by a call to `new`
[INFO] [stderr]    --> src/lib.rs:330:29
[INFO] [stderr]     |
[INFO] [stderr] 330 |           let system_prefix = env::var_os("CMAKE_PREFIX_PATH")
[INFO] [stderr]     |  _____________________________^
[INFO] [stderr] 331 | |                                 .unwrap_or(OsString::new());
[INFO] [stderr]     | |___________________________________________________________^ help: try this: `env::var_os("CMAKE_PREFIX_PATH").unwrap_or_default()`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::or_fun_call)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call
[INFO] [stderr] 
[INFO] [stderr] warning: use of `unwrap_or` followed by a function call
[INFO] [stderr]    --> src/lib.rs:337:44
[INFO] [stderr]     |
[INFO] [stderr] 337 |         let executable = env::var("CMAKE").unwrap_or("cmake".to_owned());
[INFO] [stderr]     |                                            ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| "cmake".to_owned())`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call
[INFO] [stderr] 
[INFO] [stderr] warning: use of `unwrap_or` followed by a function call
[INFO] [stderr]    --> src/lib.rs:652:48
[INFO] [stderr]     |
[INFO] [stderr] 652 |         let target = self.cmake_target.clone().unwrap_or("install".to_string());
[INFO] [stderr]     |                                                ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| "install".to_string())`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call
[INFO] [stderr] 
[INFO] [stderr] warning: use of `unwrap_or` followed by a function call
[INFO] [stderr]    --> src/lib.rs:714:49
[INFO] [stderr]     |
[INFO] [stderr] 714 |         let path = fs::canonicalize(&self.path).unwrap_or(self.path.clone());
[INFO] [stderr]     |                                                 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| self.path.clone())`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call
[INFO] [stderr] 
[INFO] [stderr] warning: use of `unwrap_or` followed by a function call
[INFO] [stderr]    --> src/lib.rs:767:10
[INFO] [stderr]     |
[INFO] [stderr] 767 |         .unwrap_or(path.to_owned())
[INFO] [stderr]     |          ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| path.to_owned())`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call
[INFO] [stderr] 
[INFO] [stderr] warning: use of `unwrap_or` followed by a call to `new`
[INFO] [stderr]    --> src/lib.rs:764:23
[INFO] [stderr]     |
[INFO] [stderr] 764 |     env::split_paths(&env::var_os("PATH").unwrap_or(OsString::new()))
[INFO] [stderr]     |                       ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `env::var_os("PATH").unwrap_or_default()`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call
[INFO] [stderr] 
[INFO] [stderr] warning: the function has a cyclomatic complexity of 41
[INFO] [stderr]    --> src/lib.rs:278:5
[INFO] [stderr]     |
[INFO] [stderr] 278 | /     pub fn build(&mut self) -> PathBuf {
[INFO] [stderr] 279 | |         let target = match self.target.clone() {
[INFO] [stderr] 280 | |             Some(t) => t,
[INFO] [stderr] 281 | |             None => {
[INFO] [stderr] ...   |
[INFO] [stderr] 674 | |         return dst
[INFO] [stderr] 675 | |     }
[INFO] [stderr]     | |_____^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::cyclomatic_complexity)] on by default
[INFO] [stderr]     = help: you could split it up into multiple smaller functions
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cyclomatic_complexity
[INFO] [stderr] 
[INFO] [stderr] warning: manual implementation of an assign operation
[INFO] [stderr]    --> src/lib.rs:284:21
[INFO] [stderr]     |
[INFO] [stderr] 284 |                     t = t + "11"
[INFO] [stderr]     |                     ^^^^^^^^^^^^ help: replace it with: `t += "11"`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::assign_op_pattern)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: use of `unwrap_or` followed by a call to `new`
[INFO] [stderr]    --> src/lib.rs:330:29
[INFO] [stderr]     |
[INFO] [stderr] 330 |           let system_prefix = env::var_os("CMAKE_PREFIX_PATH")
[INFO] [stderr]     |  _____________________________^
[INFO] [stderr] 331 | |                                 .unwrap_or(OsString::new());
[INFO] [stderr]     | |___________________________________________________________^ help: try this: `env::var_os("CMAKE_PREFIX_PATH").unwrap_or_default()`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::or_fun_call)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call
[INFO] [stderr] 
[INFO] [stderr] warning: use of `unwrap_or` followed by a function call
[INFO] [stderr]    --> src/lib.rs:337:44
[INFO] [stderr]     |
[INFO] [stderr] 337 |         let executable = env::var("CMAKE").unwrap_or("cmake".to_owned());
[INFO] [stderr]     |                                            ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| "cmake".to_owned())`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call
[INFO] [stderr] 
[INFO] [stderr] warning: use of `unwrap_or` followed by a function call
[INFO] [stderr]    --> src/lib.rs:652:48
[INFO] [stderr]     |
[INFO] [stderr] 652 |         let target = self.cmake_target.clone().unwrap_or("install".to_string());
[INFO] [stderr]     |                                                ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| "install".to_string())`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call
[INFO] [stderr] 
[INFO] [stderr] warning: use of `unwrap_or` followed by a function call
[INFO] [stderr]    --> src/lib.rs:714:49
[INFO] [stderr]     |
[INFO] [stderr] 714 |         let path = fs::canonicalize(&self.path).unwrap_or(self.path.clone());
[INFO] [stderr]     |                                                 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| self.path.clone())`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call
[INFO] [stderr] 
[INFO] [stderr] warning: use of `unwrap_or` followed by a function call
[INFO] [stderr]    --> src/lib.rs:767:10
[INFO] [stderr]     |
[INFO] [stderr] 767 |         .unwrap_or(path.to_owned())
[INFO] [stderr]     |          ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| path.to_owned())`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call
[INFO] [stderr] 
[INFO] [stderr] warning: use of `unwrap_or` followed by a call to `new`
[INFO] [stderr]    --> src/lib.rs:764:23
[INFO] [stderr]     |
[INFO] [stderr] 764 |     env::split_paths(&env::var_os("PATH").unwrap_or(OsString::new()))
[INFO] [stderr]     |                       ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `env::var_os("PATH").unwrap_or_default()`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call
[INFO] [stderr] 
[INFO] [stderr]     Finished dev [unoptimized + debuginfo] target(s) in 1.09s
[INFO] running `"docker" "inspect" "7598d71d13fe092416a58d6f5921445d768a82f546967962cb99dd5c1c007f8a"`
[INFO] running `"docker" "rm" "-f" "7598d71d13fe092416a58d6f5921445d768a82f546967962cb99dd5c1c007f8a"`
[INFO] [stdout] 7598d71d13fe092416a58d6f5921445d768a82f546967962cb99dd5c1c007f8a