[INFO] crate cmail 0.3.0 is already in cache [INFO] extracting crate cmail 0.3.0 into work/ex/clippy-test-run/sources/stable/reg/cmail/0.3.0 [INFO] extracting crate cmail 0.3.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/cmail/0.3.0 [INFO] validating manifest of cmail-0.3.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of cmail-0.3.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing cmail-0.3.0 [INFO] finished frobbing cmail-0.3.0 [INFO] frobbed toml for cmail-0.3.0 written to work/ex/clippy-test-run/sources/stable/reg/cmail/0.3.0/Cargo.toml [INFO] started frobbing cmail-0.3.0 [INFO] finished frobbing cmail-0.3.0 [INFO] frobbed toml for cmail-0.3.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/cmail/0.3.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting cmail-0.3.0 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-5/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/cmail/0.3.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] de390cef42b16753a2ec79769b1e931955e603ffb694ab0f1a2dcf60ab9d0acc [INFO] running `"docker" "start" "-a" "de390cef42b16753a2ec79769b1e931955e603ffb694ab0f1a2dcf60ab9d0acc"` [INFO] [stderr] Checking cmail v0.3.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> cmail.rs:216:13 [INFO] [stderr] | [INFO] [stderr] 216 | send_lines: send_lines, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `send_lines` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> cmail.rs:217:13 [INFO] [stderr] | [INFO] [stderr] 217 | recv_result: recv_result, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `recv_result` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> cmail.rs:218:13 [INFO] [stderr] | [INFO] [stderr] 218 | recv_done: recv_done, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `recv_done` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> cmail.rs:310:19 [INFO] [stderr] | [INFO] [stderr] 310 | Ok((Cmd { child: child }, muxer(vec![stdout, stderr]))) [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `child` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> cmail.rs:216:13 [INFO] [stderr] | [INFO] [stderr] 216 | send_lines: send_lines, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `send_lines` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> cmail.rs:217:13 [INFO] [stderr] | [INFO] [stderr] 217 | recv_result: recv_result, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `recv_result` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> cmail.rs:218:13 [INFO] [stderr] | [INFO] [stderr] 218 | recv_done: recv_done, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `recv_done` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> cmail.rs:310:19 [INFO] [stderr] | [INFO] [stderr] 310 | Ok((Cmd { child: child }, muxer(vec![stdout, stderr]))) [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `child` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> cmail.rs:193:24 [INFO] [stderr] | [INFO] [stderr] 193 | } else { [INFO] [stderr] | ________________________^ [INFO] [stderr] 194 | | if lines.len() == 0 { [INFO] [stderr] 195 | | to_send = vec!["No output.".to_owned()]; [INFO] [stderr] 196 | | } else { [INFO] [stderr] 197 | | to_send = lines; [INFO] [stderr] 198 | | } [INFO] [stderr] 199 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 193 | } else if lines.len() == 0 { [INFO] [stderr] 194 | to_send = vec!["No output.".to_owned()]; [INFO] [stderr] 195 | } else { [INFO] [stderr] 196 | to_send = lines; [INFO] [stderr] 197 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> cmail.rs:193:24 [INFO] [stderr] | [INFO] [stderr] 193 | } else { [INFO] [stderr] | ________________________^ [INFO] [stderr] 194 | | if lines.len() == 0 { [INFO] [stderr] 195 | | to_send = vec!["No output.".to_owned()]; [INFO] [stderr] 196 | | } else { [INFO] [stderr] 197 | | to_send = lines; [INFO] [stderr] 198 | | } [INFO] [stderr] 199 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 193 | } else if lines.len() == 0 { [INFO] [stderr] 194 | to_send = vec!["No output.".to_owned()]; [INFO] [stderr] 195 | } else { [INFO] [stderr] 196 | to_send = lines; [INFO] [stderr] 197 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> cmail.rs:89:35 [INFO] [stderr] | [INFO] [stderr] 89 | None => env::var("EMAIL").unwrap_or("".to_owned()), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| "".to_owned())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> cmail.rs:194:24 [INFO] [stderr] | [INFO] [stderr] 194 | if lines.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `lines.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> cmail.rs:89:35 [INFO] [stderr] | [INFO] [stderr] 89 | None => env::var("EMAIL").unwrap_or("".to_owned()), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| "".to_owned())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> cmail.rs:194:24 [INFO] [stderr] | [INFO] [stderr] 194 | if lines.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `lines.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 4.26s [INFO] running `"docker" "inspect" "de390cef42b16753a2ec79769b1e931955e603ffb694ab0f1a2dcf60ab9d0acc"` [INFO] running `"docker" "rm" "-f" "de390cef42b16753a2ec79769b1e931955e603ffb694ab0f1a2dcf60ab9d0acc"` [INFO] [stdout] de390cef42b16753a2ec79769b1e931955e603ffb694ab0f1a2dcf60ab9d0acc