[INFO] crate cmacros 0.1.0 is already in cache
[INFO] extracting crate cmacros 0.1.0 into work/ex/clippy-test-run/sources/stable/reg/cmacros/0.1.0
[INFO] extracting crate cmacros 0.1.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/cmacros/0.1.0
[INFO] validating manifest of cmacros-0.1.0 on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of cmacros-0.1.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing cmacros-0.1.0
[INFO] finished frobbing cmacros-0.1.0
[INFO] frobbed toml for cmacros-0.1.0 written to work/ex/clippy-test-run/sources/stable/reg/cmacros/0.1.0/Cargo.toml
[INFO] started frobbing cmacros-0.1.0
[INFO] finished frobbing cmacros-0.1.0
[INFO] frobbed toml for cmacros-0.1.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/cmacros/0.1.0/Cargo.toml
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting cmacros-0.1.0 against stable for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-3/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/cmacros/0.1.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] ad0b8d7548810f079b180ec3c7c72ebe9be4e56d3303e2451d19a04e78592784
[INFO] running `"docker" "start" "-a" "ad0b8d7548810f079b180ec3c7c72ebe9be4e56d3303e2451d19a04e78592784"`
[INFO] [stderr]     Checking walker v1.0.1
[INFO] [stderr]     Checking cmacros v0.1.0 (/opt/crater/workdir)
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/lib.rs:42:20
[INFO] [stderr]    |
[INFO] [stderr] 42 |         CharStream{input: input, pos: 0}
[INFO] [stderr]    |                    ^^^^^^^^^^^^ help: replace it with: `input`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::redundant_field_names)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/lib.rs:196:9
[INFO] [stderr]     |
[INFO] [stderr] 196 |         args: args,
[INFO] [stderr]     |         ^^^^^^^^^^ help: replace it with: `args`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/lib.rs:42:20
[INFO] [stderr]    |
[INFO] [stderr] 42 |         CharStream{input: input, pos: 0}
[INFO] [stderr]    |                    ^^^^^^^^^^^^ help: replace it with: `input`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::redundant_field_names)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/lib.rs:196:9
[INFO] [stderr]     |
[INFO] [stderr] 196 |         args: args,
[INFO] [stderr]     |         ^^^^^^^^^^ help: replace it with: `args`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: use of deprecated item 'std::slice::SliceConcatExt::connect': renamed to join
[INFO] [stderr]    --> src/lib.rs:247:16
[INFO] [stderr]     |
[INFO] [stderr] 247 |     decl_lines.connect("\n")
[INFO] [stderr]     |                ^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(deprecated)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]   --> src/lib.rs:69:9
[INFO] [stderr]    |
[INFO] [stderr] 69 |         self.consume_while(|ch| ch == required).len() > 0
[INFO] [stderr]    |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!self.consume_while(|ch| ch == required).is_empty()`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::len_zero)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: useless use of `format!`
[INFO] [stderr]    --> src/lib.rs:157:32
[INFO] [stderr]     |
[INFO] [stderr] 157 |                     return Err(format!("Expected '...' in macro argument list"))
[INFO] [stderr]     |                                ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"Expected '...' in macro argument list".to_string()`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::useless_format)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format
[INFO] [stderr] 
[INFO] [stderr] warning: useless use of `format!`
[INFO] [stderr]    --> src/lib.rs:164:32
[INFO] [stderr]     |
[INFO] [stderr] 164 |                     return Err(format!("Expected C-style comment after '/' in argument list"));
[INFO] [stderr]     |                                ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"Expected C-style comment after '/' in argument list".to_string()`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format
[INFO] [stderr] 
[INFO] [stderr] warning: redundant closure found
[INFO] [stderr]    --> src/lib.rs:177:25
[INFO] [stderr]     |
[INFO] [stderr] 177 |     input.consume_while(|ch| is_ident_char(ch))
[INFO] [stderr]     |                         ^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `is_ident_char`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::redundant_closure)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]    --> src/lib.rs:182:8
[INFO] [stderr]     |
[INFO] [stderr] 182 |     if name.len() == 0 {
[INFO] [stderr]     |        ^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `name.is_empty()`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]    --> src/lib.rs:197:18
[INFO] [stderr]     |
[INFO] [stderr] 197 |         body: if body.len() > 0 {
[INFO] [stderr]     |                  ^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!body.is_empty()`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: single-character string constant used as pattern
[INFO] [stderr]    --> src/lib.rs:263:25
[INFO] [stderr]     |
[INFO] [stderr] 263 |     if body.starts_with("\"") {
[INFO] [stderr]     |                         ^^^^ help: try using a char instead: `'\"'`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::single_char_pattern)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: use of deprecated item 'std::slice::SliceConcatExt::connect': renamed to join
[INFO] [stderr]    --> src/lib.rs:247:16
[INFO] [stderr]     |
[INFO] [stderr] 247 |     decl_lines.connect("\n")
[INFO] [stderr]     |                ^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(deprecated)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: use of deprecated item 'std::slice::SliceConcatExt::connect': renamed to join
[INFO] [stderr]    --> src/lib.rs:376:7
[INFO] [stderr]     |
[INFO] [stderr] 376 |     ].connect("\n"))
[INFO] [stderr]     |       ^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]   --> src/lib.rs:69:9
[INFO] [stderr]    |
[INFO] [stderr] 69 |         self.consume_while(|ch| ch == required).len() > 0
[INFO] [stderr]    |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!self.consume_while(|ch| ch == required).is_empty()`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::len_zero)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: useless use of `format!`
[INFO] [stderr]    --> src/lib.rs:157:32
[INFO] [stderr]     |
[INFO] [stderr] 157 |                     return Err(format!("Expected '...' in macro argument list"))
[INFO] [stderr]     |                                ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"Expected '...' in macro argument list".to_string()`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::useless_format)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format
[INFO] [stderr] 
[INFO] [stderr] warning: useless use of `format!`
[INFO] [stderr]    --> src/lib.rs:164:32
[INFO] [stderr]     |
[INFO] [stderr] 164 |                     return Err(format!("Expected C-style comment after '/' in argument list"));
[INFO] [stderr]     |                                ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"Expected C-style comment after '/' in argument list".to_string()`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format
[INFO] [stderr] 
[INFO] [stderr] warning: redundant closure found
[INFO] [stderr]    --> src/lib.rs:177:25
[INFO] [stderr]     |
[INFO] [stderr] 177 |     input.consume_while(|ch| is_ident_char(ch))
[INFO] [stderr]     |                         ^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `is_ident_char`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::redundant_closure)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]    --> src/lib.rs:182:8
[INFO] [stderr]     |
[INFO] [stderr] 182 |     if name.len() == 0 {
[INFO] [stderr]     |        ^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `name.is_empty()`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]    --> src/lib.rs:197:18
[INFO] [stderr]     |
[INFO] [stderr] 197 |         body: if body.len() > 0 {
[INFO] [stderr]     |                  ^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!body.is_empty()`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: single-character string constant used as pattern
[INFO] [stderr]    --> src/lib.rs:263:25
[INFO] [stderr]     |
[INFO] [stderr] 263 |     if body.starts_with("\"") {
[INFO] [stderr]     |                         ^^^^ help: try using a char instead: `'\"'`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::single_char_pattern)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: unused import: `std::fs`
[INFO] [stderr]  --> examples/parse_header.rs:1:5
[INFO] [stderr]   |
[INFO] [stderr] 1 | use std::fs;
[INFO] [stderr]   |     ^^^^^^^
[INFO] [stderr]   |
[INFO] [stderr]   = note: #[warn(unused_imports)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let`
[INFO] [stderr]   --> examples/parse_header.rs:11:5
[INFO] [stderr]    |
[INFO] [stderr] 11 | /     match header_file.read_to_string(&mut header_src) {
[INFO] [stderr] 12 | |         Err(e) => panic!("Failed to read header file: {}", e),
[INFO] [stderr] 13 | |         _ => ()
[INFO] [stderr] 14 | |     }
[INFO] [stderr]    | |_____^ help: try this: `if let Err(e) = header_file.read_to_string(&mut header_src) { panic!("Failed to read header file: {}", e) }`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::single_match)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match
[INFO] [stderr] 
[INFO] [stderr] warning: use of deprecated item 'std::slice::SliceConcatExt::connect': renamed to join
[INFO] [stderr]   --> examples/parse_all_headers.rs:51:75
[INFO] [stderr]    |
[INFO] [stderr] 51 |                         Some(args) => def.push_str(&format!("({})", &args.connect(","))),
[INFO] [stderr]    |                                                                           ^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(deprecated)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let`
[INFO] [stderr]   --> examples/parse_all_headers.rs:50:21
[INFO] [stderr]    |
[INFO] [stderr] 50 | /                     match cmacro.args {
[INFO] [stderr] 51 | |                         Some(args) => def.push_str(&format!("({})", &args.connect(","))),
[INFO] [stderr] 52 | |                         None => ()
[INFO] [stderr] 53 | |                     }
[INFO] [stderr]    | |_____________________^ help: try this: `if let Some(args) = cmacro.args { def.push_str(&format!("({})", &args.connect(","))) }`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::single_match)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match
[INFO] [stderr] 
[INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let`
[INFO] [stderr]   --> examples/parse_all_headers.rs:54:21
[INFO] [stderr]    |
[INFO] [stderr] 54 | /                     match cmacro.body {
[INFO] [stderr] 55 | |                         Some(body) => def.push_str(&format!(" {}", &body)),
[INFO] [stderr] 56 | |                         None => ()
[INFO] [stderr] 57 | |                     }
[INFO] [stderr]    | |_____________________^ help: try this: `if let Some(body) = cmacro.body { def.push_str(&format!(" {}", &body)) }`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match
[INFO] [stderr] 
[INFO] [stderr]     Finished dev [unoptimized + debuginfo] target(s) in 2.20s
[INFO] running `"docker" "inspect" "ad0b8d7548810f079b180ec3c7c72ebe9be4e56d3303e2451d19a04e78592784"`
[INFO] running `"docker" "rm" "-f" "ad0b8d7548810f079b180ec3c7c72ebe9be4e56d3303e2451d19a04e78592784"`
[INFO] [stdout] ad0b8d7548810f079b180ec3c7c72ebe9be4e56d3303e2451d19a04e78592784