[INFO] crate cloudwrap 0.0.1 is already in cache
[INFO] extracting crate cloudwrap 0.0.1 into work/ex/clippy-test-run/sources/stable/reg/cloudwrap/0.0.1
[INFO] extracting crate cloudwrap 0.0.1 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/cloudwrap/0.0.1
[INFO] validating manifest of cloudwrap-0.0.1 on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of cloudwrap-0.0.1 on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing cloudwrap-0.0.1
[INFO] finished frobbing cloudwrap-0.0.1
[INFO] frobbed toml for cloudwrap-0.0.1 written to work/ex/clippy-test-run/sources/stable/reg/cloudwrap/0.0.1/Cargo.toml
[INFO] started frobbing cloudwrap-0.0.1
[INFO] finished frobbing cloudwrap-0.0.1
[INFO] frobbed toml for cloudwrap-0.0.1 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/cloudwrap/0.0.1/Cargo.toml
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting cloudwrap-0.0.1 against stable for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-7/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/cloudwrap/0.0.1:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] b22a1700ba72d00debea0e7048440fe38a7d68930e1d0f619b7b5b92d3ff335e
[INFO] running `"docker" "start" "-a" "b22a1700ba72d00debea0e7048440fe38a7d68930e1d0f619b7b5b92d3ff335e"`
[INFO] [stderr]    Compiling rusoto_core v0.32.0
[INFO] [stderr]     Checking rusoto_credential v0.11.0
[INFO] [stderr]     Checking rusoto_ssm v0.32.0
[INFO] [stderr]     Checking cloudwrap v0.0.1 (/opt/crater/workdir)
[INFO] [stderr] warning: called `map(f)` on an Option value where `f` is a unit closure
[INFO] [stderr]   --> src/ssm.rs:45:13
[INFO] [stderr]    |
[INFO] [stderr] 45 | /             res.parameters
[INFO] [stderr] 46 | |                 .clone()
[INFO] [stderr] 47 | |                 .map(|mut p| parameters.append(&mut p));
[INFO] [stderr]    | |_______________________________________________________^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::option_map_unit_fn)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_map_unit_fn
[INFO] [stderr] help: try this
[INFO] [stderr]    |
[INFO] [stderr] 45 |             if let Some(mut p) = res.parameters
[INFO] [stderr] 46 |                 .clone() { parameters.append(&mut p) }
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: called `map(f)` on an Option value where `f` is a unit closure
[INFO] [stderr]   --> src/ssm.rs:73:13
[INFO] [stderr]    |
[INFO] [stderr] 73 | /             res.parameters
[INFO] [stderr] 74 | |                 .clone()
[INFO] [stderr] 75 | |                 .map(|mut p| parameters.append(&mut p));
[INFO] [stderr]    | |_______________________________________________________^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_map_unit_fn
[INFO] [stderr] help: try this
[INFO] [stderr]    |
[INFO] [stderr] 73 |             if let Some(mut p) = res.parameters
[INFO] [stderr] 74 |                 .clone() { parameters.append(&mut p) }
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: use of `unwrap_or` followed by a function call
[INFO] [stderr]  --> src/output.rs:8:10
[INFO] [stderr]   |
[INFO] [stderr] 8 |         .unwrap_or("".into())
[INFO] [stderr]   |          ^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| "".into())`
[INFO] [stderr]   |
[INFO] [stderr]   = note: #[warn(clippy::or_fun_call)] on by default
[INFO] [stderr]   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call
[INFO] [stderr] 
[INFO] [stderr] warning: this .into_iter() call is equivalent to .iter() and will not move the Vec
[INFO] [stderr]   --> src/output.rs:48:23
[INFO] [stderr]    |
[INFO] [stderr] 48 |         for p in self.into_iter() {
[INFO] [stderr]    |                       ^^^^^^^^^ help: call directly: `iter`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::into_iter_on_ref)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref
[INFO] [stderr] 
[INFO] [stderr] warning: this .into_iter() call is equivalent to .iter() and will not move the Vec
[INFO] [stderr]   --> src/output.rs:61:23
[INFO] [stderr]    |
[INFO] [stderr] 61 |         for p in self.into_iter() {
[INFO] [stderr]    |                       ^^^^^^^^^ help: call directly: `iter`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref
[INFO] [stderr] 
[INFO] [stderr] warning: this .into_iter() call is equivalent to .iter() and will not move the Vec
[INFO] [stderr]   --> src/output.rs:79:23
[INFO] [stderr]    |
[INFO] [stderr] 79 |         for p in self.into_iter() {
[INFO] [stderr]    |                       ^^^^^^^^^ help: call directly: `iter`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref
[INFO] [stderr] 
[INFO] [stderr] warning: called `map(f)` on an Option value where `f` is a unit closure
[INFO] [stderr]   --> src/main.rs:66:13
[INFO] [stderr]    |
[INFO] [stderr] 66 |                path.parent().map(|p| {
[INFO] [stderr]    |   _____________^
[INFO] [stderr]    |  |_____________|
[INFO] [stderr]    | ||
[INFO] [stderr] 67 | ||                 if !p.exists() {
[INFO] [stderr] 68 | ||                     panic!(format!("{:?} does not exist", p))
[INFO] [stderr] 69 | ||                 }
[INFO] [stderr] 70 | ||             });
[INFO] [stderr]    | ||______________^- help: try this: `if let Some(p) = path.parent() { ... }`
[INFO] [stderr]    | |_______________|
[INFO] [stderr]    | 
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_map_unit_fn
[INFO] [stderr] 
[INFO] [stderr] warning: called `map(f)` on an Option value where `f` is a unit closure
[INFO] [stderr]   --> src/main.rs:73:13
[INFO] [stderr]    |
[INFO] [stderr] 73 |                parameters.export().map(|pairs| {
[INFO] [stderr]    |   _____________^
[INFO] [stderr]    |  |_____________|
[INFO] [stderr]    | ||
[INFO] [stderr] 74 | ||                 for (k, v) in pairs {
[INFO] [stderr] 75 | ||                     file.write_all(format!("export {}={}\n", k, v).as_bytes())
[INFO] [stderr] 76 | ||                         .expect("writing to file");
[INFO] [stderr] 77 | ||                 }
[INFO] [stderr] 78 | ||             });
[INFO] [stderr]    | ||______________^- help: try this: `if let Some(pairs) = parameters.export() { ... }`
[INFO] [stderr]    | |_______________|
[INFO] [stderr]    | 
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_map_unit_fn
[INFO] [stderr] 
[INFO] [stderr] warning: use of `expect` followed by a function call
[INFO] [stderr]   --> src/main.rs:86:22
[INFO] [stderr]    |
[INFO] [stderr] 86 |                     .expect(&format!("failed to start {}", cmd));
[INFO] [stderr]    |                      ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| panic!("failed to start {}", cmd))`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::expect_fun_call)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call
[INFO] [stderr] 
[INFO] [stderr] warning: use of `expect` followed by a function call
[INFO] [stderr]   --> src/main.rs:92:22
[INFO] [stderr]    |
[INFO] [stderr] 92 |                     .expect(&format!("failed to start {}", cmd));
[INFO] [stderr]    |                      ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| panic!("failed to start {}", cmd))`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call
[INFO] [stderr] 
[INFO] [stderr] warning: called `map(f)` on an Option value where `f` is a unit closure
[INFO] [stderr]   --> src/ssm.rs:45:13
[INFO] [stderr]    |
[INFO] [stderr] 45 | /             res.parameters
[INFO] [stderr] 46 | |                 .clone()
[INFO] [stderr] 47 | |                 .map(|mut p| parameters.append(&mut p));
[INFO] [stderr]    | |_______________________________________________________^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::option_map_unit_fn)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_map_unit_fn
[INFO] [stderr] help: try this
[INFO] [stderr]    |
[INFO] [stderr] 45 |             if let Some(mut p) = res.parameters
[INFO] [stderr] 46 |                 .clone() { parameters.append(&mut p) }
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: called `map(f)` on an Option value where `f` is a unit closure
[INFO] [stderr]   --> src/ssm.rs:73:13
[INFO] [stderr]    |
[INFO] [stderr] 73 | /             res.parameters
[INFO] [stderr] 74 | |                 .clone()
[INFO] [stderr] 75 | |                 .map(|mut p| parameters.append(&mut p));
[INFO] [stderr]    | |_______________________________________________________^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_map_unit_fn
[INFO] [stderr] help: try this
[INFO] [stderr]    |
[INFO] [stderr] 73 |             if let Some(mut p) = res.parameters
[INFO] [stderr] 74 |                 .clone() { parameters.append(&mut p) }
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: use of `unwrap_or` followed by a function call
[INFO] [stderr]  --> src/output.rs:8:10
[INFO] [stderr]   |
[INFO] [stderr] 8 |         .unwrap_or("".into())
[INFO] [stderr]   |          ^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| "".into())`
[INFO] [stderr]   |
[INFO] [stderr]   = note: #[warn(clippy::or_fun_call)] on by default
[INFO] [stderr]   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call
[INFO] [stderr] 
[INFO] [stderr] warning: this .into_iter() call is equivalent to .iter() and will not move the Vec
[INFO] [stderr]   --> src/output.rs:48:23
[INFO] [stderr]    |
[INFO] [stderr] 48 |         for p in self.into_iter() {
[INFO] [stderr]    |                       ^^^^^^^^^ help: call directly: `iter`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::into_iter_on_ref)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref
[INFO] [stderr] 
[INFO] [stderr] warning: this .into_iter() call is equivalent to .iter() and will not move the Vec
[INFO] [stderr]   --> src/output.rs:61:23
[INFO] [stderr]    |
[INFO] [stderr] 61 |         for p in self.into_iter() {
[INFO] [stderr]    |                       ^^^^^^^^^ help: call directly: `iter`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref
[INFO] [stderr] 
[INFO] [stderr] warning: this .into_iter() call is equivalent to .iter() and will not move the Vec
[INFO] [stderr]   --> src/output.rs:79:23
[INFO] [stderr]    |
[INFO] [stderr] 79 |         for p in self.into_iter() {
[INFO] [stderr]    |                       ^^^^^^^^^ help: call directly: `iter`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref
[INFO] [stderr] 
[INFO] [stderr] warning: called `map(f)` on an Option value where `f` is a unit closure
[INFO] [stderr]   --> src/main.rs:66:13
[INFO] [stderr]    |
[INFO] [stderr] 66 |                path.parent().map(|p| {
[INFO] [stderr]    |   _____________^
[INFO] [stderr]    |  |_____________|
[INFO] [stderr]    | ||
[INFO] [stderr] 67 | ||                 if !p.exists() {
[INFO] [stderr] 68 | ||                     panic!(format!("{:?} does not exist", p))
[INFO] [stderr] 69 | ||                 }
[INFO] [stderr] 70 | ||             });
[INFO] [stderr]    | ||______________^- help: try this: `if let Some(p) = path.parent() { ... }`
[INFO] [stderr]    | |_______________|
[INFO] [stderr]    | 
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_map_unit_fn
[INFO] [stderr] 
[INFO] [stderr] warning: called `map(f)` on an Option value where `f` is a unit closure
[INFO] [stderr]   --> src/main.rs:73:13
[INFO] [stderr]    |
[INFO] [stderr] 73 |                parameters.export().map(|pairs| {
[INFO] [stderr]    |   _____________^
[INFO] [stderr]    |  |_____________|
[INFO] [stderr]    | ||
[INFO] [stderr] 74 | ||                 for (k, v) in pairs {
[INFO] [stderr] 75 | ||                     file.write_all(format!("export {}={}\n", k, v).as_bytes())
[INFO] [stderr] 76 | ||                         .expect("writing to file");
[INFO] [stderr] 77 | ||                 }
[INFO] [stderr] 78 | ||             });
[INFO] [stderr]    | ||______________^- help: try this: `if let Some(pairs) = parameters.export() { ... }`
[INFO] [stderr]    | |_______________|
[INFO] [stderr]    | 
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_map_unit_fn
[INFO] [stderr] 
[INFO] [stderr] warning: use of `expect` followed by a function call
[INFO] [stderr]   --> src/main.rs:86:22
[INFO] [stderr]    |
[INFO] [stderr] 86 |                     .expect(&format!("failed to start {}", cmd));
[INFO] [stderr]    |                      ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| panic!("failed to start {}", cmd))`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::expect_fun_call)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call
[INFO] [stderr] 
[INFO] [stderr] warning: use of `expect` followed by a function call
[INFO] [stderr]   --> src/main.rs:92:22
[INFO] [stderr]    |
[INFO] [stderr] 92 |                     .expect(&format!("failed to start {}", cmd));
[INFO] [stderr]    |                      ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| panic!("failed to start {}", cmd))`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call
[INFO] [stderr] 
[INFO] [stderr]     Finished dev [unoptimized + debuginfo] target(s) in 54.16s
[INFO] running `"docker" "inspect" "b22a1700ba72d00debea0e7048440fe38a7d68930e1d0f619b7b5b92d3ff335e"`
[INFO] running `"docker" "rm" "-f" "b22a1700ba72d00debea0e7048440fe38a7d68930e1d0f619b7b5b92d3ff335e"`
[INFO] [stdout] b22a1700ba72d00debea0e7048440fe38a7d68930e1d0f619b7b5b92d3ff335e