[INFO] crate clipping 0.1.1 is already in cache [INFO] extracting crate clipping 0.1.1 into work/ex/clippy-test-run/sources/stable/reg/clipping/0.1.1 [INFO] extracting crate clipping 0.1.1 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/clipping/0.1.1 [INFO] validating manifest of clipping-0.1.1 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of clipping-0.1.1 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing clipping-0.1.1 [INFO] finished frobbing clipping-0.1.1 [INFO] frobbed toml for clipping-0.1.1 written to work/ex/clippy-test-run/sources/stable/reg/clipping/0.1.1/Cargo.toml [INFO] started frobbing clipping-0.1.1 [INFO] finished frobbing clipping-0.1.1 [INFO] frobbed toml for clipping-0.1.1 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/clipping/0.1.1/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting clipping-0.1.1 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-6/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/clipping/0.1.1:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] c56ef3b2f384d85d11e4f194999f6dc2be5a319cb68882db464541db8c0bcb85 [INFO] running `"docker" "start" "-a" "c56ef3b2f384d85d11e4f194999f6dc2be5a319cb68882db464541db8c0bcb85"` [INFO] [stderr] Checking pistoncore-input v0.20.0 [INFO] [stderr] Checking gfx_core v0.8.3 [INFO] [stderr] Checking pistoncore-window v0.30.0 [INFO] [stderr] Checking pistoncore-event_loop v0.35.0 [INFO] [stderr] Checking pistoncore-glutin_window v0.43.0 [INFO] [stderr] Checking piston v0.35.0 [INFO] [stderr] Checking gfx v0.17.1 [INFO] [stderr] Checking gfx_device_gl v0.15.5 [INFO] [stderr] Checking piston-gfx_texture v0.31.0 [INFO] [stderr] Checking piston2d-gfx_graphics v0.48.0 [INFO] [stderr] Checking piston_window v0.75.0 [INFO] [stderr] Checking clipping v0.1.1 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/gh.rs:23:13 [INFO] [stderr] | [INFO] [stderr] 23 | pt: pt, [INFO] [stderr] | ^^^^^^ help: replace it with: `pt` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/gh.rs:27:13 [INFO] [stderr] | [INFO] [stderr] 27 | entry: entry, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `entry` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/gh.rs:28:13 [INFO] [stderr] | [INFO] [stderr] 28 | alpha: alpha, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `alpha` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/gh.rs:29:13 [INFO] [stderr] | [INFO] [stderr] 29 | inter: inter, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `inter` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/gh.rs:30:13 [INFO] [stderr] | [INFO] [stderr] 30 | checked: checked [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `checked` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/gh.rs:23:13 [INFO] [stderr] | [INFO] [stderr] 23 | pt: pt, [INFO] [stderr] | ^^^^^^ help: replace it with: `pt` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/gh.rs:27:13 [INFO] [stderr] | [INFO] [stderr] 27 | entry: entry, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `entry` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/gh.rs:28:13 [INFO] [stderr] | [INFO] [stderr] 28 | alpha: alpha, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `alpha` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/gh.rs:29:13 [INFO] [stderr] | [INFO] [stderr] 29 | inter: inter, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `inter` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/gh.rs:30:13 [INFO] [stderr] | [INFO] [stderr] 30 | checked: checked [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `checked` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/gh.rs:58:26 [INFO] [stderr] | [INFO] [stderr] 58 | let infinity = [-100000. - (rand::random::() % 100.), -100000. - (rand::random::() % 100.)]; [INFO] [stderr] | ^^^^^^^ help: consider: `100_000.` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/gh.rs:58:69 [INFO] [stderr] | [INFO] [stderr] 58 | let infinity = [-100000. - (rand::random::() % 100.), -100000. - (rand::random::() % 100.)]; [INFO] [stderr] | ^^^^^^^ help: consider: `100_000.` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/gh.rs:200:22 [INFO] [stderr] | [INFO] [stderr] 200 | }else{ [INFO] [stderr] | ______________________^ [INFO] [stderr] 201 | | if vertex == self.fst.as_ref().unwrap().prev{ [INFO] [stderr] 202 | | if self.fst.as_ref().unwrap().pt != pt{ [INFO] [stderr] 203 | | poly.push(pt); [INFO] [stderr] ... | [INFO] [stderr] 211 | | } [INFO] [stderr] 212 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 200 | }elseif vertex == self.fst.as_ref().unwrap().prev{ [INFO] [stderr] 201 | if self.fst.as_ref().unwrap().pt != pt{ [INFO] [stderr] 202 | poly.push(pt); [INFO] [stderr] 203 | } [INFO] [stderr] 204 | }else{ [INFO] [stderr] 205 | let prev = vertex.as_ref().unwrap().prev.as_ref().unwrap().pt; [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/gh.rs:407:14 [INFO] [stderr] | [INFO] [stderr] 407 | }else{ [INFO] [stderr] | ______________^ [INFO] [stderr] 408 | | if self.curr == self.first{ [INFO] [stderr] 409 | | None [INFO] [stderr] 410 | | }else{ [INFO] [stderr] ... | [INFO] [stderr] 416 | | } [INFO] [stderr] 417 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 407 | }elseif self.curr == self.first{ [INFO] [stderr] 408 | None [INFO] [stderr] 409 | }else{ [INFO] [stderr] 410 | let i = self.curr; [INFO] [stderr] 411 | unsafe{ [INFO] [stderr] 412 | self.curr = self.curr.as_ref().unwrap().next; [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/gh.rs:65:17 [INFO] [stderr] | [INFO] [stderr] 65 | / match intersect(self.pt, infinity, pt_q, pt_q_next){ [INFO] [stderr] 66 | | Some(_) => if !q.as_ref().unwrap().inter{ [INFO] [stderr] 67 | | w += 1; [INFO] [stderr] 68 | | }, [INFO] [stderr] 69 | | None => {} [INFO] [stderr] 70 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 65 | if let Some(_) = intersect(self.pt, infinity, pt_q, pt_q_next) { if !q.as_ref().unwrap().inter{ [INFO] [stderr] 66 | w += 1; [INFO] [stderr] 67 | } } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you should consider adding a `Default` implementation for `gh::CPolygon` [INFO] [stderr] --> src/gh.rs:108:5 [INFO] [stderr] | [INFO] [stderr] 108 | / pub fn new()->Self{ [INFO] [stderr] 109 | | Self{ [INFO] [stderr] 110 | | fst: ptr::null_mut() [INFO] [stderr] 111 | | } [INFO] [stderr] 112 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 105 | impl Default for gh::CPolygon { [INFO] [stderr] 106 | fn default() -> Self { [INFO] [stderr] 107 | Self::new() [INFO] [stderr] 108 | } [INFO] [stderr] 109 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/gh.rs:115:26 [INFO] [stderr] | [INFO] [stderr] 115 | pub fn from_vec(vec: &Vec<[f64; 2]>)->Self{ [INFO] [stderr] | ^^^^^^^^^^^^^^ help: change this to: `&[[f64; 2]]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/gh.rs:243:29 [INFO] [stderr] | [INFO] [stderr] 243 | / match intersect(s_pt, s_next_pt, c_pt, c_next_pt){ [INFO] [stderr] 244 | | Some((i, alpha_s, alpha_c)) => { [INFO] [stderr] 245 | | let mut is = Vertex::new(i, alpha_s, true, false, false); [INFO] [stderr] 246 | | let mut ic = Vertex::new(i, alpha_c, true, false, false); [INFO] [stderr] ... | [INFO] [stderr] 256 | | None => {} [INFO] [stderr] 257 | | } [INFO] [stderr] | |_____________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 243 | if let Some((i, alpha_s, alpha_c)) = intersect(s_pt, s_next_pt, c_pt, c_next_pt) { [INFO] [stderr] 244 | let mut is = Vertex::new(i, alpha_s, true, false, false); [INFO] [stderr] 245 | let mut ic = Vertex::new(i, alpha_c, true, false, false); [INFO] [stderr] 246 | is.as_mut().unwrap().neighbour = ic; [INFO] [stderr] 247 | ic.as_mut().unwrap().neighbour = is; [INFO] [stderr] 248 | [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/gh.rs:433:21 [INFO] [stderr] | [INFO] [stderr] 433 | if (us == 0. || us == 1.) && (0. <= uc && uc <= 1.) || [INFO] [stderr] | ^^^^^^^^ help: consider comparing them within some error: `(us - 1.).abs() < error` [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::float_cmp)] on by default [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/gh.rs:433:21 [INFO] [stderr] | [INFO] [stderr] 433 | if (us == 0. || us == 1.) && (0. <= uc && uc <= 1.) || [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/gh.rs:434:22 [INFO] [stderr] | [INFO] [stderr] 434 | (uc == 0. || uc == 1.) && (0. <= us && us <= 1.){ [INFO] [stderr] | ^^^^^^^^ help: consider comparing them within some error: `(uc - 1.).abs() < error` [INFO] [stderr] | [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/gh.rs:434:22 [INFO] [stderr] | [INFO] [stderr] 434 | (uc == 0. || uc == 1.) && (0. <= us && us <= 1.){ [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] [INFO] [stderr] error: aborting due to 2 previous errors [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/gh.rs:58:26 [INFO] [stderr] | [INFO] [stderr] 58 | let infinity = [-100000. - (rand::random::() % 100.), -100000. - (rand::random::() % 100.)]; [INFO] [stderr] | ^^^^^^^ help: consider: `100_000.` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/gh.rs:58:69 [INFO] [stderr] | [INFO] [stderr] 58 | let infinity = [-100000. - (rand::random::() % 100.), -100000. - (rand::random::() % 100.)]; [INFO] [stderr] | ^^^^^^^ help: consider: `100_000.` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/gh.rs:200:22 [INFO] [stderr] | [INFO] [stderr] 200 | }else{ [INFO] [stderr] | ______________________^ [INFO] [stderr] 201 | | if vertex == self.fst.as_ref().unwrap().prev{ [INFO] [stderr] 202 | | if self.fst.as_ref().unwrap().pt != pt{ [INFO] [stderr] 203 | | poly.push(pt); [INFO] [stderr] ... | [INFO] [stderr] 211 | | } [INFO] [stderr] 212 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 200 | }elseif vertex == self.fst.as_ref().unwrap().prev{ [INFO] [stderr] 201 | if self.fst.as_ref().unwrap().pt != pt{ [INFO] [stderr] 202 | poly.push(pt); [INFO] [stderr] 203 | } [INFO] [stderr] 204 | }else{ [INFO] [stderr] 205 | let prev = vertex.as_ref().unwrap().prev.as_ref().unwrap().pt; [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/gh.rs:407:14 [INFO] [stderr] | [INFO] [stderr] 407 | }else{ [INFO] [stderr] | ______________^ [INFO] [stderr] 408 | | if self.curr == self.first{ [INFO] [stderr] 409 | | None [INFO] [stderr] 410 | | }else{ [INFO] [stderr] ... | [INFO] [stderr] 416 | | } [INFO] [stderr] 417 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 407 | }elseif self.curr == self.first{ [INFO] [stderr] 408 | None [INFO] [stderr] 409 | }else{ [INFO] [stderr] 410 | let i = self.curr; [INFO] [stderr] 411 | unsafe{ [INFO] [stderr] 412 | self.curr = self.curr.as_ref().unwrap().next; [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] error: Could not compile `clipping`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/gh.rs:65:17 [INFO] [stderr] | [INFO] [stderr] 65 | / match intersect(self.pt, infinity, pt_q, pt_q_next){ [INFO] [stderr] 66 | | Some(_) => if !q.as_ref().unwrap().inter{ [INFO] [stderr] 67 | | w += 1; [INFO] [stderr] 68 | | }, [INFO] [stderr] 69 | | None => {} [INFO] [stderr] 70 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 65 | if let Some(_) = intersect(self.pt, infinity, pt_q, pt_q_next) { if !q.as_ref().unwrap().inter{ [INFO] [stderr] 66 | w += 1; [INFO] [stderr] 67 | } } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you should consider adding a `Default` implementation for `gh::CPolygon` [INFO] [stderr] --> src/gh.rs:108:5 [INFO] [stderr] | [INFO] [stderr] 108 | / pub fn new()->Self{ [INFO] [stderr] 109 | | Self{ [INFO] [stderr] 110 | | fst: ptr::null_mut() [INFO] [stderr] 111 | | } [INFO] [stderr] 112 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 105 | impl Default for gh::CPolygon { [INFO] [stderr] 106 | fn default() -> Self { [INFO] [stderr] 107 | Self::new() [INFO] [stderr] 108 | } [INFO] [stderr] 109 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/gh.rs:115:26 [INFO] [stderr] | [INFO] [stderr] 115 | pub fn from_vec(vec: &Vec<[f64; 2]>)->Self{ [INFO] [stderr] | ^^^^^^^^^^^^^^ help: change this to: `&[[f64; 2]]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/gh.rs:243:29 [INFO] [stderr] | [INFO] [stderr] 243 | / match intersect(s_pt, s_next_pt, c_pt, c_next_pt){ [INFO] [stderr] 244 | | Some((i, alpha_s, alpha_c)) => { [INFO] [stderr] 245 | | let mut is = Vertex::new(i, alpha_s, true, false, false); [INFO] [stderr] 246 | | let mut ic = Vertex::new(i, alpha_c, true, false, false); [INFO] [stderr] ... | [INFO] [stderr] 256 | | None => {} [INFO] [stderr] 257 | | } [INFO] [stderr] | |_____________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 243 | if let Some((i, alpha_s, alpha_c)) = intersect(s_pt, s_next_pt, c_pt, c_next_pt) { [INFO] [stderr] 244 | let mut is = Vertex::new(i, alpha_s, true, false, false); [INFO] [stderr] 245 | let mut ic = Vertex::new(i, alpha_c, true, false, false); [INFO] [stderr] 246 | is.as_mut().unwrap().neighbour = ic; [INFO] [stderr] 247 | ic.as_mut().unwrap().neighbour = is; [INFO] [stderr] 248 | [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/gh.rs:433:21 [INFO] [stderr] | [INFO] [stderr] 433 | if (us == 0. || us == 1.) && (0. <= uc && uc <= 1.) || [INFO] [stderr] | ^^^^^^^^ help: consider comparing them within some error: `(us - 1.).abs() < error` [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::float_cmp)] on by default [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/gh.rs:433:21 [INFO] [stderr] | [INFO] [stderr] 433 | if (us == 0. || us == 1.) && (0. <= uc && uc <= 1.) || [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/gh.rs:434:22 [INFO] [stderr] | [INFO] [stderr] 434 | (uc == 0. || uc == 1.) && (0. <= us && us <= 1.){ [INFO] [stderr] | ^^^^^^^^ help: consider comparing them within some error: `(uc - 1.).abs() < error` [INFO] [stderr] | [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/gh.rs:434:22 [INFO] [stderr] | [INFO] [stderr] 434 | (uc == 0. || uc == 1.) && (0. <= us && us <= 1.){ [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] [INFO] [stderr] error: aborting due to 2 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `clipping`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "c56ef3b2f384d85d11e4f194999f6dc2be5a319cb68882db464541db8c0bcb85"` [INFO] running `"docker" "rm" "-f" "c56ef3b2f384d85d11e4f194999f6dc2be5a319cb68882db464541db8c0bcb85"` [INFO] [stdout] c56ef3b2f384d85d11e4f194999f6dc2be5a319cb68882db464541db8c0bcb85