[INFO] crate cline 0.1.0 is already in cache
[INFO] extracting crate cline 0.1.0 into work/ex/clippy-test-run/sources/stable/reg/cline/0.1.0
[INFO] extracting crate cline 0.1.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/cline/0.1.0
[INFO] validating manifest of cline-0.1.0 on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of cline-0.1.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing cline-0.1.0
[INFO] finished frobbing cline-0.1.0
[INFO] frobbed toml for cline-0.1.0 written to work/ex/clippy-test-run/sources/stable/reg/cline/0.1.0/Cargo.toml
[INFO] started frobbing cline-0.1.0
[INFO] finished frobbing cline-0.1.0
[INFO] frobbed toml for cline-0.1.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/cline/0.1.0/Cargo.toml
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting cline-0.1.0 against stable for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-3/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/cline/0.1.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] f21de18baf0208cdfbf1d9ef126f8a773590843e03dc90b6663897c2f78dfbff
[INFO] running `"docker" "start" "-a" "f21de18baf0208cdfbf1d9ef126f8a773590843e03dc90b6663897c2f78dfbff"`
[INFO] [stderr] warning: An explicit [[bin]] section is specified in Cargo.toml which currently
[INFO] [stderr] disables Cargo from automatically inferring other binary targets.
[INFO] [stderr] This inference behavior will change in the Rust 2018 edition and the following
[INFO] [stderr] files will be included as a binary target:
[INFO] [stderr] 
[INFO] [stderr] * /opt/crater/workdir/src/main.rs
[INFO] [stderr] 
[INFO] [stderr] This is likely to break cargo build or cargo test as these files may not be
[INFO] [stderr] ready to be compiled as a binary target today. You can future-proof yourself
[INFO] [stderr] and disable this warning by adding `autobins = false` to your [package]
[INFO] [stderr] section. You may also move the files to a location where Cargo would not
[INFO] [stderr] automatically infer them to be a target, such as in subfolders.
[INFO] [stderr] 
[INFO] [stderr] For more information on this warning you can consult
[INFO] [stderr] https://github.com/rust-lang/cargo/issues/5330
[INFO] [stderr] warning: path `/opt/crater/workdir/src/main.rs` was erroneously implicitly accepted for binary `cline_test`,
[INFO] [stderr] please set bin.path in Cargo.toml
[INFO] [stderr]     Checking termios v0.1.0
[INFO] [stderr]     Checking cline v0.1.0 (/opt/crater/workdir)
[INFO] [stderr] warning: literal with an empty format string
[INFO] [stderr]    --> src/lib.rs:319:54
[INFO] [stderr]     |
[INFO] [stderr] 319 |                                 println!("{} {} {}", 0x1B, 0x5b, c.unwrap().unwrap());
[INFO] [stderr]     |                                                      ^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::print_literal)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#print_literal
[INFO] [stderr] 
[INFO] [stderr] warning: literal with an empty format string
[INFO] [stderr]    --> src/lib.rs:319:60
[INFO] [stderr]     |
[INFO] [stderr] 319 |                                 println!("{} {} {}", 0x1B, 0x5b, c.unwrap().unwrap());
[INFO] [stderr]     |                                                            ^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#print_literal
[INFO] [stderr] 
[INFO] [stderr] warning: literal with an empty format string
[INFO] [stderr]    --> src/lib.rs:325:43
[INFO] [stderr]     |
[INFO] [stderr] 325 |                         println!("{} {}", 0x1B, c.unwrap().unwrap());
[INFO] [stderr]     |                                           ^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#print_literal
[INFO] [stderr] 
[INFO] [stderr] warning: literal with an empty format string
[INFO] [stderr]    --> src/lib.rs:398:42
[INFO] [stderr]     |
[INFO] [stderr] 398 |                             print!("{}", '\n');
[INFO] [stderr]     |                                          ^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#print_literal
[INFO] [stderr] 
[INFO] [stderr] warning: using `println!("")`
[INFO] [stderr]    --> src/lib.rs:406:29
[INFO] [stderr]     |
[INFO] [stderr] 406 |                             println!("");
[INFO] [stderr]     |                             ^^^^^^^^^^^^ help: replace it with: `println!()`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::println_empty_string)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#println_empty_string
[INFO] [stderr] 
[INFO] [stderr] warning: using `println!("")`
[INFO] [stderr]    --> src/lib.rs:413:29
[INFO] [stderr]     |
[INFO] [stderr] 413 |                             println!("");
[INFO] [stderr]     |                             ^^^^^^^^^^^^ help: replace it with: `println!()`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#println_empty_string
[INFO] [stderr] 
[INFO] [stderr] warning: literal with an empty format string
[INFO] [stderr]    --> src/lib.rs:319:54
[INFO] [stderr]     |
[INFO] [stderr] 319 |                                 println!("{} {} {}", 0x1B, 0x5b, c.unwrap().unwrap());
[INFO] [stderr]     |                                                      ^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::print_literal)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#print_literal
[INFO] [stderr] 
[INFO] [stderr] warning: literal with an empty format string
[INFO] [stderr]    --> src/lib.rs:319:60
[INFO] [stderr]     |
[INFO] [stderr] 319 |                                 println!("{} {} {}", 0x1B, 0x5b, c.unwrap().unwrap());
[INFO] [stderr]     |                                                            ^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#print_literal
[INFO] [stderr] 
[INFO] [stderr] warning: literal with an empty format string
[INFO] [stderr]    --> src/lib.rs:325:43
[INFO] [stderr]     |
[INFO] [stderr] 325 |                         println!("{} {}", 0x1B, c.unwrap().unwrap());
[INFO] [stderr]     |                                           ^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#print_literal
[INFO] [stderr] 
[INFO] [stderr] warning: literal with an empty format string
[INFO] [stderr]    --> src/lib.rs:398:42
[INFO] [stderr]     |
[INFO] [stderr] 398 |                             print!("{}", '\n');
[INFO] [stderr]     |                                          ^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#print_literal
[INFO] [stderr] 
[INFO] [stderr] warning: using `println!("")`
[INFO] [stderr]    --> src/lib.rs:406:29
[INFO] [stderr]     |
[INFO] [stderr] 406 |                             println!("");
[INFO] [stderr]     |                             ^^^^^^^^^^^^ help: replace it with: `println!()`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::println_empty_string)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#println_empty_string
[INFO] [stderr] 
[INFO] [stderr] warning: using `println!("")`
[INFO] [stderr]    --> src/lib.rs:413:29
[INFO] [stderr]     |
[INFO] [stderr] 413 |                             println!("");
[INFO] [stderr]     |                             ^^^^^^^^^^^^ help: replace it with: `println!()`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#println_empty_string
[INFO] [stderr] 
[INFO] [stderr] warning: this `else { if .. }` block can be collapsed
[INFO] [stderr]    --> src/lib.rs:148:20
[INFO] [stderr]     |
[INFO] [stderr] 148 |               } else {
[INFO] [stderr]     |  ____________________^
[INFO] [stderr] 149 | |                 if let Some(cmd) = self.commands.get_mut(portion) {
[INFO] [stderr] 150 | |                     if let Err(_) = cmd._register(it, command.clone()) {
[INFO] [stderr] 151 | |                         cmd.handler = Some(command.clone())
[INFO] [stderr] 152 | |                     }
[INFO] [stderr] 153 | |                 }
[INFO] [stderr] 154 | |             };
[INFO] [stderr]     | |_____________^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::collapsible_if)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if
[INFO] [stderr] help: try
[INFO] [stderr]     |
[INFO] [stderr] 148 |             } else if let Some(cmd) = self.commands.get_mut(portion) {
[INFO] [stderr] 149 |     if let Err(_) = cmd._register(it, command.clone()) {
[INFO] [stderr] 150 |         cmd.handler = Some(command.clone())
[INFO] [stderr] 151 |     }
[INFO] [stderr] 152 | };
[INFO] [stderr]     |
[INFO] [stderr] 
[INFO] [stderr] warning: this `else { if .. }` block can be collapsed
[INFO] [stderr]    --> src/lib.rs:237:16
[INFO] [stderr]     |
[INFO] [stderr] 237 |           } else {
[INFO] [stderr]     |  ________________^
[INFO] [stderr] 238 | |             if let Some(ref mut cb) = self.handler {
[INFO] [stderr] 239 | |                 (&mut *cb.exec.borrow_mut())(argv);
[INFO] [stderr] 240 | |             }
[INFO] [stderr] 241 | |         }
[INFO] [stderr]     | |_________^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if
[INFO] [stderr] help: try
[INFO] [stderr]     |
[INFO] [stderr] 237 |         } else if let Some(ref mut cb) = self.handler {
[INFO] [stderr] 238 |     (&mut *cb.exec.borrow_mut())(argv);
[INFO] [stderr] 239 | }
[INFO] [stderr]     |
[INFO] [stderr] 
[INFO] [stderr] warning: this `else { if .. }` block can be collapsed
[INFO] [stderr]    --> src/lib.rs:232:20
[INFO] [stderr]     |
[INFO] [stderr] 232 |               } else {
[INFO] [stderr]     |  ____________________^
[INFO] [stderr] 233 | |                 if let Some(ref mut cb) = self.handler {
[INFO] [stderr] 234 | |                     (&mut *cb.exec.borrow_mut())(argv);
[INFO] [stderr] 235 | |                 }
[INFO] [stderr] 236 | |             }
[INFO] [stderr]     | |_____________^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if
[INFO] [stderr] help: try
[INFO] [stderr]     |
[INFO] [stderr] 232 |             } else if let Some(ref mut cb) = self.handler {
[INFO] [stderr] 233 |     (&mut *cb.exec.borrow_mut())(argv);
[INFO] [stderr] 234 | }
[INFO] [stderr]     |
[INFO] [stderr] 
[INFO] [stderr] warning: this `else { if .. }` block can be collapsed
[INFO] [stderr]    --> src/lib.rs:148:20
[INFO] [stderr]     |
[INFO] [stderr] 148 |               } else {
[INFO] [stderr]     |  ____________________^
[INFO] [stderr] 149 | |                 if let Some(cmd) = self.commands.get_mut(portion) {
[INFO] [stderr] 150 | |                     if let Err(_) = cmd._register(it, command.clone()) {
[INFO] [stderr] 151 | |                         cmd.handler = Some(command.clone())
[INFO] [stderr] 152 | |                     }
[INFO] [stderr] 153 | |                 }
[INFO] [stderr] 154 | |             };
[INFO] [stderr]     | |_____________^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::collapsible_if)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if
[INFO] [stderr] help: try
[INFO] [stderr]     |
[INFO] [stderr] 148 |             } else if let Some(cmd) = self.commands.get_mut(portion) {
[INFO] [stderr] 149 |     if let Err(_) = cmd._register(it, command.clone()) {
[INFO] [stderr] warning: field is never used: `command`
[INFO] [stderr]   --> src/lib.rs:49:5
[INFO] [stderr]    |
[INFO] [stderr] 49 |     command: Vec<&'a str>,
[INFO] [stderr]    |     ^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(dead_code)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: very complex type used. Consider factoring parts into `type` definitions
[INFO] [stderr]   --> src/lib.rs:51:15
[INFO] [stderr]    |
[INFO] [stderr] 51 |     complete: Option<Box<RefCell<for <'b> FnMut(Vec<&'b str>) -> Vec<&'a str> + 'a>>>
[INFO] [stderr]    |               ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::type_complexity)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity
[INFO] [stderr] 
[INFO] [stderr] 150 |         cmd.handler = Some(command.clone())
[INFO] [stderr] 151 |     }
[INFO] [stderr] 152 | };
[INFO] [stderr]     |
[INFO] [stderr] 
[INFO] [stderr] warning: this `else { if .. }` block can be collapsed
[INFO] [stderr]    --> src/lib.rs:237:16
[INFO] [stderr]     |
[INFO] [stderr] 237 |           } else {
[INFO] [stderr]     |  ________________^
[INFO] [stderr] 238 | |             if let Some(ref mut cb) = self.handler {
[INFO] [stderr] 239 | |                 (&mut *cb.exec.borrow_mut())(argv);
[INFO] [stderr] 240 | |             }
[INFO] [stderr] 241 | |         }
[INFO] [stderr]     | |_________^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if
[INFO] [stderr] help: try
[INFO] [stderr]     |
[INFO] [stderr] 237 |         } else if let Some(ref mut cb) = self.handler {
[INFO] [stderr] 238 |     (&mut *cb.exec.borrow_mut())(argv);
[INFO] [stderr] 239 | }
[INFO] [stderr]     |
[INFO] [stderr] 
[INFO] [stderr] warning: this `else { if .. }` block can be collapsed
[INFO] [stderr]    --> src/lib.rs:232:20
[INFO] [stderr]     |
[INFO] [stderr] 232 |               } else {
[INFO] [stderr]     |  ____________________^
[INFO] [stderr] 233 | |                 if let Some(ref mut cb) = self.handler {
[INFO] [stderr] 234 | |                     (&mut *cb.exec.borrow_mut())(argv);
[INFO] [stderr] 235 | |                 }
[INFO] [stderr] 236 | |             }
[INFO] [stderr]     | |_____________^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if
[INFO] [stderr] help: try
[INFO] [stderr]     |
[INFO] [stderr] 232 |             } else if let Some(ref mut cb) = self.handler {
[INFO] [stderr] 233 |     (&mut *cb.exec.borrow_mut())(argv);
[INFO] [stderr] 234 | }
[INFO] [stderr]     |
[INFO] [stderr] 
[INFO] [stderr] warning: very complex type used. Consider factoring parts into `type` definitions
[INFO] [stderr]   --> src/lib.rs:56:29
[INFO] [stderr]    |
[INFO] [stderr] 56 |         let mut complete_cb:Option<Box<RefCell<for <'b> FnMut(Vec<&'b str>) -> Vec<&'a str>>>> = None;
[INFO] [stderr]    |                             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity
[INFO] [stderr] 
[INFO] [stderr] warning: you should consider deriving a `Default` implementation for `Cli<'a>`
[INFO] [stderr]   --> src/lib.rs:80:5
[INFO] [stderr]    |
[INFO] [stderr] 80 | /     pub fn new() -> Cli<'a> {
[INFO] [stderr] 81 | |         Cli {
[INFO] [stderr] 82 | |             commands: HashMap::new(),
[INFO] [stderr] 83 | |             handler: None
[INFO] [stderr] 84 | |         }
[INFO] [stderr] 85 | |     }
[INFO] [stderr]    | |_____^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::new_without_default_derive)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive
[INFO] [stderr] help: try this
[INFO] [stderr]    |
[INFO] [stderr] 70 | #[derive(Default)]
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: redundant pattern matching, consider using `is_err()`
[INFO] [stderr]    --> src/lib.rs:144:24
[INFO] [stderr]     |
[INFO] [stderr] 144 |                   if let Err(_) = cli._register(it, command.clone()) {
[INFO] [stderr]     |  _________________-      ^^^^^^
[INFO] [stderr] 145 | |                     cli.handler = Some(command.clone())
[INFO] [stderr] 146 | |                 }
[INFO] [stderr]     | |_________________- help: try this: `if cli._register(it, command.clone()).is_err()`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::redundant_pattern_matching)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching
[INFO] [stderr] 
[INFO] [stderr] warning: redundant pattern matching, consider using `is_err()`
[INFO] [stderr]    --> src/lib.rs:150:28
[INFO] [stderr]     |
[INFO] [stderr] 150 |                       if let Err(_) = cmd._register(it, command.clone()) {
[INFO] [stderr]     |  _____________________-      ^^^^^^
[INFO] [stderr] 151 | |                         cmd.handler = Some(command.clone())
[INFO] [stderr] 152 | |                     }
[INFO] [stderr]     | |_____________________- help: try this: `if cmd._register(it, command.clone()).is_err()`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching
[INFO] [stderr] 
[INFO] [stderr] error: using `clone` on a double-reference; this will copy the reference instead of cloning the inner type
[INFO] [stderr]    --> src/lib.rs:221:30
[INFO] [stderr]     |
[INFO] [stderr] 221 |         let argv:Vec<&str> = cmd.clone().split_whitespace().collect();
[INFO] [stderr]     |                              ^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[deny(clippy::clone_double_ref)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_double_ref
[INFO] [stderr] help: try dereferencing it
[INFO] [stderr]     |
[INFO] [stderr] 221 |         let argv:Vec<&str> = &(*cmd).clone().split_whitespace().collect();
[INFO] [stderr]     |                              ^^^^^^^^^^^^^^^
[INFO] [stderr] help: or try being explicit about what type to clone
[INFO] [stderr]     |
[INFO] [stderr] 221 |         let argv:Vec<&str> = &str::clone(cmd).split_whitespace().collect();
[INFO] [stderr]     |                              ^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: the `c @ _` pattern can be written as just `c`
[INFO] [stderr]    --> src/lib.rs:318:29
[INFO] [stderr]     |
[INFO] [stderr] 318 |                             c @ _ => {
[INFO] [stderr]     |                             ^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::redundant_pattern)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: the `c @ _` pattern can be written as just `c`
[INFO] [stderr]    --> src/lib.rs:324:21
[INFO] [stderr]     |
[INFO] [stderr] 324 |                     c @ _ => {
[INFO] [stderr]     |                     ^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: this loop could be written as a `while let` loop
[INFO] [stderr]    --> src/lib.rs:377:9
[INFO] [stderr]     |
[INFO] [stderr] 377 | /         loop {
[INFO] [stderr] 378 | |             match read_key(&mut input_iter) {
[INFO] [stderr] 379 | |                 Some(key) => {
[INFO] [stderr] 380 | |                     match key {
[INFO] [stderr] ...   |
[INFO] [stderr] 424 | |             }
[INFO] [stderr] 425 | |         }
[INFO] [stderr]     | |_________^ help: try: `while let Some(key) = read_key(&mut input_iter) { .. }`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::while_let_loop)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#while_let_loop
[INFO] [stderr] 
[INFO] [stderr] warning: the `x @ _` pattern can be written as just `x`
[INFO] [stderr]    --> src/lib.rs:416:25
[INFO] [stderr]     |
[INFO] [stderr] 416 |                         x @ _ => {
[INFO] [stderr]     |                         ^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: equality checks against true are unnecessary
[INFO] [stderr]    --> src/lib.rs:442:17
[INFO] [stderr]     |
[INFO] [stderr] 442 |         assert!(called == true)
[INFO] [stderr]     |                 ^^^^^^^^^^^^^^ help: try simplifying it as shown: `called`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::bool_comparison)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison
[INFO] [stderr] 
[INFO] [stderr] warning: manual implementation of an assign operation
[INFO] [stderr]    --> src/lib.rs:450:54
[INFO] [stderr]     |
[INFO] [stderr] 450 |             cli.register(vec!["foo", "bar"], | _ | { called = called + 1} ).ok();
[INFO] [stderr]     |                                                      ^^^^^^^^^^^^^^^^^^^ help: replace it with: `called += 1`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::assign_op_pattern)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: equality checks against true are unnecessary
[INFO] [stderr]    --> src/lib.rs:498:17
[INFO] [stderr]     |
[INFO] [stderr] 498 |         assert!(called == true);
[INFO] [stderr]     |                 ^^^^^^^^^^^^^^ help: try simplifying it as shown: `called`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison
[INFO] [stderr] 
[INFO] [stderr] error: aborting due to previous error
[INFO] [stderr] 
[INFO] [stderr] error: Could not compile `cline`.
[INFO] [stderr] warning: build failed, waiting for other jobs to finish...
[INFO] [stderr] warning: field is never used: `command`
[INFO] [stderr]   --> src/lib.rs:49:5
[INFO] [stderr]    |
[INFO] [stderr] 49 |     command: Vec<&'a str>,
[INFO] [stderr]    |     ^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(dead_code)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: very complex type used. Consider factoring parts into `type` definitions
[INFO] [stderr]   --> src/lib.rs:51:15
[INFO] [stderr]    |
[INFO] [stderr] 51 |     complete: Option<Box<RefCell<for <'b> FnMut(Vec<&'b str>) -> Vec<&'a str> + 'a>>>
[INFO] [stderr]    |               ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::type_complexity)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity
[INFO] [stderr] 
[INFO] [stderr] warning: very complex type used. Consider factoring parts into `type` definitions
[INFO] [stderr]   --> src/lib.rs:56:29
[INFO] [stderr]    |
[INFO] [stderr] 56 |         let mut complete_cb:Option<Box<RefCell<for <'b> FnMut(Vec<&'b str>) -> Vec<&'a str>>>> = None;
[INFO] [stderr]    |                             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity
[INFO] [stderr] 
[INFO] [stderr] warning: you should consider deriving a `Default` implementation for `Cli<'a>`
[INFO] [stderr]   --> src/lib.rs:80:5
[INFO] [stderr]    |
[INFO] [stderr] 80 | /     pub fn new() -> Cli<'a> {
[INFO] [stderr] 81 | |         Cli {
[INFO] [stderr] 82 | |             commands: HashMap::new(),
[INFO] [stderr] 83 | |             handler: None
[INFO] [stderr] 84 | |         }
[INFO] [stderr] 85 | |     }
[INFO] [stderr]    | |_____^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::new_without_default_derive)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive
[INFO] [stderr] help: try this
[INFO] [stderr]    |
[INFO] [stderr] 70 | #[derive(Default)]
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: redundant pattern matching, consider using `is_err()`
[INFO] [stderr]    --> src/lib.rs:144:24
[INFO] [stderr]     |
[INFO] [stderr] 144 |                   if let Err(_) = cli._register(it, command.clone()) {
[INFO] [stderr]     |  _________________-      ^^^^^^
[INFO] [stderr] 145 | |                     cli.handler = Some(command.clone())
[INFO] [stderr] 146 | |                 }
[INFO] [stderr]     | |_________________- help: try this: `if cli._register(it, command.clone()).is_err()`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::redundant_pattern_matching)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching
[INFO] [stderr] 
[INFO] [stderr] warning: redundant pattern matching, consider using `is_err()`
[INFO] [stderr]    --> src/lib.rs:150:28
[INFO] [stderr]     |
[INFO] [stderr] 150 |                       if let Err(_) = cmd._register(it, command.clone()) {
[INFO] [stderr]     |  _____________________-      ^^^^^^
[INFO] [stderr] 151 | |                         cmd.handler = Some(command.clone())
[INFO] [stderr] 152 | |                     }
[INFO] [stderr]     | |_____________________- help: try this: `if cmd._register(it, command.clone()).is_err()`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching
[INFO] [stderr] 
[INFO] [stderr] error: using `clone` on a double-reference; this will copy the reference instead of cloning the inner type
[INFO] [stderr]    --> src/lib.rs:221:30
[INFO] [stderr]     |
[INFO] [stderr] 221 |         let argv:Vec<&str> = cmd.clone().split_whitespace().collect();
[INFO] [stderr]     |                              ^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[deny(clippy::clone_double_ref)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_double_ref
[INFO] [stderr] help: try dereferencing it
[INFO] [stderr]     |
[INFO] [stderr] 221 |         let argv:Vec<&str> = &(*cmd).clone().split_whitespace().collect();
[INFO] [stderr]     |                              ^^^^^^^^^^^^^^^
[INFO] [stderr] help: or try being explicit about what type to clone
[INFO] [stderr]     |
[INFO] [stderr] 221 |         let argv:Vec<&str> = &str::clone(cmd).split_whitespace().collect();
[INFO] [stderr]     |                              ^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: the `c @ _` pattern can be written as just `c`
[INFO] [stderr]    --> src/lib.rs:318:29
[INFO] [stderr]     |
[INFO] [stderr] 318 |                             c @ _ => {
[INFO] [stderr]     |                             ^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::redundant_pattern)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: the `c @ _` pattern can be written as just `c`
[INFO] [stderr]    --> src/lib.rs:324:21
[INFO] [stderr]     |
[INFO] [stderr] 324 |                     c @ _ => {
[INFO] [stderr]     |                     ^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: this loop could be written as a `while let` loop
[INFO] [stderr]    --> src/lib.rs:377:9
[INFO] [stderr]     |
[INFO] [stderr] 377 | /         loop {
[INFO] [stderr] 378 | |             match read_key(&mut input_iter) {
[INFO] [stderr] 379 | |                 Some(key) => {
[INFO] [stderr] 380 | |                     match key {
[INFO] [stderr] ...   |
[INFO] [stderr] 424 | |             }
[INFO] [stderr] 425 | |         }
[INFO] [stderr]     | |_________^ help: try: `while let Some(key) = read_key(&mut input_iter) { .. }`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::while_let_loop)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#while_let_loop
[INFO] [stderr] 
[INFO] [stderr] warning: the `x @ _` pattern can be written as just `x`
[INFO] [stderr]    --> src/lib.rs:416:25
[INFO] [stderr]     |
[INFO] [stderr] 416 |                         x @ _ => {
[INFO] [stderr]     |                         ^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern
[INFO] [stderr] 
[INFO] [stderr] error: aborting due to previous error
[INFO] [stderr] 
[INFO] [stderr] error: Could not compile `cline`.
[INFO] [stderr] 
[INFO] [stderr] To learn more, run the command again with --verbose.
[INFO] running `"docker" "inspect" "f21de18baf0208cdfbf1d9ef126f8a773590843e03dc90b6663897c2f78dfbff"`
[INFO] running `"docker" "rm" "-f" "f21de18baf0208cdfbf1d9ef126f8a773590843e03dc90b6663897c2f78dfbff"`
[INFO] [stdout] f21de18baf0208cdfbf1d9ef126f8a773590843e03dc90b6663897c2f78dfbff