[INFO] crate clicolors-control 0.3.1 is already in cache [INFO] extracting crate clicolors-control 0.3.1 into work/ex/clippy-test-run/sources/stable/reg/clicolors-control/0.3.1 [INFO] extracting crate clicolors-control 0.3.1 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/clicolors-control/0.3.1 [INFO] validating manifest of clicolors-control-0.3.1 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of clicolors-control-0.3.1 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing clicolors-control-0.3.1 [INFO] finished frobbing clicolors-control-0.3.1 [INFO] frobbed toml for clicolors-control-0.3.1 written to work/ex/clippy-test-run/sources/stable/reg/clicolors-control/0.3.1/Cargo.toml [INFO] started frobbing clicolors-control-0.3.1 [INFO] finished frobbing clicolors-control-0.3.1 [INFO] frobbed toml for clicolors-control-0.3.1 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/clicolors-control/0.3.1/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting clicolors-control-0.3.1 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-3/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/clicolors-control/0.3.1:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 0eae4a2f1f589ff9b05173a06d5675e57c232ec27eeeefaecb53dcf6fe093a4a [INFO] running `"docker" "start" "-a" "0eae4a2f1f589ff9b05173a06d5675e57c232ec27eeeefaecb53dcf6fe093a4a"` [INFO] [stderr] Checking clicolors-control v0.3.1 (/opt/crater/workdir) [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/common.rs:11:53 [INFO] [stderr] | [INFO] [stderr] 11 | (is_a_color_terminal() && &env::var("CLICOLOR").unwrap_or("1".into()) != "0") || [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| "1".into())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/common.rs:12:33 [INFO] [stderr] | [INFO] [stderr] 12 | &env::var("CLICOLOR_FORCE").unwrap_or("0".into()) != "0" [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| "0".into())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/common.rs:11:53 [INFO] [stderr] | [INFO] [stderr] 11 | (is_a_color_terminal() && &env::var("CLICOLOR").unwrap_or("1".into()) != "0") || [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| "1".into())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/common.rs:12:33 [INFO] [stderr] | [INFO] [stderr] 12 | &env::var("CLICOLOR_FORCE").unwrap_or("0".into()) != "0" [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| "0".into())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 1.81s [INFO] running `"docker" "inspect" "0eae4a2f1f589ff9b05173a06d5675e57c232ec27eeeefaecb53dcf6fe093a4a"` [INFO] running `"docker" "rm" "-f" "0eae4a2f1f589ff9b05173a06d5675e57c232ec27eeeefaecb53dcf6fe093a4a"` [INFO] [stdout] 0eae4a2f1f589ff9b05173a06d5675e57c232ec27eeeefaecb53dcf6fe093a4a