[INFO] crate cli-proxy 0.3.5 is already in cache
[INFO] extracting crate cli-proxy 0.3.5 into work/ex/clippy-test-run/sources/stable/reg/cli-proxy/0.3.5
[INFO] extracting crate cli-proxy 0.3.5 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/cli-proxy/0.3.5
[INFO] validating manifest of cli-proxy-0.3.5 on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of cli-proxy-0.3.5 on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing cli-proxy-0.3.5
[INFO] finished frobbing cli-proxy-0.3.5
[INFO] frobbed toml for cli-proxy-0.3.5 written to work/ex/clippy-test-run/sources/stable/reg/cli-proxy/0.3.5/Cargo.toml
[INFO] started frobbing cli-proxy-0.3.5
[INFO] finished frobbing cli-proxy-0.3.5
[INFO] frobbed toml for cli-proxy-0.3.5 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/cli-proxy/0.3.5/Cargo.toml
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting cli-proxy-0.3.5 against stable for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-7/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/cli-proxy/0.3.5:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] a2b461081f34b2c4b20c25186a7809cf7b42258aa763e384b2cae96d911ade75
[INFO] running `"docker" "start" "-a" "a2b461081f34b2c4b20c25186a7809cf7b42258aa763e384b2cae96d911ade75"`
[INFO] [stderr]     Checking tiny_http v0.6.2
[INFO] [stderr]     Checking multipart v0.13.6
[INFO] [stderr]     Checking rouille v2.2.0
[INFO] [stderr]     Checking cli-proxy v0.3.5 (/opt/crater/workdir)
[INFO] [stderr] warning: single-character string constant used as pattern
[INFO] [stderr]    --> src/main.rs:141:27
[INFO] [stderr]     |
[INFO] [stderr] 141 |     if !cur_dir.ends_with("/") { cur_dir.push('/'); }
[INFO] [stderr]     |                           ^^^ help: try using a char instead: `'/'`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::single_char_pattern)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: single-character string constant used as pattern
[INFO] [stderr]    --> src/main.rs:153:84
[INFO] [stderr]     |
[INFO] [stderr] 153 |     let path = base_dir.join(std::path::Path::new(&request.url().trim_left_matches("/")));
[INFO] [stderr]     |                                                                                    ^^^ help: try using a char instead: `'/'`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: single-character string constant used as pattern
[INFO] [stderr]    --> src/main.rs:165:38
[INFO] [stderr]     |
[INFO] [stderr] 165 |         if is_dir && !path.ends_with("/") { path.push('/'); }
[INFO] [stderr]     |                                      ^^^ help: try using a char instead: `'/'`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: you don't need to add `&` to all patterns
[INFO] [stderr]    --> src/main.rs:194:21
[INFO] [stderr]     |
[INFO] [stderr] 194 | /                     match e.kind() {
[INFO] [stderr] 195 | |                         &ErrorKind::DoesNotExist(_) => {
[INFO] [stderr] 196 | |                             Response::text("Not Found").with_status_code(404)
[INFO] [stderr] 197 | |                         }
[INFO] [stderr] ...   |
[INFO] [stderr] 200 | |                         }
[INFO] [stderr] 201 | |                     }
[INFO] [stderr]     | |_____________________^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::match_ref_pats)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats
[INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression
[INFO] [stderr]     |
[INFO] [stderr] 194 |                     match *e.kind() {
[INFO] [stderr] 195 |                         ErrorKind::DoesNotExist(_) => {
[INFO] [stderr]     |
[INFO] [stderr] 
[INFO] [stderr] warning: single-character string constant used as pattern
[INFO] [stderr]    --> src/main.rs:358:34
[INFO] [stderr]     |
[INFO] [stderr] 358 |                 proxy_addr.split(":").nth(0).unwrap().to_owned()
[INFO] [stderr]     |                                  ^^^ help: try using a char instead: `':'`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: single-character string constant used as pattern
[INFO] [stderr]    --> src/main.rs:368:43
[INFO] [stderr]     |
[INFO] [stderr] 368 |                     let parts = val.split(",").collect::<Vec<_>>();
[INFO] [stderr]     |                                           ^^^ help: try using a char instead: `','`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: single-character string constant used as pattern
[INFO] [stderr]    --> src/main.rs:382:43
[INFO] [stderr]     |
[INFO] [stderr] 382 |                     let parts = val.split(",").collect::<Vec<_>>();
[INFO] [stderr]     |                                           ^^^ help: try using a char instead: `','`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: single-character string constant used as pattern
[INFO] [stderr]    --> src/main.rs:395:45
[INFO] [stderr]     |
[INFO] [stderr] 395 |                     let parts = proxy.split(",").collect::<Vec<_>>();
[INFO] [stderr]     |                                             ^^^ help: try using a char instead: `','`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: single-character string constant used as pattern
[INFO] [stderr]    --> src/main.rs:403:63
[INFO] [stderr]     |
[INFO] [stderr] 403 |                             replace_host: Some(parts[1].split(":").nth(0).unwrap().to_owned().into()),
[INFO] [stderr]     |                                                               ^^^ help: try using a char instead: `':'`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: single-character string constant used as pattern
[INFO] [stderr]    --> src/main.rs:141:27
[INFO] [stderr]     |
[INFO] [stderr] 141 |     if !cur_dir.ends_with("/") { cur_dir.push('/'); }
[INFO] [stderr]     |                           ^^^ help: try using a char instead: `'/'`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::single_char_pattern)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: single-character string constant used as pattern
[INFO] [stderr]    --> src/main.rs:153:84
[INFO] [stderr]     |
[INFO] [stderr] 153 |     let path = base_dir.join(std::path::Path::new(&request.url().trim_left_matches("/")));
[INFO] [stderr]     |                                                                                    ^^^ help: try using a char instead: `'/'`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: single-character string constant used as pattern
[INFO] [stderr]    --> src/main.rs:165:38
[INFO] [stderr]     |
[INFO] [stderr] 165 |         if is_dir && !path.ends_with("/") { path.push('/'); }
[INFO] [stderr]     |                                      ^^^ help: try using a char instead: `'/'`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: you don't need to add `&` to all patterns
[INFO] [stderr]    --> src/main.rs:194:21
[INFO] [stderr]     |
[INFO] [stderr] 194 | /                     match e.kind() {
[INFO] [stderr] 195 | |                         &ErrorKind::DoesNotExist(_) => {
[INFO] [stderr] 196 | |                             Response::text("Not Found").with_status_code(404)
[INFO] [stderr] 197 | |                         }
[INFO] [stderr] ...   |
[INFO] [stderr] 200 | |                         }
[INFO] [stderr] 201 | |                     }
[INFO] [stderr]     | |_____________________^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::match_ref_pats)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats
[INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression
[INFO] [stderr]     |
[INFO] [stderr] 194 |                     match *e.kind() {
[INFO] [stderr] 195 |                         ErrorKind::DoesNotExist(_) => {
[INFO] [stderr]     |
[INFO] [stderr] 
[INFO] [stderr] warning: single-character string constant used as pattern
[INFO] [stderr]    --> src/main.rs:358:34
[INFO] [stderr]     |
[INFO] [stderr] 358 |                 proxy_addr.split(":").nth(0).unwrap().to_owned()
[INFO] [stderr]     |                                  ^^^ help: try using a char instead: `':'`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: single-character string constant used as pattern
[INFO] [stderr]    --> src/main.rs:368:43
[INFO] [stderr]     |
[INFO] [stderr] 368 |                     let parts = val.split(",").collect::<Vec<_>>();
[INFO] [stderr]     |                                           ^^^ help: try using a char instead: `','`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: single-character string constant used as pattern
[INFO] [stderr]    --> src/main.rs:382:43
[INFO] [stderr]     |
[INFO] [stderr] 382 |                     let parts = val.split(",").collect::<Vec<_>>();
[INFO] [stderr]     |                                           ^^^ help: try using a char instead: `','`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: single-character string constant used as pattern
[INFO] [stderr]    --> src/main.rs:395:45
[INFO] [stderr]     |
[INFO] [stderr] 395 |                     let parts = proxy.split(",").collect::<Vec<_>>();
[INFO] [stderr]     |                                             ^^^ help: try using a char instead: `','`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: single-character string constant used as pattern
[INFO] [stderr]    --> src/main.rs:403:63
[INFO] [stderr]     |
[INFO] [stderr] 403 |                             replace_host: Some(parts[1].split(":").nth(0).unwrap().to_owned().into()),
[INFO] [stderr]     |                                                               ^^^ help: try using a char instead: `':'`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern
[INFO] [stderr] 
[INFO] [stderr]     Finished dev [unoptimized + debuginfo] target(s) in 14.20s
[INFO] running `"docker" "inspect" "a2b461081f34b2c4b20c25186a7809cf7b42258aa763e384b2cae96d911ade75"`
[INFO] running `"docker" "rm" "-f" "a2b461081f34b2c4b20c25186a7809cf7b42258aa763e384b2cae96d911ade75"`
[INFO] [stdout] a2b461081f34b2c4b20c25186a7809cf7b42258aa763e384b2cae96d911ade75