[INFO] crate clear_on_drop 0.2.3 is already in cache [INFO] extracting crate clear_on_drop 0.2.3 into work/ex/clippy-test-run/sources/stable/reg/clear_on_drop/0.2.3 [INFO] extracting crate clear_on_drop 0.2.3 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/clear_on_drop/0.2.3 [INFO] validating manifest of clear_on_drop-0.2.3 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of clear_on_drop-0.2.3 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing clear_on_drop-0.2.3 [INFO] finished frobbing clear_on_drop-0.2.3 [INFO] frobbed toml for clear_on_drop-0.2.3 written to work/ex/clippy-test-run/sources/stable/reg/clear_on_drop/0.2.3/Cargo.toml [INFO] started frobbing clear_on_drop-0.2.3 [INFO] finished frobbing clear_on_drop-0.2.3 [INFO] frobbed toml for clear_on_drop-0.2.3 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/clear_on_drop/0.2.3/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting clear_on_drop-0.2.3 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-6/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/clear_on_drop/0.2.3:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 69885f19e224c47e5c2215d69037086e196692ab218560ed597cfca5ac4729b4 [INFO] running `"docker" "start" "-a" "69885f19e224c47e5c2215d69037086e196692ab218560ed597cfca5ac4729b4"` [INFO] [stderr] Compiling clear_on_drop v0.2.3 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/clear_stack_on_return.rs:28:37 [INFO] [stderr] | [INFO] [stderr] 28 | let _clear = ClearStackOnDrop { pages: pages }; [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `pages` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/clear_stack_on_return.rs:28:37 [INFO] [stderr] | [INFO] [stderr] 28 | let _clear = ClearStackOnDrop { pages: pages }; [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `pages` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: methods called `into_*` usually take self by value; consider choosing a less ambiguous name [INFO] [stderr] --> src/clear_on_drop.rs:69:23 [INFO] [stderr] | [INFO] [stderr] 69 | pub fn into_place(mut c: Self) -> P { [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::wrong_self_convention)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention [INFO] [stderr] [INFO] [stderr] warning: methods called `into_*` usually take self by value; consider choosing a less ambiguous name [INFO] [stderr] --> src/clear_on_drop.rs:81:33 [INFO] [stderr] | [INFO] [stderr] 81 | pub fn into_uncleared_place(c: Self) -> P { [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention [INFO] [stderr] [INFO] [stderr] warning: re-implementing `PartialEq::ne` is unnecessary [INFO] [stderr] --> src/clear_on_drop.rs:237:5 [INFO] [stderr] | [INFO] [stderr] 237 | / fn ne(&self, other: &ClearOnDrop) -> bool { [INFO] [stderr] 238 | | PartialEq::ne(&self._place, &other._place) [INFO] [stderr] 239 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::partialeq_ne_impl)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#partialeq_ne_impl [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/clear_on_drop.rs:302:29 [INFO] [stderr] | [INFO] [stderr] 302 | const DATA: [u32; 4] = [0x01234567, 0x89abcdef, 0xfedcba98, 0x76543210]; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0123_4567` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/clear_on_drop.rs:302:41 [INFO] [stderr] | [INFO] [stderr] 302 | const DATA: [u32; 4] = [0x01234567, 0x89abcdef, 0xfedcba98, 0x76543210]; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x89ab_cdef` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/clear_on_drop.rs:302:53 [INFO] [stderr] | [INFO] [stderr] 302 | const DATA: [u32; 4] = [0x01234567, 0x89abcdef, 0xfedcba98, 0x76543210]; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0xfedc_ba98` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/clear_on_drop.rs:302:65 [INFO] [stderr] | [INFO] [stderr] 302 | const DATA: [u32; 4] = [0x01234567, 0x89abcdef, 0xfedcba98, 0x76543210]; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x7654_3210` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/hide.rs:92:29 [INFO] [stderr] | [INFO] [stderr] 92 | const DATA: [u32; 4] = [0x01234567, 0x89abcdef, 0xfedcba98, 0x76543210]; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0123_4567` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/hide.rs:92:41 [INFO] [stderr] | [INFO] [stderr] 92 | const DATA: [u32; 4] = [0x01234567, 0x89abcdef, 0xfedcba98, 0x76543210]; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x89ab_cdef` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/hide.rs:92:53 [INFO] [stderr] | [INFO] [stderr] 92 | const DATA: [u32; 4] = [0x01234567, 0x89abcdef, 0xfedcba98, 0x76543210]; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0xfedc_ba98` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/hide.rs:92:65 [INFO] [stderr] | [INFO] [stderr] 92 | const DATA: [u32; 4] = [0x01234567, 0x89abcdef, 0xfedcba98, 0x76543210]; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x7654_3210` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] error[E0554]: #![feature] may not be used on the stable release channel [INFO] [stderr] --> benches/clear_on_drop.rs:1:1 [INFO] [stderr] | [INFO] [stderr] 1 | #![feature(test)] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] For more information about this error, try `rustc --explain E0554`. [INFO] [stderr] error: Could not compile `clear_on_drop`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] warning: methods called `into_*` usually take self by value; consider choosing a less ambiguous name [INFO] [stderr] --> src/clear_on_drop.rs:69:23 [INFO] [stderr] | [INFO] [stderr] 69 | pub fn into_place(mut c: Self) -> P { [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::wrong_self_convention)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention [INFO] [stderr] [INFO] [stderr] warning: methods called `into_*` usually take self by value; consider choosing a less ambiguous name [INFO] [stderr] --> src/clear_on_drop.rs:81:33 [INFO] [stderr] | [INFO] [stderr] 81 | pub fn into_uncleared_place(c: Self) -> P { [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention [INFO] [stderr] [INFO] [stderr] warning: re-implementing `PartialEq::ne` is unnecessary [INFO] [stderr] --> src/clear_on_drop.rs:237:5 [INFO] [stderr] | [INFO] [stderr] 237 | / fn ne(&self, other: &ClearOnDrop) -> bool { [INFO] [stderr] 238 | | PartialEq::ne(&self._place, &other._place) [INFO] [stderr] 239 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::partialeq_ne_impl)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#partialeq_ne_impl [INFO] [stderr] [INFO] [stderr] error[E0554]: #![feature] may not be used on the stable release channel [INFO] [stderr] --> benches/clear_stack_on_return.rs:1:1 [INFO] [stderr] | [INFO] [stderr] 1 | #![feature(test)] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] For more information about this error, try `rustc --explain E0554`. [INFO] [stderr] error: Could not compile `clear_on_drop`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "69885f19e224c47e5c2215d69037086e196692ab218560ed597cfca5ac4729b4"` [INFO] running `"docker" "rm" "-f" "69885f19e224c47e5c2215d69037086e196692ab218560ed597cfca5ac4729b4"` [INFO] [stdout] 69885f19e224c47e5c2215d69037086e196692ab218560ed597cfca5ac4729b4