[INFO] crate clean 1.0.0 is already in cache [INFO] extracting crate clean 1.0.0 into work/ex/clippy-test-run/sources/stable/reg/clean/1.0.0 [INFO] extracting crate clean 1.0.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/clean/1.0.0 [INFO] validating manifest of clean-1.0.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of clean-1.0.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing clean-1.0.0 [INFO] finished frobbing clean-1.0.0 [INFO] frobbed toml for clean-1.0.0 written to work/ex/clippy-test-run/sources/stable/reg/clean/1.0.0/Cargo.toml [INFO] started frobbing clean-1.0.0 [INFO] finished frobbing clean-1.0.0 [INFO] frobbed toml for clean-1.0.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/clean/1.0.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting clean-1.0.0 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-3/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/clean/1.0.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] c39a4f09ce77245fab77e3f835da9e43be425899d7d8e8ec2ebad8d5e48ebb28 [INFO] running `"docker" "start" "-a" "c39a4f09ce77245fab77e3f835da9e43be425899d7d8e8ec2ebad8d5e48ebb28"` [INFO] [stderr] Checking clean v1.0.0 (/opt/crater/workdir) [INFO] [stderr] warning: this if statement can be collapsed [INFO] [stderr] --> src/main.rs:97:37 [INFO] [stderr] | [INFO] [stderr] 97 | Some(ss) => if ss.ends_with("~") { [INFO] [stderr] | _____________________________________^ [INFO] [stderr] 98 | | if !options.confirmation || ask_confirmation(&Path::new(s)) { [INFO] [stderr] 99 | | match fs::remove_file(entry) { [INFO] [stderr] 100 | | Ok(_) => { [INFO] [stderr] ... | [INFO] [stderr] 109 | | } [INFO] [stderr] 110 | | }, [INFO] [stderr] | |_________________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 97 | Some(ss) => if ss.ends_with("~") && (!options.confirmation || ask_confirmation(&Path::new(s))) { [INFO] [stderr] 98 | match fs::remove_file(entry) { [INFO] [stderr] 99 | Ok(_) => { [INFO] [stderr] 100 | if options.verbose { [INFO] [stderr] 101 | println!("\x1b[32;1m{} deleted\x1b[0m", entry_name); [INFO] [stderr] 102 | } [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: this if statement can be collapsed [INFO] [stderr] --> src/main.rs:97:37 [INFO] [stderr] | [INFO] [stderr] 97 | Some(ss) => if ss.ends_with("~") { [INFO] [stderr] | _____________________________________^ [INFO] [stderr] 98 | | if !options.confirmation || ask_confirmation(&Path::new(s)) { [INFO] [stderr] 99 | | match fs::remove_file(entry) { [INFO] [stderr] 100 | | Ok(_) => { [INFO] [stderr] ... | [INFO] [stderr] 109 | | } [INFO] [stderr] 110 | | }, [INFO] [stderr] | |_________________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 97 | Some(ss) => if ss.ends_with("~") && (!options.confirmation || ask_confirmation(&Path::new(s))) { [INFO] [stderr] 98 | match fs::remove_file(entry) { [INFO] [stderr] 99 | Ok(_) => { [INFO] [stderr] 100 | if options.verbose { [INFO] [stderr] 101 | println!("\x1b[32;1m{} deleted\x1b[0m", entry_name); [INFO] [stderr] 102 | } [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/main.rs:32:13 [INFO] [stderr] | [INFO] [stderr] 32 | / match std::io::stdin().read_line(&mut s) { [INFO] [stderr] 33 | | Ok(_) => { [INFO] [stderr] 34 | | let tmp_s = s.replace("\r\n", "").replace("\n", ""); [INFO] [stderr] 35 | | [INFO] [stderr] ... | [INFO] [stderr] 42 | | Err(_) => {} [INFO] [stderr] 43 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 32 | if let Ok(_) = std::io::stdin().read_line(&mut s) { [INFO] [stderr] 33 | let tmp_s = s.replace("\r\n", "").replace("\n", ""); [INFO] [stderr] 34 | [INFO] [stderr] 35 | if tmp_s == "y" || tmp_s == "yes" { [INFO] [stderr] 36 | return true; [INFO] [stderr] 37 | } else if tmp_s == "n" || tmp_s == "no" { [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/main.rs:96:21 [INFO] [stderr] | [INFO] [stderr] 96 | / match s.to_str() { [INFO] [stderr] 97 | | Some(ss) => if ss.ends_with("~") { [INFO] [stderr] 98 | | if !options.confirmation || ask_confirmation(&Path::new(s)) { [INFO] [stderr] 99 | | match fs::remove_file(entry) { [INFO] [stderr] ... | [INFO] [stderr] 111 | | _ => {} [INFO] [stderr] 112 | | } [INFO] [stderr] | |_____________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 96 | if let Some(ss) = s.to_str() { if ss.ends_with("~") { [INFO] [stderr] 97 | if !options.confirmation || ask_confirmation(&Path::new(s)) { [INFO] [stderr] 98 | match fs::remove_file(entry) { [INFO] [stderr] 99 | Ok(_) => { [INFO] [stderr] 100 | if options.verbose { [INFO] [stderr] 101 | println!("\x1b[32;1m{} deleted\x1b[0m", entry_name); [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/main.rs:97:53 [INFO] [stderr] | [INFO] [stderr] 97 | Some(ss) => if ss.ends_with("~") { [INFO] [stderr] | ^^^ help: try using a char instead: `'~'` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/main.rs:32:13 [INFO] [stderr] | [INFO] [stderr] 32 | / match std::io::stdin().read_line(&mut s) { [INFO] [stderr] 33 | | Ok(_) => { [INFO] [stderr] 34 | | let tmp_s = s.replace("\r\n", "").replace("\n", ""); [INFO] [stderr] 35 | | [INFO] [stderr] ... | [INFO] [stderr] 42 | | Err(_) => {} [INFO] [stderr] 43 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 32 | if let Ok(_) = std::io::stdin().read_line(&mut s) { [INFO] [stderr] 33 | let tmp_s = s.replace("\r\n", "").replace("\n", ""); [INFO] [stderr] 34 | [INFO] [stderr] 35 | if tmp_s == "y" || tmp_s == "yes" { [INFO] [stderr] 36 | return true; [INFO] [stderr] 37 | } else if tmp_s == "n" || tmp_s == "no" { [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: casting character literal to u8. `char`s are 4 bytes wide in rust, so casting to u8 truncates them [INFO] [stderr] --> src/main.rs:144:43 [INFO] [stderr] | [INFO] [stderr] 144 | if tmp.clone().into_bytes()[0] == '-' as u8 { [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::char_lit_as_u8)] on by default [INFO] [stderr] = help: Consider using a byte literal instead: [INFO] [stderr] b'-' [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#char_lit_as_u8 [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/main.rs:148:16 [INFO] [stderr] | [INFO] [stderr] 148 | if tmp_arg.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!tmp_arg.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/main.rs:96:21 [INFO] [stderr] | [INFO] [stderr] 96 | / match s.to_str() { [INFO] [stderr] 97 | | Some(ss) => if ss.ends_with("~") { [INFO] [stderr] 98 | | if !options.confirmation || ask_confirmation(&Path::new(s)) { [INFO] [stderr] 99 | | match fs::remove_file(entry) { [INFO] [stderr] ... | [INFO] [stderr] 111 | | _ => {} [INFO] [stderr] 112 | | } [INFO] [stderr] | |_____________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 96 | if let Some(ss) = s.to_str() { if ss.ends_with("~") { [INFO] [stderr] 97 | if !options.confirmation || ask_confirmation(&Path::new(s)) { [INFO] [stderr] 98 | match fs::remove_file(entry) { [INFO] [stderr] 99 | Ok(_) => { [INFO] [stderr] 100 | if options.verbose { [INFO] [stderr] 101 | println!("\x1b[32;1m{} deleted\x1b[0m", entry_name); [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/main.rs:97:53 [INFO] [stderr] | [INFO] [stderr] 97 | Some(ss) => if ss.ends_with("~") { [INFO] [stderr] | ^^^ help: try using a char instead: `'~'` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/main.rs:195:8 [INFO] [stderr] | [INFO] [stderr] 195 | if files.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `files.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: casting character literal to u8. `char`s are 4 bytes wide in rust, so casting to u8 truncates them [INFO] [stderr] --> src/main.rs:144:43 [INFO] [stderr] | [INFO] [stderr] 144 | if tmp.clone().into_bytes()[0] == '-' as u8 { [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::char_lit_as_u8)] on by default [INFO] [stderr] = help: Consider using a byte literal instead: [INFO] [stderr] b'-' [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#char_lit_as_u8 [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/main.rs:148:16 [INFO] [stderr] | [INFO] [stderr] 148 | if tmp_arg.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!tmp_arg.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/main.rs:195:8 [INFO] [stderr] | [INFO] [stderr] 195 | if files.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `files.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 0.85s [INFO] running `"docker" "inspect" "c39a4f09ce77245fab77e3f835da9e43be425899d7d8e8ec2ebad8d5e48ebb28"` [INFO] running `"docker" "rm" "-f" "c39a4f09ce77245fab77e3f835da9e43be425899d7d8e8ec2ebad8d5e48ebb28"` [INFO] [stdout] c39a4f09ce77245fab77e3f835da9e43be425899d7d8e8ec2ebad8d5e48ebb28