[INFO] crate classif 0.0.2 is already in cache [INFO] extracting crate classif 0.0.2 into work/ex/clippy-test-run/sources/stable/reg/classif/0.0.2 [INFO] extracting crate classif 0.0.2 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/classif/0.0.2 [INFO] validating manifest of classif-0.0.2 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of classif-0.0.2 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing classif-0.0.2 [INFO] finished frobbing classif-0.0.2 [INFO] frobbed toml for classif-0.0.2 written to work/ex/clippy-test-run/sources/stable/reg/classif/0.0.2/Cargo.toml [INFO] started frobbing classif-0.0.2 [INFO] finished frobbing classif-0.0.2 [INFO] frobbed toml for classif-0.0.2 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/classif/0.0.2/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting classif-0.0.2 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-0/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/classif/0.0.2:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 72219ffacc071aba44ed4a64422530b3613f999db76419a5a57c45ff715b67ce [INFO] running `"docker" "start" "-a" "72219ffacc071aba44ed4a64422530b3613f999db76419a5a57c45ff715b67ce"` [INFO] [stderr] Checking classif v0.0.2 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/jenks.rs:14:13 [INFO] [stderr] | [INFO] [stderr] 14 | dim: dim, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `dim` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: 5th binding whose name is just one char [INFO] [stderr] --> src/jenks.rs:68:13 [INFO] [stderr] | [INFO] [stderr] 68 | let mut j = k; [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::many_single_char_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/classif.rs:97:16 [INFO] [stderr] | [INFO] [stderr] 97 | type_classif: type_classif, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `type_classif` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/jenks.rs:14:13 [INFO] [stderr] | [INFO] [stderr] 14 | dim: dim, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `dim` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: 5th binding whose name is just one char [INFO] [stderr] --> src/jenks.rs:68:13 [INFO] [stderr] | [INFO] [stderr] 68 | let mut j = k; [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::many_single_char_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/classif.rs:97:16 [INFO] [stderr] | [INFO] [stderr] 97 | type_classif: type_classif, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `type_classif` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/jenks.rs:25:13 [INFO] [stderr] | [INFO] [stderr] 25 | let mut v = unsafe { self.values.get_unchecked_mut(ix.0 * self.dim + ix.1) }; [INFO] [stderr] | ----^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_mut)] on by default [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:45:50 [INFO] [stderr] | [INFO] [stderr] 45 | assert_eq!(b.bounds.as_slice(), [1., 7., 9.090909090909092, 11., 12.]); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: consider: `9.090_909_090_909_092` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:48:48 [INFO] [stderr] | [INFO] [stderr] 48 | assert_eq!(breaks.as_slice(), [1., 7., 9.090909090909092, 11., 12.]); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: consider: `9.090_909_090_909_092` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:87:21 [INFO] [stderr] | [INFO] [stderr] 87 | 1.5238095238095237, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider: `1.523_809_523_809_523_7` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:88:21 [INFO] [stderr] | [INFO] [stderr] 88 | 2.571428571428571, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: consider: `2.571_428_571_428_571` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:89:21 [INFO] [stderr] | [INFO] [stderr] 89 | 4.142857142857142, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: consider: `4.142_857_142_857_142` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:90:21 [INFO] [stderr] | [INFO] [stderr] 90 | 6.238095238095237, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: consider: `6.238_095_238_095_237` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:91:21 [INFO] [stderr] | [INFO] [stderr] 91 | 8.857142857142856, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: consider: `8.857_142_857_142_856` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:97:21 [INFO] [stderr] | [INFO] [stderr] 97 | 1.5238095238095237, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider: `1.523_809_523_809_523_7` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:98:21 [INFO] [stderr] | [INFO] [stderr] 98 | 2.571428571428571, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: consider: `2.571_428_571_428_571` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:99:21 [INFO] [stderr] | [INFO] [stderr] 99 | 4.142857142857142, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: consider: `4.142_857_142_857_142` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:100:21 [INFO] [stderr] | [INFO] [stderr] 100 | 6.238095238095237, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: consider: `6.238_095_238_095_237` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:101:21 [INFO] [stderr] | [INFO] [stderr] 101 | 8.857142857142856, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: consider: `8.857_142_857_142_856` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:126:24 [INFO] [stderr] | [INFO] [stderr] 126 | assert_eq!(kv, 0.042107329018970074); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: consider: `0.042_107_329_018_970_074` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:133:23 [INFO] [stderr] | [INFO] [stderr] 133 | assert_eq!(r, 608.631578947369); [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: consider: `608.631_578_947_369` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:135:23 [INFO] [stderr] | [INFO] [stderr] 135 | assert_eq!(v, 8.008310249307486); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: consider: `8.008_310_249_307_486` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: unused return value of `std::iter::Iterator::collect` that must be used [INFO] [stderr] --> src/stats.rs:8:5 [INFO] [stderr] | [INFO] [stderr] 8 | values.iter().map(|v| sum += *v).collect::>(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_must_use)] on by default [INFO] [stderr] = note: if you really need to exhaust the iterator, consider `.for_each(drop)` instead [INFO] [stderr] [INFO] [stderr] warning: you are collect()ing an iterator and throwing away the result. Consider using an explicit for loop to exhaust the iterator [INFO] [stderr] --> src/stats.rs:8:5 [INFO] [stderr] | [INFO] [stderr] 8 | values.iter().map(|v| sum += *v).collect::>(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unused_collect)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_collect [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is only used to index `values`. [INFO] [stderr] --> src/stats.rs:39:14 [INFO] [stderr] | [INFO] [stderr] 39 | for i in 0..nb_elem { [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_range_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 39 | for in values.iter().take(nb_elem) { [INFO] [stderr] | ^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is only used to index `values`. [INFO] [stderr] --> src/stats.rs:57:14 [INFO] [stderr] | [INFO] [stderr] 57 | for i in 0..nb_elem { [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 57 | for in values.iter().take(nb_elem) { [INFO] [stderr] | ^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/jenks.rs:41:14 [INFO] [stderr] | [INFO] [stderr] 41 | for l in 2..(nb_elem + 1) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: use: `2..=nb_elem` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::range_plus_one)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/jenks.rs:45:18 [INFO] [stderr] | [INFO] [stderr] 45 | for m in 1..(l + 1) { [INFO] [stderr] | ^^^^^^^^^^ help: use: `1..=l` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/jenks.rs:54:26 [INFO] [stderr] | [INFO] [stderr] 54 | for j in 2..k + 1 { [INFO] [stderr] | ^^^^^^^^ help: use: `2..=k` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/classif.rs:80:24 [INFO] [stderr] | [INFO] [stderr] 80 | return Err("Too small number of values!".into()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `.into()`: `"Too small number of values!"` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_conversion)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/classif.rs:129:14 [INFO] [stderr] | [INFO] [stderr] 129 | for _ in 0..(nb_class + 1) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: use: `0..=nb_class` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/classif.rs:147:33 [INFO] [stderr] | [INFO] [stderr] 147 | let step = nb_elem as f64 / nb_class as f64; [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `f64::from(nb_class)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/classif.rs:149:21 [INFO] [stderr] | [INFO] [stderr] 149 | let qidx = (i as f64 * step + 0.49).floor() as usize; [INFO] [stderr] | ^^^^^^^^ help: try: `f64::from(i)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/classif.rs:211:14 [INFO] [stderr] | [INFO] [stderr] 211 | for i in 1..nb_class + 1 { [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: use: `1..=nb_class` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/classif.rs:219:14 [INFO] [stderr] | [INFO] [stderr] 219 | for i in 1..nb_class + 1 { [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: use: `1..=nb_class` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/jenks.rs:25:13 [INFO] [stderr] | [INFO] [stderr] 25 | let mut v = unsafe { self.values.get_unchecked_mut(ix.0 * self.dim + ix.1) }; [INFO] [stderr] | ----^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_mut)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused return value of `std::iter::Iterator::collect` that must be used [INFO] [stderr] --> src/stats.rs:8:5 [INFO] [stderr] | [INFO] [stderr] 8 | values.iter().map(|v| sum += *v).collect::>(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_must_use)] on by default [INFO] [stderr] = note: if you really need to exhaust the iterator, consider `.for_each(drop)` instead [INFO] [stderr] [INFO] [stderr] warning: you are collect()ing an iterator and throwing away the result. Consider using an explicit for loop to exhaust the iterator [INFO] [stderr] --> src/stats.rs:8:5 [INFO] [stderr] | [INFO] [stderr] 8 | values.iter().map(|v| sum += *v).collect::>(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unused_collect)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_collect [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is only used to index `values`. [INFO] [stderr] --> src/stats.rs:39:14 [INFO] [stderr] | [INFO] [stderr] 39 | for i in 0..nb_elem { [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_range_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 39 | for in values.iter().take(nb_elem) { [INFO] [stderr] | ^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is only used to index `values`. [INFO] [stderr] --> src/stats.rs:57:14 [INFO] [stderr] | [INFO] [stderr] 57 | for i in 0..nb_elem { [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 57 | for in values.iter().take(nb_elem) { [INFO] [stderr] | ^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/jenks.rs:41:14 [INFO] [stderr] | [INFO] [stderr] 41 | for l in 2..(nb_elem + 1) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: use: `2..=nb_elem` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::range_plus_one)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/jenks.rs:45:18 [INFO] [stderr] | [INFO] [stderr] 45 | for m in 1..(l + 1) { [INFO] [stderr] | ^^^^^^^^^^ help: use: `1..=l` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/jenks.rs:54:26 [INFO] [stderr] | [INFO] [stderr] 54 | for j in 2..k + 1 { [INFO] [stderr] | ^^^^^^^^ help: use: `2..=k` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/classif.rs:80:24 [INFO] [stderr] | [INFO] [stderr] 80 | return Err("Too small number of values!".into()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `.into()`: `"Too small number of values!"` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_conversion)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/classif.rs:129:14 [INFO] [stderr] | [INFO] [stderr] 129 | for _ in 0..(nb_class + 1) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: use: `0..=nb_class` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/classif.rs:147:33 [INFO] [stderr] | [INFO] [stderr] 147 | let step = nb_elem as f64 / nb_class as f64; [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `f64::from(nb_class)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/classif.rs:149:21 [INFO] [stderr] | [INFO] [stderr] 149 | let qidx = (i as f64 * step + 0.49).floor() as usize; [INFO] [stderr] | ^^^^^^^^ help: try: `f64::from(i)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/classif.rs:211:14 [INFO] [stderr] | [INFO] [stderr] 211 | for i in 1..nb_class + 1 { [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: use: `1..=nb_class` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/classif.rs:219:14 [INFO] [stderr] | [INFO] [stderr] 219 | for i in 1..nb_class + 1 { [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: use: `1..=nb_class` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: The function/method `get_head_tail_breaks` doesn't need a mutable reference [INFO] [stderr] --> src/lib.rs:47:43 [INFO] [stderr] | [INFO] [stderr] 47 | let breaks = get_head_tail_breaks(&mut values); [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unnecessary_mut_passed)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/lib.rs:126:9 [INFO] [stderr] | [INFO] [stderr] 126 | assert_eq!(kv, 0.042107329018970074); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::float_cmp)] on by default [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/lib.rs:126:9 [INFO] [stderr] | [INFO] [stderr] 126 | assert_eq!(kv, 0.042107329018970074); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/lib.rs:133:9 [INFO] [stderr] | [INFO] [stderr] 133 | assert_eq!(r, 608.631578947369); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/lib.rs:133:9 [INFO] [stderr] | [INFO] [stderr] 133 | assert_eq!(r, 608.631578947369); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/lib.rs:135:9 [INFO] [stderr] | [INFO] [stderr] 135 | assert_eq!(v, 8.008310249307486); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/lib.rs:135:9 [INFO] [stderr] | [INFO] [stderr] 135 | assert_eq!(v, 8.008310249307486); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/lib.rs:142:9 [INFO] [stderr] | [INFO] [stderr] 142 | assert_eq!(v, 1.); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/lib.rs:142:9 [INFO] [stderr] | [INFO] [stderr] 142 | assert_eq!(v, 1.); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/lib.rs:150:9 [INFO] [stderr] | [INFO] [stderr] 150 | assert_eq!(median, 6.); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/lib.rs:150:9 [INFO] [stderr] | [INFO] [stderr] 150 | assert_eq!(median, 6.); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/lib.rs:154:9 [INFO] [stderr] | [INFO] [stderr] 154 | assert_eq!(median, 4.5); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/lib.rs:154:9 [INFO] [stderr] | [INFO] [stderr] 154 | assert_eq!(median, 4.5); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] error: aborting due to 6 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `classif`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] error[E0554]: #![feature] may not be used on the stable release channel [INFO] [stderr] --> benches/benchmark.rs:1:1 [INFO] [stderr] | [INFO] [stderr] 1 | #![feature(test)] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] For more information about this error, try `rustc --explain E0554`. [INFO] [stderr] error: Could not compile `classif`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "72219ffacc071aba44ed4a64422530b3613f999db76419a5a57c45ff715b67ce"` [INFO] running `"docker" "rm" "-f" "72219ffacc071aba44ed4a64422530b3613f999db76419a5a57c45ff715b67ce"` [INFO] [stdout] 72219ffacc071aba44ed4a64422530b3613f999db76419a5a57c45ff715b67ce