[INFO] crate clapcomp 0.1.5 is already in cache [INFO] extracting crate clapcomp 0.1.5 into work/ex/clippy-test-run/sources/stable/reg/clapcomp/0.1.5 [INFO] extracting crate clapcomp 0.1.5 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/clapcomp/0.1.5 [INFO] validating manifest of clapcomp-0.1.5 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of clapcomp-0.1.5 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing clapcomp-0.1.5 [INFO] finished frobbing clapcomp-0.1.5 [INFO] frobbed toml for clapcomp-0.1.5 written to work/ex/clippy-test-run/sources/stable/reg/clapcomp/0.1.5/Cargo.toml [INFO] started frobbing clapcomp-0.1.5 [INFO] finished frobbing clapcomp-0.1.5 [INFO] frobbed toml for clapcomp-0.1.5 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/clapcomp/0.1.5/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting clapcomp-0.1.5 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-6/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/clapcomp/0.1.5:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] ceeb23d1e8ae1787a78dc37e04f22ef27b4fbff51e1fb9e824954512965822db [INFO] running `"docker" "start" "-a" "ceeb23d1e8ae1787a78dc37e04f22ef27b4fbff51e1fb9e824954512965822db"` [INFO] [stderr] Checking clapcomp v0.1.5 (/opt/crater/workdir) [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/main.rs:51:24 [INFO] [stderr] | [INFO] [stderr] 51 | .map(|s| match s { [INFO] [stderr] | ________________________^ [INFO] [stderr] 52 | | &"bash" => Shell::Bash, [INFO] [stderr] 53 | | &"fish" => Shell::Fish, [INFO] [stderr] 54 | | &"zsh" => Shell::Zsh, [INFO] [stderr] 55 | | &"powershell" => Shell::PowerShell, [INFO] [stderr] 56 | | _ => unreachable!(), [INFO] [stderr] 57 | | }) [INFO] [stderr] | |__________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 51 | .map(|s| match *s { [INFO] [stderr] 52 | "bash" => Shell::Bash, [INFO] [stderr] 53 | "fish" => Shell::Fish, [INFO] [stderr] 54 | "zsh" => Shell::Zsh, [INFO] [stderr] 55 | "powershell" => Shell::PowerShell, [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/main.rs:73:44 [INFO] [stderr] | [INFO] [stderr] 73 | let name = app.p.meta.bin_name.clone().unwrap_or(app.p.meta.name.clone()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| app.p.meta.name.clone())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/main.rs:51:24 [INFO] [stderr] | [INFO] [stderr] 51 | .map(|s| match s { [INFO] [stderr] | ________________________^ [INFO] [stderr] 52 | | &"bash" => Shell::Bash, [INFO] [stderr] 53 | | &"fish" => Shell::Fish, [INFO] [stderr] 54 | | &"zsh" => Shell::Zsh, [INFO] [stderr] 55 | | &"powershell" => Shell::PowerShell, [INFO] [stderr] 56 | | _ => unreachable!(), [INFO] [stderr] 57 | | }) [INFO] [stderr] | |__________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 51 | .map(|s| match *s { [INFO] [stderr] 52 | "bash" => Shell::Bash, [INFO] [stderr] 53 | "fish" => Shell::Fish, [INFO] [stderr] 54 | "zsh" => Shell::Zsh, [INFO] [stderr] 55 | "powershell" => Shell::PowerShell, [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/main.rs:73:44 [INFO] [stderr] | [INFO] [stderr] 73 | let name = app.p.meta.bin_name.clone().unwrap_or(app.p.meta.name.clone()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| app.p.meta.name.clone())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 1.87s [INFO] running `"docker" "inspect" "ceeb23d1e8ae1787a78dc37e04f22ef27b4fbff51e1fb9e824954512965822db"` [INFO] running `"docker" "rm" "-f" "ceeb23d1e8ae1787a78dc37e04f22ef27b4fbff51e1fb9e824954512965822db"` [INFO] [stdout] ceeb23d1e8ae1787a78dc37e04f22ef27b4fbff51e1fb9e824954512965822db