[INFO] crate clam 0.1.6 is already in cache [INFO] extracting crate clam 0.1.6 into work/ex/clippy-test-run/sources/stable/reg/clam/0.1.6 [INFO] extracting crate clam 0.1.6 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/clam/0.1.6 [INFO] validating manifest of clam-0.1.6 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of clam-0.1.6 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing clam-0.1.6 [INFO] finished frobbing clam-0.1.6 [INFO] frobbed toml for clam-0.1.6 written to work/ex/clippy-test-run/sources/stable/reg/clam/0.1.6/Cargo.toml [INFO] started frobbing clam-0.1.6 [INFO] finished frobbing clam-0.1.6 [INFO] frobbed toml for clam-0.1.6 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/clam/0.1.6/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting clam-0.1.6 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-5/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/clam/0.1.6:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] b44f2ab42a902ebcf1c63af767b1a60a8d61ace9a08a07a96339ad60a1d371b5 [INFO] running `"docker" "start" "-a" "b44f2ab42a902ebcf1c63af767b1a60a8d61ace9a08a07a96339ad60a1d371b5"` [INFO] [stderr] Checking clam v0.1.6 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/template.rs:27:25 [INFO] [stderr] | [INFO] [stderr] 27 | TemplateBuilder{name: name, data: d} [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `name` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/template.rs:40:19 [INFO] [stderr] | [INFO] [stderr] 40 | Template {name: name, data: data} [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `name` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/template.rs:40:31 [INFO] [stderr] | [INFO] [stderr] 40 | Template {name: name, data: data} [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `data` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/template.rs:27:25 [INFO] [stderr] | [INFO] [stderr] 27 | TemplateBuilder{name: name, data: d} [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `name` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/template.rs:40:19 [INFO] [stderr] | [INFO] [stderr] 40 | Template {name: name, data: data} [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `name` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/template.rs:40:31 [INFO] [stderr] | [INFO] [stderr] 40 | Template {name: name, data: data} [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `data` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: unused label `'outer` [INFO] [stderr] --> src/template.rs:58:9 [INFO] [stderr] | [INFO] [stderr] 58 | / 'outer: for xs in br.lines() { [INFO] [stderr] 59 | | let s = xs.unwrap() + "\n"; [INFO] [stderr] 60 | | let mut line = StrReplace::new(&s); [INFO] [stderr] 61 | | for cap in re.captures_iter(&s) { [INFO] [stderr] ... | [INFO] [stderr] 67 | | result += line.to_str(); [INFO] [stderr] 68 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unused_label)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_label [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/template.rs:62:17 [INFO] [stderr] | [INFO] [stderr] 62 | / match self.data.get(&cap[1]) { [INFO] [stderr] 63 | | Some(d) => {line.replace(&cap[0], d);}, [INFO] [stderr] 64 | | _ => {}, [INFO] [stderr] 65 | | } [INFO] [stderr] | |_________________^ help: try this: `if let Some(d) = self.data.get(&cap[1]) {line.replace(&cap[0], d);}` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: unused label `'outer` [INFO] [stderr] --> src/template.rs:58:9 [INFO] [stderr] | [INFO] [stderr] 58 | / 'outer: for xs in br.lines() { [INFO] [stderr] 59 | | let s = xs.unwrap() + "\n"; [INFO] [stderr] 60 | | let mut line = StrReplace::new(&s); [INFO] [stderr] 61 | | for cap in re.captures_iter(&s) { [INFO] [stderr] ... | [INFO] [stderr] 67 | | result += line.to_str(); [INFO] [stderr] 68 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unused_label)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_label [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/template.rs:62:17 [INFO] [stderr] | [INFO] [stderr] 62 | / match self.data.get(&cap[1]) { [INFO] [stderr] 63 | | Some(d) => {line.replace(&cap[0], d);}, [INFO] [stderr] 64 | | _ => {}, [INFO] [stderr] 65 | | } [INFO] [stderr] | |_________________^ help: try this: `if let Some(d) = self.data.get(&cap[1]) {line.replace(&cap[0], d);}` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 4.89s [INFO] running `"docker" "inspect" "b44f2ab42a902ebcf1c63af767b1a60a8d61ace9a08a07a96339ad60a1d371b5"` [INFO] running `"docker" "rm" "-f" "b44f2ab42a902ebcf1c63af767b1a60a8d61ace9a08a07a96339ad60a1d371b5"` [INFO] [stdout] b44f2ab42a902ebcf1c63af767b1a60a8d61ace9a08a07a96339ad60a1d371b5