[INFO] crate circbuf 0.1.4 is already in cache
[INFO] extracting crate circbuf 0.1.4 into work/ex/clippy-test-run/sources/stable/reg/circbuf/0.1.4
[INFO] extracting crate circbuf 0.1.4 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/circbuf/0.1.4
[INFO] validating manifest of circbuf-0.1.4 on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of circbuf-0.1.4 on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing circbuf-0.1.4
[INFO] finished frobbing circbuf-0.1.4
[INFO] frobbed toml for circbuf-0.1.4 written to work/ex/clippy-test-run/sources/stable/reg/circbuf/0.1.4/Cargo.toml
[INFO] started frobbing circbuf-0.1.4
[INFO] finished frobbing circbuf-0.1.4
[INFO] frobbed toml for circbuf-0.1.4 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/circbuf/0.1.4/Cargo.toml
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting circbuf-0.1.4 against stable for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-3/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/circbuf/0.1.4:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] d557b36783cd61a948fb8f44d594b7ab0a657346f4ddca52f0ffd7f9f69bc307
[INFO] running `"docker" "start" "-a" "d557b36783cd61a948fb8f44d594b7ab0a657346f4ddca52f0ffd7f9f69bc307"`
[INFO] [stderr]     Checking circbuf v0.1.4 (/opt/crater/workdir)
[INFO] [stderr]     Checking vecio v0.1.0
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/lib.rs:226:9
[INFO] [stderr]     |
[INFO] [stderr] 226 |         return self.len() == 0;
[INFO] [stderr]     |         ^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.len() == 0`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::needless_return)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/lib.rs:231:9
[INFO] [stderr]     |
[INFO] [stderr] 231 |         return self.avail() == 0;
[INFO] [stderr]     |         ^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.avail() == 0`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: you should consider deriving a `Default` implementation for `CircBuf`
[INFO] [stderr]    --> src/lib.rs:179:5
[INFO] [stderr]     |
[INFO] [stderr] 179 | /     pub fn new() -> Self {
[INFO] [stderr] 180 | |         CircBuf {
[INFO] [stderr] 181 | |             buf: Box::new([0; DEFAULT_CAPACITY]),
[INFO] [stderr] 182 | |             write_cursor: 0,
[INFO] [stderr] 183 | |             read_cursor: 0,
[INFO] [stderr] 184 | |         }
[INFO] [stderr] 185 | |     }
[INFO] [stderr]     | |_____^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::new_without_default_derive)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive
[INFO] [stderr] help: try this
[INFO] [stderr]     |
[INFO] [stderr] 169 | #[derive(Default)]
[INFO] [stderr]     |
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]    --> src/lib.rs:279:12
[INFO] [stderr]     |
[INFO] [stderr] 279 |         if self.len() == 0 {
[INFO] [stderr]     |            ^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `self.is_empty()`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::len_zero)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]    --> src/lib.rs:289:12
[INFO] [stderr]     |
[INFO] [stderr] 289 |         if self.len() == 0 {
[INFO] [stderr]     |            ^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `self.is_empty()`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]    --> src/lib.rs:506:26
[INFO] [stderr]     |
[INFO] [stderr] 506 |         if avail == 0 || buf.len() == 0 {
[INFO] [stderr]     |                          ^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `buf.is_empty()`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/lib.rs:226:9
[INFO] [stderr]     |
[INFO] [stderr] 226 |         return self.len() == 0;
[INFO] [stderr]     |         ^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.len() == 0`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::needless_return)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/lib.rs:231:9
[INFO] [stderr]     |
[INFO] [stderr] 231 |         return self.avail() == 0;
[INFO] [stderr]     |         ^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.avail() == 0`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: you should consider deriving a `Default` implementation for `CircBuf`
[INFO] [stderr]    --> src/lib.rs:179:5
[INFO] [stderr]     |
[INFO] [stderr] 179 | /     pub fn new() -> Self {
[INFO] [stderr] 180 | |         CircBuf {
[INFO] [stderr] 181 | |             buf: Box::new([0; DEFAULT_CAPACITY]),
[INFO] [stderr] 182 | |             write_cursor: 0,
[INFO] [stderr] 183 | |             read_cursor: 0,
[INFO] [stderr] 184 | |         }
[INFO] [stderr] 185 | |     }
[INFO] [stderr]     | |_____^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::new_without_default_derive)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive
[INFO] [stderr] help: try this
[INFO] [stderr]     |
[INFO] [stderr] 169 | #[derive(Default)]
[INFO] [stderr]     |
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]    --> src/lib.rs:279:12
[INFO] [stderr]     |
[INFO] [stderr] 279 |         if self.len() == 0 {
[INFO] [stderr]     |            ^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `self.is_empty()`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::len_zero)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]    --> src/lib.rs:289:12
[INFO] [stderr]     |
[INFO] [stderr] 289 |         if self.len() == 0 {
[INFO] [stderr]     |            ^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `self.is_empty()`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]    --> src/lib.rs:506:26
[INFO] [stderr]     |
[INFO] [stderr] 506 |         if avail == 0 || buf.len() == 0 {
[INFO] [stderr]     |                          ^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `buf.is_empty()`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: the function has a cyclomatic complexity of 52
[INFO] [stderr]    --> src/lib.rs:716:5
[INFO] [stderr]     |
[INFO] [stderr] 716 | /     fn get_bytes_and_avail() {
[INFO] [stderr] 717 | |         let mut c = CircBuf::with_capacity(16).unwrap();
[INFO] [stderr] 718 | |
[INFO] [stderr] 719 | |         assert_eq!(c.write(b"funkytowns").unwrap(), 10);
[INFO] [stderr] ...   |
[INFO] [stderr] 824 | |         }
[INFO] [stderr] 825 | |     }
[INFO] [stderr]     | |_____^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::cyclomatic_complexity)] on by default
[INFO] [stderr]     = help: you could split it up into multiple smaller functions
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cyclomatic_complexity
[INFO] [stderr] 
[INFO] [stderr] warning: The function/method `readv` doesn't need a mutable reference
[INFO] [stderr]    --> src/lib.rs:847:35
[INFO] [stderr]     |
[INFO] [stderr] 847 |             assert_eq!(file.readv(&mut bufs).unwrap(), 12);
[INFO] [stderr]     |                                   ^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::unnecessary_mut_passed)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed
[INFO] [stderr] 
[INFO] [stderr]     Finished dev [unoptimized + debuginfo] target(s) in 2.20s
[INFO] running `"docker" "inspect" "d557b36783cd61a948fb8f44d594b7ab0a657346f4ddca52f0ffd7f9f69bc307"`
[INFO] running `"docker" "rm" "-f" "d557b36783cd61a948fb8f44d594b7ab0a657346f4ddca52f0ffd7f9f69bc307"`
[INFO] [stdout] d557b36783cd61a948fb8f44d594b7ab0a657346f4ddca52f0ffd7f9f69bc307