[INFO] crate cicada 0.9.1 is already in cache
[INFO] extracting crate cicada 0.9.1 into work/ex/clippy-test-run/sources/stable/reg/cicada/0.9.1
[INFO] extracting crate cicada 0.9.1 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/cicada/0.9.1
[INFO] validating manifest of cicada-0.9.1 on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of cicada-0.9.1 on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing cicada-0.9.1
[INFO] finished frobbing cicada-0.9.1
[INFO] frobbed toml for cicada-0.9.1 written to work/ex/clippy-test-run/sources/stable/reg/cicada/0.9.1/Cargo.toml
[INFO] started frobbing cicada-0.9.1
[INFO] finished frobbing cicada-0.9.1
[INFO] frobbed toml for cicada-0.9.1 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/cicada/0.9.1/Cargo.toml
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting cicada-0.9.1 against stable for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-6/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/cicada/0.9.1:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] ddba8b5c65b2b50a6ce181b3f2bc7418019a1433a6e4acf01f3e131c8b3799bc
[INFO] running `"docker" "start" "-a" "ddba8b5c65b2b50a6ce181b3f2bc7418019a1433a6e4acf01f3e131c8b3799bc"`
[INFO] [stderr]     Checking smallstr v0.1.0
[INFO] [stderr]    Compiling cicada v0.9.1 (/opt/crater/workdir)
[INFO] [stderr]     Checking exec v0.3.1
[INFO] [stderr]     Checking sqlite v0.24.0
[INFO] [stderr]    Compiling terminfo v0.6.1
[INFO] [stderr]     Checking mortal v0.1.5
[INFO] [stderr]     Checking linefeed v0.5.4
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/types.rs:54:13
[INFO] [stderr]    |
[INFO] [stderr] 54 |             gid: gid,
[INFO] [stderr]    |             ^^^^^^^^ help: replace it with: `gid`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::redundant_field_names)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/types.rs:55:13
[INFO] [stderr]    |
[INFO] [stderr] 55 |             status: status,
[INFO] [stderr]    |             ^^^^^^^^^^^^^^ help: replace it with: `status`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/execute.rs:629:13
[INFO] [stderr]     |
[INFO] [stderr] 629 |             isatty: isatty,
[INFO] [stderr]     |             ^^^^^^^^^^^^^^ help: replace it with: `isatty`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/execute.rs:630:13
[INFO] [stderr]     |
[INFO] [stderr] 630 |             capture_output: capture_output,
[INFO] [stderr]     |             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `capture_output`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/execute.rs:631:13
[INFO] [stderr]     |
[INFO] [stderr] 631 |             background: background,
[INFO] [stderr]     |             ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `background`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/shell.rs:64:25
[INFO] [stderr]    |
[INFO] [stderr] 64 |                         gid: gid,
[INFO] [stderr]    |                         ^^^^^^^^ help: replace it with: `gid`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/types.rs:54:13
[INFO] [stderr]    |
[INFO] [stderr] 54 |             gid: gid,
[INFO] [stderr]    |             ^^^^^^^^ help: replace it with: `gid`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::redundant_field_names)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/types.rs:55:13
[INFO] [stderr]    |
[INFO] [stderr] 55 |             status: status,
[INFO] [stderr]    |             ^^^^^^^^^^^^^^ help: replace it with: `status`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/execute.rs:629:13
[INFO] [stderr]     |
[INFO] [stderr] 629 |             isatty: isatty,
[INFO] [stderr]     |             ^^^^^^^^^^^^^^ help: replace it with: `isatty`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/execute.rs:630:13
[INFO] [stderr]     |
[INFO] [stderr] 630 |             capture_output: capture_output,
[INFO] [stderr]     |             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `capture_output`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/execute.rs:631:13
[INFO] [stderr]     |
[INFO] [stderr] 631 |             background: background,
[INFO] [stderr]     |             ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `background`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/shell.rs:64:25
[INFO] [stderr]    |
[INFO] [stderr] 64 |                         gid: gid,
[INFO] [stderr]    |                         ^^^^^^^^ help: replace it with: `gid`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/tools.rs:93:5
[INFO] [stderr]    |
[INFO] [stderr] 93 |     return cmd_result.stdout.trim().to_string();
[INFO] [stderr]    |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `cmd_result.stdout.trim().to_string()`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::needless_return)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/tools.rs:327:5
[INFO] [stderr]     |
[INFO] [stderr] 327 |     return re.replace_all(path, "\\$c").to_string();
[INFO] [stderr]     |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `re.replace_all(path, "\\$c").to_string()`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/builtins/bg.rs:69:5
[INFO] [stderr]    |
[INFO] [stderr] 69 |     return 0;
[INFO] [stderr]    |     ^^^^^^^^^ help: remove `return` as shown: `0`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/builtins/fg.rs:83:9
[INFO] [stderr]    |
[INFO] [stderr] 83 |         return status;
[INFO] [stderr]    |         ^^^^^^^^^^^^^^ help: remove `return` as shown: `status`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/builtins/jobs.rs:12:5
[INFO] [stderr]    |
[INFO] [stderr] 12 |     return 0;
[INFO] [stderr]    |     ^^^^^^^^^ help: remove `return` as shown: `0`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/execute.rs:161:5
[INFO] [stderr]     |
[INFO] [stderr] 161 |     return (tokens, envs);
[INFO] [stderr]     |     ^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `(tokens, envs)`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/execute.rs:720:5
[INFO] [stderr]     |
[INFO] [stderr] 720 |     return run_with_shell(&mut sh, line);
[INFO] [stderr]     |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `run_with_shell(&mut sh, line)`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]  --> src/libs/os_type.rs:6:9
[INFO] [stderr]   |
[INFO] [stderr] 6 |         return get_macos_name();
[INFO] [stderr]   |         ^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `get_macos_name()`
[INFO] [stderr]   |
[INFO] [stderr]   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]  --> src/libs/os_type.rs:8:9
[INFO] [stderr]   |
[INFO] [stderr] 8 |         return get_other_os_name();
[INFO] [stderr]   |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `get_other_os_name()`
[INFO] [stderr]   |
[INFO] [stderr]   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/libs/os_type.rs:34:5
[INFO] [stderr]    |
[INFO] [stderr] 34 |     return cr.stdout.trim().to_string();
[INFO] [stderr]    |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `cr.stdout.trim().to_string()`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/libs/os_type.rs:39:5
[INFO] [stderr]    |
[INFO] [stderr] 39 |     return cr.stdout.trim().to_string();
[INFO] [stderr]    |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `cr.stdout.trim().to_string()`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/libs/os_type.rs:54:5
[INFO] [stderr]    |
[INFO] [stderr] 54 |     return cr.stdout.trim().to_string();
[INFO] [stderr]    |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `cr.stdout.trim().to_string()`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/libs/os_type.rs:59:5
[INFO] [stderr]    |
[INFO] [stderr] 59 |     return cr.stdout.trim().to_string();
[INFO] [stderr]    |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `cr.stdout.trim().to_string()`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: this if statement can be collapsed
[INFO] [stderr]    --> src/shell.rs:721:5
[INFO] [stderr]     |
[INFO] [stderr] 721 | /     if tokens.len() >= 2 {
[INFO] [stderr] 722 | |         if tokens[0].1 == "export" && tokens[1].1.starts_with("PROMPT=") {
[INFO] [stderr] 723 | |             return;
[INFO] [stderr] 724 | |         }
[INFO] [stderr] 725 | |     }
[INFO] [stderr]     | |_____^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::collapsible_if)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if
[INFO] [stderr] help: try
[INFO] [stderr]     |
[INFO] [stderr] 721 |     if tokens.len() >= 2 && tokens[0].1 == "export" && tokens[1].1.starts_with("PROMPT=") {
[INFO] [stderr] 722 |     return;
[INFO] [stderr] 723 | }
[INFO] [stderr]     |
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/lib.rs:81:5
[INFO] [stderr]    |
[INFO] [stderr] 81 |     return parsers::parser_line::cmd_to_tokens(cmd);
[INFO] [stderr]    |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `parsers::parser_line::cmd_to_tokens(cmd)`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/tools.rs:93:5
[INFO] [stderr]    |
[INFO] [stderr] 93 |     return cmd_result.stdout.trim().to_string();
[INFO] [stderr]    |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `cmd_result.stdout.trim().to_string()`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::needless_return)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/tools.rs:327:5
[INFO] [stderr]     |
[INFO] [stderr] 327 |     return re.replace_all(path, "\\$c").to_string();
[INFO] [stderr]     |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `re.replace_all(path, "\\$c").to_string()`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/builtins/bg.rs:69:5
[INFO] [stderr]    |
[INFO] [stderr] 69 |     return 0;
[INFO] [stderr]    |     ^^^^^^^^^ help: remove `return` as shown: `0`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/builtins/fg.rs:83:9
[INFO] [stderr]    |
[INFO] [stderr] 83 |         return status;
[INFO] [stderr]    |         ^^^^^^^^^^^^^^ help: remove `return` as shown: `status`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/builtins/jobs.rs:12:5
[INFO] [stderr]    |
[INFO] [stderr] 12 |     return 0;
[INFO] [stderr]    |     ^^^^^^^^^ help: remove `return` as shown: `0`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/execute.rs:161:5
[INFO] [stderr]     |
[INFO] [stderr] 161 |     return (tokens, envs);
[INFO] [stderr]     |     ^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `(tokens, envs)`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/execute.rs:720:5
[INFO] [stderr]     |
[INFO] [stderr] 720 |     return run_with_shell(&mut sh, line);
[INFO] [stderr]     |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `run_with_shell(&mut sh, line)`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: long literal lacking separators
[INFO] [stderr]    --> src/execute.rs:735:16
[INFO] [stderr]     |
[INFO] [stderr] 735 |             Ok(27.299999999999997)
[INFO] [stderr]     |                ^^^^^^^^^^^^^^^^^^ help: consider: `27.299_999_999_999_997`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::unreadable_literal)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]  --> src/libs/os_type.rs:6:9
[INFO] [stderr]   |
[INFO] [stderr] 6 |         return get_macos_name();
[INFO] [stderr]   |         ^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `get_macos_name()`
[INFO] [stderr]   |
[INFO] [stderr]   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]  --> src/libs/os_type.rs:8:9
[INFO] [stderr]   |
[INFO] [stderr] 8 |         return get_other_os_name();
[INFO] [stderr]   |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `get_other_os_name()`
[INFO] [stderr]   |
[INFO] [stderr]   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/libs/os_type.rs:34:5
[INFO] [stderr]    |
[INFO] [stderr] 34 |     return cr.stdout.trim().to_string();
[INFO] [stderr]    |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `cr.stdout.trim().to_string()`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/libs/os_type.rs:39:5
[INFO] [stderr]    |
[INFO] [stderr] 39 |     return cr.stdout.trim().to_string();
[INFO] [stderr]    |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `cr.stdout.trim().to_string()`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/libs/os_type.rs:54:5
[INFO] [stderr]    |
[INFO] [stderr] 54 |     return cr.stdout.trim().to_string();
[INFO] [stderr]    |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `cr.stdout.trim().to_string()`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/libs/os_type.rs:59:5
[INFO] [stderr]    |
[INFO] [stderr] 59 |     return cr.stdout.trim().to_string();
[INFO] [stderr]    |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `cr.stdout.trim().to_string()`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: long literal lacking separators
[INFO] [stderr]    --> src/parsers/parser_int.rs:111:37
[INFO] [stderr]     |
[INFO] [stderr] 111 |             IResult::Done(&b""[..], 4611686018400000001)
[INFO] [stderr]     |                                     ^^^^^^^^^^^^^^^^^^^ help: consider: `4_611_686_018_400_000_001`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal
[INFO] [stderr] 
[INFO] [stderr] warning: this if statement can be collapsed
[INFO] [stderr]    --> src/shell.rs:721:5
[INFO] [stderr]     |
[INFO] [stderr] 721 | /     if tokens.len() >= 2 {
[INFO] [stderr] 722 | |         if tokens[0].1 == "export" && tokens[1].1.starts_with("PROMPT=") {
[INFO] [stderr] 723 | |             return;
[INFO] [stderr] 724 | |         }
[INFO] [stderr] 725 | |     }
[INFO] [stderr]     | |_____^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::collapsible_if)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if
[INFO] [stderr] help: try
[INFO] [stderr]     |
[INFO] [stderr] 721 |     if tokens.len() >= 2 && tokens[0].1 == "export" && tokens[1].1.starts_with("PROMPT=") {
[INFO] [stderr] 722 |     return;
[INFO] [stderr] 723 | }
[INFO] [stderr]     |
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/lib.rs:81:5
[INFO] [stderr]    |
[INFO] [stderr] 81 |     return parsers::parser_line::cmd_to_tokens(cmd);
[INFO] [stderr]    |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `parsers::parser_line::cmd_to_tokens(cmd)`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: trivial regex
[INFO] [stderr]    --> src/tools.rs:146:22
[INFO] [stderr]     |
[INFO] [stderr] 146 |     match Regex::new(r"!!") {
[INFO] [stderr]     |                      ^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::trivial_regex)] on by default
[INFO] [stderr]     = help: consider using `str::contains`
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivial_regex
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]  --> src/builtins/bg.rs:8:43
[INFO] [stderr]   |
[INFO] [stderr] 8 | pub fn run(sh: &mut shell::Shell, tokens: &types::Tokens) -> i32 {
[INFO] [stderr]   |                                           ^^^^^^^^^^^^^^
[INFO] [stderr]   |
[INFO] [stderr]   = note: #[warn(clippy::ptr_arg)] on by default
[INFO] [stderr]   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] error: this loop never actually loops
[INFO] [stderr]   --> src/builtins/bg.rs:16:9
[INFO] [stderr]    |
[INFO] [stderr] 16 | /         for (gid, _) in sh.jobs.iter() {
[INFO] [stderr] 17 | |             job_id = *gid;
[INFO] [stderr] 18 | |             break;
[INFO] [stderr] 19 | |         }
[INFO] [stderr]    | |_________^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[deny(clippy::never_loop)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#never_loop
[INFO] [stderr] 
[INFO] [stderr] warning: redundant pattern matching, consider using `is_none()`
[INFO] [stderr]   --> src/builtins/bg.rs:39:16
[INFO] [stderr]    |
[INFO] [stderr] 39 |           if let None = result {
[INFO] [stderr]    |  _________-      ^^^^
[INFO] [stderr] 40 | |             result = sh.get_job_by_gid(job_id);
[INFO] [stderr] 41 | |         }
[INFO] [stderr]    | |_________- help: try this: `if result.is_none()`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::redundant_pattern_matching)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]   --> src/builtins/cd.rs:12:43
[INFO] [stderr]    |
[INFO] [stderr] 12 | pub fn run(sh: &mut shell::Shell, tokens: &Tokens) -> i32 {
[INFO] [stderr]    |                                           ^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]  --> src/builtins/exec.rs:5:20
[INFO] [stderr]   |
[INFO] [stderr] 5 | pub fn run(tokens: &Tokens) -> i32 {
[INFO] [stderr]   |                    ^^^^^^^
[INFO] [stderr]   |
[INFO] [stderr]   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]  --> src/builtins/exit.rs:8:39
[INFO] [stderr]   |
[INFO] [stderr] 8 | pub fn run(sh: &shell::Shell, tokens: &Tokens) -> i32 {
[INFO] [stderr]   |                                       ^^^^^^^
[INFO] [stderr]   |
[INFO] [stderr]   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]   --> src/builtins/export.rs:11:40
[INFO] [stderr]    |
[INFO] [stderr] 11 | pub fn run(_sh: &shell::Shell, tokens: &Tokens) -> i32 {
[INFO] [stderr]    |                                        ^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]  --> src/builtins/fg.rs:9:43
[INFO] [stderr]   |
[INFO] [stderr] 9 | pub fn run(sh: &mut shell::Shell, tokens: &types::Tokens) -> i32 {
[INFO] [stderr]   |                                           ^^^^^^^^^^^^^^
[INFO] [stderr]   |
[INFO] [stderr]   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] error: this loop never actually loops
[INFO] [stderr]   --> src/builtins/fg.rs:17:9
[INFO] [stderr]    |
[INFO] [stderr] 17 | /         for (gid, _) in sh.jobs.iter() {
[INFO] [stderr] 18 | |             job_id = *gid;
[INFO] [stderr] 19 | |             break;
[INFO] [stderr] 20 | |         }
[INFO] [stderr]    | |_________^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#never_loop
[INFO] [stderr] 
[INFO] [stderr] warning: redundant pattern matching, consider using `is_none()`
[INFO] [stderr]   --> src/builtins/fg.rs:41:16
[INFO] [stderr]    |
[INFO] [stderr] 41 |           if let None = result {
[INFO] [stderr]    |  _________-      ^^^^
[INFO] [stderr] 42 | |             result = sh.get_job_by_gid(job_id);
[INFO] [stderr] 43 | |         }
[INFO] [stderr]    | |_________- help: try this: `if result.is_none()`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]    --> src/builtins/vox.rs:114:39
[INFO] [stderr]     |
[INFO] [stderr] 114 | pub fn run(sh: &shell::Shell, tokens: &types::Tokens) -> i32 {
[INFO] [stderr]     |                                       ^^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]   --> src/execute.rs:49:33
[INFO] [stderr]    |
[INFO] [stderr] 49 | fn tokens_to_cmd_tokens(tokens: &Tokens) -> Vec<Tokens> {
[INFO] [stderr]    |                                 ^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]    --> src/execute.rs:259:23
[INFO] [stderr]     |
[INFO] [stderr] 259 | fn log_cmd_info(cmds: &Vec<Tokens>) {
[INFO] [stderr]     |                       ^^^^^^^^^^^^ help: change this to: `&[Tokens]`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]    --> src/execute.rs:286:12
[INFO] [stderr]     |
[INFO] [stderr] 286 |     pipes: &Vec<(RawFd, RawFd)>,
[INFO] [stderr]     |            ^^^^^^^^^^^^^^^^^^^^ help: change this to: `&[(RawFd, RawFd)]`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: the function has a cyclomatic complexity of 41
[INFO] [stderr]    --> src/execute.rs:278:1
[INFO] [stderr]     |
[INFO] [stderr] 278 | / fn run_command(
[INFO] [stderr] 279 | |     sh: &mut shell::Shell,
[INFO] [stderr] 280 | |     cmd: &types::Command,
[INFO] [stderr] 281 | |     idx_cmd: usize,
[INFO] [stderr] ...   |
[INFO] [stderr] 545 | |     0
[INFO] [stderr] 546 | | }
[INFO] [stderr]     | |_^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::cyclomatic_complexity)] on by default
[INFO] [stderr]     = help: you could split it up into multiple smaller functions
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cyclomatic_complexity
[INFO] [stderr] 
[INFO] [stderr] warning: this function has too many arguments (8/7)
[INFO] [stderr]    --> src/execute.rs:278:1
[INFO] [stderr]     |
[INFO] [stderr] 278 | / fn run_command(
[INFO] [stderr] 279 | |     sh: &mut shell::Shell,
[INFO] [stderr] 280 | |     cmd: &types::Command,
[INFO] [stderr] 281 | |     idx_cmd: usize,
[INFO] [stderr] ...   |
[INFO] [stderr] 545 | |     0
[INFO] [stderr] 546 | | }
[INFO] [stderr]     | |_^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::too_many_arguments)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]    --> src/execute.rs:551:13
[INFO] [stderr]     |
[INFO] [stderr] 551 |     tokens: &Tokens,
[INFO] [stderr]     |             ^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: this function has too many arguments (8/7)
[INFO] [stderr]    --> src/execute.rs:549:1
[INFO] [stderr]     |
[INFO] [stderr] 549 | / pub fn run_pipeline(
[INFO] [stderr] 550 | |     sh: &mut shell::Shell,
[INFO] [stderr] 551 | |     tokens: &Tokens,
[INFO] [stderr] 552 | |     redirect_from: &str,
[INFO] [stderr] ...   |
[INFO] [stderr] 672 | |     (term_given, cmd_result)
[INFO] [stderr] 673 | | }
[INFO] [stderr]     | |_^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments
[INFO] [stderr] 
[INFO] [stderr] warning: the variable `i` is used as a loop counter. Consider using `for (i, item) in &cmds.enumerate()` or similar iterators
[INFO] [stderr]    --> src/execute.rs:609:16
[INFO] [stderr]     |
[INFO] [stderr] 609 |     for cmd in &cmds {
[INFO] [stderr]     |                ^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::explicit_counter_loop)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_counter_loop
[INFO] [stderr] 
[INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration)
[INFO] [stderr]    --> src/execute.rs:675:1
[INFO] [stderr]     |
[INFO] [stderr] 675 | / fn run_with_shell<'a, 'b>(sh: &'a mut shell::Shell, line: &'b str) -> CommandResult {
[INFO] [stderr] 676 | |     let (mut tokens, envs) = line_to_tokens(sh, &line);
[INFO] [stderr] 677 | |     if tokens.is_empty() {
[INFO] [stderr] 678 | |         return CommandResult::new();
[INFO] [stderr] ...   |
[INFO] [stderr] 715 | |     cmd_result
[INFO] [stderr] 716 | | }
[INFO] [stderr]     | |_^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::needless_lifetimes)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes
[INFO] [stderr] 
[INFO] [stderr] error: using `clone` on a double-reference; this will copy the reference instead of cloning the inner type
[INFO] [stderr]   --> src/history.rs:50:24
[INFO] [stderr]    |
[INFO] [stderr] 50 |     match sqlite::open(hfile.clone()) {
[INFO] [stderr]    |                        ^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[deny(clippy::clone_double_ref)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_double_ref
[INFO] [stderr] help: try dereferencing it
[INFO] [stderr]    |
[INFO] [stderr] 50 |     match sqlite::open(&(*hfile).clone()) {
[INFO] [stderr]    |                        ^^^^^^^^^^^^^^^^^
[INFO] [stderr] help: or try being explicit about what type to clone
[INFO] [stderr]    |
[INFO] [stderr] 50 |     match sqlite::open(&str::clone(hfile)) {
[INFO] [stderr]    |                        ^^^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression
[INFO] [stderr]   --> src/jobc.rs:19:5
[INFO] [stderr]    |
[INFO] [stderr] 19 | /     let _cmd;
[INFO] [stderr] 20 | |     if job.status != "Running" {
[INFO] [stderr] 21 | |         _cmd = cmd.trim_matches('&').trim();
[INFO] [stderr] 22 | |     } else {
[INFO] [stderr] 23 | |         _cmd = cmd.as_str();
[INFO] [stderr] 24 | |     }
[INFO] [stderr]    | |_____^ help: it is more idiomatic to write: `let _cmd = if job.status != "Running" { cmd.trim_matches('&').trim() } else { cmd.as_str() };`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::useless_let_if_seq)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq
[INFO] [stderr] 
[INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration)
[INFO] [stderr]   --> src/libs/path.rs:12:1
[INFO] [stderr]    |
[INFO] [stderr] 12 | / pub fn basename<'a>(path: &'a str) -> Cow<'a, str> {
[INFO] [stderr] 13 | |     let mut pieces = path.rsplit('/');
[INFO] [stderr] 14 | |     match pieces.next() {
[INFO] [stderr] 15 | |         Some(p) => p.into(),
[INFO] [stderr] 16 | |         None => path.into(),
[INFO] [stderr] 17 | |     }
[INFO] [stderr] 18 | | }
[INFO] [stderr]    | |_^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes
[INFO] [stderr] 
[INFO] [stderr] warning: trivial regex
[INFO] [stderr]    --> src/tools.rs:146:22
[INFO] [stderr]     |
[INFO] [stderr] 146 |     match Regex::new(r"!!") {
[INFO] [stderr]     |                      ^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::trivial_regex)] on by default
[INFO] [stderr]     = help: consider using `str::contains`
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivial_regex
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]  --> src/builtins/bg.rs:8:43
[INFO] [stderr]   |
[INFO] [stderr] 8 | pub fn run(sh: &mut shell::Shell, tokens: &types::Tokens) -> i32 {
[INFO] [stderr]   |                                           ^^^^^^^^^^^^^^
[INFO] [stderr]   |
[INFO] [stderr]   = note: #[warn(clippy::ptr_arg)] on by default
[INFO] [stderr]   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] error: this loop never actually loops
[INFO] [stderr]   --> src/builtins/bg.rs:16:9
[INFO] [stderr]    |
[INFO] [stderr] 16 | /         for (gid, _) in sh.jobs.iter() {
[INFO] [stderr] 17 | |             job_id = *gid;
[INFO] [stderr] 18 | |             break;
[INFO] [stderr] 19 | |         }
[INFO] [stderr]    | |_________^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[deny(clippy::never_loop)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#never_loop
[INFO] [stderr] 
[INFO] [stderr] warning: redundant pattern matching, consider using `is_none()`
[INFO] [stderr]   --> src/builtins/bg.rs:39:16
[INFO] [stderr]    |
[INFO] [stderr] 39 |           if let None = result {
[INFO] [stderr]    |  _________-      ^^^^
[INFO] [stderr] 40 | |             result = sh.get_job_by_gid(job_id);
[INFO] [stderr] 41 | |         }
[INFO] [stderr]    | |_________- help: try this: `if result.is_none()`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::redundant_pattern_matching)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]   --> src/parsers/parser_line.rs:16:31
[INFO] [stderr]    |
[INFO] [stderr] 16 | pub fn tokens_to_args(tokens: &Tokens) -> Vec<String> {
[INFO] [stderr]    |                               ^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]   --> src/parsers/parser_line.rs:24:31
[INFO] [stderr]    |
[INFO] [stderr] 24 | pub fn tokens_to_line(tokens: &Tokens) -> String {
[INFO] [stderr]    |                               ^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]   --> src/builtins/cd.rs:12:43
[INFO] [stderr]    |
[INFO] [stderr] 12 | pub fn run(sh: &mut shell::Shell, tokens: &Tokens) -> i32 {
[INFO] [stderr]    |                                           ^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: the function has a cyclomatic complexity of 41
[INFO] [stderr]    --> src/parsers/parser_line.rs:155:1
[INFO] [stderr]     |
[INFO] [stderr] 155 | / pub fn cmd_to_tokens(line: &str) -> Tokens {
[INFO] [stderr] 156 | |     let mut result = Vec::new();
[INFO] [stderr] 157 | |     let mut sep = String::new();
[INFO] [stderr] 158 | |     // `sep_second` is for commands like this:
[INFO] [stderr] ...   |
[INFO] [stderr] 387 | |     result
[INFO] [stderr] 388 | | }
[INFO] [stderr]     | |_^
[INFO] [stderr]     |
[INFO] [stderr]     = help: you could split it up into multiple smaller functions
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cyclomatic_complexity
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]  --> src/builtins/exec.rs:5:20
[INFO] [stderr]   |
[INFO] [stderr] 5 | pub fn run(tokens: &Tokens) -> i32 {
[INFO] [stderr]   |                    ^^^^^^^
[INFO] [stderr]   |
[INFO] [stderr]   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]  --> src/builtins/exit.rs:8:39
[INFO] [stderr]   |
[INFO] [stderr] 8 | pub fn run(sh: &shell::Shell, tokens: &Tokens) -> i32 {
[INFO] [stderr]   |                                       ^^^^^^^
[INFO] [stderr]   |
[INFO] [stderr]   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]    --> src/parsers/parser_line.rs:390:38
[INFO] [stderr]     |
[INFO] [stderr] 390 | pub fn cmd_to_with_redirects(tokens: &Tokens) -> Result<Command, String> {
[INFO] [stderr]     |                                      ^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]   --> src/builtins/export.rs:11:40
[INFO] [stderr]    |
[INFO] [stderr] 11 | pub fn run(_sh: &shell::Shell, tokens: &Tokens) -> i32 {
[INFO] [stderr]    |                                        ^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]  --> src/builtins/fg.rs:9:43
[INFO] [stderr]   |
[INFO] [stderr] 9 | pub fn run(sh: &mut shell::Shell, tokens: &types::Tokens) -> i32 {
[INFO] [stderr]   |                                           ^^^^^^^^^^^^^^
[INFO] [stderr]   |
[INFO] [stderr]   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] error: this loop never actually loops
[INFO] [stderr]   --> src/builtins/fg.rs:17:9
[INFO] [stderr]    |
[INFO] [stderr] 17 | /         for (gid, _) in sh.jobs.iter() {
[INFO] [stderr] 18 | |             job_id = *gid;
[INFO] [stderr] 19 | |             break;
[INFO] [stderr] 20 | |         }
[INFO] [stderr]    | |_________^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#never_loop
[INFO] [stderr] 
[INFO] [stderr] warning: redundant pattern matching, consider using `is_none()`
[INFO] [stderr]   --> src/builtins/fg.rs:41:16
[INFO] [stderr]    |
[INFO] [stderr] 41 |           if let None = result {
[INFO] [stderr]    |  _________-      ^^^^
[INFO] [stderr] 42 | |             result = sh.get_job_by_gid(job_id);
[INFO] [stderr] 43 | |         }
[INFO] [stderr]    | |_________- help: try this: `if result.is_none()`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]    --> src/builtins/vox.rs:114:39
[INFO] [stderr]     |
[INFO] [stderr] 114 | pub fn run(sh: &shell::Shell, tokens: &types::Tokens) -> i32 {
[INFO] [stderr]     |                                       ^^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]   --> src/execute.rs:49:33
[INFO] [stderr]    |
[INFO] [stderr] 49 | fn tokens_to_cmd_tokens(tokens: &Tokens) -> Vec<Tokens> {
[INFO] [stderr]    |                                 ^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] error: aborting due to 3 previous errors
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]    --> src/execute.rs:259:23
[INFO] [stderr]     |
[INFO] [stderr] 259 | fn log_cmd_info(cmds: &Vec<Tokens>) {
[INFO] [stderr]     |                       ^^^^^^^^^^^^ help: change this to: `&[Tokens]`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]    --> src/execute.rs:286:12
[INFO] [stderr]     |
[INFO] [stderr] 286 |     pipes: &Vec<(RawFd, RawFd)>,
[INFO] [stderr]     |            ^^^^^^^^^^^^^^^^^^^^ help: change this to: `&[(RawFd, RawFd)]`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] error: Could not compile `cicada`.
[INFO] [stderr] warning: build failed, waiting for other jobs to finish...
[INFO] [stderr] warning: the function has a cyclomatic complexity of 41
[INFO] [stderr]    --> src/execute.rs:278:1
[INFO] [stderr]     |
[INFO] [stderr] 278 | / fn run_command(
[INFO] [stderr] 279 | |     sh: &mut shell::Shell,
[INFO] [stderr] 280 | |     cmd: &types::Command,
[INFO] [stderr] 281 | |     idx_cmd: usize,
[INFO] [stderr] ...   |
[INFO] [stderr] 545 | |     0
[INFO] [stderr] 546 | | }
[INFO] [stderr]     | |_^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::cyclomatic_complexity)] on by default
[INFO] [stderr]     = help: you could split it up into multiple smaller functions
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cyclomatic_complexity
[INFO] [stderr] 
[INFO] [stderr] warning: this function has too many arguments (8/7)
[INFO] [stderr]    --> src/execute.rs:278:1
[INFO] [stderr]     |
[INFO] [stderr] 278 | / fn run_command(
[INFO] [stderr] 279 | |     sh: &mut shell::Shell,
[INFO] [stderr] 280 | |     cmd: &types::Command,
[INFO] [stderr] 281 | |     idx_cmd: usize,
[INFO] [stderr] ...   |
[INFO] [stderr] 545 | |     0
[INFO] [stderr] 546 | | }
[INFO] [stderr]     | |_^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::too_many_arguments)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]    --> src/execute.rs:551:13
[INFO] [stderr]     |
[INFO] [stderr] 551 |     tokens: &Tokens,
[INFO] [stderr]     |             ^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: this function has too many arguments (8/7)
[INFO] [stderr]    --> src/execute.rs:549:1
[INFO] [stderr]     |
[INFO] [stderr] 549 | / pub fn run_pipeline(
[INFO] [stderr] 550 | |     sh: &mut shell::Shell,
[INFO] [stderr] 551 | |     tokens: &Tokens,
[INFO] [stderr] 552 | |     redirect_from: &str,
[INFO] [stderr] ...   |
[INFO] [stderr] 672 | |     (term_given, cmd_result)
[INFO] [stderr] 673 | | }
[INFO] [stderr]     | |_^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments
[INFO] [stderr] 
[INFO] [stderr] warning: the variable `i` is used as a loop counter. Consider using `for (i, item) in &cmds.enumerate()` or similar iterators
[INFO] [stderr]    --> src/execute.rs:609:16
[INFO] [stderr]     |
[INFO] [stderr] 609 |     for cmd in &cmds {
[INFO] [stderr]     |                ^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::explicit_counter_loop)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_counter_loop
[INFO] [stderr] 
[INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration)
[INFO] [stderr]    --> src/execute.rs:675:1
[INFO] [stderr]     |
[INFO] [stderr] 675 | / fn run_with_shell<'a, 'b>(sh: &'a mut shell::Shell, line: &'b str) -> CommandResult {
[INFO] [stderr] 676 | |     let (mut tokens, envs) = line_to_tokens(sh, &line);
[INFO] [stderr] 677 | |     if tokens.is_empty() {
[INFO] [stderr] 678 | |         return CommandResult::new();
[INFO] [stderr] ...   |
[INFO] [stderr] 715 | |     cmd_result
[INFO] [stderr] 716 | | }
[INFO] [stderr]     | |_^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::needless_lifetimes)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes
[INFO] [stderr] 
[INFO] [stderr] error: using `clone` on a double-reference; this will copy the reference instead of cloning the inner type
[INFO] [stderr]   --> src/history.rs:50:24
[INFO] [stderr]    |
[INFO] [stderr] 50 |     match sqlite::open(hfile.clone()) {
[INFO] [stderr]    |                        ^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[deny(clippy::clone_double_ref)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_double_ref
[INFO] [stderr] help: try dereferencing it
[INFO] [stderr]    |
[INFO] [stderr] 50 |     match sqlite::open(&(*hfile).clone()) {
[INFO] [stderr]    |                        ^^^^^^^^^^^^^^^^^
[INFO] [stderr] help: or try being explicit about what type to clone
[INFO] [stderr]    |
[INFO] [stderr] 50 |     match sqlite::open(&str::clone(hfile)) {
[INFO] [stderr]    |                        ^^^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression
[INFO] [stderr]   --> src/jobc.rs:19:5
[INFO] [stderr]    |
[INFO] [stderr] 19 | /     let _cmd;
[INFO] [stderr] 20 | |     if job.status != "Running" {
[INFO] [stderr] 21 | |         _cmd = cmd.trim_matches('&').trim();
[INFO] [stderr] 22 | |     } else {
[INFO] [stderr] 23 | |         _cmd = cmd.as_str();
[INFO] [stderr] 24 | |     }
[INFO] [stderr]    | |_____^ help: it is more idiomatic to write: `let _cmd = if job.status != "Running" { cmd.trim_matches('&').trim() } else { cmd.as_str() };`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::useless_let_if_seq)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq
[INFO] [stderr] 
[INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration)
[INFO] [stderr]   --> src/libs/path.rs:12:1
[INFO] [stderr]    |
[INFO] [stderr] 12 | / pub fn basename<'a>(path: &'a str) -> Cow<'a, str> {
[INFO] [stderr] 13 | |     let mut pieces = path.rsplit('/');
[INFO] [stderr] 14 | |     match pieces.next() {
[INFO] [stderr] 15 | |         Some(p) => p.into(),
[INFO] [stderr] 16 | |         None => path.into(),
[INFO] [stderr] 17 | |     }
[INFO] [stderr] 18 | | }
[INFO] [stderr]    | |_^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]   --> src/parsers/parser_line.rs:16:31
[INFO] [stderr]    |
[INFO] [stderr] 16 | pub fn tokens_to_args(tokens: &Tokens) -> Vec<String> {
[INFO] [stderr]    |                               ^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]   --> src/parsers/parser_line.rs:24:31
[INFO] [stderr]    |
[INFO] [stderr] 24 | pub fn tokens_to_line(tokens: &Tokens) -> String {
[INFO] [stderr]    |                               ^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: the function has a cyclomatic complexity of 41
[INFO] [stderr]    --> src/parsers/parser_line.rs:155:1
[INFO] [stderr]     |
[INFO] [stderr] 155 | / pub fn cmd_to_tokens(line: &str) -> Tokens {
[INFO] [stderr] 156 | |     let mut result = Vec::new();
[INFO] [stderr] 157 | |     let mut sep = String::new();
[INFO] [stderr] 158 | |     // `sep_second` is for commands like this:
[INFO] [stderr] ...   |
[INFO] [stderr] 387 | |     result
[INFO] [stderr] 388 | | }
[INFO] [stderr]     | |_^
[INFO] [stderr]     |
[INFO] [stderr]     = help: you could split it up into multiple smaller functions
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cyclomatic_complexity
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]    --> src/parsers/parser_line.rs:390:38
[INFO] [stderr]     |
[INFO] [stderr] 390 | pub fn cmd_to_with_redirects(tokens: &Tokens) -> Result<Command, String> {
[INFO] [stderr]     |                                      ^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] error: aborting due to 3 previous errors
[INFO] [stderr] 
[INFO] [stderr] error: Could not compile `cicada`.
[INFO] [stderr] 
[INFO] [stderr] To learn more, run the command again with --verbose.
[INFO] running `"docker" "inspect" "ddba8b5c65b2b50a6ce181b3f2bc7418019a1433a6e4acf01f3e131c8b3799bc"`
[INFO] running `"docker" "rm" "-f" "ddba8b5c65b2b50a6ce181b3f2bc7418019a1433a6e4acf01f3e131c8b3799bc"`
[INFO] [stdout] ddba8b5c65b2b50a6ce181b3f2bc7418019a1433a6e4acf01f3e131c8b3799bc