[INFO] crate chords 0.1.93 is already in cache
[INFO] extracting crate chords 0.1.93 into work/ex/clippy-test-run/sources/stable/reg/chords/0.1.93
[INFO] extracting crate chords 0.1.93 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/chords/0.1.93
[INFO] validating manifest of chords-0.1.93 on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of chords-0.1.93 on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing chords-0.1.93
[INFO] finished frobbing chords-0.1.93
[INFO] frobbed toml for chords-0.1.93 written to work/ex/clippy-test-run/sources/stable/reg/chords/0.1.93/Cargo.toml
[INFO] started frobbing chords-0.1.93
[INFO] finished frobbing chords-0.1.93
[INFO] frobbed toml for chords-0.1.93 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/chords/0.1.93/Cargo.toml
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting chords-0.1.93 against stable for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-3/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/chords/0.1.93:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] b6b000a56effa02becc9b2b5423564112c07ae2d17c198e9ec0b1d4140f16971
[INFO] running `"docker" "start" "-a" "b6b000a56effa02becc9b2b5423564112c07ae2d17c198e9ec0b1d4140f16971"`
[INFO] [stderr]     Checking chords v0.1.93 (/opt/crater/workdir)
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/chord.rs:36:15
[INFO] [stderr]    |
[INFO] [stderr] 36 |         Chord{name: name, notes: notes, extended: extended}
[INFO] [stderr]    |               ^^^^^^^^^^ help: replace it with: `name`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::redundant_field_names)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/chord.rs:36:27
[INFO] [stderr]    |
[INFO] [stderr] 36 |         Chord{name: name, notes: notes, extended: extended}
[INFO] [stderr]    |                           ^^^^^^^^^^^^ help: replace it with: `notes`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/chord.rs:36:41
[INFO] [stderr]    |
[INFO] [stderr] 36 |         Chord{name: name, notes: notes, extended: extended}
[INFO] [stderr]    |                                         ^^^^^^^^^^^^^^^^^^ help: replace it with: `extended`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/chord.rs:36:15
[INFO] [stderr]    |
[INFO] [stderr] 36 |         Chord{name: name, notes: notes, extended: extended}
[INFO] [stderr]    |               ^^^^^^^^^^ help: replace it with: `name`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::redundant_field_names)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/chord.rs:36:27
[INFO] [stderr]    |
[INFO] [stderr] 36 |         Chord{name: name, notes: notes, extended: extended}
[INFO] [stderr]    |                           ^^^^^^^^^^^^ help: replace it with: `notes`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/chord.rs:36:41
[INFO] [stderr]    |
[INFO] [stderr] 36 |         Chord{name: name, notes: notes, extended: extended}
[INFO] [stderr]    |                                         ^^^^^^^^^^^^^^^^^^ help: replace it with: `extended`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: doc comment not used by rustdoc
[INFO] [stderr]  --> src/scale.rs:7:25
[INFO] [stderr]   |
[INFO] [stderr] 7 |     v.push(('a', 0));   /// a
[INFO] [stderr]   |                         ^^^^^
[INFO] [stderr]   |
[INFO] [stderr]   = note: #[warn(unused_doc_comments)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: doc comment not used by rustdoc
[INFO] [stderr]  --> src/scale.rs:8:25
[INFO] [stderr]   |
[INFO] [stderr] 8 |     v.push(('a', 1));   /// a sharp
[INFO] [stderr]   |                         ^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: doc comment not used by rustdoc
[INFO] [stderr]  --> src/scale.rs:9:25
[INFO] [stderr]   |
[INFO] [stderr] 9 |     v.push(('b', 0));   /// b
[INFO] [stderr]   |                         ^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: doc comment not used by rustdoc
[INFO] [stderr]   --> src/scale.rs:10:25
[INFO] [stderr]    |
[INFO] [stderr] 10 |     v.push(('c', 0));   /// c
[INFO] [stderr]    |                         ^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: doc comment not used by rustdoc
[INFO] [stderr]   --> src/scale.rs:11:25
[INFO] [stderr]    |
[INFO] [stderr] 11 |     v.push(('c', 1));   /// c sharp
[INFO] [stderr]    |                         ^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: doc comment not used by rustdoc
[INFO] [stderr]   --> src/scale.rs:12:25
[INFO] [stderr]    |
[INFO] [stderr] 12 |     v.push(('d', 0));   /// d
[INFO] [stderr]    |                         ^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: doc comment not used by rustdoc
[INFO] [stderr]   --> src/scale.rs:13:25
[INFO] [stderr]    |
[INFO] [stderr] 13 |     v.push(('d', 1));   /// d sharp
[INFO] [stderr]    |                         ^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: doc comment not used by rustdoc
[INFO] [stderr]   --> src/scale.rs:14:25
[INFO] [stderr]    |
[INFO] [stderr] 14 |     v.push(('e', 0));   /// e
[INFO] [stderr]    |                         ^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: doc comment not used by rustdoc
[INFO] [stderr]   --> src/scale.rs:15:25
[INFO] [stderr]    |
[INFO] [stderr] 15 |     v.push(('f', 0));   /// f 
[INFO] [stderr]    |                         ^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: doc comment not used by rustdoc
[INFO] [stderr]   --> src/scale.rs:16:25
[INFO] [stderr]    |
[INFO] [stderr] 16 |     v.push(('f', 1));   /// f sharp
[INFO] [stderr]    |                         ^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: doc comment not used by rustdoc
[INFO] [stderr]   --> src/scale.rs:17:25
[INFO] [stderr]    |
[INFO] [stderr] 17 |     v.push(('g', 0));   /// g
[INFO] [stderr]    |                         ^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: doc comment not used by rustdoc
[INFO] [stderr]   --> src/scale.rs:18:25
[INFO] [stderr]    |
[INFO] [stderr] 18 |     v.push(('g', 1));   /// g sharp
[INFO] [stderr]    |                         ^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: doc comment not used by rustdoc
[INFO] [stderr]   --> src/lib.rs:18:5
[INFO] [stderr]    |
[INFO] [stderr] 18 |     ///Return notes filtered by scale
[INFO] [stderr]    |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: this if statement can be collapsed
[INFO] [stderr]   --> src/lib.rs:85:5
[INFO] [stderr]    |
[INFO] [stderr] 85 | /     if intervals.len() > 6 {
[INFO] [stderr] 86 | |         if extended {
[INFO] [stderr] 87 | |             // +4
[INFO] [stderr] 88 | |             chords.push(Chord::new(&root_str, vec![0, 
[INFO] [stderr] ...  |
[INFO] [stderr] 96 | |         }
[INFO] [stderr] 97 | |     }
[INFO] [stderr]    | |_____^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::collapsible_if)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if
[INFO] [stderr] help: try
[INFO] [stderr]    |
[INFO] [stderr] 85 |     if intervals.len() > 6 && extended {
[INFO] [stderr] 86 |     // +4
[INFO] [stderr] 87 |     chords.push(Chord::new(&root_str, vec![0, 
[INFO] [stderr] 88 |                            intervals[1], 
[INFO] [stderr] 89 |                            intervals[2], 
[INFO] [stderr] 90 |                            intervals[3], 
[INFO] [stderr]  ...
[INFO] [stderr] 
[INFO] [stderr] warning: doc comment not used by rustdoc
[INFO] [stderr]  --> src/scale.rs:7:25
[INFO] [stderr]   |
[INFO] [stderr] 7 |     v.push(('a', 0));   /// a
[INFO] [stderr]   |                         ^^^^^
[INFO] [stderr]   |
[INFO] [stderr]   = note: #[warn(unused_doc_comments)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: doc comment not used by rustdoc
[INFO] [stderr]  --> src/scale.rs:8:25
[INFO] [stderr]   |
[INFO] [stderr] 8 |     v.push(('a', 1));   /// a sharp
[INFO] [stderr]   |                         ^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: doc comment not used by rustdoc
[INFO] [stderr]  --> src/scale.rs:9:25
[INFO] [stderr]   |
[INFO] [stderr] 9 |     v.push(('b', 0));   /// b
[INFO] [stderr]   |                         ^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: doc comment not used by rustdoc
[INFO] [stderr]   --> src/scale.rs:10:25
[INFO] [stderr]    |
[INFO] [stderr] 10 |     v.push(('c', 0));   /// c
[INFO] [stderr]    |                         ^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: doc comment not used by rustdoc
[INFO] [stderr]   --> src/scale.rs:11:25
[INFO] [stderr]    |
[INFO] [stderr] 11 |     v.push(('c', 1));   /// c sharp
[INFO] [stderr]    |                         ^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: doc comment not used by rustdoc
[INFO] [stderr]   --> src/scale.rs:12:25
[INFO] [stderr]    |
[INFO] [stderr] 12 |     v.push(('d', 0));   /// d
[INFO] [stderr]    |                         ^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: doc comment not used by rustdoc
[INFO] [stderr]   --> src/scale.rs:13:25
[INFO] [stderr]    |
[INFO] [stderr] 13 |     v.push(('d', 1));   /// d sharp
[INFO] [stderr]    |                         ^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: doc comment not used by rustdoc
[INFO] [stderr]   --> src/scale.rs:14:25
[INFO] [stderr]    |
[INFO] [stderr] 14 |     v.push(('e', 0));   /// e
[INFO] [stderr]    |                         ^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: doc comment not used by rustdoc
[INFO] [stderr]   --> src/scale.rs:15:25
[INFO] [stderr]    |
[INFO] [stderr] 15 |     v.push(('f', 0));   /// f 
[INFO] [stderr]    |                         ^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: doc comment not used by rustdoc
[INFO] [stderr]   --> src/scale.rs:16:25
[INFO] [stderr]    |
[INFO] [stderr] 16 |     v.push(('f', 1));   /// f sharp
[INFO] [stderr]    |                         ^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: doc comment not used by rustdoc
[INFO] [stderr]   --> src/scale.rs:17:25
[INFO] [stderr]    |
[INFO] [stderr] 17 |     v.push(('g', 0));   /// g
[INFO] [stderr]    |                         ^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: doc comment not used by rustdoc
[INFO] [stderr]   --> src/scale.rs:18:25
[INFO] [stderr]    |
[INFO] [stderr] 18 |     v.push(('g', 1));   /// g sharp
[INFO] [stderr]    |                         ^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: doc comment not used by rustdoc
[INFO] [stderr]   --> src/lib.rs:18:5
[INFO] [stderr]    |
[INFO] [stderr] 18 |     ///Return notes filtered by scale
[INFO] [stderr]    |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: this if statement can be collapsed
[INFO] [stderr]   --> src/lib.rs:85:5
[INFO] [stderr]    |
[INFO] [stderr] 85 | /     if intervals.len() > 6 {
[INFO] [stderr] 86 | |         if extended {
[INFO] [stderr] 87 | |             // +4
[INFO] [stderr] 88 | |             chords.push(Chord::new(&root_str, vec![0, 
[INFO] [stderr] ...  |
[INFO] [stderr] 96 | |         }
[INFO] [stderr] 97 | |     }
[INFO] [stderr]    | |_____^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::collapsible_if)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if
[INFO] [stderr] help: try
[INFO] [stderr]    |
[INFO] [stderr] 85 |     if intervals.len() > 6 && extended {
[INFO] [stderr] 86 |     // +4
[INFO] [stderr] 87 |     chords.push(Chord::new(&root_str, vec![0, 
[INFO] [stderr] 88 |                            intervals[1], 
[INFO] [stderr] 89 |                            intervals[2], 
[INFO] [stderr] 90 |                            intervals[3], 
[INFO] [stderr]  ...
[INFO] [stderr] 
[INFO] [stderr] warning: value assigned to `added` is never read
[INFO] [stderr]   --> src/attribute.rs:89:17
[INFO] [stderr]    |
[INFO] [stderr] 89 |                 added = true;
[INFO] [stderr]    |                 ^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(unused_assignments)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: value assigned to `added` is never read
[INFO] [stderr]   --> src/attribute.rs:99:17
[INFO] [stderr]    |
[INFO] [stderr] 99 |                 added = true;
[INFO] [stderr]    |                 ^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: single-character string constant used as pattern
[INFO] [stderr]   --> src/scale.rs:70:20
[INFO] [stderr]    |
[INFO] [stderr] 70 |     scalestr.split(",").map(|s| s.parse::<u8>().unwrap_or(1)).collect()
[INFO] [stderr]    |                    ^^^ help: try using a char instead: `','`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::single_char_pattern)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: manual implementation of an assign operation
[INFO] [stderr]   --> src/scale.rs:77:9
[INFO] [stderr]    |
[INFO] [stderr] 77 |         *sum = *sum + step; 
[INFO] [stderr]    |         ^^^^^^^^^^^^^^^^^^ help: replace it with: `*sum += step`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::assign_op_pattern)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do.
[INFO] [stderr]   --> src/chord.rs:16:22
[INFO] [stderr]    |
[INFO] [stderr] 16 |     pub fn new(root: &String, intervals: Vec<u8>, extended: bool) -> Chord {
[INFO] [stderr]    |                      ^^^^^^^ help: change this to: `&str`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::ptr_arg)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]   --> src/chord.rs:40:41
[INFO] [stderr]    |
[INFO] [stderr] 40 |     pub fn format_notes(&mut self, src: &Vec<(char,i8)>) {
[INFO] [stderr]    |                                         ^^^^^^^^^^^^^^^ help: change this to: `&[(char,i8)]`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: You are using an explicit closure for cloning elements
[INFO] [stderr]   --> src/attribute.rs:21:26
[INFO] [stderr]    |
[INFO] [stderr] 21 |           self.intervals = self.intervals.iter()
[INFO] [stderr]    |  __________________________^
[INFO] [stderr] 22 | |             .filter(|&x| *x != i)
[INFO] [stderr] 23 | |             .map(|&x| x)
[INFO] [stderr]    | |________________________^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::map_clone)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone
[INFO] [stderr] help: Consider calling the dedicated `cloned` method
[INFO] [stderr]    |
[INFO] [stderr] 21 |         self.intervals = self.intervals.iter()
[INFO] [stderr] 22 |             .filter(|&x| *x != i).cloned()
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression
[INFO] [stderr]   --> src/attribute.rs:74:13
[INFO] [stderr]    |
[INFO] [stderr] 74 | /             let mut added = false;
[INFO] [stderr] 75 | |
[INFO] [stderr] 76 | |             // 6
[INFO] [stderr] 77 | |             if self.has(&[9]) {
[INFO] [stderr] 78 | |                 val.push_str("add6");
[INFO] [stderr] 79 | |                 added = true;
[INFO] [stderr] 80 | |             }
[INFO] [stderr]    | |_____________^ help: it is more idiomatic to write: `let <mut> added = if self.has(&[9]) { ..; true } else { false };`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::useless_let_if_seq)] on by default
[INFO] [stderr]    = note: you might not need `mut` at all
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]    --> src/attribute.rs:168:12
[INFO] [stderr]     |
[INFO] [stderr] 168 |         if nth.len() > 0 {
[INFO] [stderr]     |            ^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!nth.is_empty()`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::len_zero)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]    --> src/attribute.rs:169:16
[INFO] [stderr]     |
[INFO] [stderr] 169 |             if val.len() > 0 && &val != "m" && &val != "dim" {
[INFO] [stderr]     |                ^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!val.is_empty()`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: redundant closure found
[INFO] [stderr]  --> src/json.rs:7:48
[INFO] [stderr]   |
[INFO] [stderr] 7 |         "chords": json!(chords.into_iter().map(|c| serialize_chord(c)).collect::<Vec<Value>>()) }).to_string()
[INFO] [stderr]   |                                                ^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `serialize_chord`
[INFO] [stderr]   |
[INFO] [stderr]   = note: #[warn(clippy::redundant_closure)] on by default
[INFO] [stderr]   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]   --> src/lib.rs:28:45
[INFO] [stderr]    |
[INFO] [stderr] 28 | fn get_chords(root_note: (char, i8), notes: &Vec<(char, i8)>, extended: bool) -> Vec<Chord> {
[INFO] [stderr]    |                                             ^^^^^^^^^^^^^^^^ help: change this to: `&[(char, i8)]`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: value assigned to `added` is never read
[INFO] [stderr]   --> src/attribute.rs:89:17
[INFO] [stderr]    |
[INFO] [stderr] 89 |                 added = true;
[INFO] [stderr]    |                 ^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(unused_assignments)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: value assigned to `added` is never read
[INFO] [stderr]   --> src/attribute.rs:99:17
[INFO] [stderr]    |
[INFO] [stderr] 99 |                 added = true;
[INFO] [stderr]    |                 ^^^^^
[INFO] [stderr] 
[INFO] [stderr] error: this public function dereferences a raw pointer but is not marked `unsafe`
[INFO] [stderr]    --> src/lib.rs:155:24
[INFO] [stderr]     |
[INFO] [stderr] 155 |         CStr::from_ptr(key)
[INFO] [stderr]     |                        ^^^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[deny(clippy::not_unsafe_ptr_arg_deref)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#not_unsafe_ptr_arg_deref
[INFO] [stderr] 
[INFO] [stderr] error: this public function dereferences a raw pointer but is not marked `unsafe`
[INFO] [stderr]    --> src/lib.rs:161:24
[INFO] [stderr]     |
[INFO] [stderr] 161 |         CStr::from_ptr(scale)
[INFO] [stderr]     |                        ^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#not_unsafe_ptr_arg_deref
[INFO] [stderr] 
[INFO] [stderr] error: aborting due to 2 previous errors
[INFO] [stderr] 
[INFO] [stderr] error: Could not compile `chords`.
[INFO] [stderr] warning: build failed, waiting for other jobs to finish...
[INFO] [stderr] warning: single-character string constant used as pattern
[INFO] [stderr]   --> src/scale.rs:70:20
[INFO] [stderr]    |
[INFO] [stderr] 70 |     scalestr.split(",").map(|s| s.parse::<u8>().unwrap_or(1)).collect()
[INFO] [stderr]    |                    ^^^ help: try using a char instead: `','`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::single_char_pattern)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: manual implementation of an assign operation
[INFO] [stderr]   --> src/scale.rs:77:9
[INFO] [stderr]    |
[INFO] [stderr] 77 |         *sum = *sum + step; 
[INFO] [stderr]    |         ^^^^^^^^^^^^^^^^^^ help: replace it with: `*sum += step`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::assign_op_pattern)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do.
[INFO] [stderr]   --> src/chord.rs:16:22
[INFO] [stderr]    |
[INFO] [stderr] 16 |     pub fn new(root: &String, intervals: Vec<u8>, extended: bool) -> Chord {
[INFO] [stderr]    |                      ^^^^^^^ help: change this to: `&str`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::ptr_arg)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]   --> src/chord.rs:40:41
[INFO] [stderr]    |
[INFO] [stderr] 40 |     pub fn format_notes(&mut self, src: &Vec<(char,i8)>) {
[INFO] [stderr]    |                                         ^^^^^^^^^^^^^^^ help: change this to: `&[(char,i8)]`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: You are using an explicit closure for cloning elements
[INFO] [stderr]   --> src/attribute.rs:21:26
[INFO] [stderr]    |
[INFO] [stderr] 21 |           self.intervals = self.intervals.iter()
[INFO] [stderr]    |  __________________________^
[INFO] [stderr] 22 | |             .filter(|&x| *x != i)
[INFO] [stderr] 23 | |             .map(|&x| x)
[INFO] [stderr]    | |________________________^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::map_clone)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone
[INFO] [stderr] help: Consider calling the dedicated `cloned` method
[INFO] [stderr]    |
[INFO] [stderr] 21 |         self.intervals = self.intervals.iter()
[INFO] [stderr] 22 |             .filter(|&x| *x != i).cloned()
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression
[INFO] [stderr]   --> src/attribute.rs:74:13
[INFO] [stderr]    |
[INFO] [stderr] 74 | /             let mut added = false;
[INFO] [stderr] 75 | |
[INFO] [stderr] 76 | |             // 6
[INFO] [stderr] 77 | |             if self.has(&[9]) {
[INFO] [stderr] 78 | |                 val.push_str("add6");
[INFO] [stderr] 79 | |                 added = true;
[INFO] [stderr] 80 | |             }
[INFO] [stderr]    | |_____________^ help: it is more idiomatic to write: `let <mut> added = if self.has(&[9]) { ..; true } else { false };`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::useless_let_if_seq)] on by default
[INFO] [stderr]    = note: you might not need `mut` at all
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]    --> src/attribute.rs:168:12
[INFO] [stderr]     |
[INFO] [stderr] 168 |         if nth.len() > 0 {
[INFO] [stderr]     |            ^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!nth.is_empty()`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::len_zero)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]    --> src/attribute.rs:169:16
[INFO] [stderr]     |
[INFO] [stderr] 169 |             if val.len() > 0 && &val != "m" && &val != "dim" {
[INFO] [stderr]     |                ^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!val.is_empty()`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: redundant closure found
[INFO] [stderr]  --> src/json.rs:7:48
[INFO] [stderr]   |
[INFO] [stderr] 7 |         "chords": json!(chords.into_iter().map(|c| serialize_chord(c)).collect::<Vec<Value>>()) }).to_string()
[INFO] [stderr]   |                                                ^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `serialize_chord`
[INFO] [stderr]   |
[INFO] [stderr]   = note: #[warn(clippy::redundant_closure)] on by default
[INFO] [stderr]   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]   --> src/lib.rs:28:45
[INFO] [stderr]    |
[INFO] [stderr] 28 | fn get_chords(root_note: (char, i8), notes: &Vec<(char, i8)>, extended: bool) -> Vec<Chord> {
[INFO] [stderr]    |                                             ^^^^^^^^^^^^^^^^ help: change this to: `&[(char, i8)]`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] error: this public function dereferences a raw pointer but is not marked `unsafe`
[INFO] [stderr]    --> src/lib.rs:155:24
[INFO] [stderr]     |
[INFO] [stderr] 155 |         CStr::from_ptr(key)
[INFO] [stderr]     |                        ^^^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[deny(clippy::not_unsafe_ptr_arg_deref)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#not_unsafe_ptr_arg_deref
[INFO] [stderr] 
[INFO] [stderr] error: this public function dereferences a raw pointer but is not marked `unsafe`
[INFO] [stderr]    --> src/lib.rs:161:24
[INFO] [stderr]     |
[INFO] [stderr] 161 |         CStr::from_ptr(scale)
[INFO] [stderr]     |                        ^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#not_unsafe_ptr_arg_deref
[INFO] [stderr] 
[INFO] [stderr] error: aborting due to 2 previous errors
[INFO] [stderr] 
[INFO] [stderr] error: Could not compile `chords`.
[INFO] [stderr] 
[INFO] [stderr] To learn more, run the command again with --verbose.
[INFO] running `"docker" "inspect" "b6b000a56effa02becc9b2b5423564112c07ae2d17c198e9ec0b1d4140f16971"`
[INFO] running `"docker" "rm" "-f" "b6b000a56effa02becc9b2b5423564112c07ae2d17c198e9ec0b1d4140f16971"`
[INFO] [stdout] b6b000a56effa02becc9b2b5423564112c07ae2d17c198e9ec0b1d4140f16971