[INFO] crate chipmunk-rs 0.1.1 is already in cache [INFO] extracting crate chipmunk-rs 0.1.1 into work/ex/clippy-test-run/sources/stable/reg/chipmunk-rs/0.1.1 [INFO] extracting crate chipmunk-rs 0.1.1 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/chipmunk-rs/0.1.1 [INFO] validating manifest of chipmunk-rs-0.1.1 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of chipmunk-rs-0.1.1 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing chipmunk-rs-0.1.1 [INFO] finished frobbing chipmunk-rs-0.1.1 [INFO] frobbed toml for chipmunk-rs-0.1.1 written to work/ex/clippy-test-run/sources/stable/reg/chipmunk-rs/0.1.1/Cargo.toml [INFO] started frobbing chipmunk-rs-0.1.1 [INFO] finished frobbing chipmunk-rs-0.1.1 [INFO] frobbed toml for chipmunk-rs-0.1.1 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/chipmunk-rs/0.1.1/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting chipmunk-rs-0.1.1 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-2/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/chipmunk-rs/0.1.1:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] af258e96ed00349cd463eb0aaab26d82fcf04f875f8810928c8edeb204f19fac [INFO] running `"docker" "start" "-a" "af258e96ed00349cd463eb0aaab26d82fcf04f875f8810928c8edeb204f19fac"` [INFO] [stderr] Compiling chipmunk-rs v0.1.1 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/ffi.rs:19:53 [INFO] [stderr] | [INFO] [stderr] 19 | pub fn new(x: f64, y: f64) -> CPVect { CPVect { x: x, y: y } } [INFO] [stderr] | ^^^^ help: replace it with: `x` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/ffi.rs:19:59 [INFO] [stderr] | [INFO] [stderr] 19 | pub fn new(x: f64, y: f64) -> CPVect { CPVect { x: x, y: y } } [INFO] [stderr] | ^^^^ help: replace it with: `y` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/ffi.rs:19:53 [INFO] [stderr] | [INFO] [stderr] 19 | pub fn new(x: f64, y: f64) -> CPVect { CPVect { x: x, y: y } } [INFO] [stderr] | ^^^^ help: replace it with: `x` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/ffi.rs:19:59 [INFO] [stderr] | [INFO] [stderr] 19 | pub fn new(x: f64, y: f64) -> CPVect { CPVect { x: x, y: y } } [INFO] [stderr] | ^^^^ help: replace it with: `y` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: you should consider adding a `Default` implementation for `Space` [INFO] [stderr] --> src/lib.rs:79:5 [INFO] [stderr] | [INFO] [stderr] 79 | / pub fn new() -> Space { [INFO] [stderr] 80 | | Space { [INFO] [stderr] 81 | | ptr: unsafe { cpSpaceNew() }, [INFO] [stderr] 82 | | bodies: HashMap::new(), [INFO] [stderr] 83 | | shapes: HashMap::new() [INFO] [stderr] 84 | | } [INFO] [stderr] 85 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 77 | impl Default for Space { [INFO] [stderr] 78 | fn default() -> Self { [INFO] [stderr] 79 | Self::new() [INFO] [stderr] 80 | } [INFO] [stderr] 81 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_some()` [INFO] [stderr] --> src/lib.rs:203:16 [INFO] [stderr] | [INFO] [stderr] 203 | if let Some(_) = self.shapes.insert(handle.borrow().to_shape(), handle.clone()) { [INFO] [stderr] | _________- ^^^^^^^ [INFO] [stderr] 204 | | panic!("Trying to insert an already instered shape in to a space. This should not be possible as Shape::new() is the only way to create owned shapes and it always creates new shapes."); [INFO] [stderr] 205 | | } [INFO] [stderr] | |_________- help: try this: `if self.shapes.insert(handle.borrow().to_shape(), handle.clone()).is_some()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_pattern_matching)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_some()` [INFO] [stderr] --> src/lib.rs:217:16 [INFO] [stderr] | [INFO] [stderr] 217 | if let Some(_) = self.bodies.insert(handle.borrow().ptr, handle.clone()) { [INFO] [stderr] | _________- ^^^^^^^ [INFO] [stderr] 218 | | panic!("Trying to insert an already instered body in to a space. This should not be possible as Body::new() is the only way to create owned bodies and it always creates new bodies."); [INFO] [stderr] 219 | | } [INFO] [stderr] | |_________- help: try this: `if self.bodies.insert(handle.borrow().ptr, handle.clone()).is_some()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: you should consider adding a `Default` implementation for `Space` [INFO] [stderr] --> src/lib.rs:79:5 [INFO] [stderr] | [INFO] [stderr] 79 | / pub fn new() -> Space { [INFO] [stderr] 80 | | Space { [INFO] [stderr] 81 | | ptr: unsafe { cpSpaceNew() }, [INFO] [stderr] 82 | | bodies: HashMap::new(), [INFO] [stderr] 83 | | shapes: HashMap::new() [INFO] [stderr] 84 | | } [INFO] [stderr] 85 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 77 | impl Default for Space { [INFO] [stderr] 78 | fn default() -> Self { [INFO] [stderr] 79 | Self::new() [INFO] [stderr] 80 | } [INFO] [stderr] 81 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_some()` [INFO] [stderr] --> src/lib.rs:203:16 [INFO] [stderr] | [INFO] [stderr] 203 | if let Some(_) = self.shapes.insert(handle.borrow().to_shape(), handle.clone()) { [INFO] [stderr] | _________- ^^^^^^^ [INFO] [stderr] 204 | | panic!("Trying to insert an already instered shape in to a space. This should not be possible as Shape::new() is the only way to create owned shapes and it always creates new shapes."); [INFO] [stderr] 205 | | } [INFO] [stderr] | |_________- help: try this: `if self.shapes.insert(handle.borrow().to_shape(), handle.clone()).is_some()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_pattern_matching)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_some()` [INFO] [stderr] --> src/lib.rs:217:16 [INFO] [stderr] | [INFO] [stderr] 217 | if let Some(_) = self.bodies.insert(handle.borrow().ptr, handle.clone()) { [INFO] [stderr] | _________- ^^^^^^^ [INFO] [stderr] 218 | | panic!("Trying to insert an already instered body in to a space. This should not be possible as Body::new() is the only way to create owned bodies and it always creates new bodies."); [INFO] [stderr] 219 | | } [INFO] [stderr] | |_________- help: try this: `if self.bodies.insert(handle.borrow().ptr, handle.clone()).is_some()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 5.47s [INFO] running `"docker" "inspect" "af258e96ed00349cd463eb0aaab26d82fcf04f875f8810928c8edeb204f19fac"` [INFO] running `"docker" "rm" "-f" "af258e96ed00349cd463eb0aaab26d82fcf04f875f8810928c8edeb204f19fac"` [INFO] [stdout] af258e96ed00349cd463eb0aaab26d82fcf04f875f8810928c8edeb204f19fac