[INFO] crate chip8_vm 0.4.0 is already in cache
[INFO] extracting crate chip8_vm 0.4.0 into work/ex/clippy-test-run/sources/stable/reg/chip8_vm/0.4.0
[INFO] extracting crate chip8_vm 0.4.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/chip8_vm/0.4.0
[INFO] validating manifest of chip8_vm-0.4.0 on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of chip8_vm-0.4.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing chip8_vm-0.4.0
[INFO] finished frobbing chip8_vm-0.4.0
[INFO] frobbed toml for chip8_vm-0.4.0 written to work/ex/clippy-test-run/sources/stable/reg/chip8_vm/0.4.0/Cargo.toml
[INFO] started frobbing chip8_vm-0.4.0
[INFO] finished frobbing chip8_vm-0.4.0
[INFO] frobbed toml for chip8_vm-0.4.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/chip8_vm/0.4.0/Cargo.toml
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting chip8_vm-0.4.0 against stable for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-6/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/chip8_vm/0.4.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] 4e28a97774d67f8508bdfe2153a1c18fa2d20c4c8932dbe0dea6391bb8a7ee12
[INFO] running `"docker" "start" "-a" "4e28a97774d67f8508bdfe2153a1c18fa2d20c4c8932dbe0dea6391bb8a7ee12"`
[INFO] [stderr]     Checking chip8_vm v0.4.0 (/opt/crater/workdir)
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/instructions.rs:107:25
[INFO] [stderr]     |
[INFO] [stderr] 107 |         RawInstruction{ bits: bits }
[INFO] [stderr]     |                         ^^^^^^^^^^ help: replace it with: `bits`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::redundant_field_names)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: using `println!("")`
[INFO] [stderr]    --> src/vm.rs:416:13
[INFO] [stderr]     |
[INFO] [stderr] 416 |             println!("");
[INFO] [stderr]     |             ^^^^^^^^^^^^ help: replace it with: `println!()`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::println_empty_string)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#println_empty_string
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/instructions.rs:107:25
[INFO] [stderr]     |
[INFO] [stderr] 107 |         RawInstruction{ bits: bits }
[INFO] [stderr]     |                         ^^^^^^^^^^ help: replace it with: `bits`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::redundant_field_names)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: using `println!("")`
[INFO] [stderr]    --> src/vm.rs:416:13
[INFO] [stderr]     |
[INFO] [stderr] 416 |             println!("");
[INFO] [stderr]     |             ^^^^^^^^^^^^ help: replace it with: `println!()`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::println_empty_string)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#println_empty_string
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/vm.rs:129:9
[INFO] [stderr]     |
[INFO] [stderr] 129 |         return Ok(rom_len);
[INFO] [stderr]     |         ^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(rom_len)`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::needless_return)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/vm.rs:361:9
[INFO] [stderr]     |
[INFO] [stderr] 361 |         return false;
[INFO] [stderr]     |         ^^^^^^^^^^^^^ help: remove `return` as shown: `false`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: long literal lacking separators
[INFO] [stderr]    --> src/vm.rs:283:56
[INFO] [stderr]     |
[INFO] [stderr] 283 |                         let px = (*byte >> (7 - sx)) & 0b00000001;
[INFO] [stderr]     |                                                        ^^^^^^^^^^ help: consider: `0b0000_0001`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::unreadable_literal)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/vm.rs:129:9
[INFO] [stderr]     |
[INFO] [stderr] 129 |         return Ok(rom_len);
[INFO] [stderr]     |         ^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(rom_len)`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::needless_return)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/vm.rs:361:9
[INFO] [stderr]     |
[INFO] [stderr] 361 |         return false;
[INFO] [stderr]     |         ^^^^^^^^^^^^^ help: remove `return` as shown: `false`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: long literal lacking separators
[INFO] [stderr]    --> src/vm.rs:283:56
[INFO] [stderr]     |
[INFO] [stderr] 283 |                         let px = (*byte >> (7 - sx)) & 0b00000001;
[INFO] [stderr]     |                                                        ^^^^^^^^^^ help: consider: `0b0000_0001`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::unreadable_literal)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal
[INFO] [stderr] 
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]    --> src/instructions.rs:112:17
[INFO] [stderr]     |
[INFO] [stderr] 112 |     pub fn bits(&self) -> u16 {
[INFO] [stderr]     |                 ^^^^^ help: consider passing by value instead: `self`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]    --> src/instructions.rs:117:17
[INFO] [stderr]     |
[INFO] [stderr] 117 |     pub fn addr(&self) -> Addr {
[INFO] [stderr]     |                 ^^^^^ help: consider passing by value instead: `self`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]    --> src/instructions.rs:122:14
[INFO] [stderr]     |
[INFO] [stderr] 122 |     pub fn x(&self) -> Vx {
[INFO] [stderr]     |              ^^^^^ help: consider passing by value instead: `self`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]    --> src/instructions.rs:127:14
[INFO] [stderr]     |
[INFO] [stderr] 127 |     pub fn y(&self) -> Vy {
[INFO] [stderr]     |              ^^^^^ help: consider passing by value instead: `self`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]    --> src/instructions.rs:132:19
[INFO] [stderr]     |
[INFO] [stderr] 132 |     pub fn n_high(&self) -> Nibble {
[INFO] [stderr]     |                   ^^^^^ help: consider passing by value instead: `self`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]    --> src/instructions.rs:137:18
[INFO] [stderr]     |
[INFO] [stderr] 137 |     pub fn n_low(&self) -> Nibble {
[INFO] [stderr]     |                  ^^^^^ help: consider passing by value instead: `self`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]    --> src/instructions.rs:142:14
[INFO] [stderr]     |
[INFO] [stderr] 142 |     pub fn k(&self) -> Byte {
[INFO] [stderr]     |              ^^^^^ help: consider passing by value instead: `self`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]    --> src/instructions.rs:255:26
[INFO] [stderr]     |
[INFO] [stderr] 255 |     pub fn from_raw(raw: &RawInstruction) -> Instruction {
[INFO] [stderr]     |                          ^^^^^^^^^^^^^^^ help: consider passing by value instead: `RawInstruction`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr] warning: you should consider adding a `Default` implementation for `vm::Vm`
[INFO] [stderr]    --> src/vm.rs:88:5
[INFO] [stderr]     |
[INFO] [stderr] 88  | /     pub fn new() -> Vm {
[INFO] [stderr] 89  | |         let mut vm = Vm {
[INFO] [stderr] 90  | |             reg: [0; NUM_DATA_REGISTERS],
[INFO] [stderr] 91  | |             i: 0,
[INFO] [stderr] ...   |
[INFO] [stderr] 112 | |         vm
[INFO] [stderr] 113 | |     }
[INFO] [stderr]     | |_____^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::new_without_default)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default
[INFO] [stderr] help: try this
[INFO] [stderr]     |
[INFO] [stderr] 86  | impl Default for vm::Vm {
[INFO] [stderr] 87  |     fn default() -> Self {
[INFO] [stderr] 88  |         Self::new()
[INFO] [stderr] 89  |     }
[INFO] [stderr] 90  | }
[INFO] [stderr]     |
[INFO] [stderr] 
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]    --> src/vm.rs:159:29
[INFO] [stderr]     |
[INFO] [stderr] 159 |     fn exec(&mut self, ins: &Instruction) -> bool {
[INFO] [stderr]     |                             ^^^^^^^^^^^^ help: consider passing by value instead: `Instruction`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change
[INFO] [stderr]    --> src/vm.rs:212:25
[INFO] [stderr]     |
[INFO] [stderr] 212 |                 let x = self.reg[vx as usize] as u16;
[INFO] [stderr]     |                         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(self.reg[vx as usize])`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::cast_lossless)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change
[INFO] [stderr]    --> src/vm.rs:213:25
[INFO] [stderr]     |
[INFO] [stderr] 213 |                 let y = self.reg[vy as usize] as u16;
[INFO] [stderr]     |                         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(self.reg[vy as usize])`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change
[INFO] [stderr]    --> src/vm.rs:266:28
[INFO] [stderr]     |
[INFO] [stderr] 266 |                 self.pc = (self.reg[Register::V0 as usize] as u16 + addr.bits) as usize;
[INFO] [stderr]     |                            ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(self.reg[Register::V0 as usize])`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: an inclusive range would be more readable
[INFO] [stderr]    --> src/vm.rs:341:45
[INFO] [stderr]     |
[INFO] [stderr] 341 |                 let mut dst = &mut self.ram[i..i+vx+1];
[INFO] [stderr]     |                                             ^^^^^^^^^ help: use: `i..=i+vx`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::range_plus_one)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one
[INFO] [stderr] 
[INFO] [stderr] warning: an inclusive range would be more readable
[INFO] [stderr]    --> src/vm.rs:351:37
[INFO] [stderr]     |
[INFO] [stderr] 351 |                 let src = &self.ram[i..i+vx+1];
[INFO] [stderr]     |                                     ^^^^^^^^^ help: use: `i..=i+vx`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change
[INFO] [stderr]    --> src/vm.rs:399:18
[INFO] [stderr]     |
[INFO] [stderr] 399 |                 ((codes[0] as u16) << 8) | codes[1] as u16
[INFO] [stderr]     |                  ^^^^^^^^^^^^^^^^^ help: try: `u16::from(codes[0])`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change
[INFO] [stderr]    --> src/vm.rs:399:44
[INFO] [stderr]     |
[INFO] [stderr] 399 |                 ((codes[0] as u16) << 8) | codes[1] as u16
[INFO] [stderr]     |                                            ^^^^^^^^^^^^^^^ help: try: `u16::from(codes[1])`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration)
[INFO] [stderr]    --> src/vm.rs:408:5
[INFO] [stderr]     |
[INFO] [stderr] 408 | /     pub fn screen_rows<'a>(&'a self) -> Chunks<'a, u8> {
[INFO] [stderr] 409 | |         self.screen.chunks(SCREEN_WIDTH)
[INFO] [stderr] 410 | |     }
[INFO] [stderr]     | |_____^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::needless_lifetimes)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes
[INFO] [stderr] 
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]    --> src/instructions.rs:112:17
[INFO] [stderr]     |
[INFO] [stderr] 112 |     pub fn bits(&self) -> u16 {
[INFO] [stderr]     |                 ^^^^^ help: consider passing by value instead: `self`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]    --> src/instructions.rs:117:17
[INFO] [stderr]     |
[INFO] [stderr] 117 |     pub fn addr(&self) -> Addr {
[INFO] [stderr]     |                 ^^^^^ help: consider passing by value instead: `self`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]    --> src/instructions.rs:122:14
[INFO] [stderr]     |
[INFO] [stderr] 122 |     pub fn x(&self) -> Vx {
[INFO] [stderr]     |              ^^^^^ help: consider passing by value instead: `self`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]    --> src/instructions.rs:127:14
[INFO] [stderr]     |
[INFO] [stderr] 127 |     pub fn y(&self) -> Vy {
[INFO] [stderr]     |              ^^^^^ help: consider passing by value instead: `self`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]    --> src/instructions.rs:132:19
[INFO] [stderr]     |
[INFO] [stderr] 132 |     pub fn n_high(&self) -> Nibble {
[INFO] [stderr]     |                   ^^^^^ help: consider passing by value instead: `self`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]    --> src/instructions.rs:137:18
[INFO] [stderr]     |
[INFO] [stderr] 137 |     pub fn n_low(&self) -> Nibble {
[INFO] [stderr]     |                  ^^^^^ help: consider passing by value instead: `self`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]    --> src/instructions.rs:142:14
[INFO] [stderr]     |
[INFO] [stderr] 142 |     pub fn k(&self) -> Byte {
[INFO] [stderr]     |              ^^^^^ help: consider passing by value instead: `self`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]    --> src/instructions.rs:255:26
[INFO] [stderr]     |
[INFO] [stderr] 255 |     pub fn from_raw(raw: &RawInstruction) -> Instruction {
[INFO] [stderr]     |                          ^^^^^^^^^^^^^^^ help: consider passing by value instead: `RawInstruction`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr] warning: you should consider adding a `Default` implementation for `vm::Vm`
[INFO] [stderr]    --> src/vm.rs:88:5
[INFO] [stderr]     |
[INFO] [stderr] 88  | /     pub fn new() -> Vm {
[INFO] [stderr] 89  | |         let mut vm = Vm {
[INFO] [stderr] 90  | |             reg: [0; NUM_DATA_REGISTERS],
[INFO] [stderr] 91  | |             i: 0,
[INFO] [stderr] ...   |
[INFO] [stderr] 112 | |         vm
[INFO] [stderr] 113 | |     }
[INFO] [stderr]     | |_____^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::new_without_default)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default
[INFO] [stderr] help: try this
[INFO] [stderr]     |
[INFO] [stderr] 86  | impl Default for vm::Vm {
[INFO] [stderr] 87  |     fn default() -> Self {
[INFO] [stderr] 88  |         Self::new()
[INFO] [stderr] 89  |     }
[INFO] [stderr] 90  | }
[INFO] [stderr]     |
[INFO] [stderr] 
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]    --> src/vm.rs:159:29
[INFO] [stderr]     |
[INFO] [stderr] 159 |     fn exec(&mut self, ins: &Instruction) -> bool {
[INFO] [stderr]     |                             ^^^^^^^^^^^^ help: consider passing by value instead: `Instruction`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change
[INFO] [stderr]    --> src/vm.rs:212:25
[INFO] [stderr]     |
[INFO] [stderr] 212 |                 let x = self.reg[vx as usize] as u16;
[INFO] [stderr]     |                         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(self.reg[vx as usize])`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::cast_lossless)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change
[INFO] [stderr]    --> src/vm.rs:213:25
[INFO] [stderr]     |
[INFO] [stderr] 213 |                 let y = self.reg[vy as usize] as u16;
[INFO] [stderr]     |                         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(self.reg[vy as usize])`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change
[INFO] [stderr]    --> src/vm.rs:266:28
[INFO] [stderr]     |
[INFO] [stderr] 266 |                 self.pc = (self.reg[Register::V0 as usize] as u16 + addr.bits) as usize;
[INFO] [stderr]     |                            ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(self.reg[Register::V0 as usize])`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: an inclusive range would be more readable
[INFO] [stderr]    --> src/vm.rs:341:45
[INFO] [stderr]     |
[INFO] [stderr] 341 |                 let mut dst = &mut self.ram[i..i+vx+1];
[INFO] [stderr]     |                                             ^^^^^^^^^ help: use: `i..=i+vx`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::range_plus_one)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one
[INFO] [stderr] 
[INFO] [stderr] warning: an inclusive range would be more readable
[INFO] [stderr]    --> src/vm.rs:351:37
[INFO] [stderr]     |
[INFO] [stderr] 351 |                 let src = &self.ram[i..i+vx+1];
[INFO] [stderr]     |                                     ^^^^^^^^^ help: use: `i..=i+vx`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change
[INFO] [stderr]    --> src/vm.rs:399:18
[INFO] [stderr]     |
[INFO] [stderr] 399 |                 ((codes[0] as u16) << 8) | codes[1] as u16
[INFO] [stderr]     |                  ^^^^^^^^^^^^^^^^^ help: try: `u16::from(codes[0])`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change
[INFO] [stderr]    --> src/vm.rs:399:44
[INFO] [stderr]     |
[INFO] [stderr] 399 |                 ((codes[0] as u16) << 8) | codes[1] as u16
[INFO] [stderr]     |                                            ^^^^^^^^^^^^^^^ help: try: `u16::from(codes[1])`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration)
[INFO] [stderr]    --> src/vm.rs:408:5
[INFO] [stderr]     |
[INFO] [stderr] 408 | /     pub fn screen_rows<'a>(&'a self) -> Chunks<'a, u8> {
[INFO] [stderr] 409 | |         self.screen.chunks(SCREEN_WIDTH)
[INFO] [stderr] 410 | |     }
[INFO] [stderr]     | |_____^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::needless_lifetimes)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes
[INFO] [stderr] 
[INFO] [stderr]     Finished dev [unoptimized + debuginfo] target(s) in 1.32s
[INFO] running `"docker" "inspect" "4e28a97774d67f8508bdfe2153a1c18fa2d20c4c8932dbe0dea6391bb8a7ee12"`
[INFO] running `"docker" "rm" "-f" "4e28a97774d67f8508bdfe2153a1c18fa2d20c4c8932dbe0dea6391bb8a7ee12"`
[INFO] [stdout] 4e28a97774d67f8508bdfe2153a1c18fa2d20c4c8932dbe0dea6391bb8a7ee12