[INFO] crate chip 0.0.4 is already in cache [INFO] extracting crate chip 0.0.4 into work/ex/clippy-test-run/sources/stable/reg/chip/0.0.4 [INFO] extracting crate chip 0.0.4 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/chip/0.0.4 [INFO] validating manifest of chip-0.0.4 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of chip-0.0.4 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing chip-0.0.4 [INFO] finished frobbing chip-0.0.4 [INFO] frobbed toml for chip-0.0.4 written to work/ex/clippy-test-run/sources/stable/reg/chip/0.0.4/Cargo.toml [INFO] started frobbing chip-0.0.4 [INFO] finished frobbing chip-0.0.4 [INFO] frobbed toml for chip-0.0.4 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/chip/0.0.4/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting chip-0.0.4 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-6/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/chip/0.0.4:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] ebdc63fd4226d413f8b89dfaab7fff0adeeaf0e17601fd766f740fdeb43cb161 [INFO] running `"docker" "start" "-a" "ebdc63fd4226d413f8b89dfaab7fff0adeeaf0e17601fd766f740fdeb43cb161"` [INFO] [stderr] Compiling chip v0.0.4 (/opt/crater/workdir) [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `ball::Ball` [INFO] [stderr] --> src/ball.rs:25:5 [INFO] [stderr] | [INFO] [stderr] 25 | / pub fn new() -> Self { [INFO] [stderr] 26 | | Ball(unsafe { ffi::Ball::new() }) [INFO] [stderr] 27 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 21 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `car::Car` [INFO] [stderr] --> src/car.rs:50:5 [INFO] [stderr] | [INFO] [stderr] 50 | / pub fn new() -> Self { [INFO] [stderr] 51 | | Car(unsafe { ffi::Car::new() }) [INFO] [stderr] 52 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 46 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/ffi.rs:79:28 [INFO] [stderr] | [INFO] [stderr] 79 | pub unsafe fn _Getcont(&self) -> *const std__Container_base0 { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/ffi.rs:146:30 [INFO] [stderr] | [INFO] [stderr] 146 | pub unsafe fn _Getpfirst(&self) -> *mut *mut std__Iterator_base12 { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `ball::Ball` [INFO] [stderr] --> src/ball.rs:25:5 [INFO] [stderr] | [INFO] [stderr] 25 | / pub fn new() -> Self { [INFO] [stderr] 26 | | Ball(unsafe { ffi::Ball::new() }) [INFO] [stderr] 27 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 21 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `car::Car` [INFO] [stderr] --> src/car.rs:50:5 [INFO] [stderr] | [INFO] [stderr] 50 | / pub fn new() -> Self { [INFO] [stderr] 51 | | Car(unsafe { ffi::Car::new() }) [INFO] [stderr] 52 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 46 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/car.rs:127:9 [INFO] [stderr] | [INFO] [stderr] 127 | assert_eq!(result, -1.0); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::float_cmp)] on by default [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/car.rs:127:9 [INFO] [stderr] | [INFO] [stderr] 127 | assert_eq!(result, -1.0); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/ffi.rs:79:28 [INFO] [stderr] | [INFO] [stderr] 79 | pub unsafe fn _Getcont(&self) -> *const std__Container_base0 { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/ffi.rs:146:30 [INFO] [stderr] | [INFO] [stderr] 146 | pub unsafe fn _Getpfirst(&self) -> *mut *mut std__Iterator_base12 { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: Could not compile `chip`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "ebdc63fd4226d413f8b89dfaab7fff0adeeaf0e17601fd766f740fdeb43cb161"` [INFO] running `"docker" "rm" "-f" "ebdc63fd4226d413f8b89dfaab7fff0adeeaf0e17601fd766f740fdeb43cb161"` [INFO] [stdout] ebdc63fd4226d413f8b89dfaab7fff0adeeaf0e17601fd766f740fdeb43cb161