[INFO] crate chess-rs 0.1.0 is already in cache [INFO] extracting crate chess-rs 0.1.0 into work/ex/clippy-test-run/sources/stable/reg/chess-rs/0.1.0 [INFO] extracting crate chess-rs 0.1.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/chess-rs/0.1.0 [INFO] validating manifest of chess-rs-0.1.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of chess-rs-0.1.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing chess-rs-0.1.0 [INFO] finished frobbing chess-rs-0.1.0 [INFO] frobbed toml for chess-rs-0.1.0 written to work/ex/clippy-test-run/sources/stable/reg/chess-rs/0.1.0/Cargo.toml [INFO] started frobbing chess-rs-0.1.0 [INFO] finished frobbing chess-rs-0.1.0 [INFO] frobbed toml for chess-rs-0.1.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/chess-rs/0.1.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting chess-rs-0.1.0 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-6/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/chess-rs/0.1.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] c95ee227ff217595dbe24edc8596954e8dcf22d3e8217b4b90ee29eadbcf33bb [INFO] running `"docker" "start" "-a" "c95ee227ff217595dbe24edc8596954e8dcf22d3e8217b4b90ee29eadbcf33bb"` [INFO] [stderr] Checking chess-rs v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/xchess.rs:38:14 [INFO] [stderr] | [INFO] [stderr] 38 | .map(|x| expand_if_numeric(x)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `expand_if_numeric` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_closure)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/xchess.rs:36:5 [INFO] [stderr] | [INFO] [stderr] 36 | / xchess.chars() [INFO] [stderr] 37 | | .into_iter() [INFO] [stderr] | |____________________^ help: consider removing `.into_iter()`: `xchess.chars()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_conversion)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression [INFO] [stderr] --> src/xchess.rs:44:13 [INFO] [stderr] | [INFO] [stderr] 44 | / let mut ansi_bg = 0; [INFO] [stderr] 45 | | if i % 2 + (i / 8) % 2 == 1 { [INFO] [stderr] 46 | | ansi_bg = 7; [INFO] [stderr] 47 | | } [INFO] [stderr] | |_____________^ help: it is more idiomatic to write: `let ansi_bg = if i % 2 + (i / 8) % 2 == 1 { 7 } else { 0 };` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_let_if_seq)] on by default [INFO] [stderr] = note: you might not need `mut` at all [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/main.rs:34:17 [INFO] [stderr] | [INFO] [stderr] 34 | / match me { [INFO] [stderr] 35 | | MouseEvent::Press(_, x, y) => { [INFO] [stderr] 36 | | let previous_bg_color; [INFO] [stderr] 37 | | { [INFO] [stderr] ... | [INFO] [stderr] 48 | | _ => (), [INFO] [stderr] 49 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 34 | if let MouseEvent::Press(_, x, y) = me { [INFO] [stderr] 35 | let previous_bg_color; [INFO] [stderr] 36 | { [INFO] [stderr] 37 | let mut cell = [INFO] [stderr] 38 | display.cell_at_cursor_position((x as usize, y as usize)); [INFO] [stderr] 39 | previous_bg_color = cell.color.bg; [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/xchess.rs:38:14 [INFO] [stderr] | [INFO] [stderr] 38 | .map(|x| expand_if_numeric(x)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `expand_if_numeric` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_closure)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/xchess.rs:36:5 [INFO] [stderr] | [INFO] [stderr] 36 | / xchess.chars() [INFO] [stderr] 37 | | .into_iter() [INFO] [stderr] | |____________________^ help: consider removing `.into_iter()`: `xchess.chars()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_conversion)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression [INFO] [stderr] --> src/xchess.rs:44:13 [INFO] [stderr] | [INFO] [stderr] 44 | / let mut ansi_bg = 0; [INFO] [stderr] 45 | | if i % 2 + (i / 8) % 2 == 1 { [INFO] [stderr] 46 | | ansi_bg = 7; [INFO] [stderr] 47 | | } [INFO] [stderr] | |_____________^ help: it is more idiomatic to write: `let ansi_bg = if i % 2 + (i / 8) % 2 == 1 { 7 } else { 0 };` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_let_if_seq)] on by default [INFO] [stderr] = note: you might not need `mut` at all [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/main.rs:34:17 [INFO] [stderr] | [INFO] [stderr] 34 | / match me { [INFO] [stderr] 35 | | MouseEvent::Press(_, x, y) => { [INFO] [stderr] 36 | | let previous_bg_color; [INFO] [stderr] 37 | | { [INFO] [stderr] ... | [INFO] [stderr] 48 | | _ => (), [INFO] [stderr] 49 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 34 | if let MouseEvent::Press(_, x, y) = me { [INFO] [stderr] 35 | let previous_bg_color; [INFO] [stderr] 36 | { [INFO] [stderr] 37 | let mut cell = [INFO] [stderr] 38 | display.cell_at_cursor_position((x as usize, y as usize)); [INFO] [stderr] 39 | previous_bg_color = cell.color.bg; [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 1.62s [INFO] running `"docker" "inspect" "c95ee227ff217595dbe24edc8596954e8dcf22d3e8217b4b90ee29eadbcf33bb"` [INFO] running `"docker" "rm" "-f" "c95ee227ff217595dbe24edc8596954e8dcf22d3e8217b4b90ee29eadbcf33bb"` [INFO] [stdout] c95ee227ff217595dbe24edc8596954e8dcf22d3e8217b4b90ee29eadbcf33bb