[INFO] crate chelone 0.1.2 is already in cache [INFO] extracting crate chelone 0.1.2 into work/ex/clippy-test-run/sources/stable/reg/chelone/0.1.2 [INFO] extracting crate chelone 0.1.2 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/chelone/0.1.2 [INFO] validating manifest of chelone-0.1.2 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of chelone-0.1.2 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing chelone-0.1.2 [INFO] finished frobbing chelone-0.1.2 [INFO] frobbed toml for chelone-0.1.2 written to work/ex/clippy-test-run/sources/stable/reg/chelone/0.1.2/Cargo.toml [INFO] started frobbing chelone-0.1.2 [INFO] finished frobbing chelone-0.1.2 [INFO] frobbed toml for chelone-0.1.2 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/chelone/0.1.2/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting chelone-0.1.2 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-0/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/chelone/0.1.2:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] aff056c94aa22da6daf09f35db7b3819cb4742d72e860aa3117f84ed0a541b73 [INFO] running `"docker" "start" "-a" "aff056c94aa22da6daf09f35db7b3819cb4742d72e860aa3117f84ed0a541b73"` [INFO] [stderr] Checking chelone v0.1.2 (/opt/crater/workdir) [INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead [INFO] [stderr] --> src/triple.rs:76:13 [INFO] [stderr] | [INFO] [stderr] 76 | write!(f, "{}\n", triple)?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::write_with_newline)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline [INFO] [stderr] [INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead [INFO] [stderr] --> src/triple.rs:76:13 [INFO] [stderr] | [INFO] [stderr] 76 | write!(f, "{}\n", triple)?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::write_with_newline)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/lib.rs:61:18 [INFO] [stderr] | [INFO] [stderr] 61 | const _GRAMMAR: &'static str = include_str!("grammar.pest"); [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/lib.rs:61:18 [INFO] [stderr] | [INFO] [stderr] 61 | const _GRAMMAR: &'static str = include_str!("grammar.pest"); [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: method is never used: `create_map` [INFO] [stderr] --> src/triple.rs:37:5 [INFO] [stderr] | [INFO] [stderr] 37 | fn create_map(&self) -> HashMap { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_some()` [INFO] [stderr] --> src/literal.rs:49:31 [INFO] [stderr] | [INFO] [stderr] 49 | } else if let Some(_) = language_tag.as_ref() { [INFO] [stderr] | ________________________- ^^^^^^^ [INFO] [stderr] 50 | | rdf!("langString") [INFO] [stderr] 51 | | } else { [INFO] [stderr] 52 | | xsd!("string") [INFO] [stderr] 53 | | } [INFO] [stderr] | |_________________- help: try this: `if language_tag.as_ref().is_some()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_pattern_matching)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/literal.rs:75:13 [INFO] [stderr] | [INFO] [stderr] 75 | / if let &Some(ref tag) = language_tag { [INFO] [stderr] 76 | | value.push_str(&format!("@{}", tag)); [INFO] [stderr] 77 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 75 | if let Some(ref tag) = *language_tag { [INFO] [stderr] | ^^^^^^^^^^^^^ ^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: methods called `to_*` usually take self by reference; consider choosing a less ambiguous name [INFO] [stderr] --> src/object.rs:20:30 [INFO] [stderr] | [INFO] [stderr] 20 | pub(crate) fn to_subject(self) -> Subject { [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::wrong_self_convention)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention [INFO] [stderr] [INFO] [stderr] warning: method is never used: `create_map` [INFO] [stderr] --> src/triple.rs:37:5 [INFO] [stderr] | [INFO] [stderr] 37 | fn create_map(&self) -> HashMap { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_some()` [INFO] [stderr] --> src/literal.rs:49:31 [INFO] [stderr] | [INFO] [stderr] 49 | } else if let Some(_) = language_tag.as_ref() { [INFO] [stderr] | ________________________- ^^^^^^^ [INFO] [stderr] 50 | | rdf!("langString") [INFO] [stderr] 51 | | } else { [INFO] [stderr] 52 | | xsd!("string") [INFO] [stderr] 53 | | } [INFO] [stderr] | |_________________- help: try this: `if language_tag.as_ref().is_some()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_pattern_matching)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/literal.rs:75:13 [INFO] [stderr] | [INFO] [stderr] 75 | / if let &Some(ref tag) = language_tag { [INFO] [stderr] 76 | | value.push_str(&format!("@{}", tag)); [INFO] [stderr] 77 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 75 | if let Some(ref tag) = *language_tag { [INFO] [stderr] | ^^^^^^^^^^^^^ ^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: methods called `to_*` usually take self by reference; consider choosing a less ambiguous name [INFO] [stderr] --> src/object.rs:20:30 [INFO] [stderr] | [INFO] [stderr] 20 | pub(crate) fn to_subject(self) -> Subject { [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::wrong_self_convention)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention [INFO] [stderr] [INFO] [stderr] warning: constant item is never used: `TURTLE` [INFO] [stderr] --> src/main.rs:5:1 [INFO] [stderr] | [INFO] [stderr] 5 | / const TURTLE: &str = r##" [INFO] [stderr] 6 | | @base . [INFO] [stderr] 7 | | @prefix foaf: . [INFO] [stderr] 8 | | @prefix rel: . [INFO] [stderr] ... | [INFO] [stderr] 17 | | foaf:name "Rust" . [INFO] [stderr] 18 | | "##; [INFO] [stderr] | |____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: constant item is never used: `TURTLE` [INFO] [stderr] --> src/main.rs:5:1 [INFO] [stderr] | [INFO] [stderr] 5 | / const TURTLE: &str = r##" [INFO] [stderr] 6 | | @base . [INFO] [stderr] 7 | | @prefix foaf: . [INFO] [stderr] 8 | | @prefix rel: . [INFO] [stderr] ... | [INFO] [stderr] 17 | | foaf:name "Rust" . [INFO] [stderr] 18 | | "##; [INFO] [stderr] | |____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 8.34s [INFO] running `"docker" "inspect" "aff056c94aa22da6daf09f35db7b3819cb4742d72e860aa3117f84ed0a541b73"` [INFO] running `"docker" "rm" "-f" "aff056c94aa22da6daf09f35db7b3819cb4742d72e860aa3117f84ed0a541b73"` [INFO] [stdout] aff056c94aa22da6daf09f35db7b3819cb4742d72e860aa3117f84ed0a541b73