[INFO] crate checked 0.5.0 is already in cache [INFO] extracting crate checked 0.5.0 into work/ex/clippy-test-run/sources/stable/reg/checked/0.5.0 [INFO] extracting crate checked 0.5.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/checked/0.5.0 [INFO] validating manifest of checked-0.5.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of checked-0.5.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing checked-0.5.0 [INFO] finished frobbing checked-0.5.0 [INFO] frobbed toml for checked-0.5.0 written to work/ex/clippy-test-run/sources/stable/reg/checked/0.5.0/Cargo.toml [INFO] started frobbing checked-0.5.0 [INFO] finished frobbing checked-0.5.0 [INFO] frobbed toml for checked-0.5.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/checked/0.5.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting checked-0.5.0 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-6/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/checked/0.5.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 80adf78676418841e7bbc84eff652b9c10aa83a2a752ff0760b7f9cdb7d31b20 [INFO] running `"docker" "start" "-a" "80adf78676418841e7bbc84eff652b9c10aa83a2a752ff0760b7f9cdb7d31b20"` [INFO] [stderr] Checking checked v0.5.0 (/opt/crater/workdir) [INFO] [stderr] warning: unnecessary parentheses around function argument [INFO] [stderr] --> src/tests.rs:100:24 [INFO] [stderr] | [INFO] [stderr] 100 | test_binop! (add3 i32: (-2_000_000_000) + (-2_000_000_000) == None); [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: remove these parentheses [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_parens)] on by default [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around function argument [INFO] [stderr] --> src/tests.rs:100:43 [INFO] [stderr] | [INFO] [stderr] 100 | test_binop! (add3 i32: (-2_000_000_000) + (-2_000_000_000) == None); [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: remove these parentheses [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around function argument [INFO] [stderr] --> src/tests.rs:113:29 [INFO] [stderr] | [INFO] [stderr] 113 | test_unop! (neg2 i8: - 5 == (-5)); [INFO] [stderr] | ^^^^ help: remove these parentheses [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around function argument [INFO] [stderr] --> src/tests.rs:114:28 [INFO] [stderr] | [INFO] [stderr] 114 | test_unop! (not i8: ! 5 == (-6)); [INFO] [stderr] | ^^^^ help: remove these parentheses [INFO] [stderr] [INFO] [stderr] warning: The use of negated comparison operators on partially ordered types produces code that is hard to read and refactor. Please consider using the `partial_cmp` method instead, to make it clear that the two values could be incomparable. [INFO] [stderr] --> src/tests.rs:119:13 [INFO] [stderr] | [INFO] [stderr] 119 | assert!(!(Checked::from(1_000_u32) <= Checked::from(None))); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::neg_cmp_op_on_partial_ord)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#neg_cmp_op_on_partial_ord [INFO] [stderr] [INFO] [stderr] warning: The use of negated comparison operators on partially ordered types produces code that is hard to read and refactor. Please consider using the `partial_cmp` method instead, to make it clear that the two values could be incomparable. [INFO] [stderr] --> src/tests.rs:120:13 [INFO] [stderr] | [INFO] [stderr] 120 | assert!(!(Checked::from(None) <= Checked::from(1_000_u32))); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#neg_cmp_op_on_partial_ord [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 4.75s [INFO] running `"docker" "inspect" "80adf78676418841e7bbc84eff652b9c10aa83a2a752ff0760b7f9cdb7d31b20"` [INFO] running `"docker" "rm" "-f" "80adf78676418841e7bbc84eff652b9c10aa83a2a752ff0760b7f9cdb7d31b20"` [INFO] [stdout] 80adf78676418841e7bbc84eff652b9c10aa83a2a752ff0760b7f9cdb7d31b20