[INFO] crate chashmap 2.2.0 is already in cache
[INFO] extracting crate chashmap 2.2.0 into work/ex/clippy-test-run/sources/stable/reg/chashmap/2.2.0
[INFO] extracting crate chashmap 2.2.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/chashmap/2.2.0
[INFO] validating manifest of chashmap-2.2.0 on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of chashmap-2.2.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing chashmap-2.2.0
[INFO] finished frobbing chashmap-2.2.0
[INFO] frobbed toml for chashmap-2.2.0 written to work/ex/clippy-test-run/sources/stable/reg/chashmap/2.2.0/Cargo.toml
[INFO] started frobbing chashmap-2.2.0
[INFO] finished frobbing chashmap-2.2.0
[INFO] frobbed toml for chashmap-2.2.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/chashmap/2.2.0/Cargo.toml
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting chashmap-2.2.0 against stable for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-7/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/chashmap/2.2.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] d90d06680dc15a1e026e16a2265a79de9eece4659d099b5b5cfef4065f05a4f2
[INFO] running `"docker" "start" "-a" "d90d06680dc15a1e026e16a2265a79de9eece4659d099b5b5cfef4065f05a4f2"`
[INFO] [stderr]     Checking chashmap v2.2.0 (/opt/crater/workdir)
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/tests.rs:331:20
[INFO] [stderr]     |
[INFO] [stderr] 331 |         Dropable { k: k }
[INFO] [stderr]     |                    ^^^^ help: replace it with: `k`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::redundant_field_names)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/lib.rs:691:17
[INFO] [stderr]     |
[INFO] [stderr] 691 |                 inner: inner,
[INFO] [stderr]     |                 ^^^^^^^^^^^^ help: replace it with: `inner`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/lib.rs:714:17
[INFO] [stderr]     |
[INFO] [stderr] 714 |                 inner: inner,
[INFO] [stderr]     |                 ^^^^^^^^^^^^ help: replace it with: `inner`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/lib.rs:691:17
[INFO] [stderr]     |
[INFO] [stderr] 691 |                 inner: inner,
[INFO] [stderr]     |                 ^^^^^^^^^^^^ help: replace it with: `inner`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::redundant_field_names)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/lib.rs:714:17
[INFO] [stderr]     |
[INFO] [stderr] 714 |                 inner: inner,
[INFO] [stderr]     |                 ^^^^^^^^^^^^ help: replace it with: `inner`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: in an 'if' condition, avoid complex blocks or closures with blocks; instead, move the block or closure higher and bind it with a 'let'
[INFO] [stderr]    --> src/lib.rs:296:16
[INFO] [stderr]     |
[INFO] [stderr] 296 |               if {
[INFO] [stderr]     |  ________________^
[INFO] [stderr] 297 | |                 let bucket = self.buckets[idx].get_mut();
[INFO] [stderr] 298 | |                 matches(&bucket)
[INFO] [stderr] 299 | |             } {
[INFO] [stderr]     | |_____________^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::block_in_if_condition_stmt)] on by default
[INFO] [stderr]     = help: try
[INFO] [stderr]             let res = {
[INFO] [stderr]                 let bucket = self.buckets[idx].get_mut();
[INFO] [stderr]                 matches(&bucket)
[INFO] [stderr]             };
[INFO] [stderr]             if res {
[INFO] [stderr]                 // Yup. Return.
[INFO] [stderr]                 return self.buckets[idx].get_mut();
[INFO] [stderr]             } ... 
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#block_in_if_condition_stmt
[INFO] [stderr] 
[INFO] [stderr] warning: very complex type used. Consider factoring parts into `type` definitions
[INFO] [stderr]    --> src/lib.rs:490:12
[INFO] [stderr]     |
[INFO] [stderr] 490 |     inner: OwningRef<OwningHandle<RwLockReadGuard<'a, Table<K, V>>, RwLockReadGuard<'a, Bucket<K, V>>>, V>,
[INFO] [stderr]     |            ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::type_complexity)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity
[INFO] [stderr] 
[INFO] [stderr] warning: very complex type used. Consider factoring parts into `type` definitions
[INFO] [stderr]    --> src/lib.rs:520:12
[INFO] [stderr]     |
[INFO] [stderr] 520 |     inner: OwningHandle<OwningHandle<RwLockReadGuard<'a, Table<K, V>>, RwLockWriteGuard<'a, Bucket<K, V>>>, &'a mut V>,
[INFO] [stderr]     |            ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity
[INFO] [stderr] 
[INFO] [stderr] warning: you don't need to add `&` to all patterns
[INFO] [stderr]    --> src/lib.rs:706:128
[INFO] [stderr]     |
[INFO] [stderr] 706 |           if let Ok(inner) = OwningHandle::try_new(OwningHandle::new(self.table.read(), |x| unsafe { &*x }.lookup_mut(key)), |x| if let &mut Bucket::Contains(_, ref mut val) = unsafe { &mut *(x as *mut Bucket<K, V>) } {
[INFO] [stderr]     |  ________________________________________________________________________________________________________________________________^
[INFO] [stderr] 707 | |             // The bucket contains data.
[INFO] [stderr] 708 | |             Ok(val)
[INFO] [stderr] 709 | |         } else {
[INFO] [stderr] 710 | |             // The bucket is empty/removed.
[INFO] [stderr] 711 | |             Err(())
[INFO] [stderr] 712 | |         }) {
[INFO] [stderr]     | |_________^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::match_ref_pats)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats
[INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression
[INFO] [stderr]     |
[INFO] [stderr] 706 |         if let Ok(inner) = OwningHandle::try_new(OwningHandle::new(self.table.read(), |x| unsafe { &*x }.lookup_mut(key)), |x| if let Bucket::Contains(_, ref mut val) = *unsafe { &mut *(x as *mut Bucket<K, V>) } {
[INFO] [stderr]     |                                                                                                                                       ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^   ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: the function has a cyclomatic complexity of 27
[INFO] [stderr]    --> src/tests.rs:480:1
[INFO] [stderr]     |
[INFO] [stderr] 480 | / fn lots_of_insertions() {
[INFO] [stderr] 481 | |     let m = CHashMap::new();
[INFO] [stderr] 482 | |
[INFO] [stderr] 483 | |     // Try this a few times to make sure we never screw up the hashmap's internal state.
[INFO] [stderr] ...   |
[INFO] [stderr] 538 | |     }
[INFO] [stderr] 539 | | }
[INFO] [stderr]     | |_^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::cyclomatic_complexity)] on by default
[INFO] [stderr]     = help: you could split it up into multiple smaller functions
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cyclomatic_complexity
[INFO] [stderr] 
[INFO] [stderr] warning: an inclusive range would be more readable
[INFO] [stderr]    --> src/tests.rs:490:22
[INFO] [stderr]     |
[INFO] [stderr] 490 |             for j in 1..i+1 {
[INFO] [stderr]     |                      ^^^^^^ help: use: `1..=i`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::range_plus_one)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one
[INFO] [stderr] 
[INFO] [stderr] warning: an inclusive range would be more readable
[INFO] [stderr]    --> src/tests.rs:509:22
[INFO] [stderr]     |
[INFO] [stderr] 509 |             for j in 1..i+1 {
[INFO] [stderr]     |                      ^^^^^^ help: use: `1..=i`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one
[INFO] [stderr] 
[INFO] [stderr] warning: in an 'if' condition, avoid complex blocks or closures with blocks; instead, move the block or closure higher and bind it with a 'let'
[INFO] [stderr]    --> src/lib.rs:296:16
[INFO] [stderr]     |
[INFO] [stderr] 296 |               if {
[INFO] [stderr]     |  ________________^
[INFO] [stderr] 297 | |                 let bucket = self.buckets[idx].get_mut();
[INFO] [stderr] 298 | |                 matches(&bucket)
[INFO] [stderr] 299 | |             } {
[INFO] [stderr]     | |_____________^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::block_in_if_condition_stmt)] on by default
[INFO] [stderr]     = help: try
[INFO] [stderr]             let res = {
[INFO] [stderr]                 let bucket = self.buckets[idx].get_mut();
[INFO] [stderr]                 matches(&bucket)
[INFO] [stderr]             };
[INFO] [stderr]             if res {
[INFO] [stderr]                 // Yup. Return.
[INFO] [stderr]                 return self.buckets[idx].get_mut();
[INFO] [stderr]             } ... 
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#block_in_if_condition_stmt
[INFO] [stderr] 
[INFO] [stderr] warning: very complex type used. Consider factoring parts into `type` definitions
[INFO] [stderr]    --> src/lib.rs:490:12
[INFO] [stderr]     |
[INFO] [stderr] 490 |     inner: OwningRef<OwningHandle<RwLockReadGuard<'a, Table<K, V>>, RwLockReadGuard<'a, Bucket<K, V>>>, V>,
[INFO] [stderr]     |            ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::type_complexity)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity
[INFO] [stderr] 
[INFO] [stderr] warning: very complex type used. Consider factoring parts into `type` definitions
[INFO] [stderr]    --> src/lib.rs:520:12
[INFO] [stderr]     |
[INFO] [stderr] 520 |     inner: OwningHandle<OwningHandle<RwLockReadGuard<'a, Table<K, V>>, RwLockWriteGuard<'a, Bucket<K, V>>>, &'a mut V>,
[INFO] [stderr]     |            ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity
[INFO] [stderr] 
[INFO] [stderr] warning: you don't need to add `&` to all patterns
[INFO] [stderr]    --> src/lib.rs:706:128
[INFO] [stderr]     |
[INFO] [stderr] 706 |           if let Ok(inner) = OwningHandle::try_new(OwningHandle::new(self.table.read(), |x| unsafe { &*x }.lookup_mut(key)), |x| if let &mut Bucket::Contains(_, ref mut val) = unsafe { &mut *(x as *mut Bucket<K, V>) } {
[INFO] [stderr]     |  ________________________________________________________________________________________________________________________________^
[INFO] [stderr] 707 | |             // The bucket contains data.
[INFO] [stderr] 708 | |             Ok(val)
[INFO] [stderr] 709 | |         } else {
[INFO] [stderr] 710 | |             // The bucket is empty/removed.
[INFO] [stderr] 711 | |             Err(())
[INFO] [stderr] 712 | |         }) {
[INFO] [stderr]     | |_________^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::match_ref_pats)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats
[INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression
[INFO] [stderr]     |
[INFO] [stderr] 706 |         if let Ok(inner) = OwningHandle::try_new(OwningHandle::new(self.table.read(), |x| unsafe { &*x }.lookup_mut(key)), |x| if let Bucket::Contains(_, ref mut val) = *unsafe { &mut *(x as *mut Bucket<K, V>) } {
[INFO] [stderr]     |                                                                                                                                       ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^   ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr]     Finished dev [unoptimized + debuginfo] target(s) in 3.23s
[INFO] running `"docker" "inspect" "d90d06680dc15a1e026e16a2265a79de9eece4659d099b5b5cfef4065f05a4f2"`
[INFO] running `"docker" "rm" "-f" "d90d06680dc15a1e026e16a2265a79de9eece4659d099b5b5cfef4065f05a4f2"`
[INFO] [stdout] d90d06680dc15a1e026e16a2265a79de9eece4659d099b5b5cfef4065f05a4f2