[INFO] crate chars 0.3.2 is already in cache [INFO] extracting crate chars 0.3.2 into work/ex/clippy-test-run/sources/stable/reg/chars/0.3.2 [INFO] extracting crate chars 0.3.2 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/chars/0.3.2 [INFO] validating manifest of chars-0.3.2 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of chars-0.3.2 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing chars-0.3.2 [INFO] finished frobbing chars-0.3.2 [INFO] frobbed toml for chars-0.3.2 written to work/ex/clippy-test-run/sources/stable/reg/chars/0.3.2/Cargo.toml [INFO] started frobbing chars-0.3.2 [INFO] finished frobbing chars-0.3.2 [INFO] frobbed toml for chars-0.3.2 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/chars/0.3.2/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting chars-0.3.2 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-5/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/chars/0.3.2:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 59693e7bfd82488eee9980422ad6884b4c048905ebd923b58e289213d0b9aac4 [INFO] running `"docker" "start" "-a" "59693e7bfd82488eee9980422ad6884b4c048905ebd923b58e289213d0b9aac4"` [INFO] [stderr] Checking unicode_names2 v0.2.2 [INFO] [stderr] Checking proptest v0.6.0 [INFO] [stderr] Checking chars v0.3.2 (/opt/crater/workdir) [INFO] [stderr] warning: `cfg_attr` is deprecated for rustfmt and got replaced by tool_attributes [INFO] [stderr] --> src/ascii/names.rs:11:1 [INFO] [stderr] | [INFO] [stderr] 11 | #[cfg_attr(rustfmt, rustfmt_skip)] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `#[rustfmt::skip]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::deprecated_cfg_attr)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#deprecated_cfg_attr [INFO] [stderr] [INFO] [stderr] warning: `cfg_attr` is deprecated for rustfmt and got replaced by tool_attributes [INFO] [stderr] --> src/unicode/names.rs:2:1 [INFO] [stderr] | [INFO] [stderr] 2 | #[cfg_attr(rustfmt, rustfmt_skip)] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `#[rustfmt::skip]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#deprecated_cfg_attr [INFO] [stderr] [INFO] [stderr] warning: You are using an explicit closure for cloning elements [INFO] [stderr] --> src/display.rs:33:37 [INFO] [stderr] | [INFO] [stderr] 33 | let mnemos: Vec<&str> = ascii [INFO] [stderr] | _____________________________________^ [INFO] [stderr] 34 | | .mnemonics [INFO] [stderr] 35 | | .iter() [INFO] [stderr] 36 | | .filter(|n| n.len() != 1) [INFO] [stderr] 37 | | .map(|s| *s) [INFO] [stderr] | |____________________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::map_clone)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stderr] help: Consider calling the dedicated `cloned` method [INFO] [stderr] | [INFO] [stderr] 33 | let mnemos: Vec<&str> = ascii [INFO] [stderr] 34 | .mnemonics [INFO] [stderr] 35 | .iter() [INFO] [stderr] 36 | .filter(|n| n.len() != 1).cloned() [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: `cfg_attr` is deprecated for rustfmt and got replaced by tool_attributes [INFO] [stderr] --> src/ascii/names.rs:11:1 [INFO] [stderr] | [INFO] [stderr] 11 | #[cfg_attr(rustfmt, rustfmt_skip)] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `#[rustfmt::skip]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::deprecated_cfg_attr)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#deprecated_cfg_attr [INFO] [stderr] [INFO] [stderr] warning: `cfg_attr` is deprecated for rustfmt and got replaced by tool_attributes [INFO] [stderr] --> src/unicode/names.rs:2:1 [INFO] [stderr] | [INFO] [stderr] 2 | #[cfg_attr(rustfmt, rustfmt_skip)] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `#[rustfmt::skip]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#deprecated_cfg_attr [INFO] [stderr] [INFO] [stderr] warning: length comparison to one [INFO] [stderr] --> tests/human_names.rs:27:17 [INFO] [stderr] | [INFO] [stderr] 27 | assert!(found.len() >= 1); [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!found.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to one [INFO] [stderr] --> tests/human_names.rs:37:17 [INFO] [stderr] | [INFO] [stderr] 37 | assert!(found.len() >= 1, "{}", diagnostics(ch, &query)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!found.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to one [INFO] [stderr] --> tests/human_names.rs:57:17 [INFO] [stderr] | [INFO] [stderr] 57 | assert!(found.len() >= 1, "{}", diagnostics(ch, &query)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!found.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: You are using an explicit closure for cloning elements [INFO] [stderr] --> src/display.rs:33:37 [INFO] [stderr] | [INFO] [stderr] 33 | let mnemos: Vec<&str> = ascii [INFO] [stderr] | _____________________________________^ [INFO] [stderr] 34 | | .mnemonics [INFO] [stderr] 35 | | .iter() [INFO] [stderr] 36 | | .filter(|n| n.len() != 1) [INFO] [stderr] 37 | | .map(|s| *s) [INFO] [stderr] | |____________________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::map_clone)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stderr] help: Consider calling the dedicated `cloned` method [INFO] [stderr] | [INFO] [stderr] 33 | let mnemos: Vec<&str> = ascii [INFO] [stderr] 34 | .mnemonics [INFO] [stderr] 35 | .iter() [INFO] [stderr] 36 | .filter(|n| n.len() != 1).cloned() [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 17.43s [INFO] running `"docker" "inspect" "59693e7bfd82488eee9980422ad6884b4c048905ebd923b58e289213d0b9aac4"` [INFO] running `"docker" "rm" "-f" "59693e7bfd82488eee9980422ad6884b4c048905ebd923b58e289213d0b9aac4"` [INFO] [stdout] 59693e7bfd82488eee9980422ad6884b4c048905ebd923b58e289213d0b9aac4