[INFO] crate chariot_slp 0.1.2 is already in cache [INFO] extracting crate chariot_slp 0.1.2 into work/ex/clippy-test-run/sources/stable/reg/chariot_slp/0.1.2 [INFO] extracting crate chariot_slp 0.1.2 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/chariot_slp/0.1.2 [INFO] validating manifest of chariot_slp-0.1.2 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of chariot_slp-0.1.2 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing chariot_slp-0.1.2 [INFO] finished frobbing chariot_slp-0.1.2 [INFO] frobbed toml for chariot_slp-0.1.2 written to work/ex/clippy-test-run/sources/stable/reg/chariot_slp/0.1.2/Cargo.toml [INFO] started frobbing chariot_slp-0.1.2 [INFO] finished frobbing chariot_slp-0.1.2 [INFO] frobbed toml for chariot_slp-0.1.2 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/chariot_slp/0.1.2/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting chariot_slp-0.1.2 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-2/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/chariot_slp/0.1.2:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 689305055b1dcb1e4064f1d467a6d604d2d717fe99fe6a4ac43117cbc051c395 [INFO] running `"docker" "start" "-a" "689305055b1dcb1e4064f1d467a6d604d2d717fe99fe6a4ac43117cbc051c395"` [INFO] [stderr] Checking chariot_io_tools v0.1.4 [INFO] [stderr] Checking chariot_slp v0.1.2 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/slp.rs:185:13 [INFO] [stderr] | [INFO] [stderr] 185 | player_index: player_index, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `player_index` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/slp.rs:185:13 [INFO] [stderr] | [INFO] [stderr] 185 | player_index: player_index, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `player_index` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/slp.rs:194:9 [INFO] [stderr] | [INFO] [stderr] 194 | return SlpFile::read_from(&mut file, player_index); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `SlpFile::read_from(&mut file, player_index)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/slp.rs:194:9 [INFO] [stderr] | [INFO] [stderr] 194 | return SlpFile::read_from(&mut file, player_index); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `SlpFile::read_from(&mut file, player_index)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/error.rs:25:1 [INFO] [stderr] | [INFO] [stderr] 25 | / error_chain! { [INFO] [stderr] 26 | | types { [INFO] [stderr] 27 | | Error, ErrorKind, ChainErr, Result; [INFO] [stderr] 28 | | } [INFO] [stderr] ... | [INFO] [stderr] 46 | | } [INFO] [stderr] 47 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_closure)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `slp::SlpHeader` [INFO] [stderr] --> src/slp.rs:45:5 [INFO] [stderr] | [INFO] [stderr] 45 | / pub fn new() -> SlpHeader { [INFO] [stderr] 46 | | SlpHeader { [INFO] [stderr] 47 | | file_version: [0u8; 4], [INFO] [stderr] 48 | | shape_count: 0u32, [INFO] [stderr] 49 | | comment: [0u8; 24], [INFO] [stderr] 50 | | } [INFO] [stderr] 51 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 37 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/slp.rs:61:35 [INFO] [stderr] | [INFO] [stderr] 61 | if header.file_version != "2.0N".as_bytes() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"2.0N"` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::string_lit_as_bytes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `slp::SlpShapeHeader` [INFO] [stderr] --> src/slp.rs:91:5 [INFO] [stderr] | [INFO] [stderr] 91 | / pub fn new() -> SlpShapeHeader { [INFO] [stderr] 92 | | SlpShapeHeader { [INFO] [stderr] 93 | | shape_data_offsets: 0u32, [INFO] [stderr] 94 | | shape_outline_offset: 0u32, [INFO] [stderr] ... | [INFO] [stderr] 101 | | } [INFO] [stderr] 102 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 72 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/error.rs:25:1 [INFO] [stderr] | [INFO] [stderr] 25 | / error_chain! { [INFO] [stderr] 26 | | types { [INFO] [stderr] 27 | | Error, ErrorKind, ChainErr, Result; [INFO] [stderr] 28 | | } [INFO] [stderr] ... | [INFO] [stderr] 46 | | } [INFO] [stderr] 47 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_closure)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: you should consider adding a `Default` implementation for `slp::SlpLogicalShape` [INFO] [stderr] --> src/slp.rs:128:5 [INFO] [stderr] | [INFO] [stderr] 128 | / pub fn new() -> SlpLogicalShape { [INFO] [stderr] 129 | | SlpLogicalShape { [INFO] [stderr] 130 | | header: SlpShapeHeader::new(), [INFO] [stderr] 131 | | pixels: SlpPixels::new(), [INFO] [stderr] 132 | | } [INFO] [stderr] 133 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 127 | impl Default for slp::SlpLogicalShape { [INFO] [stderr] 128 | fn default() -> Self { [INFO] [stderr] 129 | Self::new() [INFO] [stderr] 130 | } [INFO] [stderr] 131 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `slp::SlpHeader` [INFO] [stderr] --> src/slp.rs:45:5 [INFO] [stderr] | [INFO] [stderr] 45 | / pub fn new() -> SlpHeader { [INFO] [stderr] 46 | | SlpHeader { [INFO] [stderr] 47 | | file_version: [0u8; 4], [INFO] [stderr] 48 | | shape_count: 0u32, [INFO] [stderr] 49 | | comment: [0u8; 24], [INFO] [stderr] 50 | | } [INFO] [stderr] 51 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 37 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/slp.rs:61:35 [INFO] [stderr] | [INFO] [stderr] 61 | if header.file_version != "2.0N".as_bytes() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"2.0N"` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::string_lit_as_bytes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/slp.rs:226:46 [INFO] [stderr] | [INFO] [stderr] 226 | try!(cursor.seek(SeekFrom::Start(line_outline_offset as u64))); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(line_outline_offset)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/slp.rs:227:25 [INFO] [stderr] | [INFO] [stderr] 227 | let mut x = try!(cursor.read_u16()) as u32; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 227 | let mut x = u32::from(match $ expr { [INFO] [stderr] 228 | $ crate :: result :: Result :: Ok ( val ) => val , $ crate :: result :: Result [INFO] [stderr] 229 | :: Err ( err ) => { [INFO] [stderr] 230 | return $ crate :: result :: Result :: Err ( [INFO] [stderr] 231 | $ crate :: convert :: From :: from ( err ) ) } }); [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/slp.rs:228:33 [INFO] [stderr] | [INFO] [stderr] 228 | let right_padding = try!(cursor.read_u16()) as u32; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 228 | let right_padding = u32::from(match $ expr { [INFO] [stderr] 229 | $ crate :: result :: Result :: Ok ( val ) => val , $ crate :: result :: Result [INFO] [stderr] 230 | :: Err ( err ) => { [INFO] [stderr] 231 | return $ crate :: result :: Result :: Err ( [INFO] [stderr] 232 | $ crate :: convert :: From :: from ( err ) ) } }); [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/slp.rs:237:46 [INFO] [stderr] | [INFO] [stderr] 237 | try!(cursor.seek(SeekFrom::Start(shape_data_ptr_offset as u64))); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(shape_data_ptr_offset)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `slp::SlpShapeHeader` [INFO] [stderr] --> src/slp.rs:91:5 [INFO] [stderr] | [INFO] [stderr] 91 | / pub fn new() -> SlpShapeHeader { [INFO] [stderr] 92 | | SlpShapeHeader { [INFO] [stderr] 93 | | shape_data_offsets: 0u32, [INFO] [stderr] 94 | | shape_outline_offset: 0u32, [INFO] [stderr] ... | [INFO] [stderr] 101 | | } [INFO] [stderr] 102 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 72 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/slp.rs:241:46 [INFO] [stderr] | [INFO] [stderr] 241 | try!(cursor.seek(SeekFrom::Start(data_offset as u64))); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try: `u64::from(data_offset)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] [INFO] [stderr] warning: you should consider adding a `Default` implementation for `slp::SlpLogicalShape` [INFO] [stderr] --> src/slp.rs:128:5 [INFO] [stderr] | [INFO] [stderr] 128 | / pub fn new() -> SlpLogicalShape { [INFO] [stderr] 129 | | SlpLogicalShape { [INFO] [stderr] 130 | | header: SlpShapeHeader::new(), [INFO] [stderr] 131 | | pixels: SlpPixels::new(), [INFO] [stderr] 132 | | } [INFO] [stderr] 133 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 127 | impl Default for slp::SlpLogicalShape { [INFO] [stderr] 128 | fn default() -> Self { [INFO] [stderr] 129 | Self::new() [INFO] [stderr] 130 | } [INFO] [stderr] 131 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/slp.rs:381:17 [INFO] [stderr] | [INFO] [stderr] 381 | / match e.kind() { [INFO] [stderr] 382 | | &ErrorKind::InvalidSlp(ref reason) => assert_eq!(*reason, "bad header".to_string()), [INFO] [stderr] 383 | | _ => panic!("unexpected error: {}", e), [INFO] [stderr] 384 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 381 | match *e.kind() { [INFO] [stderr] 382 | ErrorKind::InvalidSlp(ref reason) => assert_eq!(*reason, "bad header".to_string()), [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/slp.rs:226:46 [INFO] [stderr] | [INFO] [stderr] 226 | try!(cursor.seek(SeekFrom::Start(line_outline_offset as u64))); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(line_outline_offset)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/slp.rs:227:25 [INFO] [stderr] | [INFO] [stderr] 227 | let mut x = try!(cursor.read_u16()) as u32; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 227 | let mut x = u32::from(match $ expr { [INFO] [stderr] 228 | $ crate :: result :: Result :: Ok ( val ) => val , $ crate :: result :: Result [INFO] [stderr] 229 | :: Err ( err ) => { [INFO] [stderr] 230 | return $ crate :: result :: Result :: Err ( [INFO] [stderr] 231 | $ crate :: convert :: From :: from ( err ) ) } }); [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/slp.rs:228:33 [INFO] [stderr] | [INFO] [stderr] 228 | let right_padding = try!(cursor.read_u16()) as u32; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 228 | let right_padding = u32::from(match $ expr { [INFO] [stderr] 229 | $ crate :: result :: Result :: Ok ( val ) => val , $ crate :: result :: Result [INFO] [stderr] 230 | :: Err ( err ) => { [INFO] [stderr] 231 | return $ crate :: result :: Result :: Err ( [INFO] [stderr] 232 | $ crate :: convert :: From :: from ( err ) ) } }); [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/slp.rs:237:46 [INFO] [stderr] | [INFO] [stderr] 237 | try!(cursor.seek(SeekFrom::Start(shape_data_ptr_offset as u64))); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(shape_data_ptr_offset)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/slp.rs:241:46 [INFO] [stderr] | [INFO] [stderr] 241 | try!(cursor.seek(SeekFrom::Start(data_offset as u64))); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try: `u64::from(data_offset)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: using `println!("")` [INFO] [stderr] --> examples/read-slp.rs:58:21 [INFO] [stderr] | [INFO] [stderr] 58 | println!(""); [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `println!()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::println_empty_string)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#println_empty_string [INFO] [stderr] [INFO] [stderr] warning: casting u8 to f32 may become silently lossy if types change [INFO] [stderr] --> examples/read-slp.rs:51:36 [INFO] [stderr] | [INFO] [stderr] 51 | let val = (shape.pixels[(y * width + x) as usize] as f32 / 25.6f32) as usize; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f32::from(shape.pixels[(y * width + x) as usize])` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 6.04s [INFO] running `"docker" "inspect" "689305055b1dcb1e4064f1d467a6d604d2d717fe99fe6a4ac43117cbc051c395"` [INFO] running `"docker" "rm" "-f" "689305055b1dcb1e4064f1d467a6d604d2d717fe99fe6a4ac43117cbc051c395"` [INFO] [stdout] 689305055b1dcb1e4064f1d467a6d604d2d717fe99fe6a4ac43117cbc051c395