[INFO] crate chariot_palette 0.1.5 is already in cache [INFO] extracting crate chariot_palette 0.1.5 into work/ex/clippy-test-run/sources/stable/reg/chariot_palette/0.1.5 [INFO] extracting crate chariot_palette 0.1.5 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/chariot_palette/0.1.5 [INFO] validating manifest of chariot_palette-0.1.5 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of chariot_palette-0.1.5 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing chariot_palette-0.1.5 [INFO] finished frobbing chariot_palette-0.1.5 [INFO] frobbed toml for chariot_palette-0.1.5 written to work/ex/clippy-test-run/sources/stable/reg/chariot_palette/0.1.5/Cargo.toml [INFO] started frobbing chariot_palette-0.1.5 [INFO] finished frobbing chariot_palette-0.1.5 [INFO] frobbed toml for chariot_palette-0.1.5 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/chariot_palette/0.1.5/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting chariot_palette-0.1.5 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-3/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/chariot_palette/0.1.5:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] d8a548d8b20ed07bd48627e9263fbf8c107ed55c4b2bbf5200fd5a315f5d71a9 [INFO] running `"docker" "start" "-a" "d8a548d8b20ed07bd48627e9263fbf8c107ed55c4b2bbf5200fd5a315f5d71a9"` [INFO] [stderr] Checking chariot_palette v0.1.5 (/opt/crater/workdir) [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/error.rs:26:1 [INFO] [stderr] | [INFO] [stderr] 26 | / error_chain! { [INFO] [stderr] 27 | | types { [INFO] [stderr] 28 | | Error, ErrorKind, ChainErr, Result; [INFO] [stderr] 29 | | } [INFO] [stderr] ... | [INFO] [stderr] 44 | | } [INFO] [stderr] 45 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_closure)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `palette::PaletteColor` [INFO] [stderr] --> src/palette.rs:37:5 [INFO] [stderr] | [INFO] [stderr] 37 | / pub fn new() -> PaletteColor { [INFO] [stderr] 38 | | PaletteColor { [INFO] [stderr] 39 | | r: 0u8, [INFO] [stderr] 40 | | g: 0u8, [INFO] [stderr] 41 | | b: 0u8, [INFO] [stderr] 42 | | } [INFO] [stderr] 43 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 30 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/palette.rs:49:10 [INFO] [stderr] | [INFO] [stderr] 49 | ((self.r as u32) << 24) | ((self.g as u32) << 16) | ((self.b as u32) << 8) | 0xFF [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `u32::from(self.r)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/palette.rs:49:36 [INFO] [stderr] | [INFO] [stderr] 49 | ((self.r as u32) << 24) | ((self.g as u32) << 16) | ((self.b as u32) << 8) | 0xFF [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `u32::from(self.g)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/palette.rs:49:62 [INFO] [stderr] | [INFO] [stderr] 49 | ((self.r as u32) << 24) | ((self.g as u32) << 16) | ((self.b as u32) << 8) | 0xFF [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `u32::from(self.b)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: the variable `line_index` is used as a loop counter. Consider using `for (line_index, item) in file.lines().enumerate()` or similar iterators [INFO] [stderr] --> src/palette.rs:59:24 [INFO] [stderr] | [INFO] [stderr] 59 | for line_result in file.lines() { [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::explicit_counter_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_counter_loop [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/error.rs:26:1 [INFO] [stderr] | [INFO] [stderr] 26 | / error_chain! { [INFO] [stderr] 27 | | types { [INFO] [stderr] 28 | | Error, ErrorKind, ChainErr, Result; [INFO] [stderr] 29 | | } [INFO] [stderr] ... | [INFO] [stderr] 44 | | } [INFO] [stderr] 45 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_closure)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `palette::PaletteColor` [INFO] [stderr] --> src/palette.rs:37:5 [INFO] [stderr] | [INFO] [stderr] 37 | / pub fn new() -> PaletteColor { [INFO] [stderr] 38 | | PaletteColor { [INFO] [stderr] 39 | | r: 0u8, [INFO] [stderr] 40 | | g: 0u8, [INFO] [stderr] 41 | | b: 0u8, [INFO] [stderr] 42 | | } [INFO] [stderr] 43 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 30 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/palette.rs:49:10 [INFO] [stderr] | [INFO] [stderr] 49 | ((self.r as u32) << 24) | ((self.g as u32) << 16) | ((self.b as u32) << 8) | 0xFF [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `u32::from(self.r)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/palette.rs:49:36 [INFO] [stderr] | [INFO] [stderr] 49 | ((self.r as u32) << 24) | ((self.g as u32) << 16) | ((self.b as u32) << 8) | 0xFF [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `u32::from(self.g)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/palette.rs:49:62 [INFO] [stderr] | [INFO] [stderr] 49 | ((self.r as u32) << 24) | ((self.g as u32) << 16) | ((self.b as u32) << 8) | 0xFF [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `u32::from(self.b)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: the variable `line_index` is used as a loop counter. Consider using `for (line_index, item) in file.lines().enumerate()` or similar iterators [INFO] [stderr] --> src/palette.rs:59:24 [INFO] [stderr] | [INFO] [stderr] 59 | for line_result in file.lines() { [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::explicit_counter_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_counter_loop [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 2.57s [INFO] running `"docker" "inspect" "d8a548d8b20ed07bd48627e9263fbf8c107ed55c4b2bbf5200fd5a315f5d71a9"` [INFO] running `"docker" "rm" "-f" "d8a548d8b20ed07bd48627e9263fbf8c107ed55c4b2bbf5200fd5a315f5d71a9"` [INFO] [stdout] d8a548d8b20ed07bd48627e9263fbf8c107ed55c4b2bbf5200fd5a315f5d71a9