[INFO] crate chanvese 0.1.0 is already in cache [INFO] extracting crate chanvese 0.1.0 into work/ex/clippy-test-run/sources/stable/reg/chanvese/0.1.0 [INFO] extracting crate chanvese 0.1.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/chanvese/0.1.0 [INFO] validating manifest of chanvese-0.1.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of chanvese-0.1.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing chanvese-0.1.0 [INFO] finished frobbing chanvese-0.1.0 [INFO] frobbed toml for chanvese-0.1.0 written to work/ex/clippy-test-run/sources/stable/reg/chanvese/0.1.0/Cargo.toml [INFO] started frobbing chanvese-0.1.0 [INFO] finished frobbing chanvese-0.1.0 [INFO] frobbed toml for chanvese-0.1.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/chanvese/0.1.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting chanvese-0.1.0 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-4/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/chanvese/0.1.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] a7641d8867403d854ed882d81a6c5169bfaef55e01a428ed21f9080ef19d2bed [INFO] running `"docker" "start" "-a" "a7641d8867403d854ed882d81a6c5169bfaef55e01a428ed21f9080ef19d2bed"` [INFO] [stderr] Checking distance-transform v0.1.2 [INFO] [stderr] Checking chanvese v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: 5th binding whose name is just one char [INFO] [stderr] --> src/lib.rs:175:22 [INFO] [stderr] | [INFO] [stderr] 175 | let (x, y) = idx[i]; [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::many_single_char_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 6th binding whose name is just one char [INFO] [stderr] --> src/lib.rs:175:25 [INFO] [stderr] | [INFO] [stderr] 175 | let (x, y) = idx[i]; [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 5th binding whose name is just one char [INFO] [stderr] --> src/lib.rs:175:22 [INFO] [stderr] | [INFO] [stderr] 175 | let (x, y) = idx[i]; [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::many_single_char_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 6th binding whose name is just one char [INFO] [stderr] --> src/lib.rs:175:25 [INFO] [stderr] | [INFO] [stderr] 175 | let (x, y) = idx[i]; [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/lib.rs:250:5 [INFO] [stderr] | [INFO] [stderr] 250 | phi [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::let_and_return)] on by default [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/lib.rs:237:15 [INFO] [stderr] | [INFO] [stderr] 237 | let phi = { [INFO] [stderr] | _______________^ [INFO] [stderr] 238 | | let dist_a = bwdist(&init_a); [INFO] [stderr] 239 | | let dist_inv_a = bwdist(&inv_init_a); [INFO] [stderr] 240 | | let mut result = FloatGrid::new(init_a.width(), init_a.height()); [INFO] [stderr] ... | [INFO] [stderr] 247 | | result [INFO] [stderr] 248 | | }; [INFO] [stderr] | |_____^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/lib.rs:123:12 [INFO] [stderr] | [INFO] [stderr] 123 | if idx.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!idx.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/lib.rs:254:40 [INFO] [stderr] | [INFO] [stderr] 254 | fn get_curvature(phi: &FloatGrid, idx: &Vec<(usize,usize)>) -> Vec { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: change this to: `&[(usize,usize)]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stderr] --> src/lib.rs:258:15 [INFO] [stderr] | [INFO] [stderr] 258 | : (Vec, Vec, Vec, Vec, Vec) = ( [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::type_complexity)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/lib.rs:301:34 [INFO] [stderr] | [INFO] [stderr] 301 | fn sussman(grid: &FloatGrid, dt: &f64) -> FloatGrid { [INFO] [stderr] | ^^^^ help: consider passing by value instead: `f64` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/lib.rs:250:5 [INFO] [stderr] | [INFO] [stderr] 250 | phi [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::let_and_return)] on by default [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/lib.rs:237:15 [INFO] [stderr] | [INFO] [stderr] 237 | let phi = { [INFO] [stderr] | _______________^ [INFO] [stderr] 238 | | let dist_a = bwdist(&init_a); [INFO] [stderr] 239 | | let dist_inv_a = bwdist(&inv_init_a); [INFO] [stderr] 240 | | let mut result = FloatGrid::new(init_a.width(), init_a.height()); [INFO] [stderr] ... | [INFO] [stderr] 247 | | result [INFO] [stderr] 248 | | }; [INFO] [stderr] | |_____^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/lib.rs:123:12 [INFO] [stderr] | [INFO] [stderr] 123 | if idx.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!idx.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/lib.rs:254:40 [INFO] [stderr] | [INFO] [stderr] 254 | fn get_curvature(phi: &FloatGrid, idx: &Vec<(usize,usize)>) -> Vec { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: change this to: `&[(usize,usize)]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stderr] --> src/lib.rs:258:15 [INFO] [stderr] | [INFO] [stderr] 258 | : (Vec, Vec, Vec, Vec, Vec) = ( [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::type_complexity)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/lib.rs:301:34 [INFO] [stderr] | [INFO] [stderr] 301 | fn sussman(grid: &FloatGrid, dt: &f64) -> FloatGrid { [INFO] [stderr] | ^^^^ help: consider passing by value instead: `f64` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 2.28s [INFO] running `"docker" "inspect" "a7641d8867403d854ed882d81a6c5169bfaef55e01a428ed21f9080ef19d2bed"` [INFO] running `"docker" "rm" "-f" "a7641d8867403d854ed882d81a6c5169bfaef55e01a428ed21f9080ef19d2bed"` [INFO] [stdout] a7641d8867403d854ed882d81a6c5169bfaef55e01a428ed21f9080ef19d2bed