[INFO] crate changelog 0.3.2 is already in cache [INFO] extracting crate changelog 0.3.2 into work/ex/clippy-test-run/sources/stable/reg/changelog/0.3.2 [INFO] extracting crate changelog 0.3.2 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/changelog/0.3.2 [INFO] validating manifest of changelog-0.3.2 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of changelog-0.3.2 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing changelog-0.3.2 [INFO] finished frobbing changelog-0.3.2 [INFO] frobbed toml for changelog-0.3.2 written to work/ex/clippy-test-run/sources/stable/reg/changelog/0.3.2/Cargo.toml [INFO] started frobbing changelog-0.3.2 [INFO] finished frobbing changelog-0.3.2 [INFO] frobbed toml for changelog-0.3.2 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/changelog/0.3.2/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting changelog-0.3.2 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-0/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/changelog/0.3.2:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] cebd2102d16b3120c7da52f75c616e3cf3732bc9d0fe7af285f4a93399251740 [INFO] running `"docker" "start" "-a" "cebd2102d16b3120c7da52f75c616e3cf3732bc9d0fe7af285f4a93399251740"` [INFO] [stderr] Compiling num-traits v0.2.6 [INFO] [stderr] Compiling nix v0.11.0 [INFO] [stderr] Compiling uuid v0.1.18 [INFO] [stderr] Compiling libgit2-sys v0.7.11 [INFO] [stderr] Checking comrak v0.2.14 [INFO] [stderr] Checking mktemp v0.3.1 [INFO] [stderr] Checking git2 v0.7.5 [INFO] [stderr] Compiling clap-port-flag v0.3.0 [INFO] [stderr] Checking pretty_env_logger v0.2.5 [INFO] [stderr] Compiling clap-verbosity-flag v0.2.0 [INFO] [stderr] Compiling num-integer v0.1.39 [INFO] [stderr] Compiling chrono v0.4.6 [INFO] [stderr] Checking clap-log-flag v0.2.1 [INFO] [stderr] Compiling privdrop v0.2.1 [INFO] [stderr] Compiling clap-permission-flag v0.1.0 [INFO] [stderr] Compiling clap-log-flag v0.1.0 [INFO] [stderr] Checking clap_flags v0.3.0 [INFO] [stderr] Compiling clap_flags v0.2.0 [INFO] [stderr] Compiling changelog v0.3.2 (/opt/crater/workdir) [INFO] [stderr] warning: unused `#[macro_use]` import [INFO] [stderr] --> src/lib.rs:4:1 [INFO] [stderr] | [INFO] [stderr] 4 | #[macro_use] [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused `#[macro_use]` import [INFO] [stderr] --> src/lib.rs:4:1 [INFO] [stderr] | [INFO] [stderr] 4 | #[macro_use] [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/git.rs:137:3 [INFO] [stderr] | [INFO] [stderr] 137 | return Ok(cr); [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(cr)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unused `#[macro_use]` import [INFO] [stderr] --> src/lib.rs:4:1 [INFO] [stderr] | [INFO] [stderr] 4 | #[macro_use] [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/git.rs:137:3 [INFO] [stderr] | [INFO] [stderr] 137 | return Ok(cr); [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(cr)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/changelog.rs:24:49 [INFO] [stderr] | [INFO] [stderr] 24 | let msg: Vec<&str> = commit.message().split("\n").collect(); [INFO] [stderr] | ^^^^ help: try using a char instead: `'\n'` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/changelog.rs:24:49 [INFO] [stderr] | [INFO] [stderr] 24 | let msg: Vec<&str> = commit.message().split("\n").collect(); [INFO] [stderr] | ^^^^ help: try using a char instead: `'\n'` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 1m 01s [INFO] running `"docker" "inspect" "cebd2102d16b3120c7da52f75c616e3cf3732bc9d0fe7af285f4a93399251740"` [INFO] running `"docker" "rm" "-f" "cebd2102d16b3120c7da52f75c616e3cf3732bc9d0fe7af285f4a93399251740"` [INFO] [stdout] cebd2102d16b3120c7da52f75c616e3cf3732bc9d0fe7af285f4a93399251740