[INFO] crate chainmail 0.2.0 is already in cache [INFO] extracting crate chainmail 0.2.0 into work/ex/clippy-test-run/sources/stable/reg/chainmail/0.2.0 [INFO] extracting crate chainmail 0.2.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/chainmail/0.2.0 [INFO] validating manifest of chainmail-0.2.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of chainmail-0.2.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing chainmail-0.2.0 [INFO] finished frobbing chainmail-0.2.0 [INFO] frobbed toml for chainmail-0.2.0 written to work/ex/clippy-test-run/sources/stable/reg/chainmail/0.2.0/Cargo.toml [INFO] started frobbing chainmail-0.2.0 [INFO] finished frobbing chainmail-0.2.0 [INFO] frobbed toml for chainmail-0.2.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/chainmail/0.2.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting chainmail-0.2.0 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-5/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/chainmail/0.2.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 534bf313b5c886cbc9a86e041a1f1c2cbb38b355f1e0571e66a6c01d38b1a2d7 [INFO] running `"docker" "start" "-a" "534bf313b5c886cbc9a86e041a1f1c2cbb38b355f1e0571e66a6c01d38b1a2d7"` [INFO] [stderr] Checking chainmail v0.2.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:75:13 [INFO] [stderr] | [INFO] [stderr] 75 | strategies: strategies, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `strategies` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:75:13 [INFO] [stderr] | [INFO] [stderr] 75 | strategies: strategies, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `strategies` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:39:33 [INFO] [stderr] | [INFO] [stderr] 39 | Some(ref hn) => return hn.handle(req), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `hn.handle(req)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:57:27 [INFO] [stderr] | [INFO] [stderr] 57 | Err(e) => return Err(e), [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove `return` as shown: `Err(e)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:94:9 [INFO] [stderr] | [INFO] [stderr] 94 | return None; [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `None` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/lib.rs:84:13 [INFO] [stderr] | [INFO] [stderr] 84 | / match strategy.authenticate(req) { [INFO] [stderr] 85 | | Ok(u) => { [INFO] [stderr] 86 | | return Some(AuthedUser { [INFO] [stderr] 87 | | user: u, [INFO] [stderr] ... | [INFO] [stderr] 91 | | Err(_) => {} [INFO] [stderr] 92 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 84 | if let Ok(u) = strategy.authenticate(req) { [INFO] [stderr] 85 | return Some(AuthedUser { [INFO] [stderr] 86 | user: u, [INFO] [stderr] 87 | authed_by: st_name, [INFO] [stderr] 88 | }) [INFO] [stderr] 89 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_some()` [INFO] [stderr] --> src/lib.rs:121:9 [INFO] [stderr] | [INFO] [stderr] 121 | / match *cur_user { [INFO] [stderr] 122 | | Some(_) => true, [INFO] [stderr] 123 | | None => false, [INFO] [stderr] 124 | | } [INFO] [stderr] | |_________^ help: try this: `*cur_user.is_some()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_pattern_matching)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:39:33 [INFO] [stderr] | [INFO] [stderr] 39 | Some(ref hn) => return hn.handle(req), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `hn.handle(req)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:57:27 [INFO] [stderr] | [INFO] [stderr] 57 | Err(e) => return Err(e), [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove `return` as shown: `Err(e)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:94:9 [INFO] [stderr] | [INFO] [stderr] 94 | return None; [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `None` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/lib.rs:84:13 [INFO] [stderr] | [INFO] [stderr] 84 | / match strategy.authenticate(req) { [INFO] [stderr] 85 | | Ok(u) => { [INFO] [stderr] 86 | | return Some(AuthedUser { [INFO] [stderr] 87 | | user: u, [INFO] [stderr] ... | [INFO] [stderr] 91 | | Err(_) => {} [INFO] [stderr] 92 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 84 | if let Ok(u) = strategy.authenticate(req) { [INFO] [stderr] 85 | return Some(AuthedUser { [INFO] [stderr] 86 | user: u, [INFO] [stderr] 87 | authed_by: st_name, [INFO] [stderr] 88 | }) [INFO] [stderr] 89 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_some()` [INFO] [stderr] --> src/lib.rs:121:9 [INFO] [stderr] | [INFO] [stderr] 121 | / match *cur_user { [INFO] [stderr] 122 | | Some(_) => true, [INFO] [stderr] 123 | | None => false, [INFO] [stderr] 124 | | } [INFO] [stderr] | |_________^ help: try this: `*cur_user.is_some()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_pattern_matching)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 4.90s [INFO] running `"docker" "inspect" "534bf313b5c886cbc9a86e041a1f1c2cbb38b355f1e0571e66a6c01d38b1a2d7"` [INFO] running `"docker" "rm" "-f" "534bf313b5c886cbc9a86e041a1f1c2cbb38b355f1e0571e66a6c01d38b1a2d7"` [INFO] [stdout] 534bf313b5c886cbc9a86e041a1f1c2cbb38b355f1e0571e66a6c01d38b1a2d7