[INFO] crate chain_peer 0.1.1 is already in cache [INFO] extracting crate chain_peer 0.1.1 into work/ex/clippy-test-run/sources/stable/reg/chain_peer/0.1.1 [INFO] extracting crate chain_peer 0.1.1 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/chain_peer/0.1.1 [INFO] validating manifest of chain_peer-0.1.1 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of chain_peer-0.1.1 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing chain_peer-0.1.1 [INFO] finished frobbing chain_peer-0.1.1 [INFO] frobbed toml for chain_peer-0.1.1 written to work/ex/clippy-test-run/sources/stable/reg/chain_peer/0.1.1/Cargo.toml [INFO] started frobbing chain_peer-0.1.1 [INFO] finished frobbing chain_peer-0.1.1 [INFO] frobbed toml for chain_peer-0.1.1 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/chain_peer/0.1.1/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting chain_peer-0.1.1 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-3/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/chain_peer/0.1.1:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 7cd7e712103fbc2ccad8070d3915d60de085ca876b6546fba3cf014cc2ca68ae [INFO] running `"docker" "start" "-a" "7cd7e712103fbc2ccad8070d3915d60de085ca876b6546fba3cf014cc2ca68ae"` [INFO] [stderr] Checking chain_peer v0.1.1 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/peer/peer.rs:32:13 [INFO] [stderr] | [INFO] [stderr] 32 | client_r: client_r, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `client_r` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/peer/peer.rs:33:13 [INFO] [stderr] | [INFO] [stderr] 33 | client_w: client_w, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `client_w` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/peer/server.rs:38:13 [INFO] [stderr] | [INFO] [stderr] 38 | sock: sock, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `sock` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/peer/server.rs:50:13 [INFO] [stderr] | [INFO] [stderr] 50 | caches: caches, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `caches` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/peer/server.rs:51:13 [INFO] [stderr] | [INFO] [stderr] 51 | r_caches: r_caches, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `r_caches` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/peer/client.rs:25:13 [INFO] [stderr] | [INFO] [stderr] 25 | sock: sock, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `sock` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/peer/connection.rs:46:13 [INFO] [stderr] | [INFO] [stderr] 46 | sock: sock, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `sock` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/peer/connection.rs:47:13 [INFO] [stderr] | [INFO] [stderr] 47 | token: token, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `token` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/peer/peer.rs:32:13 [INFO] [stderr] | [INFO] [stderr] 32 | client_r: client_r, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `client_r` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/peer/peer.rs:33:13 [INFO] [stderr] | [INFO] [stderr] 33 | client_w: client_w, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `client_w` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/peer/server.rs:38:13 [INFO] [stderr] | [INFO] [stderr] 38 | sock: sock, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `sock` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/peer/server.rs:50:13 [INFO] [stderr] | [INFO] [stderr] 50 | caches: caches, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `caches` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/peer/server.rs:51:13 [INFO] [stderr] | [INFO] [stderr] 51 | r_caches: r_caches, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `r_caches` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/peer/client.rs:25:13 [INFO] [stderr] | [INFO] [stderr] 25 | sock: sock, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `sock` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/peer/connection.rs:46:13 [INFO] [stderr] | [INFO] [stderr] 46 | sock: sock, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `sock` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/peer/connection.rs:47:13 [INFO] [stderr] | [INFO] [stderr] 47 | token: token, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `token` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: module has the same name as its containing module [INFO] [stderr] --> src/peer/mod.rs:2:1 [INFO] [stderr] | [INFO] [stderr] 2 | mod peer; [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::module_inception)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#module_inception [INFO] [stderr] [INFO] [stderr] warning: unused import: `std::thread::sleep` [INFO] [stderr] --> src/peer/peer.rs:6:5 [INFO] [stderr] | [INFO] [stderr] 6 | use std::thread::sleep; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused import: `std::time::Duration` [INFO] [stderr] --> src/peer/peer.rs:7:5 [INFO] [stderr] | [INFO] [stderr] 7 | use std::time::Duration; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `channel` [INFO] [stderr] --> src/peer/server.rs:7:11 [INFO] [stderr] | [INFO] [stderr] 7 | use mio::{channel, Events, Poll, PollOpt, Ready, Token}; [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `Events` [INFO] [stderr] --> src/peer/client.rs:4:11 [INFO] [stderr] | [INFO] [stderr] 4 | use mio::{Events, Ready, Poll, PollOpt, Token}; [INFO] [stderr] | ^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `mio::unix::UnixReady` [INFO] [stderr] --> src/peer/client.rs:6:5 [INFO] [stderr] | [INFO] [stderr] 6 | use mio::unix::UnixReady; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `std::time::Duration` [INFO] [stderr] --> src/peer/client.rs:7:5 [INFO] [stderr] | [INFO] [stderr] 7 | use std::time::Duration; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused imports: `ErrorKind`, `Error` [INFO] [stderr] --> src/peer/client.rs:8:15 [INFO] [stderr] | [INFO] [stderr] 8 | use std::io::{Error, ErrorKind}; [INFO] [stderr] | ^^^^^ ^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unneeded unit expression [INFO] [stderr] --> src/peer/connection.rs:163:21 [INFO] [stderr] | [INFO] [stderr] 163 | () [INFO] [stderr] | ^^ help: remove the final `()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unused_unit)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'mio::channel': use mio-extras instead [INFO] [stderr] --> src/peer/server.rs:7:11 [INFO] [stderr] | [INFO] [stderr] 7 | use mio::{channel, Events, Poll, PollOpt, Ready, Token}; [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(deprecated)] on by default [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'mio::Events::len': Index access removed in favor of iterator only API. [INFO] [stderr] --> src/peer/server.rs:64:76 [INFO] [stderr] | [INFO] [stderr] 64 | trace!("processing events... cnt={}; len={}", cnt, self.events.len()); [INFO] [stderr] | ^^^ [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'mio::Events::get': Index access removed in favor of iterator only API. [INFO] [stderr] --> src/peer/server.rs:74:41 [INFO] [stderr] | [INFO] [stderr] 74 | let event = self.events.get(i).expect("Failed to get event"); [INFO] [stderr] | ^^^ [INFO] [stderr] [INFO] [stderr] warning: unused variable: `w_q_clone` [INFO] [stderr] --> src/peer/peer.rs:47:17 [INFO] [stderr] | [INFO] [stderr] 47 | let w_q_clone = w_q.clone(); [INFO] [stderr] | ^^^^^^^^^ help: consider using `_w_q_clone` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused variable: `caches` [INFO] [stderr] --> src/peer/server.rs:119:13 [INFO] [stderr] | [INFO] [stderr] 119 | let caches = self.caches.clone(); [INFO] [stderr] | ^^^^^^ help: consider using `_caches` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `e` [INFO] [stderr] --> src/peer/client.rs:54:17 [INFO] [stderr] | [INFO] [stderr] 54 | Err(e) => { [INFO] [stderr] | ^ help: consider using `_e` instead [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/peer/peer.rs:117:13 [INFO] [stderr] | [INFO] [stderr] 117 | let mut cache = self.client_r.clone(); [INFO] [stderr] | ----^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_mut)] on by default [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/peer/peer.rs:123:13 [INFO] [stderr] | [INFO] [stderr] 123 | let mut cache = self.client_w.clone(); [INFO] [stderr] | ----^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/peer/server.rs:171:17 [INFO] [stderr] | [INFO] [stderr] 171 | let mut w_cache = caches_clone.lock().unwrap().get_mut(&key).unwrap().clone(); [INFO] [stderr] | ----^^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/peer/server.rs:218:13 [INFO] [stderr] | [INFO] [stderr] 218 | let mut caches = self.caches.clone(); [INFO] [stderr] | ----^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/peer/server.rs:219:13 [INFO] [stderr] | [INFO] [stderr] 219 | let mut r_caches = self.r_caches.clone(); [INFO] [stderr] | ----^^^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/peer/server.rs:269:13 [INFO] [stderr] | [INFO] [stderr] 269 | let mut r_caches = self.r_caches.clone(); [INFO] [stderr] | ----^^^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/peer/client.rs:36:13 [INFO] [stderr] | [INFO] [stderr] 36 | let mut cache = self.r_cache.clone(); [INFO] [stderr] | ----^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] [INFO] [stderr] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stderr] --> src/peer/peer.rs:17:15 [INFO] [stderr] | [INFO] [stderr] 17 | r_queues: Arc>>>>>>, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::type_complexity)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stderr] [INFO] [stderr] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stderr] --> src/peer/peer.rs:18:19 [INFO] [stderr] | [INFO] [stderr] 18 | pub w_queues: Arc>>>>>>, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stderr] [INFO] [stderr] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stderr] --> src/peer/peer.rs:25:21 [INFO] [stderr] | [INFO] [stderr] 25 | pub fn new(r_q: Arc>>>>>>, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stderr] [INFO] [stderr] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stderr] --> src/peer/peer.rs:26:21 [INFO] [stderr] | [INFO] [stderr] 26 | w_q: Arc>>>>>>, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stderr] [INFO] [stderr] warning: the loop variable `n` is only used to index `buf`. [INFO] [stderr] --> src/peer/peer.rs:68:18 [INFO] [stderr] | [INFO] [stderr] 68 | for n in 0..end { [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_range_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 68 | for in buf.iter().take(end) { [INFO] [stderr] | ^^^^^^ ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/peer/peer.rs:80:29 [INFO] [stderr] | [INFO] [stderr] 80 | let key_clone = key.clone(); [INFO] [stderr] | ^^^^^^^^^^^ help: try dereferencing it: `*key` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/peer/peer.rs:96:13 [INFO] [stderr] | [INFO] [stderr] 96 | poll.register(&stream, Token(100_000_001), Ready::writable(), PollOpt::edge()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_must_use)] on by default [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/peer/peer.rs:99:17 [INFO] [stderr] | [INFO] [stderr] 99 | poll.poll(&mut events, None); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/peer/peer.rs:105:25 [INFO] [stderr] | [INFO] [stderr] 105 | client.readable(&mut poll); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] [INFO] [stderr] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stderr] --> src/peer/server.rs:30:13 [INFO] [stderr] | [INFO] [stderr] 30 | caches: Arc>>>>>>, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stderr] [INFO] [stderr] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stderr] --> src/peer/server.rs:32:15 [INFO] [stderr] | [INFO] [stderr] 32 | r_caches: Arc>>>>>>, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stderr] [INFO] [stderr] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stderr] --> src/peer/server.rs:36:43 [INFO] [stderr] | [INFO] [stderr] 36 | pub fn new(sock: TcpListener, caches: Arc>>>>>>, r_caches: Arc>>>>>>) -> Server { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stderr] [INFO] [stderr] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stderr] --> src/peer/server.rs:36:112 [INFO] [stderr] | [INFO] [stderr] 36 | pub fn new(sock: TcpListener, caches: Arc>>>>>>, r_caches: Arc>>>>>>) -> Server { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stderr] [INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression [INFO] [stderr] --> src/peer/server.rs:172:13 [INFO] [stderr] | [INFO] [stderr] 172 | / let mut buf:Vec = vec![8u8,0,0,0]; [INFO] [stderr] 173 | | if w_cache.lock().unwrap().len() != 0 { [INFO] [stderr] 174 | | // println!("缓冲区有内容"); [INFO] [stderr] 175 | | buf = w_cache.lock().unwrap().pop().unwrap(); [INFO] [stderr] 176 | | } [INFO] [stderr] | |_____________^ help: it is more idiomatic to write: `let buf = if w_cache.lock().unwrap().len() != 0 { w_cache.lock().unwrap().pop().unwrap() } else { < [ _ ] > :: into_vec ( box [ $ ( $ x ) , * ] ) };` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_let_if_seq)] on by default [INFO] [stderr] = note: you might not need `mut` at all [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/peer/server.rs:277:13 [INFO] [stderr] | [INFO] [stderr] 277 | c.send_message(Rc::new(Vec::new())); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] [INFO] [stderr] warning: module has the same name as its containing module [INFO] [stderr] --> src/peer/mod.rs:2:1 [INFO] [stderr] | [INFO] [stderr] 2 | mod peer; [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::module_inception)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#module_inception [INFO] [stderr] [INFO] [stderr] warning: unused import: `std::thread::sleep` [INFO] [stderr] --> src/peer/peer.rs:6:5 [INFO] [stderr] | [INFO] [stderr] 6 | use std::thread::sleep; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused import: `std::time::Duration` [INFO] [stderr] --> src/peer/peer.rs:7:5 [INFO] [stderr] | [INFO] [stderr] 7 | use std::time::Duration; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `channel` [INFO] [stderr] --> src/peer/server.rs:7:11 [INFO] [stderr] | [INFO] [stderr] 7 | use mio::{channel, Events, Poll, PollOpt, Ready, Token}; [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `Events` [INFO] [stderr] --> src/peer/client.rs:4:11 [INFO] [stderr] | [INFO] [stderr] 4 | use mio::{Events, Ready, Poll, PollOpt, Token}; [INFO] [stderr] | ^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `mio::unix::UnixReady` [INFO] [stderr] --> src/peer/client.rs:6:5 [INFO] [stderr] | [INFO] [stderr] 6 | use mio::unix::UnixReady; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `std::time::Duration` [INFO] [stderr] --> src/peer/client.rs:7:5 [INFO] [stderr] | [INFO] [stderr] 7 | use std::time::Duration; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused imports: `ErrorKind`, `Error` [INFO] [stderr] --> src/peer/client.rs:8:15 [INFO] [stderr] | [INFO] [stderr] 8 | use std::io::{Error, ErrorKind}; [INFO] [stderr] | ^^^^^ ^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unneeded unit expression [INFO] [stderr] --> src/peer/connection.rs:163:21 [INFO] [stderr] | [INFO] [stderr] 163 | () [INFO] [stderr] | ^^ help: remove the final `()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unused_unit)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] warning: the loop variable `i` is only used to index `buf`. [INFO] [stderr] [INFO] [stderr] --> src/peer/client.rs:48:26 [INFO] [stderr] | [INFO] [stderr] 48 | for i in 0..n { [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 48 | for in buf.iter().take(n) { [INFO] [stderr] | ^^^^^^ ^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/peer/client.rs:60:9 [INFO] [stderr] | [INFO] [stderr] 60 | poll.reregister(&self.sock, self.token, Ready::writable(), PollOpt::edge()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/peer/client.rs:107:13 [INFO] [stderr] | [INFO] [stderr] 107 | / poll.reregister(&self.sock, self.token, self.interest, [INFO] [stderr] 108 | | PollOpt::edge()); [INFO] [stderr] | |___________________________________________________^ [INFO] [stderr] | [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/peer/connection.rs:153:12 [INFO] [stderr] | [INFO] [stderr] 153 | if buf.len() != 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!buf.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'mio::channel': use mio-extras instead [INFO] [stderr] --> src/peer/server.rs:7:11 [INFO] [stderr] | [INFO] [stderr] 7 | use mio::{channel, Events, Poll, PollOpt, Ready, Token}; [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(deprecated)] on by default [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'mio::Events::len': Index access removed in favor of iterator only API. [INFO] [stderr] --> src/peer/server.rs:64:76 [INFO] [stderr] | [INFO] [stderr] 64 | trace!("processing events... cnt={}; len={}", cnt, self.events.len()); [INFO] [stderr] | ^^^ [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'mio::Events::get': Index access removed in favor of iterator only API. [INFO] [stderr] --> src/peer/server.rs:74:41 [INFO] [stderr] | [INFO] [stderr] 74 | let event = self.events.get(i).expect("Failed to get event"); [INFO] [stderr] | ^^^ [INFO] [stderr] [INFO] [stderr] warning: unused variable: `w_q_clone` [INFO] [stderr] --> src/peer/peer.rs:47:17 [INFO] [stderr] | [INFO] [stderr] 47 | let w_q_clone = w_q.clone(); [INFO] [stderr] | ^^^^^^^^^ help: consider using `_w_q_clone` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused variable: `caches` [INFO] [stderr] --> src/peer/server.rs:119:13 [INFO] [stderr] | [INFO] [stderr] 119 | let caches = self.caches.clone(); [INFO] [stderr] | ^^^^^^ help: consider using `_caches` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `e` [INFO] [stderr] --> src/peer/client.rs:54:17 [INFO] [stderr] | [INFO] [stderr] 54 | Err(e) => { [INFO] [stderr] | ^ help: consider using `_e` instead [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/peer/peer.rs:117:13 [INFO] [stderr] | [INFO] [stderr] 117 | let mut cache = self.client_r.clone(); [INFO] [stderr] | ----^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_mut)] on by default [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/peer/peer.rs:123:13 [INFO] [stderr] | [INFO] [stderr] 123 | let mut cache = self.client_w.clone(); [INFO] [stderr] | ----^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/peer/server.rs:171:17 [INFO] [stderr] | [INFO] [stderr] 171 | let mut w_cache = caches_clone.lock().unwrap().get_mut(&key).unwrap().clone(); [INFO] [stderr] | ----^^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/peer/server.rs:218:13 [INFO] [stderr] | [INFO] [stderr] 218 | let mut caches = self.caches.clone(); [INFO] [stderr] | ----^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/peer/server.rs:219:13 [INFO] [stderr] | [INFO] [stderr] 219 | let mut r_caches = self.r_caches.clone(); [INFO] [stderr] | ----^^^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/peer/server.rs:269:13 [INFO] [stderr] | [INFO] [stderr] 269 | let mut r_caches = self.r_caches.clone(); [INFO] [stderr] | ----^^^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/peer/client.rs:36:13 [INFO] [stderr] | [INFO] [stderr] 36 | let mut cache = self.r_cache.clone(); [INFO] [stderr] | ----^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] [INFO] [stderr] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stderr] --> src/peer/peer.rs:17:15 [INFO] [stderr] | [INFO] [stderr] 17 | r_queues: Arc>>>>>>, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::type_complexity)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stderr] [INFO] [stderr] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stderr] --> src/peer/peer.rs:18:19 [INFO] [stderr] | [INFO] [stderr] 18 | pub w_queues: Arc>>>>>>, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stderr] [INFO] [stderr] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stderr] --> src/peer/peer.rs:25:21 [INFO] [stderr] | [INFO] [stderr] 25 | pub fn new(r_q: Arc>>>>>>, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stderr] [INFO] [stderr] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stderr] --> src/peer/peer.rs:26:21 [INFO] [stderr] | [INFO] [stderr] 26 | w_q: Arc>>>>>>, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stderr] [INFO] [stderr] warning: the loop variable `n` is only used to index `buf`. [INFO] [stderr] --> src/peer/peer.rs:68:18 [INFO] [stderr] | [INFO] [stderr] 68 | for n in 0..end { [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_range_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 68 | for in buf.iter().take(end) { [INFO] [stderr] | ^^^^^^ ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/peer/peer.rs:80:29 [INFO] [stderr] | [INFO] [stderr] 80 | let key_clone = key.clone(); [INFO] [stderr] | ^^^^^^^^^^^ help: try dereferencing it: `*key` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/peer/peer.rs:96:13 [INFO] [stderr] | [INFO] [stderr] 96 | poll.register(&stream, Token(100_000_001), Ready::writable(), PollOpt::edge()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_must_use)] on by default [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/peer/peer.rs:99:17 [INFO] [stderr] | [INFO] [stderr] 99 | poll.poll(&mut events, None); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/peer/peer.rs:105:25 [INFO] [stderr] | [INFO] [stderr] 105 | client.readable(&mut poll); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] [INFO] [stderr] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stderr] --> src/peer/server.rs:30:13 [INFO] [stderr] | [INFO] [stderr] 30 | caches: Arc>>>>>>, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stderr] [INFO] [stderr] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stderr] --> src/peer/server.rs:32:15 [INFO] [stderr] | [INFO] [stderr] 32 | r_caches: Arc>>>>>>, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stderr] [INFO] [stderr] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stderr] --> src/peer/server.rs:36:43 [INFO] [stderr] | [INFO] [stderr] 36 | pub fn new(sock: TcpListener, caches: Arc>>>>>>, r_caches: Arc>>>>>>) -> Server { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stderr] [INFO] [stderr] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stderr] --> src/peer/server.rs:36:112 [INFO] [stderr] | [INFO] [stderr] 36 | pub fn new(sock: TcpListener, caches: Arc>>>>>>, r_caches: Arc>>>>>>) -> Server { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stderr] [INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression [INFO] [stderr] --> src/peer/server.rs:172:13 [INFO] [stderr] | [INFO] [stderr] 172 | / let mut buf:Vec = vec![8u8,0,0,0]; [INFO] [stderr] 173 | | if w_cache.lock().unwrap().len() != 0 { [INFO] [stderr] 174 | | // println!("缓冲区有内容"); [INFO] [stderr] 175 | | buf = w_cache.lock().unwrap().pop().unwrap(); [INFO] [stderr] 176 | | } [INFO] [stderr] | |_____________^ help: it is more idiomatic to write: `let buf = if w_cache.lock().unwrap().len() != 0 { w_cache.lock().unwrap().pop().unwrap() } else { < [ _ ] > :: into_vec ( box [ $ ( $ x ) , * ] ) };` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_let_if_seq)] on by default [INFO] [stderr] = note: you might not need `mut` at all [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/peer/server.rs:277:13 [INFO] [stderr] | [INFO] [stderr] 277 | c.send_message(Rc::new(Vec::new())); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is only used to index `buf`. [INFO] [stderr] --> src/peer/client.rs:48:26 [INFO] [stderr] | [INFO] [stderr] 48 | for i in 0..n { [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 48 | for in buf.iter().take(n) { [INFO] [stderr] | ^^^^^^ ^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/peer/client.rs:60:9 [INFO] [stderr] | [INFO] [stderr] 60 | poll.reregister(&self.sock, self.token, Ready::writable(), PollOpt::edge()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/peer/client.rs:107:13 [INFO] [stderr] | [INFO] [stderr] 107 | / poll.reregister(&self.sock, self.token, self.interest, [INFO] [stderr] 108 | | PollOpt::edge()); [INFO] [stderr] | |___________________________________________________^ [INFO] [stderr] | [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/peer/connection.rs:153:12 [INFO] [stderr] | [INFO] [stderr] 153 | if buf.len() != 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!buf.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/main.rs:11:9 [INFO] [stderr] | [INFO] [stderr] 11 | let mut r_q = Arc::new(Mutex::new(HashMap::new())); [INFO] [stderr] | ----^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_mut)] on by default [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/main.rs:12:9 [INFO] [stderr] | [INFO] [stderr] 12 | let mut w_q = Arc::new(Mutex::new(HashMap::new())); [INFO] [stderr] | ----^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/main.rs:13:9 [INFO] [stderr] | [INFO] [stderr] 13 | let mut client_r = Arc::new(Mutex::new(Vec::new())); [INFO] [stderr] | ----^^^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/main.rs:14:9 [INFO] [stderr] | [INFO] [stderr] 14 | let mut client_w = Arc::new(Mutex::new(Vec::new())); [INFO] [stderr] | ----^^^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/main.rs:15:9 [INFO] [stderr] | [INFO] [stderr] 15 | let mut r_clone = r_q.clone(); [INFO] [stderr] | ----^^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/main.rs:16:9 [INFO] [stderr] | [INFO] [stderr] 16 | let mut w_clone = w_q.clone(); [INFO] [stderr] | ----^^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/main.rs:17:9 [INFO] [stderr] | [INFO] [stderr] 17 | let mut c_r = client_r.clone(); [INFO] [stderr] | ----^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/main.rs:18:9 [INFO] [stderr] | [INFO] [stderr] 18 | let mut c_w = client_w.clone(); [INFO] [stderr] | ----^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/main.rs:32:33 [INFO] [stderr] | [INFO] [stderr] 32 | let key_clone = key.clone(); [INFO] [stderr] | ^^^^^^^^^^^ help: try dereferencing it: `*key` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: empty `loop {}` detected. You may want to either use `panic!()` or add `std::thread::sleep(..);` to the loop body. [INFO] [stderr] --> src/main.rs:62:5 [INFO] [stderr] | [INFO] [stderr] 62 | loop {} [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::empty_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#empty_loop [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/main.rs:11:9 [INFO] [stderr] | [INFO] [stderr] 11 | let mut r_q = Arc::new(Mutex::new(HashMap::new())); [INFO] [stderr] | ----^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_mut)] on by default [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/main.rs:12:9 [INFO] [stderr] | [INFO] [stderr] 12 | let mut w_q = Arc::new(Mutex::new(HashMap::new())); [INFO] [stderr] | ----^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/main.rs:13:9 [INFO] [stderr] | [INFO] [stderr] 13 | let mut client_r = Arc::new(Mutex::new(Vec::new())); [INFO] [stderr] | ----^^^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/main.rs:14:9 [INFO] [stderr] | [INFO] [stderr] 14 | let mut client_w = Arc::new(Mutex::new(Vec::new())); [INFO] [stderr] | ----^^^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/main.rs:15:9 [INFO] [stderr] | [INFO] [stderr] 15 | let mut r_clone = r_q.clone(); [INFO] [stderr] | ----^^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/main.rs:16:9 [INFO] [stderr] | [INFO] [stderr] 16 | let mut w_clone = w_q.clone(); [INFO] [stderr] | ----^^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/main.rs:17:9 [INFO] [stderr] | [INFO] [stderr] 17 | let mut c_r = client_r.clone(); [INFO] [stderr] | ----^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/main.rs:18:9 [INFO] [stderr] | [INFO] [stderr] 18 | let mut c_w = client_w.clone(); [INFO] [stderr] | ----^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/main.rs:32:33 [INFO] [stderr] | [INFO] [stderr] 32 | let key_clone = key.clone(); [INFO] [stderr] | ^^^^^^^^^^^ help: try dereferencing it: `*key` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: empty `loop {}` detected. You may want to either use `panic!()` or add `std::thread::sleep(..);` to the loop body. [INFO] [stderr] --> src/main.rs:62:5 [INFO] [stderr] | [INFO] [stderr] 62 | loop {} [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::empty_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#empty_loop [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 6.22s [INFO] running `"docker" "inspect" "7cd7e712103fbc2ccad8070d3915d60de085ca876b6546fba3cf014cc2ca68ae"` [INFO] running `"docker" "rm" "-f" "7cd7e712103fbc2ccad8070d3915d60de085ca876b6546fba3cf014cc2ca68ae"` [INFO] [stdout] 7cd7e712103fbc2ccad8070d3915d60de085ca876b6546fba3cf014cc2ca68ae