[INFO] crate cgmath-culling 0.2.0 is already in cache [INFO] extracting crate cgmath-culling 0.2.0 into work/ex/clippy-test-run/sources/stable/reg/cgmath-culling/0.2.0 [INFO] extracting crate cgmath-culling 0.2.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/cgmath-culling/0.2.0 [INFO] validating manifest of cgmath-culling-0.2.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of cgmath-culling-0.2.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing cgmath-culling-0.2.0 [INFO] finished frobbing cgmath-culling-0.2.0 [INFO] frobbed toml for cgmath-culling-0.2.0 written to work/ex/clippy-test-run/sources/stable/reg/cgmath-culling/0.2.0/Cargo.toml [INFO] started frobbing cgmath-culling-0.2.0 [INFO] finished frobbing cgmath-culling-0.2.0 [INFO] frobbed toml for cgmath-culling-0.2.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/cgmath-culling/0.2.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting cgmath-culling-0.2.0 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-7/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/cgmath-culling/0.2.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 2e7602e7f84dba7cf41c20e3ce99d1d8308678e7542a0c34c6d49934774e17ae [INFO] running `"docker" "start" "-a" "2e7602e7f84dba7cf41c20e3ce99d1d8308678e7542a0c34c6d49934774e17ae"` [INFO] [stderr] Checking cgmath-culling v0.2.0 (/opt/crater/workdir) [INFO] [stderr] warning: you should consider adding a `Default` implementation for `Sphere` [INFO] [stderr] --> src/lib.rs:60:5 [INFO] [stderr] | [INFO] [stderr] 60 | / pub fn new() -> Self { [INFO] [stderr] 61 | | Self { [INFO] [stderr] 62 | | center: Vector3::zero(), [INFO] [stderr] 63 | | radius: S::zero(), [INFO] [stderr] 64 | | } [INFO] [stderr] 65 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 53 | impl Default for Sphere { [INFO] [stderr] 54 | fn default() -> Self { [INFO] [stderr] 55 | Self::new() [INFO] [stderr] 56 | } [INFO] [stderr] 57 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you should consider adding a `Default` implementation for `BoundingBox` [INFO] [stderr] --> src/lib.rs:85:5 [INFO] [stderr] | [INFO] [stderr] 85 | / pub fn new() -> Self { [INFO] [stderr] 86 | | Self::from_params(Vector3::zero(), Vector3::zero()) [INFO] [stderr] 87 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 78 | impl Default for BoundingBox { [INFO] [stderr] 79 | fn default() -> Self { [INFO] [stderr] 80 | Self::new() [INFO] [stderr] 81 | } [INFO] [stderr] 82 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you should consider adding a `Default` implementation for `FrustumCuller` [INFO] [stderr] --> src/lib.rs:93:5 [INFO] [stderr] | [INFO] [stderr] 93 | / pub fn new() -> Self { [INFO] [stderr] 94 | | Self::from_matrix(Matrix4::identity()) [INFO] [stderr] 95 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 90 | impl Default for FrustumCuller { [INFO] [stderr] 91 | fn default() -> Self { [INFO] [stderr] 92 | Self::new() [INFO] [stderr] 93 | } [INFO] [stderr] 94 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: the function has a cyclomatic complexity of 44 [INFO] [stderr] --> src/lib.rs:283:5 [INFO] [stderr] | [INFO] [stderr] 283 | / pub fn test_bounding_box(&self, aab: T) -> Intersection [INFO] [stderr] 284 | | where [INFO] [stderr] 285 | | T: Into>, [INFO] [stderr] 286 | | { [INFO] [stderr] ... | [INFO] [stderr] 469 | | Intersection::Outside [INFO] [stderr] 470 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cyclomatic_complexity)] on by default [INFO] [stderr] = help: you could split it up into multiple smaller functions [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cyclomatic_complexity [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:524:27 [INFO] [stderr] | [INFO] [stderr] 524 | fovy: Rad(3.14159265 / 2.0), [INFO] [stderr] | ^^^^^^^^^^ help: consider: `3.141_592_65` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:545:27 [INFO] [stderr] | [INFO] [stderr] 545 | fovy: Rad(3.14159265 / 2.0), [INFO] [stderr] | ^^^^^^^^^^ help: consider: `3.141_592_65` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:656:23 [INFO] [stderr] | [INFO] [stderr] 656 | fovy: Rad(3.14159265 / 2.0), [INFO] [stderr] | ^^^^^^^^^^ help: consider: `3.141_592_65` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: you should consider adding a `Default` implementation for `Sphere` [INFO] [stderr] --> src/lib.rs:60:5 [INFO] [stderr] | [INFO] [stderr] 60 | / pub fn new() -> Self { [INFO] [stderr] 61 | | Self { [INFO] [stderr] 62 | | center: Vector3::zero(), [INFO] [stderr] 63 | | radius: S::zero(), [INFO] [stderr] 64 | | } [INFO] [stderr] 65 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 53 | impl Default for Sphere { [INFO] [stderr] 54 | fn default() -> Self { [INFO] [stderr] 55 | Self::new() [INFO] [stderr] 56 | } [INFO] [stderr] 57 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you should consider adding a `Default` implementation for `BoundingBox` [INFO] [stderr] --> src/lib.rs:85:5 [INFO] [stderr] | [INFO] [stderr] 85 | / pub fn new() -> Self { [INFO] [stderr] 86 | | Self::from_params(Vector3::zero(), Vector3::zero()) [INFO] [stderr] 87 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 78 | impl Default for BoundingBox { [INFO] [stderr] 79 | fn default() -> Self { [INFO] [stderr] 80 | Self::new() [INFO] [stderr] 81 | } [INFO] [stderr] 82 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you should consider adding a `Default` implementation for `FrustumCuller` [INFO] [stderr] --> src/lib.rs:93:5 [INFO] [stderr] | [INFO] [stderr] 93 | / pub fn new() -> Self { [INFO] [stderr] 94 | | Self::from_matrix(Matrix4::identity()) [INFO] [stderr] 95 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 90 | impl Default for FrustumCuller { [INFO] [stderr] 91 | fn default() -> Self { [INFO] [stderr] 92 | Self::new() [INFO] [stderr] 93 | } [INFO] [stderr] 94 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: the function has a cyclomatic complexity of 44 [INFO] [stderr] --> src/lib.rs:283:5 [INFO] [stderr] | [INFO] [stderr] 283 | / pub fn test_bounding_box(&self, aab: T) -> Intersection [INFO] [stderr] 284 | | where [INFO] [stderr] 285 | | T: Into>, [INFO] [stderr] 286 | | { [INFO] [stderr] ... | [INFO] [stderr] 469 | | Intersection::Outside [INFO] [stderr] 470 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cyclomatic_complexity)] on by default [INFO] [stderr] = help: you could split it up into multiple smaller functions [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cyclomatic_complexity [INFO] [stderr] [INFO] [stderr] error: approximate value of `f{32, 64}::consts::PI` found. Consider using it directly [INFO] [stderr] --> src/lib.rs:524:27 [INFO] [stderr] | [INFO] [stderr] 524 | fovy: Rad(3.14159265 / 2.0), [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::approx_constant)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#approx_constant [INFO] [stderr] [INFO] [stderr] error: approximate value of `f{32, 64}::consts::PI` found. Consider using it directly [INFO] [stderr] --> src/lib.rs:545:27 [INFO] [stderr] | [INFO] [stderr] 545 | fovy: Rad(3.14159265 / 2.0), [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#approx_constant [INFO] [stderr] [INFO] [stderr] error: approximate value of `f{32, 64}::consts::PI` found. Consider using it directly [INFO] [stderr] --> src/lib.rs:656:23 [INFO] [stderr] | [INFO] [stderr] 656 | fovy: Rad(3.14159265 / 2.0), [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#approx_constant [INFO] [stderr] [INFO] [stderr] error: aborting due to 3 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `cgmath-culling`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "2e7602e7f84dba7cf41c20e3ce99d1d8308678e7542a0c34c6d49934774e17ae"` [INFO] running `"docker" "rm" "-f" "2e7602e7f84dba7cf41c20e3ce99d1d8308678e7542a0c34c6d49934774e17ae"` [INFO] [stdout] 2e7602e7f84dba7cf41c20e3ce99d1d8308678e7542a0c34c6d49934774e17ae