[INFO] crate cfb 0.3.1 is already in cache [INFO] extracting crate cfb 0.3.1 into work/ex/clippy-test-run/sources/stable/reg/cfb/0.3.1 [INFO] extracting crate cfb 0.3.1 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/cfb/0.3.1 [INFO] validating manifest of cfb-0.3.1 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of cfb-0.3.1 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing cfb-0.3.1 [INFO] finished frobbing cfb-0.3.1 [INFO] frobbed toml for cfb-0.3.1 written to work/ex/clippy-test-run/sources/stable/reg/cfb/0.3.1/Cargo.toml [INFO] started frobbing cfb-0.3.1 [INFO] finished frobbing cfb-0.3.1 [INFO] frobbed toml for cfb-0.3.1 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/cfb/0.3.1/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting cfb-0.3.1 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-6/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/cfb/0.3.1:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 03e48e6be869b10486187715e3a5c8cb1adb787f091967d981eb164fa6202d0c [INFO] running `"docker" "start" "-a" "03e48e6be869b10486187715e3a5c8cb1adb787f091967d981eb164fa6202d0c"` [INFO] [stderr] Checking cfb v0.3.1 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/internal/alloc.rs:31:13 [INFO] [stderr] | [INFO] [stderr] 31 | sectors: sectors, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `sectors` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/internal/alloc.rs:32:13 [INFO] [stderr] | [INFO] [stderr] 32 | difat_sector_ids: difat_sector_ids, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `difat_sector_ids` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/internal/alloc.rs:33:13 [INFO] [stderr] | [INFO] [stderr] 33 | difat: difat, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `difat` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/internal/alloc.rs:34:13 [INFO] [stderr] | [INFO] [stderr] 34 | fat: fat, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `fat` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/internal/chain.rs:25:13 [INFO] [stderr] | [INFO] [stderr] 25 | allocator: allocator, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `allocator` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/internal/chain.rs:26:13 [INFO] [stderr] | [INFO] [stderr] 26 | init: init, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `init` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/internal/chain.rs:27:13 [INFO] [stderr] | [INFO] [stderr] 27 | sector_ids: sector_ids, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `sector_ids` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/internal/direntry.rs:153:16 [INFO] [stderr] | [INFO] [stderr] 153 | name: name, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `name` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/internal/direntry.rs:154:16 [INFO] [stderr] | [INFO] [stderr] 154 | obj_type: obj_type, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `obj_type` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/internal/direntry.rs:155:16 [INFO] [stderr] | [INFO] [stderr] 155 | color: color, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `color` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/internal/direntry.rs:156:16 [INFO] [stderr] | [INFO] [stderr] 156 | left_sibling: left_sibling, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `left_sibling` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/internal/direntry.rs:157:16 [INFO] [stderr] | [INFO] [stderr] 157 | right_sibling: right_sibling, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `right_sibling` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/internal/direntry.rs:158:16 [INFO] [stderr] | [INFO] [stderr] 158 | child: child, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `child` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/internal/direntry.rs:159:16 [INFO] [stderr] | [INFO] [stderr] 159 | clsid: clsid, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `clsid` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/internal/direntry.rs:160:16 [INFO] [stderr] | [INFO] [stderr] 160 | state_bits: state_bits, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `state_bits` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/internal/direntry.rs:161:16 [INFO] [stderr] | [INFO] [stderr] 161 | creation_time: creation_time, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `creation_time` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/internal/direntry.rs:162:16 [INFO] [stderr] | [INFO] [stderr] 162 | modified_time: modified_time, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `modified_time` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/internal/direntry.rs:163:16 [INFO] [stderr] | [INFO] [stderr] 163 | start_sector: start_sector, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `start_sector` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/internal/direntry.rs:164:16 [INFO] [stderr] | [INFO] [stderr] 164 | stream_len: stream_len, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `stream_len` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/internal/entry.rs:25:13 [INFO] [stderr] | [INFO] [stderr] 25 | path: path, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `path` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/internal/entry.rs:103:13 [INFO] [stderr] | [INFO] [stderr] 103 | order: order, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `order` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/internal/entry.rs:104:13 [INFO] [stderr] | [INFO] [stderr] 104 | directory: directory, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `directory` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/internal/sector.rs:19:13 [INFO] [stderr] | [INFO] [stderr] 19 | inner: inner, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `inner` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/internal/sector.rs:20:13 [INFO] [stderr] | [INFO] [stderr] 20 | version: version, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `version` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/internal/sector.rs:21:13 [INFO] [stderr] | [INFO] [stderr] 21 | num_sectors: num_sectors, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `num_sectors` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/internal/sector.rs:61:16 [INFO] [stderr] | [INFO] [stderr] 61 | sector_len: sector_len, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `sector_len` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:617:13 [INFO] [stderr] | [INFO] [stderr] 617 | allocator: allocator, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `allocator` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:618:13 [INFO] [stderr] | [INFO] [stderr] 618 | minifat: minifat, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `minifat` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:719:16 [INFO] [stderr] | [INFO] [stderr] 719 | allocator: allocator, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `allocator` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:1180:13 [INFO] [stderr] | [INFO] [stderr] 1180 | obj_type: obj_type, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `obj_type` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:1411:16 [INFO] [stderr] | [INFO] [stderr] 1411 | comp: comp, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `comp` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:1412:16 [INFO] [stderr] | [INFO] [stderr] 1412 | stream_id: stream_id, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `stream_id` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:1661:26 [INFO] [stderr] | [INFO] [stderr] 1661 | UpdateDirEntry { stream_id: stream_id } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `stream_id` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/internal/alloc.rs:31:13 [INFO] [stderr] | [INFO] [stderr] 31 | sectors: sectors, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `sectors` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/internal/alloc.rs:32:13 [INFO] [stderr] | [INFO] [stderr] 32 | difat_sector_ids: difat_sector_ids, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `difat_sector_ids` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/internal/alloc.rs:33:13 [INFO] [stderr] | [INFO] [stderr] 33 | difat: difat, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `difat` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/internal/alloc.rs:34:13 [INFO] [stderr] | [INFO] [stderr] 34 | fat: fat, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `fat` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/internal/chain.rs:25:13 [INFO] [stderr] | [INFO] [stderr] 25 | allocator: allocator, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `allocator` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/internal/chain.rs:26:13 [INFO] [stderr] | [INFO] [stderr] 26 | init: init, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `init` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/internal/chain.rs:27:13 [INFO] [stderr] | [INFO] [stderr] 27 | sector_ids: sector_ids, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `sector_ids` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/internal/direntry.rs:153:16 [INFO] [stderr] | [INFO] [stderr] 153 | name: name, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `name` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/internal/direntry.rs:154:16 [INFO] [stderr] | [INFO] [stderr] 154 | obj_type: obj_type, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `obj_type` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/internal/direntry.rs:155:16 [INFO] [stderr] | [INFO] [stderr] 155 | color: color, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `color` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/internal/direntry.rs:156:16 [INFO] [stderr] | [INFO] [stderr] 156 | left_sibling: left_sibling, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `left_sibling` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/internal/direntry.rs:157:16 [INFO] [stderr] | [INFO] [stderr] 157 | right_sibling: right_sibling, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `right_sibling` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/internal/direntry.rs:158:16 [INFO] [stderr] | [INFO] [stderr] 158 | child: child, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `child` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/internal/direntry.rs:159:16 [INFO] [stderr] | [INFO] [stderr] 159 | clsid: clsid, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `clsid` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/internal/direntry.rs:160:16 [INFO] [stderr] | [INFO] [stderr] 160 | state_bits: state_bits, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `state_bits` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/internal/direntry.rs:161:16 [INFO] [stderr] | [INFO] [stderr] 161 | creation_time: creation_time, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `creation_time` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/internal/direntry.rs:162:16 [INFO] [stderr] | [INFO] [stderr] 162 | modified_time: modified_time, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `modified_time` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/internal/direntry.rs:163:16 [INFO] [stderr] | [INFO] [stderr] 163 | start_sector: start_sector, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `start_sector` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/internal/direntry.rs:164:16 [INFO] [stderr] | [INFO] [stderr] 164 | stream_len: stream_len, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `stream_len` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/internal/entry.rs:25:13 [INFO] [stderr] | [INFO] [stderr] 25 | path: path, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `path` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/internal/entry.rs:103:13 [INFO] [stderr] | [INFO] [stderr] 103 | order: order, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `order` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/internal/entry.rs:104:13 [INFO] [stderr] | [INFO] [stderr] 104 | directory: directory, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `directory` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/internal/sector.rs:19:13 [INFO] [stderr] | [INFO] [stderr] 19 | inner: inner, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `inner` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/internal/sector.rs:20:13 [INFO] [stderr] | [INFO] [stderr] 20 | version: version, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `version` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/internal/sector.rs:21:13 [INFO] [stderr] | [INFO] [stderr] 21 | num_sectors: num_sectors, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `num_sectors` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/internal/sector.rs:61:16 [INFO] [stderr] | [INFO] [stderr] 61 | sector_len: sector_len, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `sector_len` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:617:13 [INFO] [stderr] | [INFO] [stderr] 617 | allocator: allocator, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `allocator` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:618:13 [INFO] [stderr] | [INFO] [stderr] 618 | minifat: minifat, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `minifat` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:719:16 [INFO] [stderr] | [INFO] [stderr] 719 | allocator: allocator, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `allocator` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:1180:13 [INFO] [stderr] | [INFO] [stderr] 1180 | obj_type: obj_type, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `obj_type` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:1411:16 [INFO] [stderr] | [INFO] [stderr] 1411 | comp: comp, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `comp` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:1412:16 [INFO] [stderr] | [INFO] [stderr] 1412 | stream_id: stream_id, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `stream_id` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:1661:26 [INFO] [stderr] | [INFO] [stderr] 1661 | UpdateDirEntry { stream_id: stream_id } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `stream_id` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/internal/consts.rs:17:37 [INFO] [stderr] | [INFO] [stderr] 17 | pub const MAX_REGULAR_SECTOR: u32 = 0xfffffffa; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0xffff_fffa` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/internal/consts.rs:18:33 [INFO] [stderr] | [INFO] [stderr] 18 | pub const INVALID_SECTOR: u32 = 0xfffffffb; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0xffff_fffb` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/internal/consts.rs:19:31 [INFO] [stderr] | [INFO] [stderr] 19 | pub const DIFAT_SECTOR: u32 = 0xfffffffc; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0xffff_fffc` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/internal/consts.rs:20:29 [INFO] [stderr] | [INFO] [stderr] 20 | pub const FAT_SECTOR: u32 = 0xfffffffd; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0xffff_fffd` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/internal/consts.rs:21:31 [INFO] [stderr] | [INFO] [stderr] 21 | pub const END_OF_CHAIN: u32 = 0xfffffffe; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0xffff_fffe` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/internal/consts.rs:22:30 [INFO] [stderr] | [INFO] [stderr] 22 | pub const FREE_SECTOR: u32 = 0xffffffff; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0xffff_ffff` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/internal/consts.rs:33:40 [INFO] [stderr] | [INFO] [stderr] 33 | pub const MAX_REGULAR_STREAM_ID: u32 = 0xfffffffa; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0xffff_fffa` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/internal/consts.rs:34:28 [INFO] [stderr] | [INFO] [stderr] 34 | pub const NO_STREAM: u32 = 0xffffffff; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0xffff_ffff` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/internal/time.rs:26:38 [INFO] [stderr] | [INFO] [stderr] 26 | UNIX_EPOCH - Duration::from_secs(11644473600) [INFO] [stderr] | ^^^^^^^^^^^ help: consider: `11_644_473_600` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/internal/version.rs:52:28 [INFO] [stderr] | [INFO] [stderr] 52 | Version::V3 => 0xffffffff, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0xffff_ffff` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/internal/version.rs:53:28 [INFO] [stderr] | [INFO] [stderr] 53 | Version::V4 => 0xffffffffffffffff, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider: `0xffff_ffff_ffff_ffff` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/lib.rs:1490:20 [INFO] [stderr] | [INFO] [stderr] 1490 | } else { [INFO] [stderr] | ____________________^ [INFO] [stderr] 1491 | | if size == 0 { [INFO] [stderr] 1492 | | debug_assert_eq!(sector, self.dir_entry().start_sector); [INFO] [stderr] 1493 | | self.dir_entry_mut().start_sector = END_OF_CHAIN; [INFO] [stderr] ... | [INFO] [stderr] 1501 | | } [INFO] [stderr] 1502 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 1490 | } else if size == 0 { [INFO] [stderr] 1491 | debug_assert_eq!(sector, self.dir_entry().start_sector); [INFO] [stderr] 1492 | self.dir_entry_mut().start_sector = END_OF_CHAIN; [INFO] [stderr] 1493 | self.current_sector = END_OF_CHAIN; [INFO] [stderr] 1494 | self.comp.allocator.free_chain(sector)?; [INFO] [stderr] 1495 | } else { [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/internal/consts.rs:17:37 [INFO] [stderr] | [INFO] [stderr] 17 | pub const MAX_REGULAR_SECTOR: u32 = 0xfffffffa; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0xffff_fffa` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/internal/consts.rs:18:33 [INFO] [stderr] | [INFO] [stderr] 18 | pub const INVALID_SECTOR: u32 = 0xfffffffb; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0xffff_fffb` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/internal/consts.rs:19:31 [INFO] [stderr] | [INFO] [stderr] 19 | pub const DIFAT_SECTOR: u32 = 0xfffffffc; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0xffff_fffc` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/internal/consts.rs:20:29 [INFO] [stderr] | [INFO] [stderr] 20 | pub const FAT_SECTOR: u32 = 0xfffffffd; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0xffff_fffd` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/internal/consts.rs:21:31 [INFO] [stderr] | [INFO] [stderr] 21 | pub const END_OF_CHAIN: u32 = 0xfffffffe; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0xffff_fffe` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/internal/consts.rs:22:30 [INFO] [stderr] | [INFO] [stderr] 22 | pub const FREE_SECTOR: u32 = 0xffffffff; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0xffff_ffff` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/internal/consts.rs:33:40 [INFO] [stderr] | [INFO] [stderr] 33 | pub const MAX_REGULAR_STREAM_ID: u32 = 0xfffffffa; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0xffff_fffa` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/internal/consts.rs:34:28 [INFO] [stderr] | [INFO] [stderr] 34 | pub const NO_STREAM: u32 = 0xffffffff; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0xffff_ffff` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/internal/direntry.rs:236:42 [INFO] [stderr] | [INFO] [stderr] 236 | assert_eq!(dir_entry.state_bits, 0xdeadbeef); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0xdead_beef` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/internal/time.rs:26:38 [INFO] [stderr] | [INFO] [stderr] 26 | UNIX_EPOCH - Duration::from_secs(11644473600) [INFO] [stderr] | ^^^^^^^^^^^ help: consider: `11_644_473_600` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/internal/time.rs:39:33 [INFO] [stderr] | [INFO] [stderr] 39 | Duration::from_secs(1489862796); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `1_489_862_796` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/internal/time.rs:40:47 [INFO] [stderr] | [INFO] [stderr] 40 | assert_eq!(system_time_from_timestamp(131343363960000000), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider: `131_343_363_960_000_000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/internal/version.rs:52:28 [INFO] [stderr] | [INFO] [stderr] 52 | Version::V3 => 0xffffffff, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0xffff_ffff` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/internal/version.rs:53:28 [INFO] [stderr] | [INFO] [stderr] 53 | Version::V4 => 0xffffffffffffffff, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider: `0xffff_ffff_ffff_ffff` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/lib.rs:1490:20 [INFO] [stderr] | [INFO] [stderr] 1490 | } else { [INFO] [stderr] | ____________________^ [INFO] [stderr] 1491 | | if size == 0 { [INFO] [stderr] 1492 | | debug_assert_eq!(sector, self.dir_entry().start_sector); [INFO] [stderr] 1493 | | self.dir_entry_mut().start_sector = END_OF_CHAIN; [INFO] [stderr] ... | [INFO] [stderr] 1501 | | } [INFO] [stderr] 1502 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 1490 | } else if size == 0 { [INFO] [stderr] 1491 | debug_assert_eq!(sector, self.dir_entry().start_sector); [INFO] [stderr] 1492 | self.dir_entry_mut().start_sector = END_OF_CHAIN; [INFO] [stderr] 1493 | self.current_sector = END_OF_CHAIN; [INFO] [stderr] 1494 | self.comp.allocator.free_chain(sector)?; [INFO] [stderr] 1495 | } else { [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:1814:36 [INFO] [stderr] | [INFO] [stderr] 1814 | comp.set_state_bits("foo", 0x12345678).unwrap(); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x1234_5678` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:1815:36 [INFO] [stderr] | [INFO] [stderr] 1815 | comp.set_state_bits("bar", 0x0ABCDEF0).unwrap(); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0ABC_DEF0` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:1820:61 [INFO] [stderr] | [INFO] [stderr] 1820 | assert_eq!(comp.entry("foo").unwrap().state_bits(), 0x12345678); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x1234_5678` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:1821:61 [INFO] [stderr] | [INFO] [stderr] 1821 | assert_eq!(comp.entry("bar").unwrap().state_bits(), 0x0ABCDEF0); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0ABC_DEF0` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:1829:37 [INFO] [stderr] | [INFO] [stderr] 1829 | comp.set_state_bits("/foo", 0x12345678).unwrap(); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x1234_5678` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/internal/direntry.rs:67:19 [INFO] [stderr] | [INFO] [stderr] 67 | let d1 = ((bytes[0] as u32) << 24) | ((bytes[1] as u32) << 16) | [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `u32::from(bytes[0])` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/internal/direntry.rs:67:47 [INFO] [stderr] | [INFO] [stderr] 67 | let d1 = ((bytes[0] as u32) << 24) | ((bytes[1] as u32) << 16) | [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `u32::from(bytes[1])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/internal/direntry.rs:68:14 [INFO] [stderr] | [INFO] [stderr] 68 | ((bytes[2] as u32) << 8) | (bytes[3] as u32); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `u32::from(bytes[2])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/internal/direntry.rs:68:40 [INFO] [stderr] | [INFO] [stderr] 68 | ((bytes[2] as u32) << 8) | (bytes[3] as u32); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `u32::from(bytes[3])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/internal/direntry.rs:69:19 [INFO] [stderr] | [INFO] [stderr] 69 | let d2 = ((bytes[4] as u16) << 8) | (bytes[5] as u16); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `u16::from(bytes[4])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/internal/direntry.rs:69:45 [INFO] [stderr] | [INFO] [stderr] 69 | let d2 = ((bytes[4] as u16) << 8) | (bytes[5] as u16); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `u16::from(bytes[5])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/internal/direntry.rs:70:19 [INFO] [stderr] | [INFO] [stderr] 70 | let d3 = ((bytes[6] as u16) << 8) | (bytes[7] as u16); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `u16::from(bytes[6])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/internal/direntry.rs:70:45 [INFO] [stderr] | [INFO] [stderr] 70 | let d3 = ((bytes[6] as u16) << 8) | (bytes[7] as u16); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `u16::from(bytes[7])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: item `internal::entry::Entry` has a public `len` method but no corresponding `is_empty` method [INFO] [stderr] --> src/internal/entry.rs:21:1 [INFO] [stderr] | [INFO] [stderr] 21 | / impl Entry { [INFO] [stderr] 22 | | pub(crate) fn new(dir_entry: &DirEntry, path: PathBuf) -> Entry { [INFO] [stderr] 23 | | Entry { [INFO] [stderr] 24 | | name: dir_entry.name.clone(), [INFO] [stderr] ... | [INFO] [stderr] 78 | | } [INFO] [stderr] 79 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_without_is_empty)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_without_is_empty [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/internal/entry.rs:99:55 [INFO] [stderr] | [INFO] [stderr] 99 | pub(crate) fn new(order: EntriesOrder, directory: &'a Vec, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: change this to: `&[DirEntry]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/internal/sector.rs:57:35 [INFO] [stderr] | [INFO] [stderr] 57 | .seek(SeekFrom::Start((sector_id + 1) as u64 * sector_len as u64 + [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(sector_id + 1)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/internal/time.rs:10:44 [INFO] [stderr] | [INFO] [stderr] 10 | delta.as_secs() * 10_000_000 + (delta.subsec_nanos() / 100) as u64 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(delta.subsec_nanos() / 100)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:407:46 [INFO] [stderr] | [INFO] [stderr] 407 | consts::MINI_SECTOR_LEN as u64 * mini_sector as u64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try: `u64::from(mini_sector)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:497:26 [INFO] [stderr] | [INFO] [stderr] 497 | if num_sectors > (consts::MAX_REGULAR_SECTOR + 1) as u64 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(consts::MAX_REGULAR_SECTOR + 1)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: the loop variable `index` is only used to index `difat`. [INFO] [stderr] --> src/lib.rs:581:22 [INFO] [stderr] | [INFO] [stderr] 581 | for index in 0..difat.len() { [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_range_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 581 | for in &difat { [INFO] [stderr] | ^^^^^^ ^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/lib.rs:771:23 [INFO] [stderr] | [INFO] [stderr] 771 | for length in 1..(names.len() + 1) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: use: `1..=names.len()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::range_plus_one)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:944:37 [INFO] [stderr] | [INFO] [stderr] 944 | dir_entry.stream_len < consts::MINI_STREAM_CUTOFF as u64) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(consts::MINI_STREAM_CUTOFF)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:1351:36 [INFO] [stderr] | [INFO] [stderr] 1351 | chain.seek(SeekFrom::Start((index as u64) * 4))?; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try: `u64::from(index)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:1365:55 [INFO] [stderr] | [INFO] [stderr] 1365 | let offset = (consts::DIR_ENTRY_LEN as u64) * (stream_id as u64); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try: `u64::from(stream_id)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: item `Stream<'a, F>` has a public `len` method but no corresponding `is_empty` method [INFO] [stderr] --> src/lib.rs:1383:1 [INFO] [stderr] | [INFO] [stderr] 1383 | / impl<'a, F> Stream<'a, F> { [INFO] [stderr] 1384 | | fn dir_entry(&self) -> &DirEntry { self.comp.dir_entry(self.stream_id) } [INFO] [stderr] 1385 | | [INFO] [stderr] 1386 | | fn dir_entry_mut(&mut self) -> &mut DirEntry { [INFO] [stderr] ... | [INFO] [stderr] 1403 | | } [INFO] [stderr] 1404 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_without_is_empty [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:1394:22 [INFO] [stderr] | [INFO] [stderr] 1394 | self.len() < consts::MINI_STREAM_CUTOFF as u64 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(consts::MINI_STREAM_CUTOFF)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: the function has a cyclomatic complexity of 27 [INFO] [stderr] --> src/lib.rs:1579:5 [INFO] [stderr] | [INFO] [stderr] 1579 | / fn write(&mut self, buf: &[u8]) -> io::Result { [INFO] [stderr] 1580 | | if buf.is_empty() { [INFO] [stderr] 1581 | | return Ok(0); [INFO] [stderr] 1582 | | } [INFO] [stderr] ... | [INFO] [stderr] 1630 | | Ok(bytes_written) [INFO] [stderr] 1631 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cyclomatic_complexity)] on by default [INFO] [stderr] = help: you could split it up into multiple smaller functions [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cyclomatic_complexity [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:1617:34 [INFO] [stderr] | [INFO] [stderr] 1617 | consts::MINI_STREAM_CUTOFF as u64); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(consts::MINI_STREAM_CUTOFF)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/internal/direntry.rs:67:19 [INFO] [stderr] | [INFO] [stderr] 67 | let d1 = ((bytes[0] as u32) << 24) | ((bytes[1] as u32) << 16) | [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `u32::from(bytes[0])` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/internal/direntry.rs:67:47 [INFO] [stderr] | [INFO] [stderr] 67 | let d1 = ((bytes[0] as u32) << 24) | ((bytes[1] as u32) << 16) | [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `u32::from(bytes[1])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/internal/direntry.rs:68:14 [INFO] [stderr] | [INFO] [stderr] 68 | ((bytes[2] as u32) << 8) | (bytes[3] as u32); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `u32::from(bytes[2])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/internal/direntry.rs:68:40 [INFO] [stderr] | [INFO] [stderr] 68 | ((bytes[2] as u32) << 8) | (bytes[3] as u32); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `u32::from(bytes[3])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/internal/direntry.rs:69:19 [INFO] [stderr] | [INFO] [stderr] 69 | let d2 = ((bytes[4] as u16) << 8) | (bytes[5] as u16); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `u16::from(bytes[4])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/internal/direntry.rs:69:45 [INFO] [stderr] | [INFO] [stderr] 69 | let d2 = ((bytes[4] as u16) << 8) | (bytes[5] as u16); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `u16::from(bytes[5])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/internal/direntry.rs:70:19 [INFO] [stderr] | [INFO] [stderr] 70 | let d3 = ((bytes[6] as u16) << 8) | (bytes[7] as u16); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `u16::from(bytes[6])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/internal/direntry.rs:70:45 [INFO] [stderr] | [INFO] [stderr] 70 | let d3 = ((bytes[6] as u16) << 8) | (bytes[7] as u16); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `u16::from(bytes[7])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: item `internal::entry::Entry` has a public `len` method but no corresponding `is_empty` method [INFO] [stderr] --> src/internal/entry.rs:21:1 [INFO] [stderr] | [INFO] [stderr] 21 | / impl Entry { [INFO] [stderr] 22 | | pub(crate) fn new(dir_entry: &DirEntry, path: PathBuf) -> Entry { [INFO] [stderr] 23 | | Entry { [INFO] [stderr] 24 | | name: dir_entry.name.clone(), [INFO] [stderr] ... | [INFO] [stderr] 78 | | } [INFO] [stderr] 79 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_without_is_empty)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_without_is_empty [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/internal/entry.rs:99:55 [INFO] [stderr] | [INFO] [stderr] 99 | pub(crate) fn new(order: EntriesOrder, directory: &'a Vec, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: change this to: `&[DirEntry]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/internal/sector.rs:57:35 [INFO] [stderr] | [INFO] [stderr] 57 | .seek(SeekFrom::Start((sector_id + 1) as u64 * sector_len as u64 + [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(sector_id + 1)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: useless use of `vec!` [INFO] [stderr] --> src/internal/sector.rs:253:37 [INFO] [stderr] | [INFO] [stderr] 253 | assert_eq!(sector.write(&vec![1; 400]).unwrap(), 400); [INFO] [stderr] | ^^^^^^^^^^^^^ help: you can use a slice directly: `&[1; 400]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_vec)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec [INFO] [stderr] [INFO] [stderr] warning: useless use of `vec!` [INFO] [stderr] --> src/internal/sector.rs:254:37 [INFO] [stderr] | [INFO] [stderr] 254 | assert_eq!(sector.write(&vec![2; 400]).unwrap(), 112); [INFO] [stderr] | ^^^^^^^^^^^^^ help: you can use a slice directly: `&[2; 400]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec [INFO] [stderr] [INFO] [stderr] warning: useless use of `vec!` [INFO] [stderr] --> src/internal/sector.rs:255:37 [INFO] [stderr] | [INFO] [stderr] 255 | assert_eq!(sector.write(&vec![3; 400]).unwrap(), 0); [INFO] [stderr] | ^^^^^^^^^^^^^ help: you can use a slice directly: `&[3; 400]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/internal/time.rs:10:44 [INFO] [stderr] | [INFO] [stderr] 10 | delta.as_secs() * 10_000_000 + (delta.subsec_nanos() / 100) as u64 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(delta.subsec_nanos() / 100)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:407:46 [INFO] [stderr] | [INFO] [stderr] 407 | consts::MINI_SECTOR_LEN as u64 * mini_sector as u64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try: `u64::from(mini_sector)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:497:26 [INFO] [stderr] | [INFO] [stderr] 497 | if num_sectors > (consts::MAX_REGULAR_SECTOR + 1) as u64 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(consts::MAX_REGULAR_SECTOR + 1)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: the loop variable `index` is only used to index `difat`. [INFO] [stderr] --> src/lib.rs:581:22 [INFO] [stderr] | [INFO] [stderr] 581 | for index in 0..difat.len() { [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_range_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 581 | for in &difat { [INFO] [stderr] | ^^^^^^ ^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/lib.rs:771:23 [INFO] [stderr] | [INFO] [stderr] 771 | for length in 1..(names.len() + 1) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: use: `1..=names.len()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::range_plus_one)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:944:37 [INFO] [stderr] | [INFO] [stderr] 944 | dir_entry.stream_len < consts::MINI_STREAM_CUTOFF as u64) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(consts::MINI_STREAM_CUTOFF)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:1351:36 [INFO] [stderr] | [INFO] [stderr] 1351 | chain.seek(SeekFrom::Start((index as u64) * 4))?; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try: `u64::from(index)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:1365:55 [INFO] [stderr] | [INFO] [stderr] 1365 | let offset = (consts::DIR_ENTRY_LEN as u64) * (stream_id as u64); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try: `u64::from(stream_id)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: item `Stream<'a, F>` has a public `len` method but no corresponding `is_empty` method [INFO] [stderr] --> src/lib.rs:1383:1 [INFO] [stderr] | [INFO] [stderr] 1383 | / impl<'a, F> Stream<'a, F> { [INFO] [stderr] 1384 | | fn dir_entry(&self) -> &DirEntry { self.comp.dir_entry(self.stream_id) } [INFO] [stderr] 1385 | | [INFO] [stderr] 1386 | | fn dir_entry_mut(&mut self) -> &mut DirEntry { [INFO] [stderr] ... | [INFO] [stderr] 1403 | | } [INFO] [stderr] 1404 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_without_is_empty [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:1394:22 [INFO] [stderr] | [INFO] [stderr] 1394 | self.len() < consts::MINI_STREAM_CUTOFF as u64 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(consts::MINI_STREAM_CUTOFF)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: the function has a cyclomatic complexity of 27 [INFO] [stderr] --> src/lib.rs:1579:5 [INFO] [stderr] | [INFO] [stderr] 1579 | / fn write(&mut self, buf: &[u8]) -> io::Result { [INFO] [stderr] 1580 | | if buf.is_empty() { [INFO] [stderr] 1581 | | return Ok(0); [INFO] [stderr] 1582 | | } [INFO] [stderr] ... | [INFO] [stderr] 1630 | | Ok(bytes_written) [INFO] [stderr] 1631 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cyclomatic_complexity)] on by default [INFO] [stderr] = help: you could split it up into multiple smaller functions [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cyclomatic_complexity [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:1617:34 [INFO] [stderr] | [INFO] [stderr] 1617 | consts::MINI_STREAM_CUTOFF as u64); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(consts::MINI_STREAM_CUTOFF)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: useless use of `vec!` [INFO] [stderr] --> src/lib.rs:2173:24 [INFO] [stderr] | [INFO] [stderr] 2173 | .write_all(&vec![b'x'; 5000]) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: you can use a slice directly: `&[b'x'; 5000]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec [INFO] [stderr] [INFO] [stderr] warning: useless use of `vec!` [INFO] [stderr] --> src/lib.rs:2193:24 [INFO] [stderr] | [INFO] [stderr] 2193 | .write_all(&vec![b'x'; 500]) [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: you can use a slice directly: `&[b'x'; 500]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec [INFO] [stderr] [INFO] [stderr] warning: useless use of `vec!` [INFO] [stderr] --> src/lib.rs:2221:30 [INFO] [stderr] | [INFO] [stderr] 2221 | stream.write_all(&vec![b'x'; 5000]).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: you can use a slice directly: `&[b'x'; 5000]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec [INFO] [stderr] [INFO] [stderr] warning: useless use of `vec!` [INFO] [stderr] --> src/lib.rs:2222:30 [INFO] [stderr] | [INFO] [stderr] 2222 | stream.write_all(&vec![b'y'; 5000]).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: you can use a slice directly: `&[b'y'; 5000]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec [INFO] [stderr] [INFO] [stderr] warning: useless use of `vec!` [INFO] [stderr] --> src/lib.rs:2230:30 [INFO] [stderr] | [INFO] [stderr] 2230 | stream.write_all(&vec![b'x'; 1000]).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: you can use a slice directly: `&[b'x'; 1000]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec [INFO] [stderr] [INFO] [stderr] warning: useless use of `vec!` [INFO] [stderr] --> src/lib.rs:2251:30 [INFO] [stderr] | [INFO] [stderr] 2251 | stream.write_all(&vec![b'x'; 2000]).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: you can use a slice directly: `&[b'x'; 2000]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec [INFO] [stderr] [INFO] [stderr] warning: useless use of `vec!` [INFO] [stderr] --> src/lib.rs:2254:30 [INFO] [stderr] | [INFO] [stderr] 2254 | stream.write_all(&vec![b'y'; 500]).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: you can use a slice directly: `&[b'y'; 500]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec [INFO] [stderr] [INFO] [stderr] warning: useless use of `vec!` [INFO] [stderr] --> src/lib.rs:2260:30 [INFO] [stderr] | [INFO] [stderr] 2260 | stream.write_all(&vec![b'z'; 500]).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: you can use a slice directly: `&[b'z'; 500]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 5.43s [INFO] running `"docker" "inspect" "03e48e6be869b10486187715e3a5c8cb1adb787f091967d981eb164fa6202d0c"` [INFO] running `"docker" "rm" "-f" "03e48e6be869b10486187715e3a5c8cb1adb787f091967d981eb164fa6202d0c"` [INFO] [stdout] 03e48e6be869b10486187715e3a5c8cb1adb787f091967d981eb164fa6202d0c