[INFO] crate cex_derive 0.1.1 is already in cache [INFO] extracting crate cex_derive 0.1.1 into work/ex/clippy-test-run/sources/stable/reg/cex_derive/0.1.1 [INFO] extracting crate cex_derive 0.1.1 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/cex_derive/0.1.1 [INFO] validating manifest of cex_derive-0.1.1 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of cex_derive-0.1.1 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing cex_derive-0.1.1 [INFO] finished frobbing cex_derive-0.1.1 [INFO] frobbed toml for cex_derive-0.1.1 written to work/ex/clippy-test-run/sources/stable/reg/cex_derive/0.1.1/Cargo.toml [INFO] started frobbing cex_derive-0.1.1 [INFO] finished frobbing cex_derive-0.1.1 [INFO] frobbed toml for cex_derive-0.1.1 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/cex_derive/0.1.1/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting cex_derive-0.1.1 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-7/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/cex_derive/0.1.1:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] d01280760b666acf41738ece482254a9a4d94faf580e116fdb00c32c92de1f4a [INFO] running `"docker" "start" "-a" "d01280760b666acf41738ece482254a9a4d94faf580e116fdb00c32c92de1f4a"` [INFO] [stderr] Checking cex_derive v0.1.1 (/opt/crater/workdir) [INFO] [stderr] warning: You matched a field with a wildcard pattern. Consider using `..` instead [INFO] [stderr] --> src/lib.rs:41:34 [INFO] [stderr] | [INFO] [stderr] 41 | if let Type::Path( TypePath{ qself:_, ref mut path }) = ty { [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unneeded_field_pattern)] on by default [INFO] [stderr] = help: Try with `TypePath { ref mut path, .. }` [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unneeded_field_pattern [INFO] [stderr] [INFO] [stderr] warning: You matched a field with a wildcard pattern. Consider using `..` instead [INFO] [stderr] --> src/lib.rs:63:62 [INFO] [stderr] | [INFO] [stderr] 63 | self.cex_path = if let Type::Path( TypePath{ qself:_, path }) = cex_type { Some( path.clone() )} else { None }; [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: Try with `TypePath { path, .. }` [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unneeded_field_pattern [INFO] [stderr] [INFO] [stderr] warning: You matched a field with a wildcard pattern. Consider using `..` instead [INFO] [stderr] --> src/lib.rs:41:34 [INFO] [stderr] | [INFO] [stderr] 41 | if let Type::Path( TypePath{ qself:_, ref mut path }) = ty { [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unneeded_field_pattern)] on by default [INFO] [stderr] = help: Try with `TypePath { ref mut path, .. }` [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unneeded_field_pattern [INFO] [stderr] [INFO] [stderr] warning: You matched a field with a wildcard pattern. Consider using `..` instead [INFO] [stderr] --> src/lib.rs:63:62 [INFO] [stderr] | [INFO] [stderr] 63 | self.cex_path = if let Type::Path( TypePath{ qself:_, path }) = cex_type { Some( path.clone() )} else { None }; [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: Try with `TypePath { path, .. }` [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unneeded_field_pattern [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/lib.rs:40:1 [INFO] [stderr] | [INFO] [stderr] 40 | / fn mut_generics<'a>( ty: &'a mut Type ) -> impl Iterator { [INFO] [stderr] 41 | | if let Type::Path( TypePath{ qself:_, ref mut path }) = ty { [INFO] [stderr] 42 | | if let Some( segment ) = path.segments.iter_mut().last() { [INFO] [stderr] 43 | | if let PathArguments::AngleBracketed( ref mut generic ) = segment.arguments { [INFO] [stderr] ... | [INFO] [stderr] 54 | | syntax_err!(); [INFO] [stderr] 55 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_lifetimes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: You are using an explicit closure for cloning elements [INFO] [stderr] --> src/lib.rs:64:34 [INFO] [stderr] | [INFO] [stderr] 64 | self.err_types = mut_generics( cex_type ).map( |err| err.clone() ).collect::>(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: Consider calling the dedicated `cloned` method: `mut_generics( cex_type ).cloned()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::map_clone)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/lib.rs:140:23 [INFO] [stderr] | [INFO] [stderr] 140 | acc.push( syn::ItemImpl::from( [INFO] [stderr] | _______________________^ [INFO] [stderr] 141 | | if deriving_cex { [INFO] [stderr] 142 | | parse_quote! { [INFO] [stderr] 143 | | impl #impl_generics From<#current_cex_name #ty_generics> for __CeX<#(#concrete_errors),*> [INFO] [stderr] ... | [INFO] [stderr] 164 | | } [INFO] [stderr] 165 | | )); [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_conversion)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] help: consider removing `syn::ItemImpl::from()` [INFO] [stderr] | [INFO] [stderr] 140 | acc.push( if deriving_cex { [INFO] [stderr] 141 | parse_quote! { [INFO] [stderr] 142 | impl #impl_generics From<#current_cex_name #ty_generics> for __CeX<#(#concrete_errors),*> [INFO] [stderr] 143 | where Self: From<<#current_cex_name #ty_generics as #cex_trait>::LR> [INFO] [stderr] 144 | { [INFO] [stderr] 145 | fn from( src: #current_cex_name #ty_generics ) -> Self { [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/lib.rs:40:1 [INFO] [stderr] | [INFO] [stderr] 40 | / fn mut_generics<'a>( ty: &'a mut Type ) -> impl Iterator { [INFO] [stderr] 41 | | if let Type::Path( TypePath{ qself:_, ref mut path }) = ty { [INFO] [stderr] 42 | | if let Some( segment ) = path.segments.iter_mut().last() { [INFO] [stderr] 43 | | if let PathArguments::AngleBracketed( ref mut generic ) = segment.arguments { [INFO] [stderr] ... | [INFO] [stderr] 54 | | syntax_err!(); [INFO] [stderr] 55 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_lifetimes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: You are using an explicit closure for cloning elements [INFO] [stderr] --> src/lib.rs:64:34 [INFO] [stderr] | [INFO] [stderr] 64 | self.err_types = mut_generics( cex_type ).map( |err| err.clone() ).collect::>(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: Consider calling the dedicated `cloned` method: `mut_generics( cex_type ).cloned()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::map_clone)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/lib.rs:140:23 [INFO] [stderr] | [INFO] [stderr] 140 | acc.push( syn::ItemImpl::from( [INFO] [stderr] | _______________________^ [INFO] [stderr] 141 | | if deriving_cex { [INFO] [stderr] 142 | | parse_quote! { [INFO] [stderr] 143 | | impl #impl_generics From<#current_cex_name #ty_generics> for __CeX<#(#concrete_errors),*> [INFO] [stderr] ... | [INFO] [stderr] 164 | | } [INFO] [stderr] 165 | | )); [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_conversion)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] help: consider removing `syn::ItemImpl::from()` [INFO] [stderr] | [INFO] [stderr] 140 | acc.push( if deriving_cex { [INFO] [stderr] 141 | parse_quote! { [INFO] [stderr] 142 | impl #impl_generics From<#current_cex_name #ty_generics> for __CeX<#(#concrete_errors),*> [INFO] [stderr] 143 | where Self: From<<#current_cex_name #ty_generics as #cex_trait>::LR> [INFO] [stderr] 144 | { [INFO] [stderr] 145 | fn from( src: #current_cex_name #ty_generics ) -> Self { [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 1.96s [INFO] running `"docker" "inspect" "d01280760b666acf41738ece482254a9a4d94faf580e116fdb00c32c92de1f4a"` [INFO] running `"docker" "rm" "-f" "d01280760b666acf41738ece482254a9a4d94faf580e116fdb00c32c92de1f4a"` [INFO] [stdout] d01280760b666acf41738ece482254a9a4d94faf580e116fdb00c32c92de1f4a