[INFO] crate cedar 0.1.1 is already in cache [INFO] extracting crate cedar 0.1.1 into work/ex/clippy-test-run/sources/stable/reg/cedar/0.1.1 [INFO] extracting crate cedar 0.1.1 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/cedar/0.1.1 [INFO] validating manifest of cedar-0.1.1 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of cedar-0.1.1 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing cedar-0.1.1 [INFO] finished frobbing cedar-0.1.1 [INFO] frobbed toml for cedar-0.1.1 written to work/ex/clippy-test-run/sources/stable/reg/cedar/0.1.1/Cargo.toml [INFO] started frobbing cedar-0.1.1 [INFO] finished frobbing cedar-0.1.1 [INFO] frobbed toml for cedar-0.1.1 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/cedar/0.1.1/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting cedar-0.1.1 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-6/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/cedar/0.1.1:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] c9091d59e267d23e8fc6fa1b671618e86fcc3cae645692489c2e489d24a45c38 [INFO] running `"docker" "start" "-a" "c9091d59e267d23e8fc6fa1b671618e86fcc3cae645692489c2e489d24a45c38"` [INFO] [stderr] Compiling gio v0.1.3 [INFO] [stderr] Compiling cairo-rs v0.1.3 [INFO] [stderr] Compiling gdk-pixbuf v0.1.3 [INFO] [stderr] Compiling gdk v0.5.3 [INFO] [stderr] Compiling gtk v0.1.3 [INFO] [stderr] Compiling gio-sys v0.3.4 [INFO] [stderr] Compiling pango-sys v0.3.4 [INFO] [stderr] Compiling gdk-pixbuf-sys v0.3.4 [INFO] [stderr] Compiling cairo-sys-rs v0.3.4 [INFO] [stderr] Compiling gdk-sys v0.3.4 [INFO] [stderr] Compiling gtk-sys v0.3.4 [INFO] [stderr] Checking pango v0.1.3 [INFO] [stderr] Checking cedar v0.1.1 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/gtk/button.rs:19:13 [INFO] [stderr] | [INFO] [stderr] 19 | stream: stream, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `stream` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/gtk/text_field.rs:18:13 [INFO] [stderr] | [INFO] [stderr] 18 | stream: stream, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `stream` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/gtk/button.rs:19:13 [INFO] [stderr] | [INFO] [stderr] 19 | stream: stream, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `stream` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/gtk/text_field.rs:18:13 [INFO] [stderr] | [INFO] [stderr] 18 | stream: stream, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `stream` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/gtk/window.rs:21:9 [INFO] [stderr] | [INFO] [stderr] 21 | / match widget { [INFO] [stderr] 22 | | &Widget::Button(ref button) => { [INFO] [stderr] 23 | | self.stack.add(&button.button); [INFO] [stderr] 24 | | button.button.show(); [INFO] [stderr] ... | [INFO] [stderr] 37 | | } [INFO] [stderr] 38 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 21 | match *widget { [INFO] [stderr] 22 | Widget::Button(ref button) => { [INFO] [stderr] 23 | self.stack.add(&button.button); [INFO] [stderr] 24 | button.button.show(); [INFO] [stderr] 25 | } [INFO] [stderr] 26 | Widget::Stack(ref stack) => { [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/gtk/label.rs:22:13 [INFO] [stderr] | [INFO] [stderr] 22 | / match attr { [INFO] [stderr] 23 | | Text(text) => self.label.set_text(&text), [INFO] [stderr] 24 | | _ => {} [INFO] [stderr] 25 | | } [INFO] [stderr] | |_____________^ help: try this: `if let Text(text) = attr { self.label.set_text(&text) }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/gtk/widget.rs:18:9 [INFO] [stderr] | [INFO] [stderr] 18 | / match self { [INFO] [stderr] 19 | | &Widget::Stack(ref stack) => stack.add(widget), [INFO] [stderr] 20 | | _ => {} [INFO] [stderr] 21 | | } [INFO] [stderr] | |_________^ help: try this: `if let &Widget::Stack(ref stack) = self { stack.add(widget) }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/gtk/widget.rs:18:9 [INFO] [stderr] | [INFO] [stderr] 18 | / match self { [INFO] [stderr] 19 | | &Widget::Stack(ref stack) => stack.add(widget), [INFO] [stderr] 20 | | _ => {} [INFO] [stderr] 21 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 18 | match *self { [INFO] [stderr] 19 | Widget::Stack(ref stack) => stack.add(widget), [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/gtk/widget.rs:25:9 [INFO] [stderr] | [INFO] [stderr] 25 | / match self { [INFO] [stderr] 26 | | &mut Widget::Button(ref mut b) => b, [INFO] [stderr] 27 | | &mut Widget::Stack(ref mut s) => s, [INFO] [stderr] 28 | | &mut Widget::Label(ref mut l) => l, [INFO] [stderr] 29 | | &mut Widget::Field(ref mut f) => f, [INFO] [stderr] 30 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 25 | match *self { [INFO] [stderr] 26 | Widget::Button(ref mut b) => b, [INFO] [stderr] 27 | Widget::Stack(ref mut s) => s, [INFO] [stderr] 28 | Widget::Label(ref mut l) => l, [INFO] [stderr] 29 | Widget::Field(ref mut f) => f, [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/gtk/window.rs:21:9 [INFO] [stderr] | [INFO] [stderr] 21 | / match widget { [INFO] [stderr] 22 | | &Widget::Button(ref button) => { [INFO] [stderr] 23 | | self.stack.add(&button.button); [INFO] [stderr] 24 | | button.button.show(); [INFO] [stderr] ... | [INFO] [stderr] 37 | | } [INFO] [stderr] 38 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 21 | match *widget { [INFO] [stderr] 22 | Widget::Button(ref button) => { [INFO] [stderr] 23 | self.stack.add(&button.button); [INFO] [stderr] 24 | button.button.show(); [INFO] [stderr] 25 | } [INFO] [stderr] 26 | Widget::Stack(ref stack) => { [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/gtk/label.rs:22:13 [INFO] [stderr] | [INFO] [stderr] 22 | / match attr { [INFO] [stderr] 23 | | Text(text) => self.label.set_text(&text), [INFO] [stderr] 24 | | _ => {} [INFO] [stderr] 25 | | } [INFO] [stderr] | |_____________^ help: try this: `if let Text(text) = attr { self.label.set_text(&text) }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/gtk/widget.rs:18:9 [INFO] [stderr] | [INFO] [stderr] 18 | / match self { [INFO] [stderr] 19 | | &Widget::Stack(ref stack) => stack.add(widget), [INFO] [stderr] 20 | | _ => {} [INFO] [stderr] 21 | | } [INFO] [stderr] | |_________^ help: try this: `if let &Widget::Stack(ref stack) = self { stack.add(widget) }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/gtk/widget.rs:18:9 [INFO] [stderr] | [INFO] [stderr] 18 | / match self { [INFO] [stderr] 19 | | &Widget::Stack(ref stack) => stack.add(widget), [INFO] [stderr] 20 | | _ => {} [INFO] [stderr] 21 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 18 | match *self { [INFO] [stderr] 19 | Widget::Stack(ref stack) => stack.add(widget), [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/gtk/widget.rs:25:9 [INFO] [stderr] | [INFO] [stderr] 25 | / match self { [INFO] [stderr] 26 | | &mut Widget::Button(ref mut b) => b, [INFO] [stderr] 27 | | &mut Widget::Stack(ref mut s) => s, [INFO] [stderr] 28 | | &mut Widget::Label(ref mut l) => l, [INFO] [stderr] 29 | | &mut Widget::Field(ref mut f) => f, [INFO] [stderr] 30 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 25 | match *self { [INFO] [stderr] 26 | Widget::Button(ref mut b) => b, [INFO] [stderr] 27 | Widget::Stack(ref mut s) => s, [INFO] [stderr] 28 | Widget::Label(ref mut l) => l, [INFO] [stderr] 29 | Widget::Field(ref mut f) => f, [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> examples/buttons.rs:22:16 [INFO] [stderr] | [INFO] [stderr] 22 | fn view(model: &Model) -> dom::Object { [INFO] [stderr] | ^^^^^^ help: consider passing by value instead: `Model` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> examples/field.rs:20:16 [INFO] [stderr] | [INFO] [stderr] 20 | fn view(model: &Model) -> dom::Object { [INFO] [stderr] | ^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 49.41s [INFO] running `"docker" "inspect" "c9091d59e267d23e8fc6fa1b671618e86fcc3cae645692489c2e489d24a45c38"` [INFO] running `"docker" "rm" "-f" "c9091d59e267d23e8fc6fa1b671618e86fcc3cae645692489c2e489d24a45c38"` [INFO] [stdout] c9091d59e267d23e8fc6fa1b671618e86fcc3cae645692489c2e489d24a45c38